From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.47459.1595816258928276076 for ; Sun, 26 Jul 2020 19:17:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vOcJQdZF; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) IronPort-SDR: hjC7V+K/8xdF6tjsZM67+qF3CgXphG36q0ZuIoPSwHfaWxjSdLuw869p9FgBnQjUCHpA20fIbV 9eGf6WJd3kkA== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="138454750" X-IronPort-AV: E=Sophos;i="5.75,400,1589266800"; d="scan'208";a="138454750" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2020 19:17:38 -0700 IronPort-SDR: Q1VQh49yBVrWSf6CHrORKJUGHAt5r/MWC8RNj0oWG9IPy5m1Rr1kxbXvjr2G66f4wPqR562KDe 88Qy7S0O3IjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,400,1589266800"; d="scan'208";a="312054469" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga004.fm.intel.com with ESMTP; 26 Jul 2020 19:17:37 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 26 Jul 2020 19:17:37 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 26 Jul 2020 19:17:37 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 26 Jul 2020 19:17:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RShwNkTnbepbKHPN6tCdii6B3iA4zGT8lnl+dQdYN240y1qtdCSTsEdOj6YsT9KvSAmEIVxm62yH8xS9nqkQY4mgTLVJrethTjbd63mDb1AxPsv/m1sKVX8cR7gPjOiD10CI5k89E/YEmNn92HAqGM2zinSWSr7hwYZ7mku7zvgCzLsQEY+ZQ6MhwI5faVvQbXF6enrUs1telC79548NQ5OSxEre6YYy3e4hw9GfOhkurW+97ivw0zA2qrogWOapQaH5W3louJI3EleJzc4khyEESGJ9duAEu+ed6MHjZJNcFyBGhOwNpAV0O2KesDN7BqfkVUkjdo5tRuZK5lLpaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lM1BWvuTapMcjTHFw6iCEfLbJzP6h+q0Md+p2a2RnQY=; b=QaMn0a7xqXd56SWcp9jhsFoAUq6iIBsci7o2P46BNN3GCXWoeo4GfTBxVQMFZ2kYei6Mru5FDpAxT3C+uYVfME7kcMsAhibABkp6QbPetWTRBBnE31BVz2FmsTwMMRwYJVuKx7pvx2L6oBEyahDiz6j7/0fq5v9CRGXrBQ0AWe1/SUF3vaeOXPAwLeqiitbS+r0qNDXJHcF89U71XkpCIYhyQeKlO7iIuolkWWUWJ1/248v689MxaxAcaXXY95uaTtT4LW680C4EuJEQBWWixAG9+4YOUehmQZ2GpKvsNDwu98swdLvXCk7+gdOv0wpvF9yUq3GbFVyOJwtp/OGWyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lM1BWvuTapMcjTHFw6iCEfLbJzP6h+q0Md+p2a2RnQY=; b=vOcJQdZFTRp5l5ngEtQrabgYTcXBbYFgY2kjM03hqoDB6MlERna4TSSR3LhNau3N7shJax69g3F0ydZO0R/kFMwLPU6C6VIXpnL9Ehh17DiPTuJCXmEGEQRIb1W811XRNBm0PC7Q/ejXA4nMmfsiAF55AhUPHeTaOOLsETUx09Y= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1311.namprd11.prod.outlook.com (2603:10b6:300:2a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Mon, 27 Jul 2020 02:17:36 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3216.031; Mon, 27 Jul 2020 02:17:36 +0000 From: "Liming Gao" To: Jessica Clarke , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "Kinney, Michael D" Subject: Re: [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Topic: [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Index: AQHWY7mNVNLohyUgW0qdMiGnOLpB26kasLdA Date: Mon, 27 Jul 2020 02:17:35 +0000 Message-ID: References: <20200727015850.16776-1-jrtc27@jrtc27.com> In-Reply-To: <20200727015850.16776-1-jrtc27@jrtc27.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: jrtc27.com; dkim=none (message not signed) header.d=none;jrtc27.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 93fef27e-944b-423f-9901-08d831d33a77 x-ms-traffictypediagnostic: MWHPR11MB1311: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q9KOaYQ6WGsaBNxx/8q+Qy7xcCBQ6aKdVH19aSCpDlzyFel2flqU2b9c/2lq+Ij3oRlIuCK67AgKQLWKp5mI98fxdGRUXUaPiZkZSJ3iLEOEi+pXtDlcn1c9n6pkFE39cH3YrdBcKTmt1vMBvVqUxzT45VY/KOaycP86rmZbDT94JTZA4CYudwourGIps7nguoO36YROExpsFfGUApgPfQjAgyqT/yEWGpGkMLvgDvtcCgmJ26Q25DZQ8Kz8fy4cdPOmDSbsULvArupMJTCuGOvfLj9OY+HR6RkaKVpQ9VK/dxQn7tbduySFmaXgVdF8yDiQK/gLF4FzDwJYNgJO93uq1QRoLrXHHoKBK96EYf/49Ey1WcP0fhhc1m0Y9+QKBCyeeM597JBmLEbflpjXyA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(110136005)(55016002)(478600001)(7696005)(71200400001)(54906003)(186003)(4326008)(107886003)(316002)(8676002)(8936002)(9686003)(53546011)(83380400001)(6506007)(26005)(966005)(52536014)(86362001)(66446008)(66556008)(5660300002)(66476007)(64756008)(33656002)(66946007)(76116006)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: lfBMwUPtcrQv4LQW8orMhBYbdm/l1WK8fQZrTrxNmlIErpX6oiJC57i7+v6gtt1uQqZRC+a9pE+Udcika1WoT6qvp5MuNCw5NTk4G4Ws6jIPcrbRLZKiBSa6FU2ffvpproqdAF+o9JHiRa0UB2fZaNz1SR1kzg7f5Au0v5oMaPf1wrVLqRGTyzzeA/pyhjBUL4lnfMpghLQYAeqkaOouZzSRDxGTHrPstdog1fU1WiSEeIlZAuSBuEYBr1Q/uI2XnreBA1rNxuUakHtZb162MvuMsU4BoZmDHrvYZeCOmxIJx0Smd/4z8LRUHu8KUHLp4bY8WqYhb4jKXXylPLuMLAX9asDa19qUtW5KEbW8UZH5TgWHoxVrC7MQX08pXPapMAcYP+Rln1WVn3ETGVeKLsxx2AJYHJzAa9icqvjpjsqZgrgEct3HmywJ+oHNPrPy675R1VsxyE6VEENLJnC+YWVZq1Z+oxfv+OXlaBlRk96/HxvrtnR4gVH1beTNZADK MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93fef27e-944b-423f-9901-08d831d33a77 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 02:17:35.9763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JzL4x555ox46hYpYI2PymZaAuenrVvLiONqfLi7mF0ezYUV/k7nZqZTsqmQQAaxyqsEbr0TinvRRPCcX2qBLNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1311 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Jessica Clarke =20 Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B27=1B$BF|=1B(B 9:59 To: devel@edk2.groups.io Cc: Jessica Clarke ; Gao, Liming ;= leif@nuviainc.com; Kinney, Michael D Subject: [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_ad= dress REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 Being a compiler builtin, the type of __builtin_return_address is already k= nown to the compiler so no prototype is needed. Clang also errors out when = redeclaring certain builtins like this[1], though currently only for ones w= ith custom type checking. At the moment, __builtin_return_address does not = use custom type checking and so does not trigger this error, however, the C= HERI fork of LLVM, which will form the basis of the toolchain for Arm's exp= erimental Morello platform, does use custom type checking for it, and so gi= ves an error. Thus, simply delete the unnecessary line. [1] llvm/llvm-project@41af97137572ad6d4dafc872e7ecf6bbb08d4984 Cc: Leif Lindholm Signed-off-by: Jessica Clarke --- Changes in v2: * Shortened [1] reference to fit column limit. The bug report has the full URL already, and this will still link correctly on GitHub. MdePkg/Include/Base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 85a091b9d5= ..8e4271f6ea 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; **/ #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (VOID *= ) 0) #elif defined (__GNUC__) || defined (__clang__) - void * __builtin_return_address (unsigned int level); /** Get the return address of the calling function. =20 -- 2.20.1