From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.7307.1594303403799839345 for ; Thu, 09 Jul 2020 07:03:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tAfhl/ir; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) IronPort-SDR: SUaOGhxY8WygVepOEV7ITRL8Pc07XJJ0fbYcwiRxzBaqMEWWDmoYWX+oqU7KecfbmluAPNdURR 0dWA5ZxK8SMw== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="232871337" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="232871337" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 07:03:22 -0700 IronPort-SDR: 1neSvmoqsNoC7pjpwXaC53sLoXbjkRZwixCZePffMqHxjJOxQoX2XR8chGAkKFTKUevhpvuYTN XwAQQaWYx10w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="284157137" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 09 Jul 2020 07:03:22 -0700 Received: from fmsmsx104.amr.corp.intel.com (10.18.124.202) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 07:03:21 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 Jul 2020 07:03:21 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 07:03:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZVdPdxbsMqjlaXZbF0gIXtFFEGRfvb+DM4kwNEkJR7XuP3t88I7MFFsmhH0W3kVRlfh4A2tUXR6J9/YJvUqekCQlxV1NgH/yUjwTijdHUihOaytaIBbo+LKD2sWEhjl9P34hbcyG1tVz2U4QRg0wVONAroXVGMz+sFjL0cY5RxjmHNY44KbJBVD6wEMIGlo+Cm0pdxq0YAzG+dqJNm8bKiBpvcMP65233R5RNwpWrz9FDQFiCZQKdF9dR7pmD6Raotll9XBEpldNdDnNcdFdlnrt0ZHK+hRulpvDWYcLEYPkp+LRlIOsO1YAKZGiZSTtl6xcJKGdyrlG1h1WyIjNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7X3ARw3OXI0iCwMCsRUKNuqjtRQO7pMNyQsfalvLy0=; b=GRrG5Lo7QkSiZTTd3GG/RphvAj3uJVutfmJBG2WFIIHWrkuLE24r0lzwXu780bN37PX9VXbyS6SJGGRHtpKm2SAKdal0XNb8z/dXyBP2bW1bx/nxJU4F7BE0AGagBoZdaPRGu2kGym00UgqFqllDSIevKyfshvpb6FMH34atNlsCoxpKaWKcGE7yHOM1UHlvMkfbsspvbbQd6lHJMqjNq441RuB8W2Ipmzj6KzkF/RDskDXbpPAj02NkJRzsCbLtpUPwOcOE6+jVBie+Xuu6/QC4zIje8FHRcu7Of1gS2VAZ0XFZlnt7zq/zhYbp429ywvbRmQf0ARcSRMyyokLKMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7X3ARw3OXI0iCwMCsRUKNuqjtRQO7pMNyQsfalvLy0=; b=tAfhl/irNNt14XW8C0/4M2Vc9tDTtI/Ss3PGH8TBNbrwfMolGOJpdRECN/hmPEAKIHImFQSoj8NY3RgBtqPWgL7qb+F4Pet6hpwpVOptoBCFJ+l+Ys1HSmeUNTKxnRjNeQ3Bk4e8NInVZhfCI02h/RdYnGp0LFf4Eo748zWLgMQ= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MW3PR11MB4683.namprd11.prod.outlook.com (2603:10b6:303:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 9 Jul 2020 14:03:20 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3174.021; Thu, 9 Jul 2020 14:03:20 +0000 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , Bret Barkelew , "Yao, Jiewen" Subject: Re: [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for host testing Thread-Topic: [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for host testing Thread-Index: AQHWQqqm2vrnvp5TaEePzE0QWMGsc6j/bggw Date: Thu, 9 Jul 2020 14:03:20 +0000 Message-ID: References: <20200615001918.22164-1-michael.d.kinney@intel.com> <20200615001918.22164-3-michael.d.kinney@intel.com> In-Reply-To: <20200615001918.22164-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 026789e2-0f74-4eee-bf68-08d82410d621 x-ms-traffictypediagnostic: MW3PR11MB4683: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +94Tl9Yk2T0pctvlgxdib3ifhat7QMpuOFjH/vwJKMD30RJxj5IsHYhEbilLbcyRxAt5oo3RNakgW53A3bUooPBa/XpKVrV+DBdi71uaM5RJP8BI0UHlKelusb62PTeaCjMBDTnRy/LFhI7lpS4QQOhUByv3H/xbxqEy+9IE8p0Wn5UQVhIdv5n7zBOyUWkzkWSKK06Ag1ohEH8iJ+Hghn1Io52rKO7zj9dHR6Cga1yHiYcAW8qxLxcmyZAmrjblXtuzo4SKXqaEw1WnO1+OduqE+3yIs1pAlznGlAfy6+C8PvlRDvSoUcHTKeIm5x7QdNq2GErC/kUQyzk7qABjXhHYGsWX0lD/W3cyXowjVTpefafpVl9t54XSc7Tm0S5MSlAEJ+ii2GNBSrvWXSE+IQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(7696005)(6506007)(71200400001)(4326008)(9686003)(54906003)(26005)(186003)(2906002)(5660300002)(478600001)(8936002)(966005)(8676002)(66556008)(107886003)(52536014)(110136005)(66446008)(64756008)(66476007)(53546011)(66946007)(76116006)(83380400001)(86362001)(55016002)(316002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: WNxUGvoRjQu/mTWOqYCp+XciDR0DnP0SgZxukJCiixYL+Px4OX/0HDaKtN+uvR9lD1AfJb5CN1owl//FHXtZzH1D0PuHGIVYniA0VSR3Tu4gBIEbqyIwVd+FnHSOE7vGf6U7GkczDCThWPpTvZlu6kqrXH4rxJBF2qlfLNdyTBfsOSyXt+2MnnmHE/u/OemU/alzTL2kp2J9QxafN0TSCfWZj1gaSgZs0mx6a8oklglA9EjhnzozONQPsQ+p0vESbwIZUbFIS7A4bbb/OZY/iToKHDs4rrD8hytrkaQRpMxPRbOYsQqWnUUhjJ8iFhnT8Yvhwyhw72HQ2Tcpi2of2kFZbxw0WFNkyog+cqfIvB+7U1cpDvtbFmIJunnb5ezYH4LUbUghWkTgwLMD1wm61Wx1WMyc4xEM9XBDTSWclnA5FqN+KhjC0MKrVHe0nWj8eyBJSXwW9LEbpwcVqIKMu1TI4DEektwvaPIPK3VlFadOxFZozS80lh9LU8TjmM8E MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 026789e2-0f74-4eee-bf68-08d82410d621 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 14:03:20.1798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gk0FYZGT0OwwBxPxUxd/mZc4EIa95xH/YrSuR8ILUus0yCn91qv/FFXPMauvK+JTjfCKMZd4CqbTm2eq7Nk5Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4683 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, June 15, 2020 8:19 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan ; Bret Barkelew ; > Yao, Jiewen > Subject: [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib = for host testing >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2798 >=20 > The services in CpuLib usually generate exceptions in a unit test > host application. Provide a Null instance that can be safely used. >=20 > This Null instance can also be used as a template for implementing > new instances of CpuLib. >=20 > Cc: Liming Gao > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Jiewen Yao > Signed-off-by: Michael D Kinney > --- > .../Library/BaseCpuLibNull/BaseCpuLibNull.c | 37 +++++++++++++++++++ > .../Library/BaseCpuLibNull/BaseCpuLibNull.inf | 26 +++++++++++++ > .../Library/BaseCpuLibNull/BaseCpuLibNull.uni | 11 ++++++ > MdePkg/MdePkg.dsc | 3 +- > 4 files changed, 76 insertions(+), 1 deletion(-) > create mode 100644 MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > create mode 100644 MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf > create mode 100644 MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.uni >=20 > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c b/MdePkg/Libr= ary/BaseCpuLibNull/BaseCpuLibNull.c > new file mode 100644 > index 0000000000..3ba7a35096 > --- /dev/null > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.c > @@ -0,0 +1,37 @@ > +/** @file > + Null instance of CPU Library. > + > + Copyright (c) 2020, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +/** > + Places the CPU in a sleep state until an interrupt is received. > + > + Places the CPU in a sleep state until an interrupt is received. If int= errupts > + are disabled prior to calling this function, then the CPU will be plac= ed in a > + sleep state indefinitely. > + > +**/ > +VOID > +EFIAPI > +CpuSleep ( > + VOID > + ) > +{ > +} > + > +/** > + Flushes all the Translation Lookaside Buffers(TLB) entries in a CPU. > + > + Flushes all the Translation Lookaside Buffers(TLB) entries in a CPU. > + > +**/ > +VOID > +EFIAPI > +CpuFlushTlb ( > + VOID > + ) > +{ > +} > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf b/MdePkg/Li= brary/BaseCpuLibNull/BaseCpuLibNull.inf > new file mode 100644 > index 0000000000..a9e8399038 > --- /dev/null > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf > @@ -0,0 +1,26 @@ > +## @file > +# Null instance of CPU Library. > +# > +# Copyright (c) 2020, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D BaseCpuLibNull > + MODULE_UNI_FILE =3D BaseCpuLibNull.uni > + FILE_GUID =3D 8A29AAA5-0FB7-44CC-8709-1344FE89B87= 8 > + MODULE_TYPE =3D BASE > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D CpuLib > + > +# > +# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 RISCV64 > +# > + > +[Sources] > + BaseCpuLibNull.c > + > +[Packages] > + MdePkg/MdePkg.dec > diff --git a/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.uni b/MdePkg/Li= brary/BaseCpuLibNull/BaseCpuLibNull.uni > new file mode 100644 > index 0000000000..1030221d5c > --- /dev/null > +++ b/MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.uni > @@ -0,0 +1,11 @@ > +// /** @file > +// Null instance of CPU Library. > +// > +// Copyright (c) 2020, Intel Corporation. All rights reserved.
> +// SPDX-License-Identifier: BSD-2-Clause-Patent > +// > +// **/ > + > +#string STR_MODULE_ABSTRACT #language en-US "Null Instance o= f CPU Library" > + > +#string STR_MODULE_DESCRIPTION #language en-US "Null instance o= f CPU Library." > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc > index 6cd38e7ec3..3abe65ec7f 100644 > --- a/MdePkg/MdePkg.dsc > +++ b/MdePkg/MdePkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # EFI/PI MdePkg Package > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2020, Intel Corporation. All rights reserved.
> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. > # (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> # > @@ -36,6 +36,7 @@ [Components] > MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > + MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf > MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib= .inf > -- > 2.21.0.windows.1