From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.32712.1595228629304696229 for ; Mon, 20 Jul 2020 00:03:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xTDoVbmv; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) IronPort-SDR: JTWTghzkxkuNtsaNtcQaFII5k8v8U4tOuWqexhBDvJg/EUPMWsNzQIqqSqVAfJahy4nP/2oS2o dH6hqWE6/v5g== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="151208261" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="151208261" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 00:03:48 -0700 IronPort-SDR: sQSLPJSLvwLptNtouZOR1iMy/eZmnP7J37wPX8nwSfXNmjN4SMIynr3h4ssjmfsQKaPqjtuMnL sWWwK9/O6L8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="325981851" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2020 00:03:47 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 00:03:47 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 00:03:47 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.53) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 00:03:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0HdKzJ0xeninkfa1RbeDZIEf0AI7EB34WVy6ZslKFCYaJj10otbsaAYZC39FRVC3wFIbMwLqkeIATWEvhyh/EogUQYhslLUay/I82MWBp4JjjhniUGYjOxs0X8qcydC3+SO1KT6/AdkQgvgLkK2pqY0mTbcvBDSxyX3ulW9AjEpdA8x9uRXwHp/ufwdLSXJ0S6y2UxjSM3Q9BL+GlxRvsoNRpRg22nYpNPtza2004hO/zTzCO5T/BAQ6NM4uJ7lZPju1K0lnh5FAs1AjAPB7ZUITjHIxbxawns1rUnpBpejhsXa6ZdIHOxbIs4TRAPnvLK6G0/UclSkbK+EEvyomQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FACaIxFsBhidkD29tZ5DOfrKrmxGQfY3c56K7tg/o8=; b=ki4PjhS07l4kuMT4p+/nM1Y4nVg2iKgrY/yncHKfYpnqYcuipITcd6BWq9UamuV5Hs1A+4KaB+Ebn752227xI3WToNQH3FaXYvqe5iQwfo1B0/sW+HARHKsAa0TVvQ3u2mycl9RVAu1KH44QzC6qvW9FJFm+4yYRhUzrDzy46bKS/MQs55o7grjihrEfZ6QjfJzVVydA/3XosyDu84jGtUgBshj7BSzS0SDN2/j/kgrgDT82NrxRoP+6bJ0dGAUY9w4r7MY02/Qeajm8HvM/RjiBIm8Jru0hIA3IBlT3r30GsEObIVeXyXIJp4Ynay62rB6RvWhIf4h6NqRBlrE2pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7FACaIxFsBhidkD29tZ5DOfrKrmxGQfY3c56K7tg/o8=; b=xTDoVbmvifKpFGMvsLkkP3D5jZkhJB1Y0yLquhJz1IsxaTI1QsaNXzdVfkHET4Bx283Xyih9nx/I3odd+jtWV0IdttxXGXuDxQAOc7NuvG+peNJdtsODLmc9iw0pV5M+KDhXDY5udwqa4wzhEazCbj7OL66SeiUw+BJvsQyGuhU= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB0048.namprd11.prod.outlook.com (2603:10b6:301:6a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Mon, 20 Jul 2020 07:03:43 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3195.025; Mon, 20 Jul 2020 07:03:43 +0000 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" Subject: Re: [Patch] BaseTools: Remove the file timestamp checking during parsing Thread-Topic: [Patch] BaseTools: Remove the file timestamp checking during parsing Thread-Index: AQHWW2NfzItNEM/DnEm0IfrC5OVDp6kQAshg Date: Mon, 20 Jul 2020 07:03:42 +0000 Message-ID: References: <20200716112204.42176-1-bob.c.feng@intel.com> In-Reply-To: <20200716112204.42176-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a827daa-9e36-4ce6-814d-08d82c7b09e9 x-ms-traffictypediagnostic: MWHPR11MB0048: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:207; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YiUDb98HnnwUX/YDJyw4eEk52HcrKoTpcgMs/JFI0qSX1AUAPoHgZWi2VQ7b8nMTSsitYteYMB57ackyOdP4pVzetM9XSN3mwh/xDfLWepGpDPMIRUW3qZz9K+GKFyJLoTaFztHMz73sN3L0+DqlzbymLLUAyb5Gp6TDAJsKZz7vDHbqUb8i7Q9B/HJ6nsErqAz0oGr9RLjzBkpw0rLKfMxH7xTJUnuD98jICpNWvgNTTuU8Q6jCXJaU7IINCUZZ2a9iShX9JwqXOcJccSBSxV4DHaeNZtZCkympQnMTUgCPHGWNZ4XeAyzs+wBL7S9TXPmUtI4/MyruRI4tGq9qCg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(86362001)(5660300002)(2906002)(316002)(33656002)(76116006)(66556008)(66446008)(52536014)(110136005)(26005)(478600001)(186003)(64756008)(8676002)(66476007)(53546011)(6506007)(8936002)(66946007)(7696005)(71200400001)(83380400001)(9686003)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Gf7ykeMIdnPy4yboH12Eoveg00SYHT2cNc/td/ivoLKbSGTLdulx0ItiWNmTnpQnTpsVoyiX8HnR5OmbOKpvngj7d8m6Iye321DtDQv45VDjdUYAmcVxEfXdUOnLUbtfF1NheDIKc/TO+xvd6GjsS/QR6h4hPTfT/+srKaKRnCN+TuwcIYXQpWwDY2oJjD4I6S2dCR9IlkGX5ea0VvYfXaBbBZh5CKKNdN69Q7Zk78v9F0xqfkLfAvTIKz5pFD+bDo++bodNNdKoPEC8XcZnSs3Z2ZMOrSxP+jCkO1iH5g1QK+U9TBVpv9K16YlOm3iAi7N1NXT278qfDqz/+bRBcVMS44KE818vNlDEAAnfUMAo+QoeAg34Aon4j7NVyhElSFGFO6ux6ZZqBpi4ljQI8fitZHdOOaMepmZ00m9z0sHI9hVYLxD/2/b+VHnFIkBKPN05WquM+L+ffU7FAiS8tSBy1x5BU9xXCf6h6ZR8+Y0Ater61VElFbTyzTsFyOs3 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a827daa-9e36-4ce6-814d-08d82c7b09e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2020 07:03:42.9553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GhmeppF0YYhHVYhUxf0/cwNR9lZss3CQwO1jXb/ye7Ehh5F19di3epAamy4QJeENx/wyTgqpR1G9l/5gfq3Djw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0048 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Feng, Bob C > Sent: Thursday, July 16, 2020 7:22 PM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [Patch] BaseTools: Remove the file timestamp checking during par= sing >=20 > During build, the meta files are not changed, so it's no need > to check file timestamp. >=20 > This patch is to remove useless logic. >=20 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > .../Source/Python/Workspace/MetaFileTable.py | 12 ++---------- > .../Source/Python/Workspace/WorkspaceDatabase.py | 16 ---------------- > 2 files changed, 2 insertions(+), 26 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py b/BaseToo= ls/Source/Python/Workspace/MetaFileTable.py > index 0555c91ccc..20cb80e36e 100644 > --- a/BaseTools/Source/Python/Workspace/MetaFileTable.py > +++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py > @@ -44,29 +44,21 @@ class MetaFileTable(): > self.TableName =3D "_%s_%s_%s" % (FileType, len(DB.TblFile),= uuid.uuid4().hex) > else: > self.TableName =3D "_%s_%s" % (FileType, len(DB.TblFile)) >=20 > def IsIntegrity(self): > + Result =3D False > try: > TimeStamp =3D self.MetaFile.TimeStamp > if not self.CurrentContent: > Result =3D False > else: > Result =3D self.CurrentContent[-1][0] < 0 > - if not Result: > - # update the timestamp in database > - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) > - return False > - > - if TimeStamp !=3D self.DB.GetFileTimeStamp(self.FileId): > - # update the timestamp in database > - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) > - return False > except Exception as Exc: > EdkLogger.debug(EdkLogger.DEBUG_5, str(Exc)) > return False > - return True > + return Result >=20 > def SetEndFlag(self): > self.CurrentContent.append(self._DUMMY_) >=20 > def GetAll(self): > diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py > b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py > index 9420eaa608..d955c78b25 100644 > --- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py > +++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py > @@ -156,16 +156,10 @@ class WorkspaceDatabase(object): >=20 > # conversion object for build or file format conversion purpose > self.BuildObject =3D WorkspaceDatabase.BuildObjectFactory(self) > self.TransformObject =3D WorkspaceDatabase.TransformObjectFactor= y(self) >=20 > - def SetFileTimeStamp(self,FileId,TimeStamp): > - self.TblFile[FileId-1][6] =3D TimeStamp > - > - def GetFileTimeStamp(self,FileId): > - return self.TblFile[FileId-1][6] > - >=20 > ## Summarize all packages in the database > def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag): > self.Platform =3D Platform > PackageList =3D [] > @@ -191,20 +185,10 @@ class WorkspaceDatabase(object): > continue > PackageList.append(Package) >=20 > return PackageList >=20 > - ## Summarize all platforms in the database > - def PlatformList(self): > - RetVal =3D [] > - for PlatformFile in [item[3] for item in self.TblFile if item[5]= =3D=3D MODEL_FILE_DSC]: > - try: > - RetVal.append(self.BuildObject[PathClass(PlatformFile), = TAB_COMMON]) > - except: > - pass > - return RetVal > - > def MapPlatform(self, Dscfile): > Platform =3D self.BuildObject[PathClass(Dscfile), TAB_COMMON] > if Platform is None: > EdkLogger.error('build', PARSER_ERROR, "Failed to parser DSC= file: %s" % Dscfile) > return Platform > -- > 2.20.1.windows.1