* [PATCH v2] MdePkg: Include Acpi header file
@ 2020-04-20 7:48 Wasim Khan
2020-05-31 12:29 ` [edk2-devel] " Zhiguang Liu
2020-06-01 8:46 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 7+ messages in thread
From: Wasim Khan @ 2020-04-20 7:48 UTC (permalink / raw)
To: devel; +Cc: michael.d.kinney, liming.gao, v.sethi, Wasim Khan
ACPI memory mapped configuration space access (MCFG) table requires
defination of EFI_ACPI_DESCRIPTION_HEADER.
Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
---
Changes in v2: Corrected typo in subject
.../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
index 3356ec9..8a4933d 100644
--- a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
+++ b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
@@ -10,6 +10,8 @@
#ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
#define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
+#include <IndustryStandard/Acpi.h>
+
//
// Ensure proper structure formats
//
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
2020-04-20 7:48 [PATCH v2] MdePkg: Include Acpi header file Wasim Khan
@ 2020-05-31 12:29 ` Zhiguang Liu
2020-06-01 8:46 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 7+ messages in thread
From: Zhiguang Liu @ 2020-05-31 12:29 UTC (permalink / raw)
To: devel@edk2.groups.io, wasim.khan@nxp.com
Cc: Kinney, Michael D, Gao, Liming, v.sethi@nxp.com
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wasim
> Khan
> Sent: Monday, April 20, 2020 3:48 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; v.sethi@nxp.com; Wasim Khan
> <wasim.khan@nxp.com>
> Subject: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>
> ACPI memory mapped configuration space access (MCFG) table requires
> defination of EFI_ACPI_DESCRIPTION_HEADER.
>
> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
> Changes in v2: Corrected typo in subject
>
> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA
> ccessTable.h
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA
> ccessTable.h
> index 3356ec9..8a4933d 100644
> ---
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA
> ccessTable.h
> +++
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceA
> ccessTable.h
> @@ -10,6 +10,8 @@
> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>
> +#include <IndustryStandard/Acpi.h>
> +
> //
> // Ensure proper structure formats
> //
> --
> 2.7.4
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
2020-04-20 7:48 [PATCH v2] MdePkg: Include Acpi header file Wasim Khan
2020-05-31 12:29 ` [edk2-devel] " Zhiguang Liu
@ 2020-06-01 8:46 ` Philippe Mathieu-Daudé
2020-06-01 11:16 ` Wasim Khan
1 sibling, 1 reply; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-01 8:46 UTC (permalink / raw)
To: devel, wasim.khan; +Cc: michael.d.kinney, liming.gao, v.sethi
On 4/20/20 9:48 AM, Wasim Khan wrote:
> ACPI memory mapped configuration space access (MCFG) table requires
> defination of EFI_ACPI_DESCRIPTION_HEADER.
What about:
- DynamicTablesPkg/Include/Library/TableHelperLib.h
- DynamicTablesPkg/Include/StandardNameSpaceObjects.h
- EmbeddedPkg/Include/Library/AcpiLib.h
>
> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> ---
> Changes in v2: Corrected typo in subject
>
> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> index 3356ec9..8a4933d 100644
> --- a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> +++ b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
> @@ -10,6 +10,8 @@
> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>
> +#include <IndustryStandard/Acpi.h>
> +
> //
> // Ensure proper structure formats
> //
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
2020-06-01 8:46 ` Philippe Mathieu-Daudé
@ 2020-06-01 11:16 ` Wasim Khan
2020-06-01 11:17 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 7+ messages in thread
From: Wasim Khan @ 2020-06-01 11:16 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, liming.gao@intel.com, Varun Sethi
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Monday, June 1, 2020 2:17 PM
> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com>
> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi
> <V.Sethi@nxp.com>
> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>
> On 4/20/20 9:48 AM, Wasim Khan wrote:
> > ACPI memory mapped configuration space access (MCFG) table requires
> > defination of EFI_ACPI_DESCRIPTION_HEADER.
>
> What about:
>
> - DynamicTablesPkg/Include/Library/TableHelperLib.h
> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> - EmbeddedPkg/Include/Library/AcpiLib.h
EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file.
For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used.
>
> >
> > Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> > ---
> > Changes in v2: Corrected typo in subject
> >
> > .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h |
> 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> >
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> > index 3356ec9..8a4933d 100644
> > ---
> >
> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
> > Table.h
> > +++
> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc
> > +++ cessTable.h
> > @@ -10,6 +10,8 @@
> > #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> > #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> >
> > +#include <IndustryStandard/Acpi.h>
> > +
> > //
> > // Ensure proper structure formats
> > //
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
2020-06-01 11:16 ` Wasim Khan
@ 2020-06-01 11:17 ` Philippe Mathieu-Daudé
2020-06-19 9:11 ` Liming Gao
[not found] ` <1619E6FD13E309C3.13400@groups.io>
0 siblings, 2 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-01 11:17 UTC (permalink / raw)
To: Wasim Khan, devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, liming.gao@intel.com, Varun Sethi
On 6/1/20 1:16 PM, Wasim Khan wrote:
>
>
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Sent: Monday, June 1, 2020 2:17 PM
>> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com>
>> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi
>> <V.Sethi@nxp.com>
>> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>>
>> On 4/20/20 9:48 AM, Wasim Khan wrote:
>>> ACPI memory mapped configuration space access (MCFG) table requires
>>> defination of EFI_ACPI_DESCRIPTION_HEADER.
>>
>> What about:
>>
>> - DynamicTablesPkg/Include/Library/TableHelperLib.h
>> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h
>> - EmbeddedPkg/Include/Library/AcpiLib.h
>
> EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file.
> For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used.
OK, thanks Wasim.
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
>>
>>>
>>> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
>>> ---
>>> Changes in v2: Corrected typo in subject
>>>
>>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h |
>> 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git
>>>
>> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
>>> Table.h
>>>
>> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
>>> Table.h
>>> index 3356ec9..8a4933d 100644
>>> ---
>>>
>> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess
>>> Table.h
>>> +++
>> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc
>>> +++ cessTable.h
>>> @@ -10,6 +10,8 @@
>>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>>>
>>> +#include <IndustryStandard/Acpi.h>
>>> +
>>> //
>>> // Ensure proper structure formats
>>> //
>>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
2020-06-01 11:17 ` Philippe Mathieu-Daudé
@ 2020-06-19 9:11 ` Liming Gao
[not found] ` <1619E6FD13E309C3.13400@groups.io>
1 sibling, 0 replies; 7+ messages in thread
From: Liming Gao @ 2020-06-19 9:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Wasim Khan, devel@edk2.groups.io
Cc: Kinney, Michael D, Varun Sethi
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Sent: 2020年6月1日 19:18
To: Wasim Khan <wasim.khan@nxp.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
On 6/1/20 1:16 PM, Wasim Khan wrote:
>
>
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Sent: Monday, June 1, 2020 2:17 PM
>> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com>
>> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi
>> <V.Sethi@nxp.com>
>> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>>
>> On 4/20/20 9:48 AM, Wasim Khan wrote:
>>> ACPI memory mapped configuration space access (MCFG) table requires
>>> defination of EFI_ACPI_DESCRIPTION_HEADER.
>>
>> What about:
>>
>> - DynamicTablesPkg/Include/Library/TableHelperLib.h
>> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h
>> - EmbeddedPkg/Include/Library/AcpiLib.h
>
> EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file.
> For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used.
OK, thanks Wasim.
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
>>
>>>
>>> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
>>> ---
>>> Changes in v2: Corrected typo in subject
>>>
>>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h |
>> 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git
>>>
>> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
>> s
>>> Table.h
>>>
>> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
>> s
>>> Table.h
>>> index 3356ec9..8a4933d 100644
>>> ---
>>>
>> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
>> s
>>> Table.h
>>> +++
>> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc
>>> +++ cessTable.h
>>> @@ -10,6 +10,8 @@
>>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
>>>
>>> +#include <IndustryStandard/Acpi.h>
>>> +
>>> //
>>> // Ensure proper structure formats
>>> //
>>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
[not found] ` <1619E6FD13E309C3.13400@groups.io>
@ 2020-06-19 14:09 ` Liming Gao
0 siblings, 0 replies; 7+ messages in thread
From: Liming Gao @ 2020-06-19 14:09 UTC (permalink / raw)
To: devel@edk2.groups.io, Gao, Liming, Philippe Mathieu-Daudé,
Wasim Khan
Cc: Kinney, Michael D, Varun Sethi
PR: https://github.com/tianocore/edk2/pull/713
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
> Sent: Friday, June 19, 2020 5:12 PM
> To: Philippe Mathieu-Daudé <philmd@redhat.com>; Wasim Khan <wasim.khan@nxp.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: 2020年6月1日 19:18
> To: Wasim Khan <wasim.khan@nxp.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
>
> On 6/1/20 1:16 PM, Wasim Khan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> Sent: Monday, June 1, 2020 2:17 PM
> >> To: devel@edk2.groups.io; Wasim Khan <wasim.khan@nxp.com>
> >> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi
> >> <V.Sethi@nxp.com>
> >> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file
> >>
> >> On 4/20/20 9:48 AM, Wasim Khan wrote:
> >>> ACPI memory mapped configuration space access (MCFG) table requires
> >>> defination of EFI_ACPI_DESCRIPTION_HEADER.
> >>
> >> What about:
> >>
> >> - DynamicTablesPkg/Include/Library/TableHelperLib.h
> >> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> >> - EmbeddedPkg/Include/Library/AcpiLib.h
> >
> > EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file.
> > For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used.
>
> OK, thanks Wasim.
>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
> >
> >>
> >>>
> >>> Signed-off-by: Wasim Khan <wasim.khan@nxp.com>
> >>> ---
> >>> Changes in v2: Corrected typo in subject
> >>>
> >>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h |
> >> 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>>
> >>> diff --git
> >>>
> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
> >> s
> >>> Table.h
> >>>
> >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
> >> s
> >>> Table.h
> >>> index 3356ec9..8a4933d 100644
> >>> ---
> >>>
> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAcces
> >> s
> >>> Table.h
> >>> +++
> >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc
> >>> +++ cessTable.h
> >>> @@ -10,6 +10,8 @@
> >>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> >>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_
> >>>
> >>> +#include <IndustryStandard/Acpi.h>
> >>> +
> >>> //
> >>> // Ensure proper structure formats
> >>> //
> >>>
> >
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-06-19 14:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-20 7:48 [PATCH v2] MdePkg: Include Acpi header file Wasim Khan
2020-05-31 12:29 ` [edk2-devel] " Zhiguang Liu
2020-06-01 8:46 ` Philippe Mathieu-Daudé
2020-06-01 11:16 ` Wasim Khan
2020-06-01 11:17 ` Philippe Mathieu-Daudé
2020-06-19 9:11 ` Liming Gao
[not found] ` <1619E6FD13E309C3.13400@groups.io>
2020-06-19 14:09 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox