From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.10830.1595297529803655541 for ; Mon, 20 Jul 2020 19:12:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZtvPAs0f; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) IronPort-SDR: p96ePnsfEwY1hpfFor1JcPaxnhGFEPZrdGBkAUQWxEVufk4nUd3Q4H3I7T/2WKqcy/uSEuei+5 52C2WJGHJRDA== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="137534449" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="137534449" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 19:12:09 -0700 IronPort-SDR: zwsfCObcZpCSQSlw+4j26bTA8LVZGGe5xN3y0iatrFgIWEI1NpCj1ZFG1OJfHMilHZaNUGPZd8 ekwf4GJlXptQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="362213495" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga001.jf.intel.com with ESMTP; 20 Jul 2020 19:12:09 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 19:12:09 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 19:12:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 19:12:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qnct2y7LGbr8Jh/ICgOBpN4x27dajeNLtzLnaHpdXZ9PO72Rkjo7XNjy9xXKiVgruLbfIyaftKvFfIZwE7+m1PkQM9MnqMYSjE9/HpsJkL9cfzPxH4SbrKVxfu6IwBIpDFlwV7LWuVTyMPNb1+1ov/C5bqR46c/LYGNeLVSQ7WWHVM6vlaK1UmAqDP8+Ebekjnctc8pVr5bcs/dh2hS3mw/qO+teHkf+RGX3k95/h2PyBd48MQlBCE7Drv7fYa90J3poHRWfYfiXiwAWzzCxgJZD95zesJZthm1400Wzgzo3NyyYBKpw1IUumLCbk/iM5LpT65hmkdfo5PCbe/394w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7yS+41xTFqPd74BaOVXzMeB5gnBFjMvOsFOauw+fQI=; b=fCsywABeXWntUm0ZdCOJskuOaV9wzWD7DcZ4C1Qy2yFIhgzvxh4ZFNu+XWuxG1zCWprzMrdQgLHvPvlppaV7zbCCUNLtHAyBzcFfpWzM3jjQXosITVHM3snj1FBZiCxB12Lrdr/d4C7tKjZyzXhlqtUvQaxVcmILpJFtVbWYpWqI0yE+VqZPmTBGHj4dotL3nbrjSSljwiItJm4QQAe8P3ORdignDjVZoae59g9md7ySb14yBq8XC31Sdj5OAjjEHpWCjF7TqPFlEn67I6FHdNTSAlfAO/66td1n6HXpjNMJdQhC/kf3e66Gdgi/T2+Yqa4KKr5Kf8+cBcxYLA/QfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7yS+41xTFqPd74BaOVXzMeB5gnBFjMvOsFOauw+fQI=; b=ZtvPAs0fj0l9TIFO/o2lj3J2IyONOhOlTcpTN1x+rwp/kEudB1bsHJVzw03NVz5UQuafMXJUUYlVQXGpRKoB2QhB04YUQKokRkWK+8i9D75AtJNazyLWN/V+EtPpLo5uwnAbF8f54k9UFWeA8CwAdAQAHfSk4sL20DoLGl1aVOs= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MW3PR11MB4555.namprd11.prod.outlook.com (2603:10b6:303:2e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 02:12:07 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 02:12:07 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "Chiu, Chasel" , "Kuo, IanX" CC: "Lu, James" , "Kumar, Chandana C" , "Prabhala, Varalakshmi A" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error Thread-Index: AQHWXvbe4KyUduZHiUCZbIPtgNl15qkRNiYAgAASFqA= Date: Tue, 21 Jul 2020 02:12:07 +0000 Message-ID: References: <82e226162a72f62a6a46e3a4733d1752908bcabc.1595291556.git.ianx.kuo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 588d9010-7afb-4bc7-d878-08d82d1b7806 x-ms-traffictypediagnostic: MW3PR11MB4555: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:549; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KRDZW39wVdY9CgbV3OMjQ1Z4SKdODvlPYJzm7tZ2VaCW0JBGOaPuK8VThd5nNgbTeqqKGuEAzewtkWFhErLmjWRZDNFqzML7ClsShSrLw3b+OnqrPlX7PjeQ4tiiL0qo0DdbjE/X+opUG8aM62/f9ISD+l9Bu8JMBLk/BRuf/4PHusFEWr1VNzXxMjHrHVuBU0d7fEsRPK9+GGZ6caiYn3ADP/efYcQSpqB7EoZYKiB5wYzGm/oF9wzn7UDe2Np2X/b1O2BpVq/ayq3b0/MA5Cpxu6FTD/ZC/Ufl9V6KrRkHdr+s/9SKJpdnQhF4KItDq3feA+O89nbYahIJXIz2eMUA6BgHZ5oktIESqqzx/elaXE2vFZmhnzLydGqQtQHWPQOg0yiJwMQsCcqCl7VYpQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(8676002)(186003)(478600001)(53546011)(6506007)(86362001)(966005)(4326008)(110136005)(55016002)(7696005)(66446008)(64756008)(66556008)(66476007)(33656002)(26005)(83380400001)(71200400001)(66946007)(76116006)(52536014)(54906003)(316002)(5660300002)(9686003)(2906002)(107886003)(8936002)(6636002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: U6kxOmAMezuqYaldqbLi6aXCjolOnWYjd3ldJsoKdTQJlXyaEo5UKNjw4Pr/AcLhHKrmCbEC5CKa/QbksmjYLr+VMBB97jvPf58/vB3be+VRt9vgdCFSwEHleKgJZHW8inB1H9XD73Vcbru2B3nxBDwZfzq9lfu7J6ehi9tEwclMrmadbKPzf6Wzq4DqKORacXZlqJp0ynpLY7cYQ7GsktRyjaA9G4qLXPSWHQ6WNcOtYPB41UXM4HqLuJS7viVPf6tFLk8s34B5svRJrXuyRhR13vUu5MIKj45WqJQ+WDQhX+zP1rmwKGRk0E/eRU+y0UVUeUxcqjV4KOD3fAdTgb3wQB8CY8SUGlRzBxHTNhDRE2C9xwkSDbvzxaNfcnU0KFKtA3/SOKDGgVZXPh2Zjl+vy/YRrhDi+S/b6aML5qVf5gIJfJkcJV2f7KRcFKgalonmFStimLlldZkkmYLAh3SxjqcbrFiXAkXqHnqTfWZWERT1NU5IO9c3J4UNbTTO MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 588d9010-7afb-4bc7-d878-08d82d1b7806 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 02:12:07.3276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: haspusyQqaV2oHPnBMot8B2lnSQ1mupghIgcIktYzjBYiMVHRsF9HqaKxa1Js+5cJRBDJt9ncGUxFPLKLabf0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4555 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable I suggest to include instead of . If so, other Pi definit= ions are not required to be included.=20 ReportCpuHobLib module type should be PEIM. Hob can be produced only in PE= I phase.=20 Thanks Liming -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chase= l Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B21=1B$BF|=1B(B 8:58 To: Kuo, IanX ; devel@edk2.groups.io Cc: Lu, James ; Kumar, Chandana C ; Prabhala, Varalakshmi A ; Chaga= nty, Rangasai V Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/M= inPlatformPkg: Fix build error Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kuo, IanX > Sent: Tuesday, July 21, 2020 8:35 AM > To: devel@edk2.groups.io > Cc: Lu, James ; Kumar, Chandana C=20 > ; Prabhala, Varalakshmi A=20 > ; Kuo, IanX ;=20 > Chaganty, Rangasai V ; Chiu, Chasel=20 > > Subject: [edk2-platforms] [PATCH v6 1/6]=20 > Platform/Intel/MinPlatformPkg: Fix build error >=20 > Fix ReportCpuHobLib build error >=20 > Create a Library instance of ReportCpuHobLib from PlatformInitPei driver= . > PA bits reported can be overridden by Library instance in Platform. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2674 >=20 > Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb > Signed-off-by: IanX Kuo > Cc: Sai Chaganty > Cc: Chasel Chiu > --- > .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > index aa256534..83fc5249 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > @@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 > **/ >=20 >=20 >=20 > -#include >=20 > +#include >=20 > +#include >=20 > +#include >=20 > +#include >=20 > #include >=20 >=20 >=20 > VOID >=20 > -- > 2.26.2.windows.1