From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.5711.1594298745664828841 for ; Thu, 09 Jul 2020 05:45:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dOhm8wCL; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) IronPort-SDR: eQydZTvZ4RypcP8fd2NE6T0IIFOeSO2oF5cYDmLlu6penZkMqx3SqY9ORwZSa/Yce0+R1chEx+ p+Wf/tGb8Aqg== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="145481007" X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="145481007" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 05:45:45 -0700 IronPort-SDR: bSWtziGnwJL7RgzPUu8H9+TNPRcMoEjNGvUXf38ebomudjI/UJAF9o+FToM4LoE6ZL5LzFxstx PgjQqlhbHbQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,331,1589266800"; d="scan'208";a="389131277" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 09 Jul 2020 05:45:45 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 05:45:44 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 05:45:44 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 05:45:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPDc23h+4tLGmM9RSmLGxnQYtsjQjvvLbLO+93zaQxdIUs1+pJQseTWhEv1TzVXJZXKUkmjUqq1BwLCT8tEmTssvsEMNhcLjWWzpIzKpbXN+0/221/dbHY6gVjMWO8l9DNj8tHwFA4bCLftF8RnY2JGc3aHWPRMnJaL60zvD74FHfMC6vTb+f1fWfQ4zcF7qu4HkgyzxKgFJsp/7tu4okXLt8zeDPPZM5u1zql6T/SBY3FVcmH+s58Y5S1sYRs6/F3zmIrupwn5yrDnkEU6y1eQIj4+v1CrSUHa4rg8vWAJaMlaVbAd8+H2AyszBRkMB/SrLvFX57BGEjSzJ/JudKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkU9lNlJdRWSncBhSfzegqKZPV/k3h1ZzR/9vPppJ9g=; b=m/TAQt0Q0ksOofJElXBSOJXBlRectsdX00i2RSC9HdJjSsME/77keWufF1FrhYpLxS0WKNMTApq/VBiCp5kYQCwP+9nxpuUMQcZtR65oHQ+TIt5WVGOlpuWsBjDbUqKvNUJVMLUXCZMqgZQkuA2bZullh/35NBGT3s8zzHSY4siwrh6qCOSFJdzi6UlyPV4Pf9EImdhqshzeFoycgCGy20ffxPcgtR8aYG4nx9ntARKe2jeH+t0yJvmx7mV57z+6kLrhVwl7uuPG0rwvF1bFMnRttrrY2FFxsC6FcHo+ilcIgW/Mn5ZZE7nfN9lczRAOdG33cRwnxo+uNBjl68O0dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkU9lNlJdRWSncBhSfzegqKZPV/k3h1ZzR/9vPppJ9g=; b=dOhm8wCL+q3bMp5YNgpLEuLXZEuAEg3bsA8MjM6yQc/E2Od7sU+KfGv6msUX79hagYsHtD6LAPLRdX2SFmXgayviNz6+BbqK7DF1hJuuKoiuHrYK6583fFSIlvB+eP46/Fop8EzBxXemYSCjonj46U1yLkby87IplLgN+hx/SKs= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1374.namprd11.prod.outlook.com (2603:10b6:300:24::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul 2020 12:45:42 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3174.021; Thu, 9 Jul 2020 12:45:42 +0000 From: "Liming Gao" To: "Kinney, Michael D" , "devel@edk2.groups.io" Subject: Re: [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in INF Thread-Topic: [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type in INF Thread-Index: AQHWVaZBgcf2D5AAk0arMw753fATdKj/MmVg Date: Thu, 9 Jul 2020 12:45:42 +0000 Message-ID: References: <20200709040521.3748-1-michael.d.kinney@intel.com> <20200709040521.3748-16-michael.d.kinney@intel.com> In-Reply-To: <20200709040521.3748-16-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8159363b-1485-4f5b-a2ec-08d82405fe0b x-ms-traffictypediagnostic: MWHPR11MB1374: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oFFKBepMHQcP+C1dNfYCCU20vHRJooM2KfMakbsFhPFgc7Bf/T6gqyvPzYldIkn8gGqCczbKJuAMaUFbnnJPYEYc0zACX9jTr8lydqkln5rVFPXscO+hyis680mDxEB0vKY5SyFhbnhDCTvWUISNfjojIzXqLL1rKRmWFd3IDIrDAmQA4vMkqlj6jtfrPRZRIuvpm+cYydrGyNyy3duTqN/jqX/K5L3WLsLCcWOprC6TvMMsJQafSzzH5urKa0AlxnwvI1BRvzksyFa3cTXTFtZSGZxzO2pvAV0Pg73Txyq9EMwTycKKe5+DtS4gTOuJZZET3HVskj7kGtmL13MIvA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(53546011)(66476007)(76116006)(7696005)(66556008)(9686003)(66446008)(64756008)(110136005)(186003)(86362001)(8936002)(5660300002)(26005)(55016002)(6506007)(316002)(52536014)(66946007)(2906002)(33656002)(83380400001)(8676002)(71200400001)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: mgfifh85CRZbWWMf+4bqHfalSsa90OMSias8b9sg3E5S3ShjkIVKWG/ErFRt8p0fLSxA8bt0CvQLF4lKmhlrp/HMhhTftn2ps/5szoxqkU8k7bBjMV106Qf78xMCSQ698ZYU473cjanjIVcjMqMBfEM0JCNL6Sql463Zzlrt0jE5qiTvK7mL73EukzcuZvdOETYZaQQ/jNFwT2ISv2R6Ll9W1gMSTHUxxga42Eo+Z9A827ghO4of1tC5Hp3jE2rKC2AI2aL0SsIRzSq8sMei3THPy2HstQzgPV4uSRU6tqblwsUMqvgse6BTlvyGjEFcL24GutyymA4Kw6Ajuqf6k5ek6JkbnUphT5mgPdujMYTDQZVKZPnFr4G23QQDmgljRQQ/gv035hKnMv76OlbtGvGwcDeyeFt60LhnSTHdZeje8jx0EfA6WfcoJ93d1bH1DL7/ymCRmyPLDaWIO4DaE2FjM16F/05/e0aq52FpLiT6JIoWgO5o8DXqKMGNQbGk MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8159363b-1485-4f5b-a2ec-08d82405fe0b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 12:45:42.7527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wcOPIb4ILcXf7eYso/dX9GOIMJaF9WVMqQQC19oj25tKnbqRkaEeRs9zYlOVqQewpMUGFsDjp1pCYbHN4JA5Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1374 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, July 9, 2020 12:05 PM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [Patch v2 15/16] MdePkg/Library/BaseStackCheckLib: Fix PCD type = in INF >=20 > Update INF file to use a [Pcd] section instead of a > [FixedPcd] section. [FixedPcd] should only be used in an > INF file if the source code looks up the PCD value using > the PcdLib FixedPcdGetxx() services. Using [FixedPcd] > forces a platform to configure the PCD to type FixedAtBuild. > In this case, PcdDebugPropertyMask supports PCD types > FixedAtBuild and PatchableInModule. Without this change > any platform that wants to use PcdDebugPropertyMask as > type PatchableInModule breaks the build. >=20 > Cc: Liming Gao > Signed-off-by: Michael D Kinney > --- > MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf b/Mde= Pkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > index 4ae3bd1a82..0dc3c4a83a 100644 > --- a/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > +++ b/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > @@ -36,5 +36,5 @@ [LibraryClasses] > BaseLib > DebugLib >=20 > -[FixedPcd] > +[Pcd] > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask ## CONSUMES > -- > 2.21.0.windows.1