From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.790.1593789226711158927 for ; Fri, 03 Jul 2020 08:13:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=o6P/FZ/k; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: qnzDGQEr05jD1tDV3rO0pSneT37xiaUp36c6R7u4SQAqMvR8v5aRfwgYKnGoGD377pNsL/YU2/ 4+HRXv5v7ocA== X-IronPort-AV: E=McAfee;i="6000,8403,9671"; a="127250741" X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="127250741" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2020 08:13:42 -0700 IronPort-SDR: k9tP6J8OIIjx83RMmD4vpb7mBZ4twww3MzWB6uMDOVEHk1dlHnIASXMuSR8GNoBj45esOPYWbk 78P+4zkc3QCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,308,1589266800"; d="scan'208";a="296228334" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 03 Jul 2020 08:13:42 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:13:41 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX122.amr.corp.intel.com (10.22.225.227) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:13:41 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Jul 2020 08:13:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jii5KgWuZg9WB3xFzf47bgl2jmcy4CFUEOIHakEILKXD/9SaAEKhFZwi5kLpGnFp1QV4p0MXd7mnqTwTEo6cGXqXxNNlGVBd+k45fQIvGQMtiP5yuCK2tMs0JiPyOWVGbraWgdBOuhTuYbcI4tk7XfFNIjZ/rpluwrS+Xh/1EsNQlNMW2T4aCwzKbfGEO5gntJHNHjnqSIWHG8CiqbgBlcqDemaYW0xhadGiiGl7dYPBI0lGOV6jBRwBnfcKb14aMXCxNmireXowrnS0wRVA0go7VQ4JKL9Hkp+CinbaUfvZ4gMNLFKBaflpdf6DfIkawOm+ZsJ7qK4Gn4qD7p5ARw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvrYmBWDYutxn69WIiFt/gqPGZoLpGjEeZb5GghyZjM=; b=FgNYc+KijCYNojbAKmPB3yyGQVCMrULlYuCRRXvB02am32BN/C2YUrida6wz8silY4j0KAy5gzDIHhQvRfC7VVYh5ssdTo6IFFPVxsKiwd6tfM7xnnHNKwYMFcu9EEqZQ6KAUxxTQT9CXGkx0FTvPzyOGTh1O26de/kicuDxq/yafSaGIOk6Ejn90nzDdRb4ap7P6Mn6pRJznEoWIOl9/affKgZXlrTiS1ZqoVEmj24jolwqMlC7zdfYwumGnkwQkmu25nD5SVexWLZUmTUr2gDJf9sTMym+cQ3er/UWcXTO2QSZJ0oJCMwQavst6YrAHRnc8NLkjxJsXfAEptNLnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvrYmBWDYutxn69WIiFt/gqPGZoLpGjEeZb5GghyZjM=; b=o6P/FZ/k4IFVZ5MzWEr05vJq5fU/viAM0FvF7LGm9uyy9So0/leiSh7AXZNGJ1JZWX6rNz2CzLnwU7uC5oAo977umXLfsb2g/toxDjfxGol+dxGzqL+jRtiMWEXFDfYcbcq8IYVjghJeRGo4dmhYShHRcIyjT85antO6FyFr+Do= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MWHPR11MB1533.namprd11.prod.outlook.com (2603:10b6:301:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Fri, 3 Jul 2020 15:13:40 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::7847:b564:1b55:b67e%6]) with mapi id 15.20.3153.028; Fri, 3 Jul 2020 15:13:39 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , Laszlo Ersek , Leif Lindholm , "afish@apple.com" CC: "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , Sean Brogan Subject: Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Topic: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Index: AQHWT0q+A+HbqNiua0qnPJnnFgj1Bqj1+M6w Date: Fri, 3 Jul 2020 15:13:39 +0000 Message-ID: References: <20200701015516.17108-1-shenglei.zhang@intel.com> In-Reply-To: <20200701015516.17108-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a06625ea-f674-48a1-c56b-08d81f63aabe x-ms-traffictypediagnostic: MWHPR11MB1533: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 045315E1EE x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iqSKk3epw0KHtcl3MOR25TRe6tlzzSNV31V7IDFUol4OfI6npurMLUG+JuyTy5OIG6k6cPOrZSu9RH9T1akpn6KThHwPQ0KYSYTNbNzBa3ZfOxVfyy0NwA/43BCH/s/N0qssucBki4w2iB6WukYoPFsOw0bWao5CT6a0/rIOtl5jfCDGTuMgJCk6R1kOUoOYUT2CR8cBojE5WMJulwTsSVvTEHxLMkhBz3XhG0X1Qc/wlb+nuCQEfTBMudbsIMPtolGCz99JxD8xjRUr4I0tzPu65xdfbFj3huW5O+HImRJ+tAsAW1dQbFswWV9JBnilVQgyePiM3YZwcL9IXIhDbxbGi3uPhMn8l21Fb6EiH1cl3dK/TlsxBis03twCRidkVR18NOksOMIDij2Q45BxQA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(26005)(33656002)(66556008)(64756008)(66476007)(66446008)(66946007)(76116006)(9686003)(55016002)(966005)(54906003)(316002)(110136005)(83380400001)(5660300002)(52536014)(186003)(71200400001)(8676002)(53546011)(6506007)(86362001)(8936002)(4326008)(2906002)(478600001)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: dm3BuuRnQQqCArWwzKxWdnGx+jBWYc7BbuwRYdhSk3/7/dNWzq5Hzh8yYdSm6LYG5YXkDr1YpAoCYN17VS7fIjlvnZgMmFTWTFypW+wE+LNFPL8XB9bD1gI76dAhOE31E+VTHG6eJHa2Gr+ob2SDv4C4nLN7wef0H9t7qXIyBXuky6NDFuhYYgLfDQQwDax4OA//k4TyLIB+tc18HMjs9SSmGfIs8EBU6jUwiWbvs52Dk9GlcOmA4tR0Go1ubuYYp7+VyGqWz6xs1sl0o1SJT87t9gquKV6M2uOMFgJIYoUBjoxDdJr2u3M9FMoUwupLmf2pfbS1w3l8HgjgJeHvBJdnymVmnYe2eKWX+pu2igNU+v9w7bwO/ehLAIedoWJgqHm4se1L4oR+1qabXsuzKde7E7DdZczBAQvibkBhASTz6X6u5IA/j5ATlkxQ25zCo8QoiSSY6x7oykTx4Y0R0yWHrmvhUS0/M9cVmczhNXw9ZVwJE8DJhojTlcj8IC6I MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1630.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a06625ea-f674-48a1-c56b-08d81f63aabe X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2020 15:13:39.7558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bypW45kqzJrQ9DaGohMhEL2/u+ip+U5Ih+pINIsJMpNRLZWj3OS4fkJaZedZXp8rztezFRE0hRUyUemzdInx1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1533 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Include more people and collect the comments.=20 ECC is the source file coding style checker. Here is its wiki page https:/= /github.com/tianocore/tianocore.github.io/wiki/ECC-tool. If the changed code doesn't follow edk2 coding style, ECC will report the = error.=20 This patch set enables ECC checker in open CI for each patch coming into e= dk2 repo. That means new changes need to follow edk2 coding style.=20 Otherwise, new changes can't be merged.=20 If you have some comments for ECC checker in open CI, please reply this ma= il.=20 Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhang, Sh= englei > Sent: Wednesday, July 1, 2020 9:55 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Bret Barkelew ; Kinney, Michael D > ; Gao, Liming ; Sean B= rogan > Subject: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues = for edk2 on open ci >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2606 > As planed we will enable Ecc check for edk2 on open ci. And they are > ready now. I appreciate receiving feedback and comments if someone > find errors or false positive issues. >=20 > I created a pipline of EccCheck for my forked edk2. Welcome everyone to > create pull request to test the quality of this plugin. > My forked tree: https://github.com/shenglei10/edk2 >=20 > And I also created some test cases for ECC plugin. Below are test cases. > https://github.com/shenglei10/edk2/tree/ECC > Results can be view in below azure server. > https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=3D= 12&_a=3Dsummary >=20 > Patches > 1/16: It's a lib necessary for py3 to run Ecc on azure servers. >=20 > 2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can b= e run > on azure servers for open ci, or a local virtual environment. >=20 > 3/16~16/16: We consider some cases that will report out Ecc issues but t= hey won't > be fixed, like submodule and industry standard related things. So w= e > add two configuration fields "Exception" and "IgnoreFiles" for peop= le > to use. These patches add configuration in yaml files for Ecc check= . >=20 > Cc: Bob Feng > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Sean Brogan >=20 > v2: Update 1/17, fix the bug that the script can't hanlde multiple commi= ts. >=20 > v3: Update 1/17, set the only workalbe workspace is edk2 root directory. > Update 2/17, designate the version of antlr4 is 4.7.1. > Add 4/17~17/17. >=20 > v4. Update 1/17, remove the function EdksetupRebuild(), instead add > function SetupEnvironment(). Update variables' format and type hints > to pass flake8 and mypy. >=20 > v5. Conver the former method to plugin solution, to align with > other check points on open ci. >=20 > v6. The 1/16 patch is missed in v5 series. Now add it in v6. >=20 > Shenglei Zhang (16): > pip-requirements.txt: Add Ecc required lib > .pytool/Plugin: Add a plugin EccCheck > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check > FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check > MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check > ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check > UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file >=20 > .pytool/Plugin/EccCheck/EccCheck.py | 268 ++++++++++++++++++ > .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 + > .pytool/Plugin/EccCheck/Readme.md | 15 + > ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 + > CryptoPkg/CryptoPkg.ci.yaml | 11 + > EmulatorPkg/EmulatorPkg.ci.yaml | 11 + > FatPkg/FatPkg.ci.yaml | 11 + > FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 + > MdeModulePkg/MdeModulePkg.ci.yaml | 11 + > MdePkg/MdePkg.ci.yaml | 11 + > NetworkPkg/NetworkPkg.ci.yaml | 11 + > OvmfPkg/OvmfPkg.ci.yaml | 11 + > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 + > SecurityPkg/SecurityPkg.ci.yaml | 11 + > ShellPkg/ShellPkg.ci.yaml | 11 + > UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 + > .../UnitTestFrameworkPkg.ci.yaml | 10 + > pip-requirements.txt | 1 + > 18 files changed, 448 insertions(+) > create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py > create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml > create mode 100644 .pytool/Plugin/EccCheck/Readme.md >=20 > -- > 2.18.0.windows.1 >=20 >=20 >=20