[Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
@ 2020-06-24 14:21 Liming Gao
  2020-06-24 14:33 ` Chiu, Chasel
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Liming Gao @ 2020-06-24 14:21 UTC (permalink / raw)
  To: devel; +Cc: Ray Ni, Chasel Chiu, Nate DeSimone, Eric Dong

Update GetPciSegmentInfo() API to match its library class definition

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
index 6a6218d906..398f4d4b78 100644
--- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
+++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
@@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
   @retval A callee owned array holding the segment information.
 **/
 PCI_SEGMENT_INFO *
+EFIAPI
 GetPciSegmentInfo (
   OUT UINTN  *Count
   )
-- 
2.13.0.windows.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
  2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
@ 2020-06-24 14:33 ` Chiu, Chasel
  2020-06-24 16:17 ` Nate DeSimone
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Chiu, Chasel @ 2020-06-24 14:33 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io
  Cc: Ni, Ray, Desimone, Nathaniel L, Dong, Eric


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, June 24, 2020 10:22 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update
> GetPciSegmentInfo() API
> 
> Update GetPciSegmentInfo() API to match its library class definition
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe
> gmentInfoLibSimple.c
> b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe
> gmentInfoLibSimple.c
> index 6a6218d906..398f4d4b78 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe
> gmentInfoLibSimple.c
> +++
> b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSe
> gmentInfoLibSimple.c
> @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
>    @retval A callee owned array holding the segment information.
>  **/
>  PCI_SEGMENT_INFO *
> +EFIAPI
>  GetPciSegmentInfo (
>    OUT UINTN  *Count
>    )
> --
> 2.13.0.windows.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
  2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
  2020-06-24 14:33 ` Chiu, Chasel
@ 2020-06-24 16:17 ` Nate DeSimone
  2020-06-25  0:28 ` Ni, Ray
  2020-06-25 15:23 ` Nate DeSimone
  3 siblings, 0 replies; 6+ messages in thread
From: Nate DeSimone @ 2020-06-24 16:17 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io; +Cc: Ni, Ray, Chiu, Chasel, Dong, Eric

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Gao, Liming <liming.gao@intel.com> 
Sent: Wednesday, June 24, 2020 7:22 AM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API

Update GetPciSegmentInfo() API to match its library class definition

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
index 6a6218d906..398f4d4b78 100644
--- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
+++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
@@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
   @retval A callee owned array holding the segment information.
 **/
 PCI_SEGMENT_INFO *
+EFIAPI
 GetPciSegmentInfo (
   OUT UINTN  *Count
   )
-- 
2.13.0.windows.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
  2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
  2020-06-24 14:33 ` Chiu, Chasel
  2020-06-24 16:17 ` Nate DeSimone
@ 2020-06-25  0:28 ` Ni, Ray
  2020-06-25 15:23 ` Nate DeSimone
  3 siblings, 0 replies; 6+ messages in thread
From: Ni, Ray @ 2020-06-25  0:28 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io
  Cc: Chiu, Chasel, Desimone, Nathaniel L, Dong, Eric

Liming,
Thank you!
I didn't realize MinPlatformPkg contain an implementation of PciSegmentInfoLib when adding
missing EFIAPI to the API prototype.

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, June 24, 2020 10:22 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
> 
> Update GetPciSegmentInfo() API to match its library class definition
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> index 6a6218d906..398f4d4b78 100644
> --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
>    @retval A callee owned array holding the segment information.
>  **/
>  PCI_SEGMENT_INFO *
> +EFIAPI
>  GetPciSegmentInfo (
>    OUT UINTN  *Count
>    )
> --
> 2.13.0.windows.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
  2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
                   ` (2 preceding siblings ...)
  2020-06-25  0:28 ` Ni, Ray
@ 2020-06-25 15:23 ` Nate DeSimone
  2020-06-26  3:27   ` Liming Gao
  3 siblings, 1 reply; 6+ messages in thread
From: Nate DeSimone @ 2020-06-25 15:23 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io; +Cc: Ni, Ray, Chiu, Chasel, Dong, Eric

Hey Liming,

Any chance we could push this? All MinPlatform builds are currently broken.

Thanks,
Nate

On 6/24/20, 7:21 AM, "Gao, Liming" <liming.gao@intel.com> wrote:

    Update GetPciSegmentInfo() API to match its library class definition

    Signed-off-by: Liming Gao <liming.gao@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Chasel Chiu <chasel.chiu@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
    ---
     .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    index 6a6218d906..398f4d4b78 100644
    --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
       @retval A callee owned array holding the segment information.
     **/
     PCI_SEGMENT_INFO *
    +EFIAPI
     GetPciSegmentInfo (
       OUT UINTN  *Count
       )
    -- 
    2.13.0.windows.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
  2020-06-25 15:23 ` Nate DeSimone
@ 2020-06-26  3:27   ` Liming Gao
  0 siblings, 0 replies; 6+ messages in thread
From: Liming Gao @ 2020-06-26  3:27 UTC (permalink / raw)
  To: Desimone, Nathaniel L, devel@edk2.groups.io
  Cc: Ni, Ray, Chiu, Chasel, Dong, Eric

It has been pushed @ edde5826b0d2a733ed1b341ffb882969a9130958

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, June 25, 2020 11:23 PM
> To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
> 
> Hey Liming,
> 
> Any chance we could push this? All MinPlatform builds are currently broken.
> 
> Thanks,
> Nate
> 
> On 6/24/20, 7:21 AM, "Gao, Liming" <liming.gao@intel.com> wrote:
> 
>     Update GetPciSegmentInfo() API to match its library class definition
> 
>     Signed-off-by: Liming Gao <liming.gao@intel.com>
>     Cc: Ray Ni <ray.ni@intel.com>
>     Cc: Chasel Chiu <chasel.chiu@intel.com>
>     Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>     Cc: Eric Dong <eric.dong@intel.com>
>     ---
>      .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
>      1 file changed, 1 insertion(+)
> 
>     diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
> b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
>     index 6a6218d906..398f4d4b78 100644
>     --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
>     +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
>     @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
>        @retval A callee owned array holding the segment information.
>      **/
>      PCI_SEGMENT_INFO *
>     +EFIAPI
>      GetPciSegmentInfo (
>        OUT UINTN  *Count
>        )
>     --
>     2.13.0.windows.1
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-06-26  3:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
2020-06-24 14:33 ` Chiu, Chasel
2020-06-24 16:17 ` Nate DeSimone
2020-06-25  0:28 ` Ni, Ray
2020-06-25 15:23 ` Nate DeSimone
2020-06-26  3:27   ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox