From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.14751.1593008860361421700 for ; Wed, 24 Jun 2020 07:27:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KsFuaCaH; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) IronPort-SDR: P7xmmmysp+roXABfT/3+nGKjeifGO83q6+2ug4Qj2EA155rPx3Bo/1frvxdLanbLQ4jy9F6feb hBjymdPW0Jlg== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="229163961" X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="229163961" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 07:27:38 -0700 IronPort-SDR: EA+xN8ObIjh15WO6KKMokHYIICa+NZr/SkGRt8oCveaE4CzGdDs4T/FD8bLCYujFDvRmkjLmSn 7MDXnQ19IF9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="265088460" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 24 Jun 2020 07:27:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:27:38 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 24 Jun 2020 07:27:37 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jun 2020 07:27:37 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 07:27:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gd98gXQWW3a0jyRJ9irJCTLusE6H6KnEQb8fXpmdRXMrnkK1DZQh4Gpj82kDNBdWWFn+wuP4accfcO9nTFzNRlqp8lhu+5YWF62mW4mHLYZg5zM2z35NJXNatguV0+11wuhe0P/zteircfDzEjdfafr9Vvf7DylQQxYHdoOKHIl5tnsv226fw+0ySMjXc7S7pZkisrgKVXYOiBW73sAKku9+yhiJjApqAAiqFixDn+d2rpFajHg9JGcxzhZODzoP1GQ0KYtzdgcKd+CuhDxA6alJPxEsGDDZ6BqP2aNa/b3JPkpDWkhS4AGpOKxIYqm+bXpgg7nY+7swAJ86xw+hCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WulNoMDLbHSNj5kRlPxYuNec938wm3OamskdxY8m4KQ=; b=MxPfdOpdYgGN85OQGlg1kc1yeGpV9qtWoHTKeQzAQhtvw8vYuBLxNRvVw7RRCFYtP1DXEdBl13zFHx2mxLz4XcJfgcHbyOfdGB5KOun4itNwXw1iqZ2eDW5/KSztm1ftTw4OjIFBI7hiAPzI/oCmXlHIpmcwd9l10EijUEavwqxnKMEoTbZMHlz+tORPmAQjFNrZOKdKplSb2IAdNkNWFfNUadf0ibqTHrN56TI/Es9YvxBxJZE2kwTBsb4/lqJRUw+jClgkmxiZb+XcOE34NztVM8KlxL6AwUoEuEM3Mdenlw/349G2hwHPePIE47TYY1u6yidb32YpQ6YhLkEKEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WulNoMDLbHSNj5kRlPxYuNec938wm3OamskdxY8m4KQ=; b=KsFuaCaHzDQ+LC3yzFh4jY6XrxaaLPWaJg09WaBfLY+g/RF6exVtH77Ft3ulfhJmEqT4xeNWCHiIUIR6AUUb5C1mcNd5J1hqhahixZtgVAfDlLv4F7QwvHFOB0x1pbz9m1pFdS3Jha8QkTucA5G3WJN9lIQbVneJLm4EzN8ttOY= Received: from MWHPR11MB1630.namprd11.prod.outlook.com (2603:10b6:301:e::7) by MW3PR11MB4555.namprd11.prod.outlook.com (2603:10b6:303:2e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 24 Jun 2020 14:27:37 +0000 Received: from MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e]) by MWHPR11MB1630.namprd11.prod.outlook.com ([fe80::50fb:d63c:5958:a67e%7]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 14:27:37 +0000 From: "Liming Gao" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [PATCH] MdePkg: Add Serial Terminal Device Type Guid Thread-Topic: [PATCH] MdePkg: Add Serial Terminal Device Type Guid Thread-Index: AQHWSXupqoKDabGLYE+/vQoe0r4rq6jn1AvQ Date: Wed, 24 Jun 2020 14:27:36 +0000 Message-ID: References: <20200623162927.82884-1-oleksiyy@ami.com> In-Reply-To: <20200623162927.82884-1-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5947a28-0cd0-40d3-4ca4-08d8184abe34 x-ms-traffictypediagnostic: MW3PR11MB4555: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GKuzzRySBZlh7ca4KCiTP582boR2gM2e7z75G58sWScl45cOMKmg4L1qGMW1HfBpyzGL/7DUsNeV3sCaMYWGAugxwEB8z31/rlauxCUVrT/vXinHrajyy9RWtkl1EWVKOjzEEE/A1ztqnbvrabFp57quHi2+0pYF7rYIK8i0RGqjI943yjle9tc65KWxdpH2wTguSua8MuVnkM4ErA6nybYia2HQoBscWgteRk3SloMTqKnIadVNJ55g97MzurPdYqneFwYm+yleljs+raXxNmtcAbHshGe5t5/Dkp1Ldf65/st0bs84ZiDWjQMijMrqfpldgYN/rZaucUIu2fXc1Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1630.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(52536014)(26005)(5660300002)(55016002)(8936002)(8676002)(66946007)(186003)(86362001)(9686003)(76116006)(66556008)(2906002)(71200400001)(6506007)(64756008)(53546011)(66446008)(4326008)(19627235002)(7696005)(66476007)(110136005)(83380400001)(316002)(33656002)(478600001)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: b+Szh2hppEh0iL2yBjwbhQM6G7/mgsimbA2GEsoiaIFgfJ0E5pMqdk86aoS70sH6GQk72TOV14ZXhFlbQx6DM61RUUtF+C/YjQEqEm1GztRsVgenLWAS5mTbGX5wav6AYXn5Smm7TmjNLKpnCuZNhfJEBXZXgoj91+J4bj5Gyj0vxYArCL30O0UW1LbfjuSGwvf6/WfYSij6db8v0k+PktlBADAgCZRmWIBLAsFTV52CeRBrySlyhgXo6NZyQ721RQqoNVuEFdCgcedK4FomxRGFxSqJQlsBihVKot7PXzorE8q6ZVcUquWyiMUdpjV6NpQ82nx9OvYwLpHnuE27+nhrs7Ctl8yu/gnpGA3L6QIcYRU9I1NG1EaNpqSePnKq9jGqabZi2Ec4i6TilGBOqv4U87Fe/Jc+dCDNDnACYE//6mKyQlOqBU0vBCi3/vecqyxhbBKvUIGdjR0GWATnfL4gr/oC02qTy+ibFD1qIX18ppvyksT1/zyFDKo8lDki MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c5947a28-0cd0-40d3-4ca4-08d8184abe34 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 14:27:36.9670 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oWWkDfIAapQz3+ZancCxxKPKErZSxvFdHKfXS/J2yDj3pW2iEFlu88sw6vSnIEvX6bW0rIZM9OmbYwG5JGn9zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4555 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable One minor comment. > -----Original Message----- > From: Oleksiy Yakovlev > Sent: Wednesday, June 24, 2020 12:29 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D ; Felixp@ami.com; oleksiyy@ami.com > Subject: [PATCH] MdePkg: Add Serial Terminal Device Type Guid >=20 > Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID. > It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch. > (UEFI 2.8, mantis 1832) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Protocol/SerialIo.h | 6 ++++++ > MdePkg/MdePkg.dec | 6 ++++++ > 2 files changed, 12 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol= /SerialIo.h > index e2e0c61..16a865b 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -17,6 +17,11 @@ > 0xBB25CF6F, 0xF1D4, 0x11D2, {0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC= 1, 0xFD } \ > } >=20 > +#define EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID \ > + { \ > + 0X6AD9A60F, 0X5815, 0X4C7C, { 0X8A, 0X10, 0X50, 0X53, 0XD2, 0XBF, 0X= 7A, 0X1B } \ > + } > + > /// > /// Protocol GUID defined in EFI1.1. > /// > @@ -299,5 +304,6 @@ struct _EFI_SERIAL_IO_PROTOCOL { > }; >=20 > extern EFI_GUID gEfiSerialIoProtocolGuid; > +extern EFI_GUID gEfiSerialTerminalDeviceTypeGuid; >=20 > #endif > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index d03fc5b..2ffb71d 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -798,6 +798,12 @@ > # > gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, { 0x9= 5, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} >=20 > + # > + # GUID defined For Serial Io Prtotocol Devicee Type > + # > + ## Include/Protocol/SerilaIo.h > + gEfiSerialTerminalDeviceTypeGuid =3D { 0x6AD9A60F, 0x5815, 0x4C7C, { 0= x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }} > + Please define this guid below # GUIDs defined in UEFI2.8a, because it is = introduced in UEFI2.8a.=20 Thanks Liming > [Guids.IA32, Guids.X64] > ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid =3D { 0xA55701F5, 0xE3EF, 0x43de, {= 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }} > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and proprie= tary to American Megatrends (AMI). This communication > is intended to be read only by the individual or entity to whom it is add= ressed or by their designee. If the reader of this message is > not the intended recipient, you are on notice that any distribution of th= is message, in any form, is strictly prohibited. Please > promptly notify the sender by reply e-mail or by telephone at 770-246-860= 0, and then delete or destroy all copies of the transmission.