From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.8686.1670488357507319709 for ; Thu, 08 Dec 2022 00:32:37 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C0azouxR; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670488357; x=1702024357; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=y8l6FlJiS7diKmeiAZtiOkaimobYHLhd/eeOSfe67wE=; b=C0azouxRCzwMNw63pw2UDkrd9qjyATpa047pSwxn/N6rBYh64Q7HVtMs MY61feJT0iM3RWo/sg/fKcxwHwz2+HE8W8O6o7x4kBnO8JP+X8GCP/ujb nSRMH5zkC0olEXJpdzeq+7yW31teIS2PKE2ikoytlL3nrB43t3ZGu+3og KAwSzeygqH5UkB7a+1Mn0T0/3BYC0CVm7+RfUFdjrVUcZs2/bWM511wet weVMaHZUBCJuSfAGfcQt2Xy8gKIyLPuLa5yLin216j8YY2S34N6ZBfe3d rasH7jlWhVOsOzR93ytCh7mg9zY+9T4P22zz8qZL3TOc1NVqslaUL6cTB A==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="315831700" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="315831700" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 00:32:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="624620913" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="624620913" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 08 Dec 2022 00:32:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 00:32:35 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 00:32:35 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 00:32:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OecxrRhMtw1HteGR0ixImNmej5urxXzGP4Dp70GlOksEg13YVV5opRf99a5tQamkbA4tGGojkm/B9BGKxWItPY0kfhpFPX2ZDC4PkLPrONh5BNdXQh6YvDuAHv6cnXqrbyUSR9LR3OUvSDA2JlwGMfz/q+/nRMv25pDk1J+8dQovI/qfSlrCJlbGbd2MsN8liogoWU/0RVNZ389Ii92Ddg5zYTpLLJXwdwbCrDShdiWY8V5zfGZN31jGU596RWy7mGoHABZe9THj1I44CzvlCdjh57bza6GGHRKeDliU4yaOcj4MWSmcUuSZnJ/3pEjB6lHikQgHYlYoxwR/7oixZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8l6FlJiS7diKmeiAZtiOkaimobYHLhd/eeOSfe67wE=; b=ZLvE+KTEjpAWeA+tz14qBndUl1QSrNhsEyFdYHxLlYqsX2yMmUSX1u8CnWTmSQYwaDxluimOumaHiRlq9XKCbtNHLQRJaJ9fRPbAgKlqahik9aJ82yPvrfgD1XQu+Do0eV6CdIiQMe52jHxbNNARKOObZ5h6hAFZwHbp4auL2AkQEoHo/xF4xsDqFXKCATBQmzMAsAG7dBWbsxYNU9wL5N1j0IMsyuF1cnVJQRsMfCn59W1ylM3G8Bdr1zEFEZLedOz+CMzo0Mok7uYL1fV+yzkkwhy05jN8VqsIL086lxvCLlaqoiwMsjDfVPbe0LBwlJFmyiTswC4C6Isbde7xNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BL1PR11MB6026.namprd11.prod.outlook.com (2603:10b6:208:391::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 08:32:32 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e%12]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 08:32:31 +0000 From: "Ni, Ray" To: Sunil V L , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" , "Dong, Eric" , "Kumar, Rahul R" , "De, Debkumar" , "West, Catharine" , Daniel Schaefer , Abner Chang , Leif Lindholm , Andrew Fish , Ard Biesheuvel , Heinrich Schuchardt , Anup Patel Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Thread-Topic: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Thread-Index: AQHYwq48vhYxUeZHmU+SsZg7QrtLf65jsmBggABLqACAADus8A== Date: Thu, 8 Dec 2022 08:32:31 +0000 Message-ID: References: <20220907113626.540065-1-sunilvl@ventanamicro.com> <20220907113626.540065-11-sunilvl@ventanamicro.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|BL1PR11MB6026:EE_ x-ms-office365-filtering-correlation-id: 7fd60eb5-eccc-4cec-f4e7-08dad8f6bfdd x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kvroGWKAj0cHKs2+f7Lrxb9/GF/RgOuPhwthPzmEw9HK5K6o5wqwhGP9Rf8awYTIURwWa+jQuA1NRkNQJzLGInKl/WYiij1OfjQR1w0b4DOmQqIvBvynITj7eJOFKLRT8atmDaS0TwbSbOGNln1FSMAsxh5g+cC95VvWoTrV3Sok33Ub5M+wTvVUI8O22n6ITw3xquo4LTjCrVKUkDmK+M7i5woggesoY1uKvk7JVM8ccGwGFqn/NXfmcIZgRVhhEi09G531b+WcErGCCMBqrXpMxKIRM35xxxKZfpabjNrRsNAgPrhC+7kttBX7bdzyWDwKQpZiZn50+uSWx8jMAeDT4efKB0so0MUJlJqkpEfqPstpM36u3gdGgzXDaS0B5pVGZ0J1WtrfZXXWhpMr/Aor0QFB/tqRglD8CbnuAsfjMWRjCDcrxa1BgA2ReTV8L2pbQC0iOjSN4yOKhEwwHK+jyo+QCGrdGGkyspPmA3najCYv95LJPvEqd4G+mXD3bNTOUfkhLIJ0aJSO4DHZGEJixKtuHYDMAonNKkNyVokqp0LBQrGlQn7EF71AIEk5G9JSHbxtpVcQduHzb9xg+gZCDwlMdz6lxymoRM54tLnQTFsqDxz8tkfQbOyAq6zwPKckHMtiCYP49QYPuIGXgbcXPtqXKLOjeoZBMLKmIuz7zWxEli1JqJroqZpVHoV7MjB4WapYL48yg8JBSBhkjJB8G/C10RaLdREj7Nrsyhw2qpG/B/Thr1FhP5LWOIWe x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(346002)(376002)(39860400002)(396003)(451199015)(83380400001)(122000001)(38100700002)(33656002)(8936002)(66446008)(86362001)(66946007)(76116006)(8676002)(478600001)(41300700001)(66556008)(2906002)(64756008)(38070700005)(52536014)(71200400001)(53546011)(186003)(55016003)(6506007)(7696005)(9686003)(26005)(110136005)(54906003)(316002)(7416002)(66476007)(5660300002)(82960400001)(966005)(4326008)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o8ADlBBeStF/6962uMIjwsgOshX13xtnCs1bV2S+TjC+A7oGRdsLM0lVzHrn?= =?us-ascii?Q?Fjs/ivWhRC0AtHhKK7tUToWvo9T8xxtR2BN2ljmfrIH51YXdhsSTK6S6pRvM?= =?us-ascii?Q?e6VtUSHWY1bT6ftUuYc9KrckhDEOBYtW5Ejz0L0K9/Ce4yfRk7ctFcj39Lkq?= =?us-ascii?Q?86Pd+4KJPJ/kmdGnYh4vHUwVwF/Kj+1phvshgdGoTlvMjEbVLo2OIPysei3l?= =?us-ascii?Q?LVz50GkFP2PyQWQ3jJVIabmalFIBbA4R9EKBeLUDGz7w68U7be/fb7dyMYa8?= =?us-ascii?Q?gWlkofw+gl5aGcXciSHcsXqgonUubGNHBfPs90p6pTs+t5KEQEd4+GtZy4ET?= =?us-ascii?Q?j2ElYV0h1SlOGPZEIpT3vNjKsag9GonofZTHa3Z1XAWGmimaHrwsBDZhp647?= =?us-ascii?Q?MnaNurDXt5Yae8iWrFq15B2zQFwWgo27yBQDNctqUOWkDoP6AgQoW7N6YiEd?= =?us-ascii?Q?idjIOhRza+tnLsE2Jjq72x1L1E+WI974alILWDpxr7jfSvRnjns3pc5zgSDc?= =?us-ascii?Q?BU2p4kHj+1iLrSOUimorOhkc7pgYnLMEEf2IjgNVTuf5atuSnWpXgGTIGiSP?= =?us-ascii?Q?jdFooSWdoalX6dJy4tU9tEPDpK2CVD0KG2/+ysTPDy8BTf3Gi4nUwEcP4B0L?= =?us-ascii?Q?Zsm1xOs8dSegL8JgkAryz8ugvKMIT9Vz9UQqEyFBLL+qV8LHhJHjG96gJ++a?= =?us-ascii?Q?PUwL64qj0qTeSw1mUjFjxh5c4ed630+07fjPkz0qmYB3VkB39LHScpBc2VIR?= =?us-ascii?Q?RAaaee+Cv4+pA0j4tB9CBM7PQaLPoAIWLNNCesKrm67rcNpJQsnRRmBstEw5?= =?us-ascii?Q?C9YTWA9Z9JWkOyZP2ttd/uVKBUfmfGzZzsN/LTcVcZsp+KqBGqusO3dCJpV3?= =?us-ascii?Q?l48TwVC4rgmnEZ9fEP7E/P+UpU9DLHzbax4sGskfxSjnGuNlffT44YeL5ybK?= =?us-ascii?Q?6DU66Or8fY0D+5pLyriUGv9ABE5sxuKgqZN2Qk0OOTriYtdLLL7km/x/ppDB?= =?us-ascii?Q?TY0emDOru1q2SxV0nokF+nMVr6t+cuEDWSsrbtmukhWPC6vyt9EmCCjUre2F?= =?us-ascii?Q?7Grl0DYAL0YxEzv8ihocCYPWK6EgfEfTvSoxwaG159ODcRTZjpsGWUQSHQLw?= =?us-ascii?Q?bB2wYRLkcGUHU55g80pRsFwUA01v+WbLbRfD/BzYziFsN2pJtjPcV/yqYbuw?= =?us-ascii?Q?CNFA/N9xon4Pg+WHCf0TEar9GdKAZaVoqCoqzDfcMf+3Q6QFNAusemnFBIJV?= =?us-ascii?Q?pQOtYYncrfA5IzlbS4wjQbYOtLhrwOeYCJWiu90KfZqB15GUwxfMDelnCB7b?= =?us-ascii?Q?i6wQ6LmmkGbStCGZ6SOvAVK+V623OzIfsGQgQilHlWri7rH9+SsIdyhqZ0+G?= =?us-ascii?Q?wEEgUyJsYl0yCYoboerMLT0SxuAoRTWVVceP4AwxfzyX5UQ0aYtDAplJLgwM?= =?us-ascii?Q?hnKuBO3KDpsKHWkXkCXMPt2v+w5IigG198/RIlt1BVqmV+HlY0fpvprAA/di?= =?us-ascii?Q?nD/pJ0KzOk6v+v04ogHYpF1UXCvgIvM4zKSejA3K4ncg7rVqEkNuGcMfxqkO?= =?us-ascii?Q?HsU5XV7oVoJQUaRUvMc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd60eb5-eccc-4cec-f4e7-08dad8f6bfdd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2022 08:32:31.8739 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rlxQxMAU/CE89QfL7THHLYL9vRolXBLh0e5SJzKc1+Y6B6QpeIU1Q1iyvcWxD+vILAHUUjQyFERXtCuSwnwvPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6026 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I am not sure if the preference for modules in other packages. But for code in UefiCpuPkg, I don't prefer this way. Thanks, Ray > -----Original Message----- > From: Sunil V L > Sent: Thursday, December 8, 2022 12:58 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Wang, Jian J ; Gao, Liming > ; Dong, Eric ; Kumar, > Rahul R ; De, Debkumar > ; West, Catharine ; > Daniel Schaefer ; Abner Chang > ; Leif Lindholm ; > Andrew Fish ; Ard Biesheuvel ; > Heinrich Schuchardt ; Anup Patel > > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V > support in DxeCpuExceptionHandlerLib >=20 > On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote: > > Sunil, > > Is there any source code sharing between Risc-V and IA32X64? > > From the patch, I cannot see any. > > If that's the case, I would prefer we don't mix the two separate > implementations together into one component. > > Can you please create a new CpuExceptionHandlerLib instance for Risc-V > instead of including the Risc-V sources into the existing INF? > > > Thank you very much Ray. Sure. That approach is also fine with me. >=20 > BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series. > Sorry for the confusion. Let me update this series and send new version. > I think your input is valid for other modules also like TimerLib. >=20 > Thanks > Sunil