From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.9900.1647610756274503659 for ; Fri, 18 Mar 2022 06:39:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HMqGXWmv; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647610756; x=1679146756; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lA8KWnValS7szzKtO4rjsGFDhhUpGRGEtYRR/EIfm54=; b=HMqGXWmvUfBoukEdGJyBiW2i0ZrwStua9x2Qt0HlwZAOkJh8XDH+sMEk YpXOIiqUEDEgtIYIVQ4kI4WiZ8w7VelGLj1PuydsgH7w9gjZvz8RwAg/a p8i3my/gaBDT0vSlPLek4CKXMdGJvs5n3I1vaDacPwEpSGBm5AJyh8mQf hsE4ybyRfUY3Be5kfoBqX9o+qqGV35DObshjVnRADsZnWzzFBeMSJtPPR wLthTUOVbr/ds8noeqFaLTzk9IypFycQ00zTod5pBnni7zvBML82OKruh xZEjqAxzaeY4a05QONxwnp0thuiAs6NfOqTysyXUte1mRVNdWNuAA6DpM A==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="237748254" X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="237748254" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2022 06:39:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,192,1643702400"; d="scan'208";a="599499844" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 18 Mar 2022 06:39:14 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Mar 2022 06:39:14 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 18 Mar 2022 06:39:14 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 18 Mar 2022 06:39:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsZpB/x1PAskF5r6A/xI4Yn3tJkw6tIG35Bbf28a3pGpfiu56GhxfVoJey4yQPecQWckmlRb9uRhkEoeiezjtcFjwJ6UBvFPiC9aah/uPozOvGcZzY1rr0jtvFRLsMkO1Y0bJ8Ar6fDve+4VqQ/WN637a+c4Q0Ih/ugJ0YbmBzGIcqaPazzcFI3e48GPGu5WzpsPPYfNr4BGbPFR+tYeLlP8X+6nwh144/mvUJfITNF3bss89LE2IR90A5+zgozMmOjFn9gvUWfipc9IFAtvf3bpdqWSCyEO+RYHcznPjy9KSsPiS5Tbr4i7h3FCgisLzhEoEbkioyzuWMsRRB+eFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zc7KZH4cYXXO8RaLQBn8R1g6ivNNMURrgY6cSgX0Rm4=; b=C1x2Vwpnb+lT+KLEjmkeor0xEEiT7yugIjhWrJp/Qm4qi2fdLr4S9+fW4UPDIhdzojoK2eMqJ2vrT39WVHze6WfiHR6Xj6Ka2JqhowwWpgietZtlls52zlpJrXVpZOCOS5qaEvukqOC80SYP4CjjB/QqCMJSXf54dg9jFmknxaX5q2SvBJ3APRSej2pVj2b9unh6nAcW577pvDkZqzUh1gBtfrJ9zsCIm+Gj2b5N7OOybngN1wR9TyOOvx1ENziUYk78IEPuPcRQIeNtYKdeVzXdCeFq9tK9AQ+NgcDSGEcaJcFK2vC2UvC1N3ZabwwckUHjlPUjZnyXFezkb31HbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA2PR11MB4907.namprd11.prod.outlook.com (2603:10b6:806:111::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.17; Fri, 18 Mar 2022 13:39:12 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::30a3:3926:64ca:50d5]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::30a3:3926:64ca:50d5%8]) with mapi id 15.20.5081.018; Fri, 18 Mar 2022 13:39:11 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Xu, Min M" CC: "Wang, Jian J" , "Wu, Hao A" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V9 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set Thread-Topic: [edk2-devel] [PATCH V9 35/47] MdeModulePkg: Skip setting IA32_ERER.NXE if it has already been set Thread-Index: AQHYOmHvVqz1x+IHDky+69P5t2QK1KzFJkiw Date: Fri, 18 Mar 2022 13:39:11 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31922c79-5c31-45df-8c56-08da08e4af8a x-ms-traffictypediagnostic: SA2PR11MB4907:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +evDZSB7qWNhnUxfbDvL4ElCzjhBB9Xo/ujDbo44yHN6XtJPCUdLuPsbTz6Vf0agzR+gcYJxCuoJ+SqPr94WJteGwxn6CsG3ZfIMf/jgMKh0k4tjTHQsibbqUeOVXqMD+Na5Zrw6lM1e61YVhpC0hGiJYSgmDr1HEn56MhgCqEEnya07xB9S7ZKKWO8KJ0zwN6vxy1hS21ghdctHdgKhz/s2fk75ERPPgEjGPOm0Dm5y7OrOkhXU1kBkBTDRRJBetPhKIT6x3CkakwE2FfFv4sJC4dquTcqNH8L2ECM7SVoS8VoA0DrLXH1ywgHMqqmMOJ0138/8z0fcE4Kxytfkxh+QNA/I/t23skpA01+B0Cvst9wlHFPGTiRpePE5Huf/4ZO1OMBHxxyAMGD8ysRLSjhUof94Xpw1cUI3MWfQhB+Er2WEVjk1dvOc6MRuQyhfc44x5UHNow8Fgoos+jr713tDGy6qaBXTl8fjKxUq03/4FTHvKm0te2w1iXxLud/TyIY/hrt9DWj2Grptg7qu+SoyjHx+IYxc2gA9Kh7Zh9sRipjY28WrgQDB9xQNjhP271vZ8Kxo8zfIDh38jd8H5qd15SoIfI9RrbT73fPhG5G2W/+Lsr0ax4dpF0pViLMiWG4QIhO5SeKEKS1LqlWe3enyUJKYdOPQX7FSLtPXfW7DeEUX556ujXuaBmjWMgN+2UZpJLJdTPo9fKmdpx0uR+NMyGLf8ItXL6gyaXdUh1i/1Mk4voFJx9m5kfz+u3x3WG9ljRmnpGScvIFiTS3Uas2HD6spGfruEj8I9xGpE8dJZ9kWoNGUEkXe9u2O4Bs+BwNVw7lCF5GZUtbPO4f7IQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(316002)(71200400001)(6636002)(19627235002)(55016003)(54906003)(33656002)(2906002)(508600001)(83380400001)(966005)(6506007)(4326008)(5660300002)(38070700005)(7696005)(53546011)(8676002)(64756008)(66446008)(66946007)(66556008)(66476007)(76116006)(122000001)(82960400001)(186003)(38100700002)(26005)(52536014)(9686003)(8936002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Dzs8g8WXTHyjt4W5q4Hy0pqDmRP9hxS3hP4SbdFX5IRfMhjOjNrLlrHFMT7d?= =?us-ascii?Q?Z77cZeOl5D5qrRdJ3c4wc/yKc8xqW24cVkQjXVqZK0k+JAYqMj5vZfT/14gw?= =?us-ascii?Q?MizEvYnOAk46VeiB5S9H0wjEroi5GpVe+TA5vxrdeKHrG67ltwb0d/DcKE4U?= =?us-ascii?Q?IE0gzNE6J5uNM1pIIj0faByc6fwWLJ5+Pkho0MYrG9SyxtNLb7dYzk37V9El?= =?us-ascii?Q?NXhYyQpGLkYQmzyzljCfRIVvMZYtfdHYo65EukBU4/T2REcE7zhYPhysYnKR?= =?us-ascii?Q?prSiQaDyifD9mZNw+z+aOz+4jDUXmjriJBvVIqScB+kcsFs9q026w1XCCcmU?= =?us-ascii?Q?P96zlk8wPRummzn4w2SnZ+coR/WIj/TtUqQBJ5up12vpqUAPsLlvB8qofpjh?= =?us-ascii?Q?VSrGAQBJKb2zia4SKoXwDllASsEs4dtesUKyVOLOzg0xkTQ4JguFTV0V1h1D?= =?us-ascii?Q?9AaxVTxRN5RB5dpNAYmcgP4S4+wqLJqn6iWmxg6pU36Hrpc8nHftNdsCKK8A?= =?us-ascii?Q?AmLA4i5ImmndrYa0fWE5L8S6pLUYUO3ayZLFuSneJejDa9+YB9qEvis/koD6?= =?us-ascii?Q?uTD0CFVGLBnhitnTZfrZNWw9UbdWzpZXUjaNEVD+QkdajAO1/58sWdiID0KN?= =?us-ascii?Q?ArkYJBdn/GVHBIwxSxznAysv6TjzTrByv7PK6iVgtVXC5s1zHfJuquGA+gnI?= =?us-ascii?Q?aJEQD7k/pJqOBeM6bq8Yg1I9TXa3ukBaNsM6JYf5vvFP+IO3kPDEHfOUjcMb?= =?us-ascii?Q?2pS9Lo9A0CFKyaWR28UaKQrlmVKY9Wcp0geP9EjMUo/7Eju6FeXa8qJ0acg0?= =?us-ascii?Q?IuSjbwBE5ifIgvcnENG2W8vShlIYs0yvfmf9Y/ynTYDobSsEMlr3w7Y0HJ0/?= =?us-ascii?Q?G7k1ZKDfYCYpsaKHFJzWWrsvqBnClCabdEvw9sQKwJZO3YA88ugR2uVrtc4x?= =?us-ascii?Q?bYFuvKMs1hJ+aCHg8c1lnNb/7ctBvoZWA6eRKg7Cwd1NUEOS9A0dUbUlMcQa?= =?us-ascii?Q?bGUcN+iFZ+Py74eSNn2/aVmuf18HrdvEW5m9xVVBjyRdJCSpJVEgv+vjzH8h?= =?us-ascii?Q?RZqcjiRw/KFJad70fZfwuLRItMNsthi8v/LEzqtiYjpRgb5DjQuovpNt1S7V?= =?us-ascii?Q?NOX8/dy9VF+g+4tCg9ImibBRgko0jfqNWGNqVG6F+yWfS+woVmUaZ2Fa1ztS?= =?us-ascii?Q?K2yspLeUvqvV4VJaxGZeo6JrV9JgJ19IwS5xtatXRU1Q5JD92BM9oURlpdUS?= =?us-ascii?Q?hGVC2KtbcqyJ4qt86TxCK6634WrdDQxDqWgps8hNFWRXOzkExGSpt61ZPCDW?= =?us-ascii?Q?NyKFdowL9FBIsref2rx2egnQs6bap74PlN/T40u8iO4tGg5HVvbFIKaGmG10?= =?us-ascii?Q?e/A5DHhzdYbQNs/u9xxfUwgTkPsYvVJkppeJ6dWHBKKqyvpI5Z+ETEfYASx7?= =?us-ascii?Q?sG1ZbIbmnDDch5APdIV1EGhYUo2XUGcr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31922c79-5c31-45df-8c56-08da08e4af8a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2022 13:39:11.5598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QXQw2alnUm3Xewgecpzgv+FZeSBmmAf8M+fH0cKROY7At6stcxgHI3ni3402B9nXmYIfn2nCcPuFreZLy4DW/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4907 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: devel@edk2.groups.io On Behalf Of Min Xu Sent: Friday, March 18, 2022 8:46 AM To: devel@edk2.groups.io Cc: Xu, Min M ; Wang, Jian J ; W= u, Hao A ; Brijesh Singh ; Aktas= , Erdem ; James Bottomley ; Yao,= Jiewen ; Tom Lendacky ; Ger= d Hoffmann Subject: [edk2-devel] [PATCH V9 35/47] MdeModulePkg: Skip setting IA32_ERER= .NXE if it has already been set RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 If IA32_ERER.NXE has already been set, skip setting it again. Cc: Jian J Wang Cc: Hao A Wu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Reviewed-by: Jian J Wang Signed-off-by: Min Xu --- MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c b/MdeModulePk= g/Core/DxeIplPeim/X64/VirtualMemory.c index 1ebab2782010..a451ca160408 100644 --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c @@ -179,9 +179,11 @@ EnableExecuteDisableBit ( { UINT64 MsrRegisters; =20 - MsrRegisters =3D AsmReadMsr64 (0xC0000080); - MsrRegisters |=3D BIT11; - AsmWriteMsr64 (0xC0000080, MsrRegisters); + MsrRegisters =3D AsmReadMsr64 (0xC0000080); + if ((MsrRegisters & BIT11) =3D=3D 0) { + MsrRegisters |=3D BIT11; + AsmWriteMsr64 (0xC0000080, MsrRegisters); + } } =20 /** --=20 2.29.2.windows.2