From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.26449.1657530715650348595 for ; Mon, 11 Jul 2022 02:11:55 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FEL6JYp3; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657530715; x=1689066715; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ic+bH/mEL94UTpV5d5XHjBIXc0LmznxuHcKLncVz+vM=; b=FEL6JYp3BDfn7hijp+UtBoTsLhNbxRhbpz5m359SWQcRMwVfsnKbA00x t5csExZXtsLVNO0kN4ycGGXh8RlXFvxKonNUylDHJF3mRQYUHb7xBqhn3 kGwIurhBsktouIb3qwqbL606upAUac8mUVVGbkRtBSXAPIlQJ1zl0wEqj Wwfyz1AJzsRjHTXU8Q2/OkEtqesp7WWhdrDMV+ZO96g4lDETsLzfnay+c dqxAF78ATb4lEpmHHuUWk81MN8Xq/LbLGlyorcMmAorioUbWDMvuG7jIR IfhaxSv7bHmcsq9W/ZoSnlTITtOJOowvKw3DwfAMHB1NxtTbiDI0klncU w==; X-IronPort-AV: E=McAfee;i="6400,9594,10404"; a="267655781" X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="267655781" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 02:11:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,262,1650956400"; d="scan'208";a="627422018" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 11 Jul 2022 02:11:55 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 11 Jul 2022 02:11:54 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 11 Jul 2022 02:11:54 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 11 Jul 2022 02:11:54 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 11 Jul 2022 02:11:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAY9HNPaDIE4ptUCau2Zycipw7/VHBn040oXPoYC1iqtBtfiW0ZnSjw96l41TXOxW94bdchE28MrV9E8R7sS2OvlclGPrFdpxkmBNRgD/DK3VRqNFTKqOyw4euzjgM5WCXXj32xJI2ZTnZVMTyuIQ3Up6BmkswYPcr84HiqzwAOVMJul8TjULT9FuJ5KPx5uqHKELBp2/s37ykagXdVXAfJGLdBIgHOfvDZF//I+fz4+GASnr1KRcl3FintQ3Ce7Tt0FuaQ6MFf3Ksy2pC4FiQGuDZVfT+FSdY1ElxUa4oXQFwo3/KYeeBXqFkKU8CB7+cfqFygSWDzlTfh25vUDxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AnFjayhfv2WO8XWh2Ry/hfTFd1gYBPvAc4YcqBFE+gg=; b=lMMVqUDLDtOUWfHr+XHQVVJvOSnV5d2ouBF+LOPG2e+Z6yuUatOSE41OgyuaBzWtk5KWg7Mcey5JgeUzGfgDDFySsigbcbQcmX6Dz2IN+7AaCbwZ8OMQJBSxHj+XS8waLOgBA+Pdhse8r75G+dNSDTsqOEj1/s+qovWnIl+Byp44w5WKdHpXOqfKk2w5bdTaSqR3d5QzV2N5hfaLmgry72JTxXJIqWaDa3lhPeqS+HrgzOEF9LXm1TDlwxobExZ3hB2ZKRT0AIpF+Ff/TnR9dpa5gRsJiX4FmBFb45Q0kTU/ipRK1dVZr5xXZ5LhrAva/6AnJAF60ufrsPepNQugpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY4PR11MB1510.namprd11.prod.outlook.com (2603:10b6:910:c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Mon, 11 Jul 2022 09:11:47 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174%10]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 09:11:47 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Kuo, Ted" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "S, Ashraf Ali" , "De, Debkumar" , "Han, Harry" , "West, Catharine" Subject: Re: [edk2-devel][PATCH v1 1/2] UefiCpuPkg: Update SEC_IDT_TABLE struct Thread-Topic: [edk2-devel][PATCH v1 1/2] UefiCpuPkg: Update SEC_IDT_TABLE struct Thread-Index: AQHYlQY/gdJJtDPtrECIbiZBNAymnA== Date: Mon, 11 Jul 2022 09:11:47 +0000 Message-ID: References: <16FC6A736EB591CC.466@groups.io> In-Reply-To: <16FC6A736EB591CC.466@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b1c5dad-fcc4-4349-1507-08da631d61bf x-ms-traffictypediagnostic: CY4PR11MB1510:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /lBozAZCWrFx+aC9e+7bb0xOIJP12VdqpVd0cwUbr7e94q8v7zr5Mps/SHjoBJGLEtAnZ3cJ/vqRUVjp3zjkcIlM2w0HaxWEXVG4kiSdgl5GILB3t7x/rfRv74Toetmn7nUo3/8RcoqCZSpMqxVBFA+Vz44IqiUe3FEP/4Z1z49alIKGIPgtB7BfbbNo1/Qqr0XYtDv1SVKp0DuKIOevVAB7OQpbnL8paTnFOie9famwLucyhtYHZEkxWhe9Dqx/I5/68uBXSNjkkCErE7Ss+1h6HPaf7ZqFYtxmijwcnds2eReNGEM2/wV/ei+l2Mj950WUU1jidsAPcRpMKrQC97WOLEtP+pq+WhZbYGtz7gFsl8OZHzWgYjDY+DIvtZG8InhKr6GwVRkSESGKRd92T7CVBcAfuIl3GRdiKynCONIZKEUJL1EjuNjoclslvTDpa/d0iHgfWn9KB3pi+gsijscfoyte6AfjMu+qy+mu9Qbw0ny9qZHDg/cxDSf+uxm6JlPGkbV198sArkGnwUVuyR+m7Je1IcPtB9KN5MxkryrmsRs7Gd80dktVrZKOO3uYA6Mhx2U30oGZHfM46OzyalcyHvPiBuPv5tKUDvC+J3BSDgdoNkrLPSwaEIaHQqc+LXQkMwMkJOCp9Ofjq+oEJi7uyJqVn4ocS570f/hE1fmnC+UyHaQcDVbQtBmJ3Cp+luSBjbOat6AWRD74U4kiwmWconpOt+NB1tyikruF78LtXNn9KjKxFUTah+XUWkWJXImUVZFMpxtPCgLNHyegFbculsi1gH18j2EHnSJ2scTrzzX1Dagh/9TRKuAyOP9iziVsmVTZpr8WL4cy8PJoB/858sqL3m2pyKJ9H/3HfmfN7rJXowtRhym1pIaqLvMf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(39860400002)(396003)(366004)(346002)(9686003)(107886003)(26005)(6506007)(41300700001)(64756008)(8676002)(76116006)(53546011)(186003)(7696005)(83380400001)(478600001)(66946007)(38100700002)(82960400001)(38070700005)(52536014)(8936002)(33656002)(2906002)(5660300002)(15650500001)(55016003)(54906003)(316002)(71200400001)(110136005)(86362001)(6636002)(122000001)(66556008)(966005)(4326008)(66446008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XLhoU/xPRgExJJlnSae56FddK/I98IPkf/fsyfThf3G9WBU4/y6DtiCbxmak?= =?us-ascii?Q?2kzFetmAQfIpfqCEDLI55uYoHigLLxb44Kku7W2KscyoBhRq+AHAQ01XHWTN?= =?us-ascii?Q?MgtYQTdy5szZ1IhBjLEO9/ThMGYTufQP3JgRseF/J6VT+1GxMBQgkaPqhLml?= =?us-ascii?Q?MQxddGU2uRlQxIKREjRBgtT5nNsaR3ZllrAdtrJe7wRsnolOJ4ZHJWCk1Jfj?= =?us-ascii?Q?4OvFEL+vQ0+euVcunZ/qAoSwI6Pt/5PqXPnBa7Wum7UCHO9C4YHuTzdifaRr?= =?us-ascii?Q?lp45RVLjLgUv2WDFN6W0HOjyGenydkH9AY0hlYch5OKmvAhFjWDdK7jVv4Ji?= =?us-ascii?Q?5lZpK7KmbSbRzimBbEwp2CMXv1zsZohkJwAWOQJtrCVnriUxA+LIWF0aHTX+?= =?us-ascii?Q?Hz+3d4ifDYB4Hbra9eBOHZg5wwdFzF0BJcmBmYip3hMkZUdph7jp8wByeBE0?= =?us-ascii?Q?B+YJtmxsovZjr9FKNb40LJJOUlnYwcat3PTpavs9mQ6t2wlPipjg52DpZcxs?= =?us-ascii?Q?eRxOSUWscFdlTbmJLK6oGSet1l5F1u7j2pAB+m2NIDO7FE7/1oJvHwOzga52?= =?us-ascii?Q?c/xp2uD4N9aPB8SgFUqPrQ2MpSvNjDHNfLtejTktkpw9qrjftUR/Quv1WZGm?= =?us-ascii?Q?iqS9zxAVMePGMDlueDuZbWGjMy21BrtNXe+FLk5r35wBlFcjqHjUySZ0nFx4?= =?us-ascii?Q?08/HIRYk5HQKp8XQAgbqEpVldXWICQNDM0ZjQ99rl1uLGVpxDBm+UzqEKY0T?= =?us-ascii?Q?7sbpHJ+Bu/jarAQNllfYn17iMc6SCpQ2723B7sryMKMCTlqF+SjaRB9hXORk?= =?us-ascii?Q?KWs7ym5txmfrx6/I+kEjw49P90jNqGVkLhIPbBvB2OIu/Z6nXHqJ1nm6Cxoj?= =?us-ascii?Q?b1BuXavgeHgMqZTsOmvJQ/dzGPazufVj2COrOD6spH0RHawCA6uCt5G0VIe4?= =?us-ascii?Q?+X10tNiOHq71ejd66VQUq8kCo+fkJm1prWFNq28EoDYpkmT4b0pFzCFlZaeZ?= =?us-ascii?Q?/5D+Q6ig9lhEf3ZrAdb2DmaE/pnRIYXWbtNhtQCD6Unzz/LDmbc+kDZsKlFe?= =?us-ascii?Q?7RXSHgVqJ59o+v3iO75SjXZx87kqsC7yDCat3sCGA3VpjqlMjFClDdLsN64C?= =?us-ascii?Q?+LwN5G60vJiGtzG5SGP7RdpY6OThga92BF0bev7neq7yTSs/uE2KGkN5tiLy?= =?us-ascii?Q?8m/xmH8cFWlrR4Wzuh+37YVqTS/zlcjQnguefIeHbANH6yJD53uyCq3p5qYD?= =?us-ascii?Q?JRDHV+ibWXK8KuojAs6kASm4UpbtMWfvN27cERILAnjM49RZuCA33UB1R2wR?= =?us-ascii?Q?/n3Qa/H0g2Mduf8kXuR/cvt2ryRUfHa4PKt8ygux/lp7vA7BY79bl+fV6+T9?= =?us-ascii?Q?/dOScMMmgct7byhHQ5R2C1/CGUi1hm7aLamBtKQIyWPjjO4t8wzZj5dxy9Sx?= =?us-ascii?Q?rvsFyTh5lOCSDkHoobnduAOI1nSqpypE6OOepu07sJh7W0/BNldaQDtDcqXG?= =?us-ascii?Q?P7/v87ewjoMI4d2ucS8IH9UlKaoSW5RANgbxVeW/DMtl7sgQEaHkoMyIH89y?= =?us-ascii?Q?NfzVrndVRtSnnWXbE6c=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b1c5dad-fcc4-4349-1507-08da631d61bf X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 09:11:47.1148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /sVgZ8HiO87J5BwGAIT3SVU435yYBoGeN60QkOyOpmHUxyr3pL2aQQD/NQmP5e+QmJ227BYPSAPJMcyg90uGlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1510 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kuo, Ted > Sent: Monday, June 27, 2022 3:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Ni, Ray > ; S, Ashraf Ali ; De, Debkumar = ; Han, Harry > ; West, Catharine > Subject: [edk2-devel][PATCH v1 1/2] UefiCpuPkg: Update SEC_IDT_TABLE stru= ct >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3957 > The reserved IDT table size in SecCore is too small for X64. Changed the = type > of IdtTable in SEC_IDT_TABLE from UINT64 to IA32_IDT_GATE_DESCRIPTOR to h= ave > sufficient size reserved in IdtTable for X64. dff >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Ray Ni > Cc: Ashraf Ali S > Cc: Debkumar De > Cc: Harry Han > Cc: Catharine West > Signed-off-by: Ted Kuo > --- > UefiCpuPkg/SecCore/SecMain.c | 1 + > UefiCpuPkg/SecCore/SecMain.h | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/SecCore/SecMain.c b/UefiCpuPkg/SecCore/SecMain.c > index a7526be9dd..d7140c2db3 100644 > --- a/UefiCpuPkg/SecCore/SecMain.c > +++ b/UefiCpuPkg/SecCore/SecMain.c > @@ -202,6 +202,7 @@ SecStartup ( >=20 >=20 > IdtTableInStack.PeiService =3D 0; >=20 > for (Index =3D 0; Index < SEC_IDT_ENTRY_COUNT; Index++) { >=20 > + ZeroMem ((VOID *)&IdtTableInStack.IdtTable[Index], sizeof (IA32_IDT_= GATE_DESCRIPTOR)); >=20 > CopyMem ((VOID *)&IdtTableInStack.IdtTable[Index], (VOID *)&mIdtEntr= yTemplate, sizeof (UINT64)); >=20 > } >=20 >=20 >=20 > diff --git a/UefiCpuPkg/SecCore/SecMain.h b/UefiCpuPkg/SecCore/SecMain.h > index 189fcf9326..1be57c2248 100644 > --- a/UefiCpuPkg/SecCore/SecMain.h > +++ b/UefiCpuPkg/SecCore/SecMain.h > @@ -43,8 +43,8 @@ typedef struct _SEC_IDT_TABLE { > // Note: For IA32, only the 4 bytes immediately preceding IDT is used = to store >=20 > // EFI_PEI_SERVICES** >=20 > // >=20 > - UINT64 PeiService; >=20 > - UINT64 IdtTable[SEC_IDT_ENTRY_COUNT]; >=20 > + UINT64 PeiService; >=20 > + IA32_IDT_GATE_DESCRIPTOR IdtTable[SEC_IDT_ENTRY_COUNT]; >=20 > } SEC_IDT_TABLE; >=20 >=20 >=20 > /** >=20 > -- > 2.26.2.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#90785): https://edk2.groups.io/g/devel/message/90785 > Mute This Topic: https://groups.io/mt/92015981/1862468 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ted.kuo@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20