Re: [PATCH 2/3] UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, December 16, 2022 11:01 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: [PATCH 2/3] UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h
> 
> Remove SmmCpuFeaturesAllocatePageTableMemory in this headfile.
> This API is not used by PiSmmCpuDxeSmm driver any more. Also
> no other files use this API.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 25 -------------------------
>  1 file changed, 25 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> index 54cae865a2..52160c7145 100644
> --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h
> @@ -386,29 +386,4 @@ SmmCpuFeaturesCompleteSmmReadyToLock (
>    VOID
>    );
> 
> -/**
> -  This API provides a method for a CPU to allocate a specific region for storing page tables.
> -
> -  This API can be called more once to allocate memory for page tables.
> -
> -  Allocates the number of 4KB pages of type EfiRuntimeServicesData and returns a pointer to the
> -  allocated buffer.  The buffer returned is aligned on a 4KB boundary.  If Pages is 0, then NULL
> -  is returned.  If there is not enough memory remaining to satisfy the request, then NULL is
> -  returned.
> -
> -  This function can also return NULL if there is no preference on where the page tables are allocated in SMRAM.
> -
> -  @param  Pages                 The number of 4 KB pages to allocate.
> -
> -  @return A pointer to the allocated buffer for page tables.
> -  @retval NULL      Fail to allocate a specific region for storing page tables,
> -                    Or there is no preference on where the page tables are allocated in SMRAM.
> -
> -**/
> -VOID *
> -EFIAPI
> -SmmCpuFeaturesAllocatePageTableMemory (
> -  IN UINTN  Pages
> -  );
> -
>  #endif
> --
> 2.31.1.windows.1