From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.15453.1671431907783982220 for ; Sun, 18 Dec 2022 22:38:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=JCpj0pSm; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671431907; x=1702967907; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4cLgPbrsCg5DmWljKrQR7I8uBkrlWwV0HvDP7ep8964=; b=JCpj0pSmR6JLhQjFuXLFx5kjqJCx7vDVNtmwE0SSL6Ip6np5vmP26jym Y5t4L3ah+ya7DbT/NfKZJT5StRDAxv9FVk/DbHSS02w7mVw8GP/zT6dnP 9acULXUfKMIlL2XVSn448UFncbmHWjHjS6FrJRBLFh0doLb8uhJPH7UDQ Qb21ifJTh/NrfapNbuLpJfvgBQC4ZDVq+/YUUnG1QZWDWqzGlRyvMa8Bh giQ3ZTqlKETqy/2A12iLUR8PXQeGQGK9/959dGLP0g/XGmTsAxSn6bV7w TmB0g0OmOASbafx3lm169aWp1ANT4Mp6cWsgi42CzLNjbrOxTRHuUuaj8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="316917432" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="316917432" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 22:38:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="628203795" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="628203795" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 18 Dec 2022 22:38:04 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 22:38:04 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 22:38:04 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 22:38:04 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 22:38:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBO9M9jExrExfkNdVrIPkHG4Q8fPSWKv1v3tFoiSlg7OP2cNM7+6lX5hHB6EEjQhLzCtXMYyPb8oSyTRXDsqpQBlNXQNGlRX7QzPYDbsLj8mDSYWdehrh3SPiwDK4B9hCWVK9C7p4LtkuRKWT23UrPobezELVqjHsFNVz36EYA3Iud8TN38PQAxlZwGQbwdapF4INJj31rl0I6vs+gvuANse+O70QwPmv86zL9mElBj8X2yQzQc+vKHYeIcXH9r/WbvAPwiGym571YY4tuC87oBL4MIUXkUX1kXfjwTXbMgDHyV6vehSGxl0HwvOZhia21tkAgyFmP33eSiJwt2zXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Hrbqj716GwfB3KuUnusoSVGMAVmEm9PiuqCzIhxYOI=; b=iOg/Eaytj6RuciDLvcakczOApJ/SuUCKHHPpk+PC/SnRdRq7LfE8/OpuG2j4bMmI2b0SHh7yNlFXzZpLYaHZkO8BJhb1Mvk03t7oAv0wiVEWFm0skW8FX2TonTUDQQd/p4bAkFA9tedF1YVqJg0AoVmRSxrMPyk8cdaKZBdv+3GZjhkJH8bmiIg2k9BMclKOG+U83jV6fkjhGgBJ4/MvchcjPpXm7NFmTKHisoYSVJNYZX6z9Tj6HMm24ApQwq6j1zB9T18xwqvIP5H6orP9QYJNFq9gZaCxpmI3ccmLABsVv72z7ERX23V19CIIH0mJsK2asmxEBr2xr+KrnYq1vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA1PR11MB5825.namprd11.prod.outlook.com (2603:10b6:806:234::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 06:37:57 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 06:37:57 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [PATCH 2/3] UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h Thread-Topic: [PATCH 2/3] UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h Thread-Index: AQHZEPq0AIK3xFP3fUKwclweAFC8+q50xtVg Date: Mon, 19 Dec 2022 06:37:57 +0000 Message-ID: References: <20221216030059.1373-1-dun.tan@intel.com> <20221216030059.1373-3-dun.tan@intel.com> In-Reply-To: <20221216030059.1373-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SA1PR11MB5825:EE_ x-ms-office365-filtering-correlation-id: 6e878ef5-7488-4ed5-7be4-08dae18b90de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3vfFVy9xPqSLvsyLSrVIq0BDNN+zYmtYHtOmwQh8mUbUUJ4n61r6x1dvLNen7vjd3NZWsBFC9FbNs5rQvr+i0hTiHNpG/gCTTcGHBjyiXLRPNjw6hWnws6fcz5rM0WPBmrpTjyUwYjdj7TGNCQJtx4lrKtLRu6BoOE2osMW4+m5mo93xuvSL23e7+NBgOjUJYVqoll7O8ftvIFmwfokTQecjWispy51IxIfdN687L181svbSrIsnawId9awd0aGirzIBAldwaHyHDN/lBuanX8aZbaQOcsJ7kCPFyvp5Rm3UodBLicgRhlGHp+TusfhD0EWW1u5ChGou9CLWu6cP92RZFj6Y+79mxOnOf/WL8EcM4iYl7lvUvEf/f1nsluYgQHH8tFUMRSvcPGBx5fKfiG6hQSFXSnqw3ZA/Ibsx0XwX2hcmEp/fXdHGKA9NOpEz3n4B+JdTz9mGhO5HdefhCukLv6x/IrzyQYIJEXYHWtZM30Y90PNPkkeP0O86LlTybHwcBjxq95d246B0UpsPo2CHtpUxCtzWewWHEFFUVGyGzERxZqVfjfIKZRrVvooBDvV2mPqRs1VPopiEVmjfwvvXiVmq5gqJKKP5TH+h53pX18MYr9gyBMUMCd2H+XSL9cwmJigFjrbRv3CMV2ZFIeUFF5SxZwfTMpjwXlDRWH99NfPdm8RE/qlYOM75D9GplNjou0dASHN1J9lY8/pzzQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(396003)(346002)(366004)(451199015)(2906002)(41300700001)(86362001)(8936002)(52536014)(76116006)(64756008)(66446008)(5660300002)(66946007)(33656002)(66476007)(4326008)(8676002)(66556008)(110136005)(316002)(54906003)(38070700005)(71200400001)(38100700002)(122000001)(478600001)(26005)(9686003)(83380400001)(53546011)(6506007)(55016003)(7696005)(107886003)(186003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YAGxLCvll0Rld/Ksm7D+umZbgBF61Iwd1SlvXixjS0BSxdt0+7yt9f0FSHfN?= =?us-ascii?Q?8cDydQkJ8fGkteIzRGj5QfQVolioER4zyZw/FNYWeuvG4z6ju/RW+dWYu6fe?= =?us-ascii?Q?QZxIcUCYKc20t8Y/B/6hFJFA/WnzobV7UTb3Blm8+HoZ/g/OGF/g5qIQNa6G?= =?us-ascii?Q?ksxDI92dXeHleMBPMgwtZLL3aUbquKnrpGLl1VwOXISxWanVoqyB4EWR/NTm?= =?us-ascii?Q?froj3GGQ0sqNeaHrXUyJIai18MSjaItfe7KpNSpXTO2BkY3eYl7I4yJvJgoE?= =?us-ascii?Q?chtOG3tdpHd/tXJ59VFmGWLKNOoj/JAVyxrnM2EQl+/QdcGqMXpV1nQG8ZBp?= =?us-ascii?Q?egPK3cx2mJgnpjc4yX8yI0XMTblOAUbpBvKFbs+3FeVtHvWRswkljyliJmyZ?= =?us-ascii?Q?3XupLf6X3FSW6jxHjtg9cULHZm/628g/HHQREjMdV9jBT/g7zj5VBMra8lYm?= =?us-ascii?Q?4M9thNty4v9n9CMuWromtYPHnG4iPwgTR5UgtFeSXO6qoDbN1zWPnTWklnAO?= =?us-ascii?Q?8VzqjKYRfbGheCyeo9yYJzU9WwvOTjMCtThIOzQ7eEcvkhpcTEEEvZ+/2zvv?= =?us-ascii?Q?sXg2xwGZUImpL+zw9yCh3/rRGn9/CbQFa+0ZhraaUSZSxJyIDfLEYPNixJYl?= =?us-ascii?Q?9OgqTgFRwn45W/q9i+wqo3lUnmbJmqG56gUMsWz886ahDqdduOeAMVri5zjv?= =?us-ascii?Q?jAS1P2ZyOgi0N6tssyxIntqJ2lIJQ+D4EDrwylpcx+UThtb4Be4qPLRNPPKk?= =?us-ascii?Q?rsc0Ny6aL+/3GVPDXcAAJdaQQar4gy5gfm7N7MFqazgPiCt+lWE6KK1ybsT6?= =?us-ascii?Q?tBrHr03AArfv7ydwjH6eUnx+jkg6oUhrrRtFnsvsG/CUW5LIeGKmBB0dNhGu?= =?us-ascii?Q?z22pXBAR+tQSxEY7yM1vsUoMnBOCxGrsK3wfyDsvn2tD1yLK8JaPfg0vaXZ4?= =?us-ascii?Q?G56HU+zYK9lF2yJwgUL3wObhAfLC4P8lMjamPvPBiIhAA5FfYV3pOG3YquYR?= =?us-ascii?Q?eEnCEx4WFUtFcAkzYpmjb/m1jNvtw0NDNgdaBjinYsDrPeZ6lxnyS/5ilf23?= =?us-ascii?Q?pv2bWOWXhLBQym0DSNCcxkTRuYyDWNSwoGmk5xecf/XuwXPsg9JgiL9LWs25?= =?us-ascii?Q?yi7djkJ6w4dWDgSUE3gM58IlOwLGHuOnXRL5u4aP6ZTb4N6uL03pkTN8hQzA?= =?us-ascii?Q?RYd2ox70FQ6cu5s7LauokAJijSGHJ3Wql5DdaHfHLxbSVHev/hRkHpWD7DRV?= =?us-ascii?Q?32Cx+42tF5Sq8fw5xNRTNjmtbe+Nc8JA6GZ9/iqvveBT/Ww5qZy+lTLCujiv?= =?us-ascii?Q?2wg0QcxnbGfddJ/pegZr1fj+8hmJTN4bT3KjSdnBJly+bKZG59sZqCxMOijr?= =?us-ascii?Q?cLH7qrDYYNMhSdkL5Jf87Wj/rWMlA4IudJwcBQick/xTY0TTN5Nh4sFP7uUa?= =?us-ascii?Q?qh9ESgCNbT6ZgcmHzd/DqZFC7yK+ueLnSEOBHQ9PeKnne0UFHAbIBJctNi/s?= =?us-ascii?Q?YgZPb8agkYTyCO3112tXaw4IgqndSS6bV6De2kJopuUSocbdwE2hH2IVSqDQ?= =?us-ascii?Q?vEMt8F/ytdGmuxyQFCA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e878ef5-7488-4ed5-7be4-08dae18b90de X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 06:37:57.3081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GY7hpgg26zaG611WKw7/X39DSEyn00JGAOepLu8C8nUjDPrJWbH5w3X0prNZrs2TA9OUAoeUTPlbq13T0ALQSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5825 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Friday, December 16, 2022 11:01 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, = Rahul R > Subject: [PATCH 2/3] UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h >=20 > Remove SmmCpuFeaturesAllocatePageTableMemory in this headfile. > This API is not used by PiSmmCpuDxeSmm driver any more. Also > no other files use this API. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > --- > UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 25 --------------------= ----- > 1 file changed, 25 deletions(-) >=20 > diff --git a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h b/UefiCpuPkg/= Include/Library/SmmCpuFeaturesLib.h > index 54cae865a2..52160c7145 100644 > --- a/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h > +++ b/UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h > @@ -386,29 +386,4 @@ SmmCpuFeaturesCompleteSmmReadyToLock ( > VOID > ); >=20 > -/** > - This API provides a method for a CPU to allocate a specific region for= storing page tables. > - > - This API can be called more once to allocate memory for page tables. > - > - Allocates the number of 4KB pages of type EfiRuntimeServicesData and r= eturns a pointer to the > - allocated buffer. The buffer returned is aligned on a 4KB boundary. = If Pages is 0, then NULL > - is returned. If there is not enough memory remaining to satisfy the r= equest, then NULL is > - returned. > - > - This function can also return NULL if there is no preference on where = the page tables are allocated in SMRAM. > - > - @param Pages The number of 4 KB pages to allocate. > - > - @return A pointer to the allocated buffer for page tables. > - @retval NULL Fail to allocate a specific region for storing page = tables, > - Or there is no preference on where the page tables a= re allocated in SMRAM. > - > -**/ > -VOID * > -EFIAPI > -SmmCpuFeaturesAllocatePageTableMemory ( > - IN UINTN Pages > - ); > - > #endif > -- > 2.31.1.windows.1