From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.5673.1646119021836982537 for ; Mon, 28 Feb 2022 23:17:02 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ceK9ZPJS; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646119021; x=1677655021; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DHG3ZfvUsYn49n039+wa/p+xSXig4jfKMMagwiXaXQo=; b=ceK9ZPJSbz/pH9HmqdkUjAEFW93ahhjCxNLIYymWqyec+WrND8HfR3oW goOjjWbmJTQ6aP0IGdiIT3sCewDz/z2oEV8sGyQ06z4IkPIntj+q+Om1i Ad/ig1tfWhyW0C921imJOAzFqJCbr5BKnGDsZ1MKNQwZpzJtxhbR1WcZf dXAWrnLoZdaQFIDuG72se1d580oeRlbGjpxSg8l+cVidVIrYBur8qSK5x BLOx+hxGClA8NhAQbmnXfy47lCpJBmqtBtf479r5MtCCWwGet7ND/ZpFl OJRqvWGB0/h9qdZnoFgs0qySWCKmG/z1E1wWuEJK1f40+VFAG479Z0R/m A==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="316289198" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="316289198" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 23:17:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="493008979" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2022 23:16:58 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Mon, 28 Feb 2022 23:16:58 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Mon, 28 Feb 2022 23:16:58 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 28 Feb 2022 23:16:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPzJuUEKQJJkU+Yc+eg/wtk2HYBAoQ0u7wv8GiDs0VSm8pAHqNJ812iupZp0Hn73w5nn+e/AyIz0zlrX5KwPy8aqCK8f/ORAXes+4KG4tBcEqBB36Qmkek/+7bsBmWIm4Zp8kCf6UEWze9qOcSzf2tXQ4SSYG51lGjsUGM98X8StQqWe77YX08J2nS8wm6svSUhTydHoy9picd/HNgiQaOUsa6QX7NDZ9xG/2pEgsN8SnfxRoP5GBcPDODbaf1wOa3j/0e3z3wedi9J399LVb35E98NMN9UxDsbytgJxFh+DoLtqCkUEzXsC/lvWr5fUX+562uykjRihfiVqzCsQxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VV1Wh96gvz8dt4Evm8XDpJiYo88uL9xGPdypZq37tk=; b=NbrU9qDeb66pexETnZAddFbqh85/37yEMUtMkHpVh0rMAzNffPhbjbvZmJS+vZiLiGptB0WXkNXBA3fE+MY7fNMocDp12mysSs0jNL4vKlQSBaxLUvit9n4u1tfYExpWQD5A4gBALK5w6JaaN7WPtfekE8DjA+qiKA3ft/OPIrmlFSGoFUV0BfsppBV9AnmyrPYVmVMLqxgdaMQjiBk/XSFyNlIcyEJt1YXxBsSUrp5KnTAQ6/M0O5rVDfkwarhwd56qIHb9szUAdByKRzUWZ3sJ0yQv9WdRiijG+FslHJZcZUzxt60/CK61p678oktA89KmPyXfpBdSRFRh2kNEEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SN6PR11MB3486.namprd11.prod.outlook.com (2603:10b6:805:c5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 07:16:55 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 07:16:55 +0000 From: "Ni, Ray" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: Andrew Fish Subject: Re: [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Topic: [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Index: AQHYJ54GpEsdtMiYMkabvYp4ikTHz6yqKP3A Date: Tue, 1 Mar 2022 07:16:55 +0000 Message-ID: References: <20220222034038.966-1-guomin.jiang@intel.com> <20220222034038.966-3-guomin.jiang@intel.com> In-Reply-To: <20220222034038.966-3-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc7b90fb-12be-4fc2-7f8a-08d9fb537771 x-ms-traffictypediagnostic: SN6PR11MB3486:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xAMXzFYAANYf9Cl4WwwgiRQt0QdfLRvayGcQDKGW68jiSHhvtt4r5WA/JnwQxY04hIaJNzQOjytUeGEHNn+MbXPA8X1/z0R40fMzMwc3voZw91STNBHt2OXY7jXVioBqZlroXjTQ3r0C8PqXC4SeExq87khrLKrKAqwFwYyOWVSRoXPsDpY4tI+mrrgIOwIp56TpFp4Z+NgDWhH/xzX+oI/0/IxcqN6UZ9o/CTuJW36z2kUtbAJsEL64Jmb7DR8dtUuPx88qaGCLIPDdvEZM/F07wmKvdT1GDdV+aAYJUHprBzwTan2PZKcolkV2nf1Ow3sv5dUwBHWk1pOjn0pwql+fjYkGzQk+pct6GxRiutWeXveZfrSkn+SUT/UNTu+Kk2rQfd0gR2vzFQ5+Z6q9usH0Jr4QpVw9rYsI7nNAcTFmk5XcMNkTiw6NZCsQoRCuKKLANofikX7fKbAVS5LSMxPU1KlwUNk4xxCWMGbdn9FrsAuyWYZuwK4JcbveViJ1JuWodAyCNAP3cN093mebIZ07aGE6ZZJUiHIAlZXbRoK5aJrL4Gcd8ziNesfFcUBMC6HJ5RI4jYYn3jK8Vur3sRyHV1Wp9F6xkhHzL5qthdYj1o5+HOtacH21QyJvWVPu/ftAUzGtE6u3NKNvrEm1c4KhH+tYqom7yHWa9JO37u8F3UP0Q9dsUGz8fCnJZglj6GyhSp5ZdeVJ0RWOxGdU1RzcRRCKRPlUKzVK3I65/Lgem0MbsHvb+yeuOj3fpyh/n5jlhDolJPqFfbadCLkoaQD8y7KzrL+mfmKzXsIRoVs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(86362001)(64756008)(122000001)(55016003)(83380400001)(508600001)(110136005)(38070700005)(966005)(316002)(66556008)(66476007)(66446008)(33656002)(6506007)(8676002)(4326008)(71200400001)(26005)(186003)(7696005)(8936002)(9686003)(53546011)(66946007)(76116006)(38100700002)(82960400001)(2906002)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2913AW7duNlWfISveF9Do3eGy52yc/LZiIpvdY1IseRacMPGA6h4iK0fqFjy?= =?us-ascii?Q?jw+nIJaP0E3acJ4klRhE4FT6kQPx1r3bm3QNDrViuIi5DqkGoXruq59BIq31?= =?us-ascii?Q?VEe1/PxiNJcBerMcZag+iwDBEOvkc96WXrd5LpTAsUr8kUNaB6ZZsBngotJP?= =?us-ascii?Q?xshvjFVXipEUYRRA0tUwg2e2ZcXEWvlwaJYjY4ZKYAA6eS8/B4Ehy+PFZIh6?= =?us-ascii?Q?TCqv4T5mnUVayBgqQ9/CHUMAvXxnVp84poW1tlKafyDqV5eFud63q3cU/7uK?= =?us-ascii?Q?AdiGs7WebepepVw2KYFGA3hfsUzIVk3b4HC/jiNEs8E1bWaAMd1EwBrw3aDM?= =?us-ascii?Q?3OZywxreJU2S67Cui5NnFlhG766rI6ZzzXwe4Im8hT4W3u4VVoQnlhBVHhyF?= =?us-ascii?Q?F5gnei+ipHN1C9nChJ/Wr0iEdwWZqol0qzQn8p2z5ahbTifiWVvOOrZ44JQ8?= =?us-ascii?Q?Wh9YWAmxtfUewOnDsJTVaB+qJq/8RPIeoAGWerDVosTg/ay8hrAHRKJtuo5P?= =?us-ascii?Q?PtjQMqroy80vNWU5PL0unoMMqbnh97N9wWdUpZqqzCJcTMR0+UyS0rX/4+AL?= =?us-ascii?Q?/rKNMUaufe71Ma+aiwkL6GLbflwsCvHm/gkhJb8VFR/HAyfBSsWU6sJsHB+5?= =?us-ascii?Q?ZPE9kZZF7Z5laS34osBMuybvcOV/t1snp9TcJ8hv6INIYMg5ecHkKKHnFRXU?= =?us-ascii?Q?+hYU8iA/Gq36FbMyMNASjExcnh45eRYqmU+nfhs8JnHdlc/V6w1lcDOsfUmB?= =?us-ascii?Q?gaXKWzvrFgJCEeiS11PwVfVDOgX3Vr1c26oQwccxZe/7urtqhoDC+8GKAdCf?= =?us-ascii?Q?pWvF0W+jcP2QVdm/fVPe/N5OWTP3djMSc6TM8gRx+su2SThRQQU5xduUYSky?= =?us-ascii?Q?YRPkyjoJKVP5MXZZturEBDhnRqdmoK6p9z430w+82sZsMSSc+LonyrXGMgg+?= =?us-ascii?Q?pS0oXfOwxFg5zJayb3AvRZ1u07hUoZaLP915C0yjlnIs11nNyC7+75u6j6SE?= =?us-ascii?Q?gXruHKKUKE1zejKl8FTv8VmFPdgznf+GFpMj/f8lE7st38VIFB+FFhNr5crN?= =?us-ascii?Q?qbJfO+9hVlIpboBZsVct6R/WxwcFqVu0EEKp0d9vyj7VdoTRP2VOw00gvAsv?= =?us-ascii?Q?Fm0zMphNh1hpbtpFcv/4LSZ4IU/quOVthefQLj9ZyohknQzzMhWDjyQZhP+j?= =?us-ascii?Q?n2ScciFDnfgatOhdY7shki1dmz8KkeJqgWwOiMnHApTLXTOZGDiok+efodIR?= =?us-ascii?Q?ePJFtXqyfiS5fFsdmnjDPGekrxtiN3wbVHpFJZkBQeg4Bv30d9GMkKJmt4zn?= =?us-ascii?Q?Ls4Ys+9j3DpwPPAIga4iAetmeE4jrhUUg1361yHq7pno/gt1x+Kv9OxnG43T?= =?us-ascii?Q?TO3L6tyKgeajjcBeLPQVz8q9oEf0o8Qk+5Goc2fDY/ckTX5DaK/0pYhns0IZ?= =?us-ascii?Q?vik2rcA95PLkt2chXjzFakb6qd0rd8CIKmm6pOi3DEujTpMXZl57q2LsCJxW?= =?us-ascii?Q?WiM4271WVG7KOIJw+HsfBF5fwACTAJ3PTPBy6RcDce8I5VsEUjim0i545hxy?= =?us-ascii?Q?qQzqUWOMcIT+0IUiEcH4GLk9PFSiy3IjIYHM6QwkoCxNW1IIlF3GJSQOfYSK?= =?us-ascii?Q?oJvEPi0//855ZGqv5QLSkBs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc7b90fb-12be-4fc2-7f8a-08d9fb537771 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 07:16:55.3170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YVI/1Nr5q53nlNrg+inobVrO65tsI00YOGf71SOXdWnov2X2pSLbed01V3MaY3s7+LB1sUz8AM7qp8UQRZJKTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3486 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Jiang, Guomin =20 Sent: Tuesday, February 22, 2022 11:41 AM To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray Subject: [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open success= fully REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2668 WindowOpen will fail in some case. for example, without XServer. Shouldn't set ModeInfo in this case to avoid the caller use it incorrectly Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/EmuGopDxe/GopScreen.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/EmulatorPkg/EmuGopDxe/GopScreen.c b/EmulatorPkg/EmuGopDxe/GopS= creen.c index 41f748bc6402..ec5ef795d6e5 100644 --- a/EmulatorPkg/EmuGopDxe/GopScreen.c +++ b/EmulatorPkg/EmuGopDxe/GopScreen.c @@ -108,10 +108,6 @@ EmuGopSetMode ( } =20 ModeData =3D &Private->M= odeData[ModeNumber]; - This->Mode->Mode =3D ModeNumber; - Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData->H= orizontalResolution; - Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData->V= erticalResolution; - Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData->H= orizontalResolution; =20 if (Private->HardwareNeedsStarting) { Status =3D EmuGopStartWindow ( @@ -128,6 +124,11 @@ EmuGopSetMode ( Private->HardwareNeedsStarting =3D FALSE; } =20 + This->Mode->Mode =3D ModeNumber; + Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData->H= orizontalResolution; + Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData->V= erticalResolution; + Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData->H= orizontalResolution; + Status =3D Private->EmuGraphicsWindow->Size ( Private->EmuGraphicsWindow, ModeData->HorizontalResolution, -- 2.35.1.windows.2