* [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
@ 2021-12-21 6:47 JackX Lin
2021-12-21 6:50 ` Ni, Ray
2021-12-21 16:33 ` Kumar, Chandana C
0 siblings, 2 replies; 4+ messages in thread
From: JackX Lin @ 2021-12-21 6:47 UTC (permalink / raw)
To: devel
Cc: JackX Lin, JackX Lin, Chasel Chiu, Dong Eric, Jiewen Yao, Ray Ni,
Rangasai V Chaganty, Donald Kuo, Chandana C Kumar
Signed-off-by: JackX Lin <JackX.Lin@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Dong Eric <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Donald Kuo <Donald.Kuo@intel.com>
Cc: Chandana C Kumar <chandana.c.kumar@intel.com>
Cc: JackX Lin <JackX.Lin@intel.com>
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 785cf4c2f9..05fc7799fb 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -169,7 +169,7 @@ SortCpuLocalApicInTable (
UINT32 Index;
UINT32 CurrProcessor;
UINT32 BspApicId;
- EFI_CPU_ID_ORDER_MAP *TempVal;
+ EFI_CPU_ID_ORDER_MAP TempVal;
EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr;
UINT32 CoreThreadMask;
EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable;
@@ -183,7 +183,6 @@ SortCpuLocalApicInTable (
}
TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP));
- TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP));
CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) {
--
2.32.0.windows.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
2021-12-21 6:47 [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space JackX Lin
@ 2021-12-21 6:50 ` Ni, Ray
2021-12-21 16:33 ` Kumar, Chandana C
1 sibling, 0 replies; 4+ messages in thread
From: Ni, Ray @ 2021-12-21 6:50 UTC (permalink / raw)
To: Lin, JackX, devel@edk2.groups.io
Cc: Chiu, Chasel, Dong, Eric, Yao, Jiewen, Chaganty, Rangasai V,
Kuo, Donald, Kumar, Chandana C
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Lin, JackX <jackx.lin@intel.com>
> Sent: Tuesday, December 21, 2021 2:48 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX <jackx.lin@intel.com>; Lin, JackX <jackx.lin@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kuo, Donald <donald.kuo@intel.com>; Kumar, Chandana C <chandana.c.kumar@intel.com>
> Subject: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer
> point to an wrong space.
>
> Signed-off-by: JackX Lin <JackX.Lin@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Dong Eric <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Donald Kuo <Donald.Kuo@intel.com>
> Cc: Chandana C Kumar <chandana.c.kumar@intel.com>
> Cc: JackX Lin <JackX.Lin@intel.com>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 785cf4c2f9..05fc7799fb 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -169,7 +169,7 @@ SortCpuLocalApicInTable (
> UINT32 Index;
> UINT32 CurrProcessor;
> UINT32 BspApicId;
> - EFI_CPU_ID_ORDER_MAP *TempVal;
> + EFI_CPU_ID_ORDER_MAP TempVal;
> EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr;
> UINT32 CoreThreadMask;
> EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable;
> @@ -183,7 +183,6 @@ SortCpuLocalApicInTable (
> }
>
> TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof (EFI_CPU_ID_ORDER_MAP));
> - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP));
> CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
>
> for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus; CurrProcessor++, Index++) {
> --
> 2.32.0.windows.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
2021-12-21 6:47 [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space JackX Lin
2021-12-21 6:50 ` Ni, Ray
@ 2021-12-21 16:33 ` Kumar, Chandana C
2021-12-22 3:25 ` Donald Kuo
1 sibling, 1 reply; 4+ messages in thread
From: Kumar, Chandana C @ 2021-12-21 16:33 UTC (permalink / raw)
To: Lin, JackX, devel@edk2.groups.io
Cc: Chiu, Chasel, Dong, Eric, Yao, Jiewen, Ni, Ray,
Chaganty, Rangasai V, Kuo, Donald
Reviewed-by: Chandana C Kumar <chandana.c.kumar@intel.com>
> -----Original Message-----
> From: Lin, JackX <jackx.lin@intel.com>
> Sent: Tuesday, December 21, 2021 12:18 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX <jackx.lin@intel.com>; Lin, JackX <jackx.lin@intel.com>; Chiu,
> Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kuo, Donald <donald.kuo@intel.com>; Kumar,
> Chandana C <chandana.c.kumar@intel.com>
> Subject: [edk2-platforms: PATCH] System will occur a CPU exception error when
> sorting CPU APIC map, because of a pointer point to an wrong space.
>
> Signed-off-by: JackX Lin <JackX.Lin@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Dong Eric <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Donald Kuo <Donald.Kuo@intel.com>
> Cc: Chandana C Kumar <chandana.c.kumar@intel.com>
> Cc: JackX Lin <JackX.Lin@intel.com>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 785cf4c2f9..05fc7799fb 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -169,7 +169,7 @@ SortCpuLocalApicInTable (
> UINT32 Index;
> UINT32 CurrProcessor;
> UINT32 BspApicId;
> - EFI_CPU_ID_ORDER_MAP *TempVal;
> + EFI_CPU_ID_ORDER_MAP TempVal;
> EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr;
> UINT32 CoreThreadMask;
> EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable;
> @@ -183,7 +183,6 @@ SortCpuLocalApicInTable (
> }
>
> TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof
> (EFI_CPU_ID_ORDER_MAP));
> - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP));
> CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
>
> for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus;
> CurrProcessor++, Index++) {
> --
> 2.32.0.windows.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
2021-12-21 16:33 ` Kumar, Chandana C
@ 2021-12-22 3:25 ` Donald Kuo
0 siblings, 0 replies; 4+ messages in thread
From: Donald Kuo @ 2021-12-22 3:25 UTC (permalink / raw)
To: Kumar, Chandana C, Lin, JackX, devel@edk2.groups.io
Cc: Chiu, Chasel, Dong, Eric, Yao, Jiewen, Ni, Ray,
Chaganty, Rangasai V
Reviewed-by: Donald Kuo <Donald.Kuo@intel.com>
-----Original Message-----
From: Kumar, Chandana C <chandana.c.kumar@intel.com>
Sent: Wednesday, December 22, 2021 12:33 AM
To: Lin, JackX <jackx.lin@intel.com>; devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Dong, Eric <eric.dong@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kuo, Donald <donald.kuo@intel.com>
Subject: RE: [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.
Reviewed-by: Chandana C Kumar <chandana.c.kumar@intel.com>
> -----Original Message-----
> From: Lin, JackX <jackx.lin@intel.com>
> Sent: Tuesday, December 21, 2021 12:18 PM
> To: devel@edk2.groups.io
> Cc: Lin, JackX <jackx.lin@intel.com>; Lin, JackX
> <jackx.lin@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Dong,
> Eric <eric.dong@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kuo, Donald <donald.kuo@intel.com>;
> Kumar, Chandana C <chandana.c.kumar@intel.com>
> Subject: [edk2-platforms: PATCH] System will occur a CPU exception
> error when sorting CPU APIC map, because of a pointer point to an wrong space.
>
> Signed-off-by: JackX Lin <JackX.Lin@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Dong Eric <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Donald Kuo <Donald.Kuo@intel.com>
> Cc: Chandana C Kumar <chandana.c.kumar@intel.com>
> Cc: JackX Lin <JackX.Lin@intel.com>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 785cf4c2f9..05fc7799fb 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -169,7 +169,7 @@ SortCpuLocalApicInTable (
> UINT32 Index;
> UINT32 CurrProcessor;
> UINT32 BspApicId;
> - EFI_CPU_ID_ORDER_MAP *TempVal;
> + EFI_CPU_ID_ORDER_MAP TempVal;
> EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr;
> UINT32 CoreThreadMask;
> EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable;
> @@ -183,7 +183,6 @@ SortCpuLocalApicInTable (
> }
>
> TempCpuApicIdOrderTable = AllocateZeroPool (mNumberOfCpus * sizeof
> (EFI_CPU_ID_ORDER_MAP));
> - TempVal = AllocateZeroPool (sizeof (EFI_CPU_ID_ORDER_MAP));
> CoreThreadMask = (UINT32) ((1 << mNumOfBitShift) - 1);
>
> for (CurrProcessor = 0, Index = 0; CurrProcessor < mNumberOfCpus;
> CurrProcessor++, Index++) {
> --
> 2.32.0.windows.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-22 3:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-21 6:47 [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space JackX Lin
2021-12-21 6:50 ` Ni, Ray
2021-12-21 16:33 ` Kumar, Chandana C
2021-12-22 3:25 ` Donald Kuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox