Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib

["Ni, Ray" <ray.ni@intel.com>]

Can you please help to review the changes and give a Reviewed-by?

> -----Original Message-----
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Sent: Tuesday, May 10, 2022 11:13 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib
> 
> On 5/10/22 09:44, Tom Lendacky wrote:
> > On 5/9/22 18:16, Ni, Ray wrote:
> >> https://github.com/niruiyu/edk2/tree/refactormp<https://github.com/niruiyu/edk2/tree/refactormp
> >>
> >
> > Thanks for the tree, Ray. I was able to build and test against legacy,
> > SEV, SEV-ES and SEV-SNP guests and found everything worked well.
> >
> > I did notice a regression in the tree, un-related to your patches, when
> > booting an SEV-SNP guest. The following message appears for each AP:
> >
> > APIC: Stale IRR:
> > 00000000,00000000,00000000,00000000,00000000,00000000,00000001,00000000
> > ISR: 00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000
> >
> > So I'll start bisecting to see which commit introduced that.
> 
> This was introduced in the debug hack I needed to boot multiple vCPUs
> successfully (since Min's fix isn't in your tree, yet).
> 
> I hadn't noticed this in Min's MpLib fix, but after investigating I do see
> it now. I'll follow up with Min.
> 
> Thanks,
> Tom
> 
> >
> > Thanks,
> > Tom
> >
> >>
> >> thanks,
> >> ray
> >> --------------------------------------------------------------------------
> >> *From:* devel@edk2.groups.io <devel@edk2.groups.io> on behalf of
> >> Lendacky, Thomas via groups.io <thomas.lendacky=amd.com@groups.io>
> >> *Sent:* Tuesday, May 10, 2022 5:39:51 AM
> >> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Ni, Ray
> >> <ray.ni@intel.com>
> >> *Subject:* Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib
> >> Hi Ray,
> >>
> >> Do you have a public git tree with these patches that I can use to test
> >> with? I'm having lots of problems pulling these patches out of my mail
> >> client and applying them.
> >>
> >> Thanks,
> >> Tom
> >>
> >> On 5/7/22 10:13, Ni, Ray via groups.io wrote:
> >>>
> >>> Ray Ni (4):
> >>>     MpInitLib: Allocate code buffer for PEI phase
> >>>     MpInitLib: remove unneeded global ASM_PFX
> >>>     MpInitLib: Put SEV logic in separate file
> >>>     MpInitLib: Only allocate below 1MB memory for 16bit code
> >>>
> >>>    UefiCpuPkg/Library/MpInitLib/AmdSev.c         |   6 +-
> >>>    UefiCpuPkg/Library/MpInitLib/DxeMpLib.c       |   2 +-
> >>>    .../Library/MpInitLib/Ia32/MpFuncs.nasm       |  11 +-
> >>>    UefiCpuPkg/Library/MpInitLib/MpEqu.inc        |   2 +-
> >>>    UefiCpuPkg/Library/MpInitLib/MpLib.c          |  99 +++++------
> >>>    UefiCpuPkg/Library/MpInitLib/MpLib.h          |   2 +-
> >>>    UefiCpuPkg/Library/MpInitLib/PeiMpLib.c       |  15 +-
> >>>    UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm  | 148 ++++++++++++++++
> >>>    UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 167 +-----------------
> >>>    9 files changed, 216 insertions(+), 236 deletions(-)
> >>>
> >>
> >>
> >> 
> >>
> >>