From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"abner.chang@amd.com" <abner.chang@amd.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>,
Garrett Kirkendall <garrett.kirkendall@amd.com>,
Paul Grimes <paul.grimes@amd.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file
Date: Mon, 31 Oct 2022 01:59:12 +0000 [thread overview]
Message-ID: <MWHPR11MB163119421D5122A6ABE44A288C379@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221030130147.1143-1-abner.chang@amd.com>
This patch will cause build failure because the INF file is not updated after rename.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, October 30, 2022 9:02 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <abdattar@amd.com>; Garrett Kirkendall
> <garrett.kirkendall@amd.com>; Paul Grimes <paul.grimes@amd.com>; Dong,
> Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com>
> Subject: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib:
> Rename the common C file
>
> From: Abner Chang <abner.chang@amd.com>
>
> BZ# 4093: Abstract SmmCpuFeaturesLib for sharing common code
>
> Rename SmmCpuFeaturesLiCommon.c to
> IntelSmmCpuFeaturesLib, because it was developed
> specifically for Intel implementation. The code
> that can be shared by other archs or vendors
> will be stripped away and put in the common
> file in the next patch.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Paul Grimes <paul.grimes@amd.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
> .../{SmmCpuFeaturesLibCommon.c => IntelSmmCpuFeaturesLib.c} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename
> UefiCpuPkg/Library/SmmCpuFeaturesLib/{SmmCpuFeaturesLibCommon.c =>
> IntelSmmCpuFeaturesLib.c} (100%)
>
> diff --git
> a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c
> similarity index 100%
> rename from
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
> rename to
> UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c
> --
> 2.37.1.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2022-10-31 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 13:01 [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Chang, Abner
2022-10-30 13:01 ` [PATCH V2 2/3] UefiCpuPkg/SmmCpuFeaturesLib: Abstract arch dependent code Chang, Abner
2022-10-30 13:01 ` [PATCH V2 3/3] UefiCpuPkg/SmmCpuFeaturesLib: Clean up header file inclusion in SmmStm.c Chang, Abner
2022-10-31 1:59 ` Ni, Ray [this message]
2022-10-31 2:56 ` [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB163119421D5122A6ABE44A288C379@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox