From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.118.1652839490637407562 for ; Tue, 17 May 2022 19:04:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AwL8vyS7; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652839490; x=1684375490; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=anvfeQKlOE9VxUM4RGl/jGTnRTDAfU+ZDbDznDICGd4=; b=AwL8vyS75tPlPZDPgepb7wY6xgqUuRfasgMuNY4dDQFre0OMLzkkPANd rt4l/rYJmYjq072ZmGRwdN2kSi4fe5svaPz4O7mp//CuyvveVToyrM5ws WyHwYnauq2JCZAnhbFhq8uD1PYkExsbLS20B75coYScarMrl9xOPVroVX 5pamfFXmOnGHjQOToORxH6mMrETIxJ2Oe1C8LZtdA51l4zb/odgZlOGo6 gzzaout6sa3Db5zT3piA64OECJ2AnLJWVSRd3XrNcQtFz5krVgByJlAhe 1rrzBYQWzIsGnJ9q0tO7wa10mmQ+igc3HJE24X5UdOK9IWFYssVKnzSCE g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270253932" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="270253932" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 19:04:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="545182586" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 17 May 2022 19:04:49 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 19:04:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 19:04:48 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 19:04:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEoNWU8hrs6SDIp4gW5OCAz6y5pSL3Xjzq5vwlJqkhkIxXg704L7PyNXcx8U7hpCq7NRdWVTc1xF6QIriWynhuvQzNtiHyz4rhdDjwdjlYm3nv3R+n8RV09DlesXN3lre3EoXX2ufTX43/V/7udDEv+UjvBVTogCGAgZrCJnwiYWlseU2MkklLaCrM8swL9SAX8WnzBSdJwS+wJNkgKGlgyflr3/ffg0qZAbxvGMXRz3r5J/g6Ea/mSA1zmALt/i6u8LB2X8uWYYz4gzQK5WgEP/SIdkgUpoKPODZn5sH5DR4HWFboGsRL2clEiEt1B5JBLCQIbZk/8L8wOEhRVv6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=duUy1ORp+TQR5WiHBH9/ttxgVMYiWJ415O+mxFvOXPE=; b=LDCZqD6k8AmdmTKFcE6xrVkOqmg/6TxjhNL0JIP/nZnkOyCmlzIOBomBagXfCd9dBc2fFQXjXz3qTpNK0+15UFahjT+c35mzaNDqE6lSVzJMRnTSEy3Ub6YNnnhUVRqoGmhJOgCkzZbuTlYPW+NO5gaLVwDm1SQ7Oa27N065ZLYHJu2SAFlH7inUejWRH2LRrDCJ03fBC/uC3hmavza2jYKWbrWgyJq2Rc1qaD+xMl2/UO5cEmUcEqNcE2SorJ7/NLnsj7mS++nMXQrL5wFRN1AbpsLyo9pHUx8G4pblU/0D+ZgSZDnQHErWY9wR5mGFnrQ9GJGKQKJ76kJOkwHB0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY4PR11MB1735.namprd11.prod.outlook.com (2603:10b6:903:127::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Wed, 18 May 2022 02:04:46 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2d8b:3e7f:83d7:1e56]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2d8b:3e7f:83d7:1e56%8]) with mapi id 15.20.5250.018; Wed, 18 May 2022 02:04:45 +0000 From: "Ni, Ray" To: "Sinha, Ankit" , "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package Thread-Topic: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package Thread-Index: AQHYaZ1I3VZQZbTFZUiiVwzHs8IKwK0jHC3ggABRuoCAAHV9MA== Date: Wed, 18 May 2022 02:04:45 +0000 Message-ID: References: <20220517031830.1520-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08490303-8cec-4dbd-3b54-08da3872c7e1 x-ms-traffictypediagnostic: CY4PR11MB1735:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZwzmtUiaduOrwaUDxLJTSHdhyR3tl9ScEIa95sy98JUTseevpKGi0xlCqghwBkhkjZ4lcHVafH5G5LxW0Lx3kipIQu+0mY5wUhDGtgRlE03Vi/RamDgbCaP3WCSZYI5O49WuyD5LNFyNAdd+0pkiv0CdYTBuxm09QmN14gIU+xVHcN9QzKEbf2oxab7lpQmJrzKa196Wul42jmdXU3xeCd0c/AdwYgi+bCMeWMHoCxUcic1lha6451GIUvg1ww0h+3XhkJWVUbPgEJCFeqmNxvRYH8AP+EwVmlHLiEF4Ye6uHc3I5dmzCEde449/rwRxE9GB7xaaGhJRlUkdRceLz25qvviYZJ5HPQsb8HlWrm/l6gITSixiyfGFUSgu1vE218g4xS13ORQaKe1y0mZiNPwFJAaY8yIPDxEyVuMpVK1LYwFjoyxAEtNo0hJ7I2b8FSYmOSOAEv7wQ31SNbDGJACg6AUtSQL+5s8e7+KuJVk0J/zgf5FdX70wxli5kvcbkNefGy+8PcplqHO0zsNj23xXR57++jK6CQrMNpmQImF8VTHOt4vZGlU512Oov9kXmMg5DgvR3KCfrVq9b4TjL5inxkYOPQHThZnYlZRHV9T9P97gBlzjVkRAlQ7NgVg1bQvKBHEDwW7Tc2q7jaHfGD31GTIjCFmSuafY+w4a5AlwYHaajJz5NVZgTSMNJjfJd1l5KREVJeTLbCxwoZgXfdupLYOgqXu7U0edoDeZgEqJ7ptBFzS5BvztnhEbXpXQ7RN0p/yNuiTiytI2dkqXdGj0v71OgrnS4lEGkYeHbw2b1Dg79BmHkoFnuRGKvJpjZInWLaRjsrCEJJINKnUZLA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(52536014)(6506007)(8936002)(107886003)(7696005)(86362001)(508600001)(53546011)(966005)(33656002)(2906002)(26005)(186003)(15650500001)(9686003)(55016003)(66476007)(66556008)(19627235002)(316002)(30864003)(4326008)(83380400001)(66946007)(76116006)(38100700002)(66446008)(64756008)(8676002)(38070700005)(54906003)(6636002)(110136005)(82960400001)(122000001)(71200400001)(5660300002)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hD7rZbR7UR+ib9Cgf9T9Ueu3YUUCWoeRziFbP/7betvAHxDf6nZuFQ1JFwBw?= =?us-ascii?Q?BHGRuHE9757PEkk+AEONUf3HNK43Rdejjpuc4cZLXlCB3z0sZe7fN9+cm2Yc?= =?us-ascii?Q?qt8l8rZf/yvCj4uB25J8IZucsRn4iKKc0x9sJmeknpIJelWvcDPelqJB3ofO?= =?us-ascii?Q?lmjbktGClEIEZNLOAfUzC/3c1Z47d4Nbw5vKxhW3dSDzsdvKg0SuVStQTa46?= =?us-ascii?Q?IzbIMTPmVcFOsEElDisAUBgUxP9M0WWpEXFi+dbQ6mS9Ww/ugbVNCDjVrr2L?= =?us-ascii?Q?sIknEMZFy0ayDHT+SRZVI3iOBX9LxbL1M0e4vj/KgFzUaDMWD9BtNcskXXfI?= =?us-ascii?Q?Od7oNbIED8+qG5BfWXQLe6EfD+7jCNyBsd4vANM8jl9n4JcPS5EnGFPJHTWh?= =?us-ascii?Q?4jL7hYuQqrm4gLDrkcCDlob0tdPq1u+uItU4rqfdUpAxZk1ptlV9SpLC9W3g?= =?us-ascii?Q?P4ULDLTrDSe/ISBfVPpiZxhd2lrB8QeaeM578+P8V3QcXmetOwHB1/gerx71?= =?us-ascii?Q?0oRH6I6toClxlbraf5cAUyduZ/SNBVbd3v6+1GeV+KZUC64CJGXbTWWREMkD?= =?us-ascii?Q?Jim9kLlBA/MVEWuh03XiOZ04YkjEslZzzhHTgJ2+GAk6AVsTnI1B3b3klahm?= =?us-ascii?Q?73Zg/AF566VidcQqIcmcQbaZANi6xZ898xSbB2zkaJQqUeLcZKILaHoLnBq4?= =?us-ascii?Q?Q8vCppL6T7ZE2SM77GuYKEOCMklnBOeqbvApuvhQCavDDlaf53Z8hJ5uhrAR?= =?us-ascii?Q?apBD5uI+o8V1oq7j+Y2yE4l04e6HPAQlZQ9JxifrioopUyAdpBHXDkvxJfWi?= =?us-ascii?Q?bDGhzKCOSN+We+Y4N7+WlbAw+G0/Y59bfrzKNK4Kscfzy/4eBhOmkwuDBzdc?= =?us-ascii?Q?pNtsuMhEFzgssVKdgISpN2ScFvwCvemDyWDkUxUJlnzx6BjwIsL1G0WJx9mZ?= =?us-ascii?Q?WGZyi5PbObfMSyyTO/3C52e6tWM2qa9+kU6oXQRr4e7jf58FDQ87+8mAdelT?= =?us-ascii?Q?5owALlkXVMnG29NAkI/3IgZphQxA4FfWJ/F+TO2CSc9b1PkQ3Ko8ESio3pvL?= =?us-ascii?Q?LPJssaEKzZHaOIg/QjZVTRK5WpHsgKlkzGFY9ufqs1ZgzlxGV+JDO+J+4Lx1?= =?us-ascii?Q?3OumG0p1HHl9tDzj90vNGVj76KfI7RJ3CE3Aks0i6dhRGuE+GrmICOUHxfWN?= =?us-ascii?Q?LXB6G6RxRRWuIlV8mPT+vzbLy59BAuxx1wRqOCVd/2p+ovI6RMqQcv7K3ck5?= =?us-ascii?Q?wZL4OZ9RThrzCdevN2DOZQ56a7OZlCnE1XVNgFRWYC8uRG4NmN+U0naJ8RgL?= =?us-ascii?Q?Au0agACX113uBFNRtE8F9v8/3LU2474hFaRzYBH5wM9lCJhbUpXO2aEN1I2N?= =?us-ascii?Q?dbkQcZZUyR88R3zM3/UfcbbVE3JHSJ+b2zLdGimM1HhJPMd9fcheq1upfgHa?= =?us-ascii?Q?pSqimA/Yf+++n8dt+cqyDikNNXMilEplvp+8cMa2s581kCsqZdhb8FILWwn7?= =?us-ascii?Q?a5zhf7D5XNUxqJDrstfEzbN5wf4LXkSJQuPIerDAumDhL8tRqBeYRUPrvN/6?= =?us-ascii?Q?cSC6yFHaKhIO7vwxuP3QaODBXRkEJ2F2hZ0c68hmbfRUtIwG66++l5Pv7zh4?= =?us-ascii?Q?Ywo/ziFCdsd6kIYH9NOPLEetzFE5B+fMKnSNWGhbmINEVgmW7c/TnMTfSXZz?= =?us-ascii?Q?4uH9nsjrD/EQDPIZpUTwCsEzdrCye38GqSfuzHZIZwCwWClPbpvlykrsE0/o?= =?us-ascii?Q?O+mzDAQVRg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08490303-8cec-4dbd-3b54-08da3872c7e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 02:04:45.6575 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hRrECB83tarxRS7h5VW5BKlbxAfntWDQ5LxnCNkD8TBINll3F9rRjRuxooXN5Pt7WMiHteEKDXxWIMQg5dAyLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1735 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ankit, I see. So, the goal is to build an infrastructure that makes sure mandatory= ACPI tables are always populated. I am fine with that. Thanks for the explanation. > -----Original Message----- > From: Sinha, Ankit > Sent: Wednesday, May 18, 2022 3:02 AM > To: Ni, Ray ; devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Gao, Liming <= gaoliming@byosoft.com.cn>; Dong, Eric > > Subject: RE: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to upda= te FADT entries from board package >=20 > Hi Ray, >=20 > That is a good feedback. However, since FADT is a mandatory table to boot= an ACPI compliant OS, we have placed it in the > implementation of MinPlatformPkg. If we move this to be a board responsib= ility then we will need to implement a check in the > boot process to make sure FADT is published correctly before booting to O= S. >=20 > Thank you, > Ankit >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Tuesday, May 17, 2022 7:11 AM > > To: devel@edk2.groups.io; Chiu, Chasel > > Cc: Sinha, Ankit ; Desimone, Nathaniel L > > ; Gao, Liming > > ; Dong, Eric > > Subject: RE: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to > > update FADT entries from board package > > > > I am thinking if most of FADT fields are configurable through PCD from > > BoardPkg. > > Then why not remove the FADT from this open-source driver but let some > > code in BoardPkg produces the FADT? > > > > It helps to remove the PCD layer and simplifies the data flow from PCD- > > >FADT to FADT. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Chiu, > > > Chasel > > > Sent: Tuesday, May 17, 2022 11:19 AM > > > To: devel@edk2.groups.io > > > Cc: Sinha, Ankit ; Chiu, Chasel > > > ; Desimone, Nathaniel L > > > ; Gao, Liming > > > ; Dong, Eric > > > Subject: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to > > > update FADT entries from board package > > > > > > From: Ankit Sinha > > > > > > Adds new PCDs to allow entries in FADT to be customized during > > > platform integration. Board packages will can update these PCDs durin= g > > boot. > > > > > > Cc: Chasel Chiu > > > Cc: Nate DeSimone > > > Cc: Liming Gao > > > Cc: Eric Dong > > > > > > Signed-off-by: Ankit Sinha > > > --- > > > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 85 > > ++++++++++++-------- > > > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 24 > > ++++++ > > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 36 = +++++++- > > - > > > 3 files changed, 105 insertions(+), 40 deletions(-) > > > > > > diff --git > > > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > > index 05fc7799fb13..b3d067def3fa 100644 > > > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > > @@ -1165,6 +1165,11 @@ PlatformUpdateTables ( > > > // Update the creator revision > > > > > > // > > > > > > TableHeader->CreatorRevision =3D > > > PcdGet32(PcdAcpiDefaultCreatorRevision); > > > > > > + > > > > > > + // > > > > > > + // Update the oem revision > > > > > > + // > > > > > > + TableHeader->OemRevision =3D PcdGet32(PcdAcpiDefaultOemRevisio= n); > > > > > > } > > > > > > } > > > > > > > > > > > > @@ -1187,44 +1192,54 @@ PlatformUpdateTables ( > > > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > > > > > > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) > > Table; > > > > > > > > > > > > - FadtHeader->PreferredPmProfile =3D PcdGet8 > > (PcdFadtPreferredPmProfile); > > > > > > - FadtHeader->IaPcBootArch =3D PcdGet16 (PcdFadtIaPcBootArch= ); > > > > > > - FadtHeader->Flags =3D PcdGet32 (PcdFadtFlags); > > > > > > + FadtHeader->PreferredPmProfile =3D PcdGet8 > > (PcdFadtPreferredPmProfile); > > > > > > + FadtHeader->IaPcBootArch =3D PcdGet16 > > (PcdFadtIaPcBootArch); > > > > > > + FadtHeader->Flags =3D PcdGet32 (PcdF= adtFlags); > > > > > > + FadtHeader->AcpiEnable =3D PcdGet8 (PcdAc= piEnableSwSmi); > > > > > > + FadtHeader->AcpiDisable =3D PcdGet8 (PcdAc= piDisableSwSmi); > > > > > > + FadtHeader->Pm1aEvtBlk =3D PcdGet16 > > (PcdAcpiPm1AEventBlockAddress); > > > > > > + FadtHeader->Pm1bEvtBlk =3D PcdGet16 > > (PcdAcpiPm1BEventBlockAddress); > > > > > > + FadtHeader->Pm1aCntBlk =3D PcdGet16 > > (PcdAcpiPm1AControlBlockAddress); > > > > > > + FadtHeader->Pm1bCntBlk =3D PcdGet16 > > (PcdAcpiPm1BControlBlockAddress); > > > > > > + FadtHeader->Pm2CntBlk =3D PcdGet16 > > (PcdAcpiPm2ControlBlockAddress); > > > > > > + FadtHeader->PmTmrBlk =3D PcdGet16 > > (PcdAcpiPmTimerBlockAddress); > > > > > > + FadtHeader->Gpe0Blk =3D PcdGet16 > > (PcdAcpiGpe0BlockAddress); > > > > > > + FadtHeader->Gpe0BlkLen =3D PcdGet8 > > (PcdAcpiGpe0BlockLength); > > > > > > + FadtHeader->Gpe1Blk =3D PcdGet16 > > (PcdAcpiGpe1BlockAddress); > > > > > > + FadtHeader->Gpe1Base =3D PcdGet8 (PcdAc= piGpe1Base); > > > > > > + FadtHeader->DutyWidth =3D PcdGet8 (PcdAc= piDutyWidth); > > > > > > > > > > > > - FadtHeader->AcpiEnable =3D PcdGet8 (PcdAcpiEnableSwSmi); > > > > > > - FadtHeader->AcpiDisable =3D PcdGet8 (PcdAcpiDisableSwSmi); > > > > > > + FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > > (PcdAcpiPm1AEventBlockAddress); > > > > > > + FadtHeader->XPm1aCntBlk.Address =3D PcdGet16 > > (PcdAcpiPm1AControlBlockAddress); > > > > > > + FadtHeader->XPm1bCntBlk.Address =3D PcdGet16 > > (PcdAcpiPm1BControlBlockAddress); > > > > > > + FadtHeader->XPm2CntBlk.Address =3D PcdGet16 > > (PcdAcpiPm2ControlBlockAddress); > > > > > > + FadtHeader->XPmTmrBlk.Address =3D PcdGet16 > > (PcdAcpiPmTimerBlockAddress); > > > > > > + FadtHeader->XGpe0Blk.Address =3D PcdGet16 > > (PcdAcpiGpe0BlockAddress); > > > > > > + FadtHeader->XGpe1Blk.Address =3D PcdGet16 > > (PcdAcpiGpe1BlockAddress); > > > > > > > > > > > > - FadtHeader->Pm1aEvtBlk =3D PcdGet16 > > (PcdAcpiPm1AEventBlockAddress); > > > > > > - FadtHeader->Pm1bEvtBlk =3D PcdGet16 > > (PcdAcpiPm1BEventBlockAddress); > > > > > > - FadtHeader->Pm1aCntBlk =3D PcdGet16 > > (PcdAcpiPm1AControlBlockAddress); > > > > > > - FadtHeader->Pm1bCntBlk =3D PcdGet16 > > (PcdAcpiPm1BControlBlockAddress); > > > > > > - FadtHeader->Pm2CntBlk =3D PcdGet16 > > (PcdAcpiPm2ControlBlockAddress); > > > > > > - FadtHeader->PmTmrBlk =3D PcdGet16 (PcdAcpiPmTimerBlockAddress)= ; > > > > > > - FadtHeader->Gpe0Blk =3D PcdGet16 (PcdAcpiGpe0BlockAddress); > > > > > > - FadtHeader->Gpe0BlkLen =3D 0x20; > > > > > > - FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiGpe1BlockAddress); > > > > > > + FadtHeader->ResetReg.AccessSize =3D PcdGet8 > > (PcdAcpiResetRegAccessSize); > > > > > > + FadtHeader->XPm1aEvtBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPm1aEvtBlkAccessSize); > > > > > > + FadtHeader->XPm1bEvtBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPm1bEvtBlkAccessSize); > > > > > > + FadtHeader->XPm1aCntBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPm1aCntBlkAccessSize); > > > > > > + FadtHeader->XPm1bCntBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPm1bCntBlkAccessSize); > > > > > > + FadtHeader->XPm2CntBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPm2CntBlkAccessSize); > > > > > > + FadtHeader->XPmTmrBlk.AccessSize =3D PcdGet8 > > (PcdAcpiXPmTmrBlkAccessSize); > > > > > > + FadtHeader->XGpe0Blk.AccessSize =3D PcdGet8 > > (PcdAcpiXGpe0BlkAccessSize); > > > > > > + FadtHeader->XGpe1Blk.AccessSize =3D PcdGet8 > > (PcdAcpiXGpe1BlkAccessSize); > > > > > > > > > > > > - FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > > (PcdAcpiPm1AEventBlockAddress); > > > > > > - FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 > > (PcdAcpiPm1BEventBlockAddress); > > > > > > - if (FadtHeader->XPm1bEvtBlk.Address =3D=3D 0) { > > > > > > - FadtHeader->XPm1bEvtBlk.AccessSize =3D 0; > > > > > > - } > > > > > > - FadtHeader->XPm1aCntBlk.Address =3D PcdGet16 > > (PcdAcpiPm1AControlBlockAddress); > > > > > > - FadtHeader->XPm1bCntBlk.Address =3D PcdGet16 > > (PcdAcpiPm1BControlBlockAddress); > > > > > > - if (FadtHeader->XPm1bCntBlk.Address =3D=3D 0) { > > > > > > - FadtHeader->XPm1bCntBlk.AccessSize =3D 0; > > > > > > - } > > > > > > - FadtHeader->XPm2CntBlk.Address =3D PcdGet16 > > (PcdAcpiPm2ControlBlockAddress); > > > > > > - //if (FadtHeader->XPm2CntBlk.Address =3D=3D 0) { > > > > > > - FadtHeader->XPm2CntBlk.AccessSize =3D 0; > > > > > > - //} > > > > > > - FadtHeader->XPmTmrBlk.Address =3D PcdGet16 > > (PcdAcpiPmTimerBlockAddress); > > > > > > - FadtHeader->XGpe0Blk.Address =3D PcdGet16 > > (PcdAcpiGpe0BlockAddress); > > > > > > - FadtHeader->XGpe1Blk.Address =3D PcdGet16 > > (PcdAcpiGpe1BlockAddress); > > > > > > - if (FadtHeader->XGpe1Blk.Address =3D=3D 0) { > > > > > > - FadtHeader->XGpe1Blk.AddressSpaceId =3D 0; > > > > > > - FadtHeader->XGpe1Blk.AccessSize =3D 0; > > > > > > - } > > > > > > + FadtHeader->SleepControlReg.AddressSpaceId =3D PcdGet8 > > (PcdAcpiSleepControlRegAddressSpaceId); > > > > > > + FadtHeader->SleepControlReg.RegisterBitOffset =3D PcdGet8 > > > + (PcdAcpiSleepControlRegRegisterBitOffset); > > > > > > + FadtHeader->SleepControlReg.AccessSize =3D PcdGet8 > > (PcdAcpiSleepControlRegAccessSize); > > > > > > + FadtHeader->SleepControlReg.Address =3D PcdGet64 > > (PcdAcpiSleepControlRegAddress); > > > > > > + FadtHeader->SleepStatusReg.AddressSpaceId =3D PcdGet8 > > (PcdAcpiSleepStatusRegAddressSpaceId); > > > > > > + FadtHeader->SleepStatusReg.RegisterBitWidth =3D PcdGet8 > > (PcdAcpiSleepStatusRegRegisterBitWidth); > > > > > > + FadtHeader->SleepStatusReg.RegisterBitOffset =3D PcdGet8 > > > + (PcdAcpiSleepStatusRegRegisterBitOffset); > > > > > > + FadtHeader->SleepStatusReg.AccessSize =3D PcdGet8 > > (PcdAcpiSleepStatusRegAccessSize); > > > > > > + FadtHeader->SleepStatusReg.Address =3D PcdGet64 > > (PcdAcpiSleepStatusRegAddress); > > > > > > + > > > > > > + FadtHeader->S4BiosReq =3D PcdGet8 (PcdAc= piS4BiosReq); > > > > > > + FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > > (PcdAcpiPm1AEventBlockAddress); > > > > > > + FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 > > (PcdAcpiPm1BEventBlockAddress); > > > > > > > > > > > > DEBUG ((DEBUG_INFO, "ACPI FADT table @ address 0x%x\n", Table)); > > > > > > DEBUG ((DEBUG_INFO, " IaPcBootArch 0x%x\n", > > > FadtHeader->IaPcBootArch)); > > > > > > diff --git > > > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > > index 99adf9c381c9..9d91e418d4ca 100644 > > > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > > @@ -62,6 +62,8 @@ > > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount > > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiDutyWidth > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > > > > > > > > > > > > @@ -77,7 +79,29 @@ > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize > > > > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffse > > > + t > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress > > > > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId > > > > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress > > > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq > > > > > > + > > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress > > > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > index e38617ce20fd..bfc50565144f 100644 > > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > @@ -112,10 +112,6 @@ > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|8|UINT32|0x9000 > > 0022 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount|4|UINT32|0x90 > > 000023 > > > > > > > > > > > > - > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8| > > 0x9 > > > 0000025 > > > > > > - > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x > > 9000 > > > 0026 > > > > > > - > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x900 > > 0002 > > > 7 > > > > > > - > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize|0 > > x65 > > > |UINT32|0x20000500 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize|0x30 > > |UIN > > > T32|0x20000501 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize|0x4 > > 02|U > > > INT32|0x20000502 > > > > > > @@ -245,6 +241,10 @@ > > > gMinPlatformPkgTokenSpaceGuid.PcdPciSegmentCount |0x1 > > |UINT8|0x4001004E > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdRandomizePlatformHierarchy > > |TRUE > > > |BOOLEAN|0x4001004F > > > > > > > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8| > > 0 > > > + x90000025 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x > > 90 > > > + 000026 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x900 > > 00 > > > + 027 > > > > > > + > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800| > > UINT > > > 16|0x00010035 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x0000| > > UINT > > > 16|0x00010036 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x180 > > 4|UI > > > NT16|0x0001037 > > > > > > @@ -252,7 +252,33 @@ > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850 > > |UIN > > > T16|0x00010039 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UI > > NT16 > > > |0x0001003A > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT1 > > 6|0x > > > 0001003B > > > > > > - > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > > 6|0x > > > 0001003C > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x > > 00 > > > + 01003C > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > > 6| > > > + 0x0001003D > > > > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x000100 > > 40 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiDutyWidth|0x00|UINT8|0x000100 > > 41 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8 > > |0 > > > + x00010042 > > > > > > + > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UI > > NT > > > + 8|0x00010043 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UI > > NT > > > + 8|0x00010044 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UI > > NT > > > + 8|0x00010045 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UI > > NT > > > + 8|0x00010046 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UIN > > T8 > > > + |0x00010047 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT > > 8| > > > + 0x00010048 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8 > > |0 > > > + x00010049 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8 > > |0 > > > + x0001004A > > > > > > + > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId| > > 0 > > > + x00|UINT8|0x0001004B > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth > > > + |0x00|UINT8|0x0001004C > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffse > > > + t|0x00|UINT8|0x0001004D > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize|0x00| > > > + UINT8|0x0001004E > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress|0x00000 > > 0 > > > + 0000000000|UINT64|0x0001004F > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId|0 > > x > > > + 00|UINT8|0x00010050 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth| > > > + 0x00|UINT8|0x00010051 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset > > > + |0x00|UINT8|0x00010052 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize|0x00| > > U > > > + INT8|0x00010053 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress|0x000000 > > 0 > > > + 000000000|UINT64|0x00010054 > > > > > > + > > > + > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x0001 > > 00 > > > + 55 > > > > > > + > > > > > > > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000| > > UIN > > > T32|0x0010004 > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr|0x9f > > 000|U > > > INT32|0x30000008 > > > > > > -- > > > 2.33.0.windows.1 > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > Groups.io Links: You receive all messages sent to this group. > > > View/Reply Online (#89792): > > > https://edk2.groups.io/g/devel/message/89792 > > > Mute This Topic: https://groups.io/mt/91156600/1712937 > > > Group Owner: devel+owner@edk2.groups.io > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > > -=3D-=3D-=3D-=3D-=3D-=3D > > >