From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.19884.1647394005837229691 for ; Tue, 15 Mar 2022 18:26:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iji2WCwb; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647394005; x=1678930005; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uJnL/5fEDH9nyi1kvzFQ0tLBxXp8zoGtZSXT243QI7s=; b=iji2WCwbXuYU0GJ3Nvdid/TgBVtf6/a+/oWDtTilyZ+CmHnc6LZ4j09A FuCoChfSfzvnLv7Sk4G1qpVfZfmvb88Ky4OzL1MTPF6SMtGWiBSWytrtK w9/FTTP/Rqo5RAji1NRJzVZtxWY5kIBqBMPUj1JVApHU0SSIsuNPSzGB5 ul1atVkGk66ZK7q+JnRWL9WL0t5v9o8HfaMV1llXENOEfZTED2435LCps poycfWd7Mv5jBd3+Jvo2Yd7JZth8EmvLVHGrs7FHbNVJhMfhb/APNnW2D 2NyCn6zOcgo3Nd4AV69r7IsEkVvKziVS/vnaL1Ukatv9WvXUucInWknqZ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="237067151" X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="237067151" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 18:26:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,185,1643702400"; d="scan'208";a="512830646" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 15 Mar 2022 18:26:44 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 18:26:44 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 18:26:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 18:26:43 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 18:26:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJr+mtU6FyBoTD7aikOhuGY1XCf7sz33AdFQ62dWfVUcZOr1NOuhzRL+eO6oTsRjJ0kuhdkl0Ev0qu4M+jSX978O4dXbUr4c+2/C8ygfHmdJV/uB1ImCzuneH7Nx6SfqGijfNUPKhwm5SLFoh5/n2EOPyzIeuFT2+rIjw3MQ3GiF3CdNn6wFCxq+4k3arNqRxcseH0HGlbUz/r1bztruYq7XMhmPk8WSb6Y+aIS04HZRQZPtmhKH647wplLR5V4JWD5bWsXLURe6b8zEwnH2tFtRufFKj7z/v9cVYAHqVLFg0u0XIyQ8zMh1tLubVbIEtxEOLdYN2Q/bpePPXPbVMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y30alCwG6jTSrIjnGKvA2WwZVWqCfC4MnJmqG/xcoDE=; b=AI8EFA1XEIw54Mntlel/FJQyCTHPLV2mx3Tfy7yJKb9+i8XNdbs/dFWCxLmZo7OXEq99x/tq6uIBoqzHBjV8CXNcYmDxGRDusGTQjgyDwRvtroHeJwPXQP3W1QN7vgINe4S/OTplq9d3cVyB+H9DUycR7UHDAQ0aStaHttT4kYBfv38ggjAy0QDv/72Lp6hQdteV7/kW2upZ+Q9zhrTW2Hwr9o+JGlMT8OslcImqIQ7xlkKjiAe/RkI3mgCapWUvQyKERnbuqASzuMKn3Mr9QSjg3IrkLctOyhp+PSmfaEg3Y5JKNaGyWSlYCKkwwOhvl9aKJQYbd9S+kZlyejn8fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BN7PR11MB2642.namprd11.prod.outlook.com (2603:10b6:406:ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26; Wed, 16 Mar 2022 01:26:37 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 01:26:37 +0000 From: "Ni, Ray" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Brijesh Singh" , "Aktas, Erdem" , "James Bottomley" , "Yao, Jiewen" , "Tom Lendacky" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Topic: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx functions in BaseLib Thread-Index: AQHYNbQpNQqpEoTQJ0GnfoI7ybFGGazAE8ZwgAEoaoCAAAHzEA== Date: Wed, 16 Mar 2022 01:26:37 +0000 Message-ID: References: <78b2b2da2b70601cc173ce5801138226ca9f4bb7.1647047481.git.min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e43f9d66-bb95-4049-4af5-08da06ec03d7 x-ms-traffictypediagnostic: BN7PR11MB2642:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JkxiGyK8xfPQnHsZ3L7kE2T7MzVHO8lvtjEbU/fljhBjZbO3mx4wxUWSHlcArtXpPVm/hYxHozUtTzsEwi/NFXSoo2+InoxL6VWNNuK60MUIb1IOvlD6y8dCxacl7TAPZdH3Q5OPBhyyuojO8HWeUhLgyKt61CJw+K3BOCXhdXvMq5GTwxhaKXFr+9HKGP7jYgmqal3BS5JrnjkHQbtwSo3UylZW9dQ5DfdsgR4/aXewC2BYK2kmk0/h9K51eZbFyrXHp/+8Q8MD1R2LxXrSRz9/0+llS+8SZUcY5UJrVoZlab/MI4TEwtlOsS8vHRk0hnyzhnVWH1XwsP3a+Mkpt6iema4tTfI/0l/fM8VAuGwj0LgNbL4mMyut9qNEOeBf7XAvu6krVYhgkrK1IdEUEk3YDg8Ihn3z1qcsl3ZSp9qw8uwp4pqxdTUsmr+vXnOIBu73r4inoEcq0IoQqeYV/7COh3YihIr5dNTeifZtL158UCjXma4d70/A864bzNF7j4g+CnbYWeJKS+l+OF0nL3icNtVWfjwGwXG+J/8rwKOQlAENISdrRPKehMUEPTyvvXTygwxhA5FZ+Vkg0gLtOQ2iwxeF0kCgVYqzFo/4cq7sbqFluC4gxeuvcb5ORsmG42Kwdj88mhoBbUvHMmNKrM5HOXyS401+1gVskOCMVVmLARdYgRG2JzSTER70F1hr3X8OovzRSwBSREtEfNJexo1jdL7UTKhQkQaEFcsL8xcLUgnSLig6vqZbQK/m38wug4F0t34X4zuxGBH3j30746HORlaXa8Wlh6+LEi/SYN8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(122000001)(186003)(26005)(38100700002)(2906002)(5660300002)(4326008)(33656002)(55016003)(52536014)(8936002)(8676002)(966005)(66556008)(86362001)(53546011)(66476007)(9686003)(76116006)(66946007)(71200400001)(316002)(64756008)(7696005)(66446008)(110136005)(508600001)(54906003)(82960400001)(38070700005)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QHs4DtNZkMvsCAoUXMUageaYPIG98vSEiyqJoYem6ufKEE5ZBBINjOanALvS?= =?us-ascii?Q?hi84IY3Dkj8jS41+VF/MS+s8j1YkF/1Qk6qCchsldXn/CvxkvVPT6CR5SqsA?= =?us-ascii?Q?sg6ZjV2uf4jlrq/AiZlYPkwv/YJIS7Up9SDrn2ToOZGoEivDcbgjX4vKvi+x?= =?us-ascii?Q?f3S/lNanhKzNJLiK6U1s6chJTKIQmU1KmTuPZhF2Opnu+XoHpr7iCcMkZuOM?= =?us-ascii?Q?s8/0dp4wOA5+fnIqpt/Jt3Lf/EaHfgLRrH7tNdQ5UeCX6qH5trKF2HzPvK6A?= =?us-ascii?Q?2iN204Kzy2Mn8kmaGm2NZ4A0KAMdV0bs6u/ZW0Ru+9DyHX0vQpxuxmbMvi/g?= =?us-ascii?Q?iPMlMnWPaP9DsiSAI8eaBaLsb2+M+helKKmU11WO12/DkLz4/2njYFq/vXVX?= =?us-ascii?Q?zFybuPDoedweWsGBXYfEJ0j9hP+AZJ5uSuClp3sm2WgXIGBnYyk95Df/1D6f?= =?us-ascii?Q?Cb2V8BTs/w09PRp5quBtRiLuoamY595RJmHG8W/X83olnxXlMx3ARLJIFhMR?= =?us-ascii?Q?FnVZbDQj1tWX0OukROvg1wPWtbrnWenNpyalWTGx5STwYvbjZWV2KvYc2XFe?= =?us-ascii?Q?Y8ct0uCWnggfoXlc97Je7ioKwgRjoFmI/NbLhRgmg1wGfoe5BkEmwxFFLDdS?= =?us-ascii?Q?ia31VT7FDPOV5L8U+FP+SQTqVBioiBo22QtcD1bDlD5dbIH7PWmu2ovwO00a?= =?us-ascii?Q?uE2zFDFlEjvziF2bIBNHyPhGaLdpoht036fiBcW+oS0pcZxiQbQIv48K4F0A?= =?us-ascii?Q?OTUhyXWyxKoKMGd6crIAnun5PwJVFMreLjQTy6VujuKz+qlf9uDaRaR5RHnt?= =?us-ascii?Q?8LNpXQjldhRlzlIvoYdPSMPDLK6rTOfqZcD5Jvx+sYgJKnTUELvU5zQxGdjm?= =?us-ascii?Q?zQiC2DAq1X/5F2GTT+2XUIMnHz/zVbuQGqIdvRITfghiBPTj8xEQF35+MtDA?= =?us-ascii?Q?yeFkjnpygvTCi3pBMoQW8zmqgYgej0mrozg+PBvKwPnHpqziMjOLYUy2S2DV?= =?us-ascii?Q?uKEb1AkQ2lPXNcspRWAP+od2Z12296wR+uBeJ/gWuLf0IMJEprTmRR2nBqR2?= =?us-ascii?Q?vwMvvg7gwkd7np6PBFqzbcd7/wysHonTYZiZ1KzzmO7d9+slkIwGSlNzvdWI?= =?us-ascii?Q?oHFyk9+54dot4opjjFEprIfdat1jJn46itXzEEIXTbXAAhcbZW6SMQkG3c+Z?= =?us-ascii?Q?UruGu9c2nqEG8Zgez6CvdRLQ4d4FXtXPPlpKG8dhfARqBW8+Yi+TTw5YyADM?= =?us-ascii?Q?9A1P2AanlrWgb6vF/VlZ6nqRLU+uOnxdYWVLXn9on2RGXKHM9sXhCBmXM7Id?= =?us-ascii?Q?d4vIyBeWO+pPPayMji5I8+K7ClQiLZdQLFegfmcOkucqHlvjsi8t30KAH/pE?= =?us-ascii?Q?yHpvYT6ffZ/g+IpB2rER7cCnCT8d1+v5PsTWK7n7lqc3tmyXLqOWH1fjbeun?= =?us-ascii?Q?3/bp1JLDRWI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e43f9d66-bb95-4049-4af5-08da06ec03d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2022 01:26:37.1117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oX8gWzn4DmVza4ws/pbWu6A5wocPcYWIu7Bk6rNxmV2H+R8KGQXglayvJfYIM0KHSJNmwjJAShbzXa55aJpqdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2642 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. I am ok with DB instructions for tdcall. -----Original Message----- From: Xu, Min M =20 Sent: Wednesday, March 16, 2022 9:19 AM To: Ni, Ray ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Brijesh Singh ; Aktas, Erdem ; James Bottomley = ; Yao, Jiewen ; Tom Lendacky ; Gerd Hoffmann Subject: RE: [edk2-devel] [PATCH V8 02/47] MdePkg: Introduce basic Tdx func= tions in BaseLib On March 15, 2022 3:42 PM, Ni Ray wrote: > + > +%macro tdcall 0 > + db 0x66,0x0f,0x01,0xcc > +%endmacro >=20 > 1. can you please check whether the tdcall instruction is supported by=20 > latest NASM compiler? I checked the NASM (2.15.05) doc https://www.nasm.us/xdoc/2.15.05/html/nasm= docb.html#section-B.1 but not find the tdcall instruction. >=20 >=20 > + AsmCpuid (CPUID_VERSION_INFO, NULL, NULL, &Ecx, NULL); > + if ((Ecx & BIT31) =3D=3D 0) { >=20 > 2. Can you please update CPUID_VERSION_INFO_ECX in=20 > MdePkg/Include/Regiter/Intel/Cpuid.h for the BIT31? Sure. It will be updated in the next version. >=20 > + break; > + } > + > + if (LargestEax < 0x21) { > + break; > + } > + > + AsmCpuidEx (0x21, 0, &Eax, &Ebx, &Ecx, &Edx); > + if ( (Ebx !=3D SIGNATURE_32 ('I', 'n', 't', 'e')) > + || (Edx !=3D SIGNATURE_32 ('l', 'T', 'D', 'X')) > + || (Ecx !=3D SIGNATURE_32 (' ', ' ', ' ', ' '))) > + { > + break; > + } > + >=20 > 3. Similar comment as #2. Sure. It will be updated in the next version. >=20 >=20 > +%macro tdcall 0 > + db 0x66,0x0f,0x01,0xcc > +%endmacro >=20 > 4. similar comment as #1. See my answer to comment #1. Thanks Min