From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.1602.1665210832280733314 for ; Fri, 07 Oct 2022 23:33:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SKhwFNjt; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665210832; x=1696746832; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IFz+dBvSrW/+oCiQRFAjcRNv0znvZBTjWFmBdh0N+FM=; b=SKhwFNjtLAE3YEWUud16K1Q9tK30DFJUvP4Hgqrs0NLdniA0WFWDpF/v Rx/g3QuSHZNAE/0kT6TMIw9ODsjucQRcShxOmzXV2fwQ8NH6L9Rj3beJt JetuqLTAEww7g1/Gj90JPH4QANpUmH2foXPO1diLdpLoq/ycCaU4emUc4 QxdELkNDhuRLn24ODtA9lOuiA/u2numyQ73Vp7EGGbRJaNxwIoq13p9/H 2hAwG1Sr6bzz+sdgzKrxTiVmag9JaUmwOErskX21zdkLD7O7rwPEnb7+u JJgE1awnvyI7WzJnxS8kBNPnGbf/zRWaflOi0lqkLuHQTtlBABIJKiSat Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="330353471" X-IronPort-AV: E=Sophos;i="5.95,169,1661842800"; d="scan'208";a="330353471" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 23:33:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="688168626" X-IronPort-AV: E=Sophos;i="5.95,169,1661842800"; d="scan'208";a="688168626" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 07 Oct 2022 23:33:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 23:33:50 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 23:33:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 23:33:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 23:33:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfZZBqLL3L8QaGbbjQZd2KY6aJeHMTckHtoYi+/1yj8bH8LsL3RQLEsZ3Hfq9bAMmVF9oVDcUQ0NBJi1WEjN0E5PqC0S5CEX6oyAV3fJJzqsiC6jFqpMJLVeeXIP45VrI4sEVamGEdcLciHR/DWqNhN7cAlOLVoEkoZRACiSSNDetuo2oG0RvF2q/Q3PYWv67eXuJwbGKT6KcgI38ARkKO2NHM6WY8Zw+Zo47O7Z8aa7660WXQuV9i4CsPA0Y/vGll15uxBpzWheMugTKODxgnGXgoxujgzsaClTQt0V5BW96fD8jMva6W6eHNUzL2VKSOJDqIUEWOGSGt7saRDa0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=16APOdhzyusA/AM7WUKF6DB2PumEHlcOleP58Ot358E=; b=FlrtEUQf0xVDDsGiUzCMb9/GrocPjQKU8NRQp9/OOWTvpzw9U7WKh6I7WqkYjiNkILsUNLIAZ+d0clC1G1Cw3k1C4rjf9x6MEQeEOozLyfSQvFSdYHrQGYIVEfDaoGRe1tiMSl4SHYIpvOKqDd4XjeyKUxa+CrwySrBPcRNrlrbdhftNEIkcHtbv+rZ6NmB9rMfMf9Rt7b6E5k58Wg+XWwIZeOQWp3oMxeCiWC1AX2f1oDAaOQRBYsHrCfrNUdMo0FGsiIfHWmNKUhDh0qMtDAT7Mmnb0dqkU+vszZN4dwbybN0RTIfD9v9rsfKOtl5oswFQ0YOYfHvidxSmtMbPog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by DM4PR11MB5551.namprd11.prod.outlook.com (2603:10b6:5:392::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Sat, 8 Oct 2022 06:33:48 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5676.036; Sat, 8 Oct 2022 06:33:47 +0000 From: "Ni, Ray" To: "Li, Zhihao" , "devel@edk2.groups.io" CC: "Dong, Eric" Subject: Re: [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode. Thread-Topic: [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode. Thread-Index: AQHY2trpSJ0CrmGMIUqiXNR+/YCkma4ECjtw Date: Sat, 8 Oct 2022 06:33:47 +0000 Message-ID: References: <20221008055746.1599-1-zhihao.li@intel.com> In-Reply-To: <20221008055746.1599-1-zhihao.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|DM4PR11MB5551:EE_ x-ms-office365-filtering-correlation-id: e7063d32-8046-4eaa-f947-08daa8f70e2b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u982V5D4TKrwIF6CJDSmcMPQ+7nahJC3xtMaR1TABfW7ZQJRCW+YjGCwMFjqxFbjvpCcQjJGwtXQ7mvsadTKKFNlU5o2oQnJTmQBExRO6fqEe6I0frksrggCk4Dy2xgUFo+VQPJi/vbsvySdr85fUu9pXPmyvt0fnTTg6rIRy9lUwKeb94zJ1gmUSLbauOXf9k1oKtbYQiYVUiLhIoqwEe8oCj3twQhB3iiE84fSwYpsEZx9Y6vyj/JcljTgkM15BX3K2Pf7zj9/5wVkJ6m9jkaedYR1ytM3Fyev4LOyOXgwY2VVYDiYxwW3/dLX7yIAvt7KYMSpNYb3L19kP7ho4xAzuGgtQuKi0cpzJ0/K8+3hJi+Q25jlf8sIJMXQQBqxCJLmPzPYaP1fejt6wUQLr71JvYxjKM3qVA1DqFUeYw4R0SgD3h6dupAdmPu0dIdbCyl8hmLv8YeY/BqdPJ7NRlGCDkEUf903zgu+OIYFEwCUadHABFRZyIKTiNhGlK/ZsCyBWaFt4sGpzyxqUsYzTtGRt92HxgBYT784dlnJybzSQLFqoj0DKhPYUwL/XbCEi/96Yjg23eZFObdqX9lAhTSAU0mtYJx8DB72mVly9/RGcz1NLgPW1e5WsTWdNv+wLIkgIxG/2cbk8AhSVIVlSy2nnNrDspIO49U1Wid/CpnS3wh4VqLtlk9kBLbHoJsdyLPTUq6RaeaRo7/wPNco+DE8sF/yjJK0F1HDeBz8giZTGogm4wyhrnjck0C0+3Swve3st9qlcgii9SUghJnlTgKu3HyP5PHsHj1OSOUFxnM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(136003)(39860400002)(366004)(376002)(451199015)(83380400001)(122000001)(38070700005)(82960400001)(52536014)(186003)(86362001)(33656002)(38100700002)(478600001)(966005)(53546011)(9686003)(26005)(107886003)(71200400001)(2906002)(66946007)(6506007)(316002)(5660300002)(41300700001)(55016003)(66556008)(66446008)(66476007)(8676002)(110136005)(7696005)(8936002)(64756008)(4326008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qcTCdDlatjP/BmjYbkWN+WDo79zr6LUPppXi2EhfiX/AY/TUIm4iZC9AlFVF?= =?us-ascii?Q?cqIYFHeFBNXWi7A9tq0Gkpr4tJZfw/0jz1bm3MeZw7XkJVkwkny+BRQWXHgh?= =?us-ascii?Q?NP2TLc8nxrPOVU7qQHuIwi70TNMCe8ZOc9pAmpZk2xLcsMm94Jt0Sq2Mx/wJ?= =?us-ascii?Q?3oJTcGZ61ZetLxMuc37DAaxMsFKjpvNmpF+ZaIX3lsF30lISQ2jtPTYcANZ6?= =?us-ascii?Q?Jwww+kl8XBi5ZDmHvPk2zlunELVD2Upb7VRGsWKbvoLQ4lxHUyE1pnNaMaPg?= =?us-ascii?Q?K4eWUenbqKCIXpTmeBFDBRfheuJBmCs9m/9ppVcMGP3VaZnxa/MPAJtp2Y+R?= =?us-ascii?Q?NgZV4QagohBxlHN0sFX+9XMUQewOknrwNOA1FcL8ftbUc1rG/WS4V+8hlbVF?= =?us-ascii?Q?D4fN+0lu5SJShq6emMFfG+rfEi+KhJU5KcLFR5seYY/jYp+mDm47wNhHLvwq?= =?us-ascii?Q?fCLkHb1Y5S8RL2G86aaukF5dWL7spnbGXfrT/0J+vRnZ43n19zVcAEokebOr?= =?us-ascii?Q?X2aLgbVaeTsimRD38CBaAU/qHEvd+9ttA/c0Wci+lYtqHyy5nTZkK46q/LQx?= =?us-ascii?Q?2OL9biglDjGb/F6+uGzlUOSEFeyc2nrxDKutFmEwXh0+m5SiHw6kCAzSb3pk?= =?us-ascii?Q?CvmOC9Hd+++4YIrzCNMNnFyb7Sk7+azk4t5TDIRhFkXsXHpSYHb4Jb9jgPts?= =?us-ascii?Q?dsCUNPykJtjkO2F+xm/o8PjkWov0zw8LNy+Wq2vUiZJ3ZJHX7j+G7eYaoRjE?= =?us-ascii?Q?MorpIySpQr6FAf95PcVcDjWocrNcJZOWfidDXWW6HU3Jelbqi66I3yinwm+o?= =?us-ascii?Q?juSu6sX9SbvsplCmFo3TBpFOJoqUK86lo0mQ+ZcZxmPMyyhGSE7VmSYKebSf?= =?us-ascii?Q?GcCD8v0SD2/jxqY0Nob5o+4CrvDyYNeunSu8d6m/RhKQFFmXkQRsry5MOMmG?= =?us-ascii?Q?djnAewRjd026h0vNXsYr1N16yBlJBi+DViAnKxIjgvJEve6bqp4Vo7WysIFo?= =?us-ascii?Q?0Gw9JvuP9mQEMzC4VtnKOCuDNhateiAef5ldfuToqYoWEZ5Z0NXgB3JYoeXA?= =?us-ascii?Q?GW6heO2sIeFxhZ9AXhpDEgYoAtQjsnH5XEw8D17QmWATzxNsPgzhVSbIkJ7o?= =?us-ascii?Q?bd91pT0C1qccv7r7kX0DOJ9b3Xlky58rlYCk6N7Aa5+MXYHb4FDSjIPCBD1X?= =?us-ascii?Q?q6Mhm5pITsgaKc6TWykGjqVHURWpgU1b+Ug+fSx/J9hYmU8fOOSU05jENEQy?= =?us-ascii?Q?pMm0PUt4EfF1+vmqE+4kNXBNmxarZMMlz8q+QqwjQ5SunM0BiM/y0i2yZTxg?= =?us-ascii?Q?2lH5eRgdOFROJp8B5B7x9wln8nzBb05gn2VhNm8YVxHRET4SAQnzizhjJ/r0?= =?us-ascii?Q?X+g2aX17A9TB3Far9jZnqrOarVfBXwOtBGPU3FQFJi8GUsDAdIVzdwuKYzNt?= =?us-ascii?Q?wHWPseAkSJh3ZGiQhpZUg3SW8VnoYkyRjsk06J4+QUolbQULcCZABzzzDNy+?= =?us-ascii?Q?691zj0ZO3206ZmGE2mRKXswzYsb/Rfyujdno2iQlBhFY+5xNukWizlja+Ptp?= =?us-ascii?Q?RW4RGBa0L8I+06mNtYY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7063d32-8046-4eaa-f947-08daa8f70e2b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 06:33:47.4341 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x5IKHDmOsfUkX7/kTzKup7UHkjLA8G3E75Kb5n7V/J0NVPukZwAwJ2ZitCp5z2MJRTiJAOg3l6FOiXV+7N1bdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5551 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you please split the patch to 2 patches? > -----Original Message----- > From: Li, Zhihao > Sent: Saturday, October 8, 2022 1:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray > Subject: [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in > CPU relaxed mode. >=20 > From: Zhihao Li >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4083 >=20 > In CPU relaxed mode, it doesn't reset the value of > mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode. > So this patch will reset this variable. Modified the flow of > SmmCpuRendezvous to avoid enter SmmWaitForApArrival repeatedly. >=20 > Cc: Eric Dong > Cc: Ray Ni >=20 > Signed-off-by: Zhihao Li > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c | 17 ++++++++++++----- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++-- > 2 files changed, 15 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c > index 2ebf4543c3ed..368bacd29ea1 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuService.c > @@ -421,11 +421,18 @@ SmmCpuRendezvous ( > goto ON_EXIT; >=20 > } >=20 >=20 >=20 > - // >=20 > - // There are some APs outside SMM, Wait for all avaiable APs to arrive= . >=20 > - // >=20 > - SmmWaitForApArrival (); >=20 > - Status =3D mSmmMpSyncData->AllApArrivedWithException ? EFI_SUCCESS : > EFI_TIMEOUT; >=20 > + if ((mSmmMpSyncData->EffectiveSyncMode !=3D > SmmCpuSyncModeTradition) && !SmmCpuFeaturesNeedConfigureMtrrs ()) > { >=20 > + // >=20 > + // There are some APs outside SMM, Wait for all avaiable APs to arri= ve. >=20 > + // >=20 > + SmmWaitForApArrival (); >=20 > + Status =3D mSmmMpSyncData->AllApArrivedWithException ? EFI_SUCCESS : > EFI_TIMEOUT; >=20 > + } else { >=20 > + // >=20 > + // BSP has already waitted for APs to arrive SMM if SmmCpuSyncMode > selected or need config MTRR. >=20 > + // >=20 > + Status =3D EFI_TIMEOUT; >=20 > + } >=20 >=20 >=20 > ON_EXIT: >=20 > if (!mSmmMpSyncData->AllApArrivedWithException) { >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 13c2cb8da4c3..c79da418e37c 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -696,8 +696,9 @@ BSPHandler ( > // >=20 > // Allow APs to check in from this point on >=20 > // >=20 > - *mSmmMpSyncData->Counter =3D 0; >=20 > - *mSmmMpSyncData->AllCpusInSync =3D FALSE; >=20 > + *mSmmMpSyncData->Counter =3D 0; >=20 > + *mSmmMpSyncData->AllCpusInSync =3D FALSE; >=20 > + mSmmMpSyncData->AllApArrivedWithException =3D FALSE; >=20 > } >=20 >=20 >=20 > /** >=20 > -- > 2.26.2.windows.1