From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [PATCH] UefiCpuPkg:Add RegisterExceptionHandler in PeiCpuExceptionHandlerLib
Date: Tue, 11 Oct 2022 09:35:32 +0000 [thread overview]
Message-ID: <MWHPR11MB1631315A49E1572103FA711A8C239@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221011060047.516-1-dun.tan@intel.com>
1. The PEI instance of the lib didn't implement the RegisterCpuInterruptHandler() API. Your patch
adds the missing implementation. Can you emphasize it in commit message?
> ExceptionHandlerData->IdtEntryCount = CPU_EXCEPTION_NUM;
> ExceptionHandlerData->ReservedVectors = ReservedVectors;
> - ExceptionHandlerData->ExternalInterruptHandler = NULL;
> + ExceptionHandlerData->ExternalInterruptHandler = AllocateZeroPool
> (sizeof (EFI_CPU_INTERRUPT_HANDLER) * CPU_EXCEPTION_NUM);
2. Can you use ExceptionHandlerData->IdtEntryCount instead of CPU_EXCEPTION_NUM?
prev parent reply other threads:[~2022-10-11 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 6:00 [PATCH] UefiCpuPkg:Add RegisterExceptionHandler in PeiCpuExceptionHandlerLib duntan
2022-10-11 9:35 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1631315A49E1572103FA711A8C239@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox