From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.5235.1665480957940911883 for ; Tue, 11 Oct 2022 02:35:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BiBFh0vL; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665480958; x=1697016958; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ad6qQwJErq4Chd3IqFH5HN3dAVdbeY8DGj+ZuVnCzY4=; b=BiBFh0vLfY5FvO0S4q9tc5Km7GB/Vl/9OvueM6bVRYYYcSnREkr/pAlX Om3K0mTQOGpxGCt6q6feI6P+u/KGW4xro4IT5EQ7Iv353pjmgjB+NfIFE dqL3I+Ecey9QWcB0Fn8tIXqBDTsyvFSk7dfibomwgnc0ylqsJpAePvm99 m0bC9AuoXQAmcHhm8zsKC4bZ9a1Cl6SOFg4fUcWJvNR8XznnGkFF8sgZj SOHlFnRXLaR6XpoMJ4aXtmDyNEQ4wjBW1XNJtI3YNBUEEgRJFmZeoV2bA KFfJ2cE0KXACJOwCzlzuzVgzcahGyTv9PqYwmiFd4cKnRSahenC0VNkjQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="284840063" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="284840063" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 02:35:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="626298145" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="626298145" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 11 Oct 2022 02:35:36 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 02:35:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 02:35:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 02:35:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVefsVX17zJqTAiC3cNKqPAK3QYdYiykGVmvuvd/NvJAYFXBxsq+tUzFD7C/YPU9L2BiGpJq2aQtqgsFevr/JlJXboI8qs2Q5JylK+9dZ702gc582TSJlNFTu/RtyKO9ojaIc+r/lT5QN+QxM/jXkE7ASG+E9iJPHX6kz3tRSHVGJMWK6LBZWwfakfVHs62QXNJ123BMXI35PkJQcLKSHazzu84C+GLRVrWYffHknGwKUQopiLbFXR/DFZuTFvjEIoxR1TifNTM0Joj4mNxAcRAK01bb8fWmMxE8KRh69NF4EmhF5z7ZKrHaiOUqPOok0vxJp75MX/pUMMRfmXB65Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aabNYYG23M6azUi+VyDqwcC8lt69LxSwwZKuGmWkuiA=; b=kF00t2LHA/+FzLBYsutw62ma59ac7nhMaClsRMQW6+n9vmMA/p3xwhbgvZ1jspg1KYYnJ1YvOr0bAiN0pTi7mAJTrmk596Vt9FbL2vnGnqsiX8Cgip37/Fk1Z/5AjaNQCeBcH8hvfo+cNw07BlSEZ1Y2TQfiD6aLj2YrHhCRTXIeEStZ9/eke+DqPG/MjzPgocnOLrNTq5UMMKsEyFC6PZwBPMN1owi0atn8U7mqgVA+koxrtlrAgNDS20x6/wZ7n8ncEjTxsFast6WGKzzUQyHDoc36j6eNuEjv/lNbUM54SlagQlA/eTsq3zha9qZdq8qdJra+Qc5vp2Ti9V5jJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA2PR11MB5099.namprd11.prod.outlook.com (2603:10b6:806:f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Tue, 11 Oct 2022 09:35:32 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5709.021; Tue, 11 Oct 2022 09:35:32 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Liu, Zhiguang" , "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [PATCH] UefiCpuPkg:Add RegisterExceptionHandler in PeiCpuExceptionHandlerLib Thread-Topic: [PATCH] UefiCpuPkg:Add RegisterExceptionHandler in PeiCpuExceptionHandlerLib Thread-Index: AQHY3Tbem080kDf960aer0fKknnl8K4I7j7A Date: Tue, 11 Oct 2022 09:35:32 +0000 Message-ID: References: <20221011060047.516-1-dun.tan@intel.com> In-Reply-To: <20221011060047.516-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SA2PR11MB5099:EE_ x-ms-office365-filtering-correlation-id: acd3ed28-b1d4-488f-377e-08daab6bf180 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HHtxE6yEGC00/KEOUO+dHleSr8k0IQGEHagUfPEwf2D636GTtmddcWGMtPtpH3uOiatjo+0tRBvWQ0UQZtXu3UWvy7BzUw996PVHrIL+th0iOY4DmQmPE8GWLlObcA1mefmtqFFywW1J+KjrZMFU4Eju6GjXFTMIvQY68C/rlK3/RGuUsjQJces8x5BaRT1Wr3WgAoRyNsDQnX9PWQxAq4ctfQy8JdOlC96Vaq7iLqs8EKSefyquY3PopwIcvhsOyI1loSi30JoZl+CluRrlodIoQj3nCotxP+xtlNgG+gXl069tacc85U9THCOxDts97lrZCgu4Sb6pX49B7LwuAr3m/IOWqgticmOzLVBxWBWJGSZqXHw/HhMNOKEVmvgwc62D8CfaKF3QJfCN/18Ea58YAqPkdUvO1PbVPoZ26OMYNSYFiFnK9dtpb81sbiMnFbARrR8JyF0dEwyUcCQ4ljQhHrsIumNJRA8TI5EuqFYFu65ZIr9bUaJaN+fXA1aqccGGewEdheF2LfGezsPHKr1ZeoF/w/qtNfPvgDVqk+VhY86va1F6ro1S4jOzHgbeO1lEkI34GvjGW7Vf8Cb+W/ruzy0l53zjAWZ94PBv+ERfJRT+2j3jMETHtd4H7HUhQxqpnKSZSgbMMxpspxYHpT/mnPJuDSP6xlK+VTpRi1qej4Dr3KBUypQVM2Sx/FJfEM5SAp8vlzKBVZBhisjn8oSq2Bq3v9uB5feg9bWQcpyIYhR7yQtdgfFGWwAKq8UUk6xcGeE5Yys+Kq9fXN3ExN81SCKODhu0FvCcg+BgI7M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(366004)(136003)(376002)(39860400002)(451199015)(55016003)(33656002)(2906002)(83380400001)(26005)(186003)(38070700005)(86362001)(9686003)(107886003)(6506007)(7696005)(66476007)(66556008)(66946007)(76116006)(64756008)(66446008)(52536014)(8676002)(41300700001)(4326008)(71200400001)(38100700002)(122000001)(316002)(54906003)(478600001)(110136005)(4744005)(5660300002)(8936002)(82960400001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AdP9oHukSqrGzEXURpExdUEFnPUBvgbzPGuHBEpq9ktdYkrRZz4YlaMtewLl?= =?us-ascii?Q?7Dth1s007XawkXp1CJfdV1e7YDOLHOXvFfJerwmJtmKvSUOoGLqlE45Gn1rT?= =?us-ascii?Q?x20dQqEsU2KmafRtYB9zFYJsILXPPmq3ap5kjlz3HZMQisVxO/7JCmd8Mlcn?= =?us-ascii?Q?OY4Gs5BkMUepQ8zrUwoOEkVDZMluARCR0t/esHPXaC7X2GYqrx4rCQyKbKFJ?= =?us-ascii?Q?R3H2/p7V7ZjyU9NAys78/cuNikT45Sk//N1soYZ9tHhisxEHNLnhMryI9Tjh?= =?us-ascii?Q?BkIeVTTOqGzzPmqmBHmg8ANHirdN0F68VGPGSuytUYUQtGMgEvB/C5TqR+E+?= =?us-ascii?Q?m8sCUccJRKKbejPI/yx/DqD/wutgpbr0BoHaQhflgjNvGDZMiN93CTX/CTHz?= =?us-ascii?Q?DNQSLLinDtLmtRAchKWensbXGuCMJqLpkDhmWOVYVjxebSh8dGKeVf2jC1jJ?= =?us-ascii?Q?DqoBAiVr9Ya0aCoR1txO+heCL1EukuVrtXOfu9dU8b8U4TXqRVj8ALE9ihSs?= =?us-ascii?Q?bNI8xGxi4lKVM3FxzqaDJVR56i4JLwbWuP1rfRdjHUT65s9iSA5CHW/4Qtfc?= =?us-ascii?Q?K2vC2Wz1mpYSwaiwzfNnxTvh5ephu3a5u8U4He35JnF/qNCYRlITcvjp2je9?= =?us-ascii?Q?LnQ5EiMgxGro0myuK5FVq0CZBsydOT9mOY5utYtHSbsBBxSxGjazt4Ix4Q5H?= =?us-ascii?Q?mrPvt2Eq70KWqf5lR0ToZS69sDtgwnkCqdyfNynUWLG8m3Fpa4hd2IwIuyyG?= =?us-ascii?Q?zopPQ/1SaUZD7sADa2LnbwDAFz+WQi9/R7Gz+Er+YP+p5EPlJ2K7QMq/ELw4?= =?us-ascii?Q?VETnCXVL7lQa5BTri+83Tmq7entSXKl7LX1IZ7OoOj+H/MsTlBTb5o6YFV7Z?= =?us-ascii?Q?g4eofQ1xrWX3MhTwaEyhnPSj9WpUv9ACTRIxIStZEwdlJl07br/LXVcY10v8?= =?us-ascii?Q?A5b9vZIa7Rj43a1h9W7eUg9WgLQURN1YVqVCoc07AmvlLySm3F0cIvyzjSMv?= =?us-ascii?Q?HDzo7KhgeS5OFx5ucTSwusikALlP6ezf/RKl/5Fg0V0EB7EFAlLByOimhKew?= =?us-ascii?Q?hUN5zTrnuwRX21vYdBLH34YR9/WQpYQ/LgLbfKpY+8N3qmrITtqKrzjfXaxN?= =?us-ascii?Q?juG5GUKVfEygSfwBnvQmk2dEPqKJc9vSrKHTCC93ipL+qCEb258UzZGV08od?= =?us-ascii?Q?CDY3KrdzqwBUuf4Id6rIOzy0GoouUicFDCLOGhSZRVg3l5qDw+vjjA2EZ30y?= =?us-ascii?Q?RWHoYyMsH5ppIJ9oULIII0aiRJg7e8H4iT3Llg+rhEUI10+TSajRmCKRr2CX?= =?us-ascii?Q?HjDNFCk248NgvqrtP2rw3kcmszj6hI+l2lIU5nqvxbmoxdzQmtk7Dch0/jZD?= =?us-ascii?Q?wPXMcvO+Tsmup6MZPbKcsTDS89YgfXSCpKqA9fuDS9RfbSzysvevHEzROAwa?= =?us-ascii?Q?Wd1IQHOuS6HmrXRJAvuLQkRxaNf6Qn+GMGul6uZfkh3sSwkLOSbKyXoklVFm?= =?us-ascii?Q?6m6gMg3rowe5FgkkO6DIq2syB3Z+fJn5L4iVVo5zmJC7jB4KGXlID3/ll3rz?= =?us-ascii?Q?thKt/A0qiGdZ0GD773ltBRnmoSWjWCgPlRJTpfHH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: acd3ed28-b1d4-488f-377e-08daab6bf180 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 09:35:32.7283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uimXf3eJBWRM6B3mERMhCN6U0ms5JxU8SSRZbcbmFdT0ebfza0EydkBB+jU46tQLgEf514VpKsbQiYW6h0MUGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5099 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 1. The PEI instance of the lib didn't implement the RegisterCpuInterruptHan= dler() API. Your patch adds the missing implementation. Can you emphasize it in commit message= ? > ExceptionHandlerData->IdtEntryCount =3D CPU_EXCEPTION_NUM; > ExceptionHandlerData->ReservedVectors =3D ReservedVectors; > - ExceptionHandlerData->ExternalInterruptHandler =3D NULL; > + ExceptionHandlerData->ExternalInterruptHandler =3D AllocateZeroPool > (sizeof (EFI_CPU_INTERRUPT_HANDLER) * CPU_EXCEPTION_NUM); 2. Can you use ExceptionHandlerData->IdtEntryCount instead of CPU_EXCEPTION= _NUM?