public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Guenzel, Robert" <robert.guenzel@intel.com>
Subject: Re: [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT
Date: Sat, 8 Oct 2022 07:31:40 +0000	[thread overview]
Message-ID: <MWHPR11MB1631335EFE64BEB55667E95A8C5E9@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB2832333520F26818FC476409975F9@SN6PR11MB2832.namprd11.prod.outlook.com>

Thanks for fixing that.
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guenzel,
> Robert
> Sent: Friday, October 7, 2022 5:27 PM
> To: devel@edk2.groups.io
> Cc: Guenzel, Robert <robert.guenzel@intel.com>
> Subject: [edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT
> 
> 
> The DSDT had a syntax error that was not detected by older iasl versions.
> This commit fixes the Syntax error.
> 
> Signed-off-by: Robert Guenzel <robert.guenzel@intel.com>
> ---
>  Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> index 8a6c3792..3421c9e8 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl
> @@ -372,7 +372,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 1, "INTEL ",
> "SIMICS  ", 4) {
> 
>              Package () {0x000EFFFF, 0x00, 0, 16},
>              Package () {0x000EFFFF, 0x01, 0, 17},
> -            Package () {0x000EFFFF, 0x02, 0C, 18},
> +            Package () {0x000EFFFF, 0x02, 0, 18},
>              Package () {0x000EFFFF, 0x03, 0, 19},
> 
>              Package () {0x000FFFFF, 0x00, 0, 16},
> --
> 2.34.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> 
> 
> 
> 


  reply	other threads:[~2022-10-08  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07  9:26 [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT robert.guenzel
2022-10-08  7:31 ` Ni, Ray [this message]
2023-04-11  2:52   ` Ni, Ray
2023-04-11 18:46     ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1631335EFE64BEB55667E95A8C5E9@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox