From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.29538.1649685336026643572 for ; Mon, 11 Apr 2022 06:55:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LyKPu+6T; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649685336; x=1681221336; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wcqDRTn5PuZH2I7UdTgWxoVoLf6jee+vFqW9TT66sK4=; b=LyKPu+6TjYuOSAt3vo3zDo+9A1sN2fPtLYxnoPgdj6l7kj1hz8X6M0pp OnBtaq3AQkR8koUbMoL0qycplCVgnnOKIabQg1utmSQAvVE0Rh7TOUFmX +tbP9XPIFdrdAtKtq/ZoHh9U2rXkEUWr5kN6UwZbSZjrpoUZBiFvp2a0a XZyViFahI8CWnTuo6xZbyRFzoAXdKTyVg+kczSn0JTs6bpH4W3rt8ujfK qBKeCGzlsFJtFtMkMl9K//wPMiIbSk8pjg/HUQz7bKBkFpbCQzwph8ADS 2Gr068r2xUMEjC4BGfK82oZgVPLYJa8U5o6KisIRULw4FzQ+4MQ3FfrKE g==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="261864758" X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="261864758" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 06:55:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="572172027" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 11 Apr 2022 06:55:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 11 Apr 2022 06:55:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 11 Apr 2022 06:55:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 11 Apr 2022 06:55:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l+qGp/crhd6OlHJJajN4XBfdk8AjdavJE/kBcJKijoF3BmAwJvSAN8Y+qNwKbwuUxFFdLng2faljuKJqFARRCfQkXLwRPLrBPLqDRyF+7p8YIR3YmEf8aB6prm8tYHsMDAXB7aApvvHFgFAbw1hdgJun72a6Y6VD5+Ba3zKipILO+z0IYO7dUec0SbW7KBUzrLHiJexDuA3Ae2AJ4DqCtTM4rY/cbW5LMIR93z8ILzDQxU9INfh8JR976RHuM1EDqg+f7J7RznOlVQFBZd0Jpo5OCCLc4ORRFR7gxMElVHGNKR4MCUeazcSIs44K3dUUC6pZvbmOlNEyDMbYQIlkhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mXo0a+DSIYRFPygaJ1BkuBtuDMhSdddShOvkBxaEdQk=; b=GgMVpC/FeRDD3K46Y1S+wGKCy4oVATRTzDrPTFyGi8pIyRiRB+teMiOLkiZeB+as21fYWc9mrSvsSW0gRqyDrq3XYxgjPm5zPv3s0hLS1W98AJb2sb3xz6u/916SxyLyUSpuT1S7vPwmdnFSez24MSDAgiIW+UW+AglBnwWhPrgtljXAvVOvE0icYcCKlmc86+yPMViWq80pYBmRcX3c/poTdVbN9Zb50IQ5G42TW7G6rFP2hdl0iZ1dvKAQvxYB4Wntey+QG23+P4OVQnyFy3z3ZSnkMXVaiew2LfwX5rDEoKYQe1kEYEhpuWV3Up8bEhoMYztskIzHdM7KdsmfQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MW4PR11MB5912.namprd11.prod.outlook.com (2603:10b6:303:18a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 13:55:23 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::a88a:3f13:4d9:3127]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::a88a:3f13:4d9:3127%11]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022 13:55:23 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Chen, Gang C" CC: "Jiang, Guomin" , "Bi, Dandan" , "Zhang, Di" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStackGuard property Thread-Index: AQHYTYzrI3T07qtV7kGT1n+6fwgo4azqu/mA Date: Mon, 11 Apr 2022 13:55:23 +0000 Message-ID: References: <20220411101350.697997-1-gang.c.chen@intel.com> <20220411101350.697997-2-gang.c.chen@intel.com> In-Reply-To: <20220411101350.697997-2-gang.c.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1c2c3bed-3072-4be7-8376-08da1bc2ec83 x-ms-traffictypediagnostic: MW4PR11MB5912:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VK2dFklFsJ/yZreps40qJY8NUzkMkjKNUZuZmJQomwBpTTql4Ke2q7u8v4DWbHwV3ut7DMx1l7bht5HZXxEvA59GHR5Jkg3udJhKYkBgZCWc95VAdzmdhOB9Bm1ch6dy1SHjOXU9BQIXxvCNcBRx5a1FV11ClkHYdHSciOHZgBk2nRcFvlhpFTWo1AqJ9cjyS0CGTgKokrBY4jX35xf4kyPWqNA3E+PXUwH0A+D3+J6AjHtR4TWm5TfgFmw4rqv/7yP08QPIBycufqSSapsbyTDIN2SgoH0ADuD9mfb/fMr5ygpVFomtBVPCVPei1cQE5S6te8RJQLCmkcA+uLbmeDNFu0MjJatj70F/HLCxSO8ZbMq8f+qh2HCM/+w/ryNc7xVl41akYnAI/LldrFTJuzULefUUo8vjWBou5yRq/NDYHTw1KO+bghP8mv53iZJzviXuZe0Kd6tKGJbtrC504Ss0EBsKWaZ5pn9s8gYkcp7CUD2JUGAt69QVU6u+K3kb+xcYpwXim8qsZnjpr4fPr4bsb3np6qmLTlsfMGOaHkyWAZVaUmwJ4550SR2FNuNHYCn61cX8jVFGFKgU0raJkf8lNt6w9NKMZsaEdukKWvuAc3K8lB6qm2Jz+/wFJboRmBnfdQi5LtwB/eGK1YngL5aqFaWseARNN0oYQ8b1vwztj9fC+WVLZdU9+o/hDGoWykIVPM4PDWjRrFPB4Q0DHOodfOvPBDJrCQxSf2AvMNyLhA+8fBEi5xMNYwP8cHzqM7hPSkWy2PQRPWTSC5PROtfsHPna2ZDDKIQXrkAk3pJS1j0D2T7ZsiGM8o8jASHXksmEMP6N9Hd6D9cjodAxhw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(2906002)(110136005)(38100700002)(66446008)(9686003)(53546011)(86362001)(71200400001)(15650500001)(66946007)(82960400001)(7696005)(316002)(6636002)(4326008)(38070700005)(76116006)(8676002)(66556008)(66476007)(54906003)(64756008)(122000001)(55016003)(8936002)(26005)(186003)(83380400001)(52536014)(5660300002)(33656002)(508600001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gXIuwzacsD3gRtfr4KwZxKdLpzTcDJrvRw3aO9ilfO2bC6g1pgQL9/BFOZpI?= =?us-ascii?Q?5Z9Pn8+ITrcLy12hYi1ooOBgPBxkiVg31hdFD8mBoVd7RnzIB5wz4c7QwC7l?= =?us-ascii?Q?Fvfmu2oGiY3Sh4v4t9qnRdYhj2YqCEx0EBP4tiiGkd7ZnLBeTM7xGFFas6ZP?= =?us-ascii?Q?OJwzxc5lWc9kymY6LhfwrUUJStOncDTJ1PmjwxCjupOd9QD/Wj7OwUNPvwBD?= =?us-ascii?Q?e3lwktc1PHiwzFoLgnXQXT6iuaRWJOL6jlVMB9O950mxCvpX4zuh2X4HakAj?= =?us-ascii?Q?gHm8EXXwNsm7o5492f2eDF1BAPyYcOeRoX2qknUaufvsGKmsDmHgAtO8KPFX?= =?us-ascii?Q?OhwtHbtpkXQBzOfB10sSK5sIAEVtzNwa6pvpxWsxb6QTG7FF0hWGDkeirVxA?= =?us-ascii?Q?YyYNgOBR+RyQiabCCZ0aTIJz9DT6tFlT3GGMdmyNChd97+2476JdOQgW2rRa?= =?us-ascii?Q?xlV8fzf9TZXbJ0ciKqIAW9LUEkEz/uEQE6KgdKJhp6gjBX5rTCFe2NaQmeKO?= =?us-ascii?Q?qaPrtqg8WQWRzdAw85TjX9Ea5vfzoOvt48HX/CyP9gmK95avJ6Io+fKKMsl+?= =?us-ascii?Q?jiLAFbRcfC5//MQnKwObxTWgNaYXNrzLrC7lECvSDPxTQMKO0BX2oaQPBpy7?= =?us-ascii?Q?2KZVm+9oL0PpxvkYNp26HSgMa2HRL3jfGmOZNrdFUbV5SCRHzNhMZbqyZlEY?= =?us-ascii?Q?6FHMmuIZeDCSQHwOMITnTSefiF2ny38o+LXX8DZof++xbH+a43FvEscRu2G5?= =?us-ascii?Q?h4HAzBiIE+awcjHC2fuPMxBOnczs3sgSVLAbDovGeEXdvyXpztKYHfXepHyI?= =?us-ascii?Q?jji3D87gzqCoh5zBTdNRp7rUNtBeB9ekmDqPTLZOaIxB4UiBK8IcfbjcH0vC?= =?us-ascii?Q?m8ToVOlEBxnaL7psJY7l1vGAi9g3Cl2VwuW+dGo/Wac5BY7thRPRrcClC7o9?= =?us-ascii?Q?pqOtD8Iumx66TlblOSUIwwOYpcDmQnaxij/SjJCzCivPy6SjJuxgVzSq1oGg?= =?us-ascii?Q?KBvwCSTb2y9iGlHbo/3aPzvIDucYybecEVwGbjAVDXZSlieprodlrYy/YzGG?= =?us-ascii?Q?9R+szV9INVYGQBCUphsLLdlQ8ilEyehhjzVHb8c0ZVdO5jXqUnXAMuoJNxn6?= =?us-ascii?Q?sA37WV2Rt1bktgL8UKZVa/UO/OkcEUoM8ewmFQN1yUyIFB+JgqhtovpXxIWB?= =?us-ascii?Q?mbPmlBFnvl/DUhk3h6MeiaUP+JPw1Wn8/iFzQykOVkCwg9ajUjy3wpVHQtS4?= =?us-ascii?Q?y4BAih0PJbNdaG99Y3INijKIQAoh2ctsrp+6L1Ai1lb7VK7Ar/xlCIuZuJa/?= =?us-ascii?Q?FMa+RKBuqdYlhVAMDby/QkiQNK0mKqbufWNPOWTBVYlKgFKpJ/mTzFZaCW7o?= =?us-ascii?Q?67o9ouPMiwzL1NDWzDkD9534Ad7V3GATy9qPwFF+EI0kKYVy5zgstZ+uprFx?= =?us-ascii?Q?KXOhAA3uAbzmoTdlu7X0Oa9aEhCaRZsqUG86Um82xt6Ysn8RwMUiutbcJhl/?= =?us-ascii?Q?2z47d+Noe50XjHvGb1aMmDQbNECdv3Hg2JE5mjGSb9/O1v488hXO7eAACPSv?= =?us-ascii?Q?DAWmnnhRplik3T6wgiarkPkmiR4lFPpCvjZjcAw2qboisOFsr4zXJXhiGh94?= =?us-ascii?Q?aY8VgYGXbVl0XLaXiNqr34c/dJB0nyH097HBvsHFtDS23gLi4cVXZtDIp3iw?= =?us-ascii?Q?DpAznYEs5WVHU21qm+uXFza/PazLXtSKuMgpTozLAMP/vJOJtswWTLst6BT5?= =?us-ascii?Q?d6lTVzdupQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2c3bed-3072-4be7-8376-08da1bc2ec83 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 13:55:23.0431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FBDG3Cs0bivGL/3oQyXeAp/SXBEjt1E5tNtd2NgmD8FtTdSwLvB7jZyOS31KOFWvzKO+kyEYpvFSLQ1t78icBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5912 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable FixedAtBuild PCD can be accessed at any time from any CPU. But dynamic PCD can only be accessed from BSP and after PCD database is ini= tialized. This impact of this change is not as simple as what the patch does. Why cannot FSP API and Dispatch mode use the same setting? (either enabled = or disabled) Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chen, Gang= C > Sent: Monday, April 11, 2022 6:14 PM > To: devel@edk2.groups.io > Cc: Jiang, Guomin ; Bi, Dandan ; Zhang, Di ; Wang, > Jian J ; Gao, Liming > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/dec: update the PcdCpuStac= kGuard property >=20 > Update the PcdCpuStackGuard from PcdsFixedAtBuild to PcdsDynamicEx > for the requirement to set different value in FSP API mode and FSP > Dispatch mode. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3897 >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: devel@edk2.groups.io >=20 > Signed-off-by: Gang Chen > --- > MdeModulePkg/MdeModulePkg.dec | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index 463e889e9a..72e7e2eced 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1070,13 +1070,6 @@ > # @Prompt The Heap Guard feature mask > gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0|UINT8|0x30= 001054 >=20 > - ## Indicates if UEFI Stack Guard will be enabled. > - # If enabled, stack overflow in UEFI can be caught, preventing chaoti= c consequences.

> - # TRUE - UEFI Stack Guard will be enabled.
> - # FALSE - UEFI Stack Guard will be disabled.
> - # @Prompt Enable UEFI Stack Guard. > - gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x300010= 55 > - > [PcdsFixedAtBuild, PcdsPatchableInModule] > ## Dynamic type PCD can be registered callback function for Pcd settin= g action. > # PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum number = of callback function > @@ -2079,6 +2072,13 @@ > # @Prompt Enable PCIe Resizable BAR Capability support. > gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE|BOOLEA= N|0x10000024 >=20 > + ## Indicates if UEFI Stack Guard will be enabled. > + # If enabled, stack overflow in UEFI can be caught, preventing chaoti= c consequences.

> + # TRUE - UEFI Stack Guard will be enabled.
> + # FALSE - UEFI Stack Guard will be disabled.
> + # @Prompt Enable UEFI Stack Guard. > + gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x000100= 25 > + > [PcdsPatchableInModule] > ## Specify memory size with page number for PEI code when > # Loading Module at Fixed Address feature is enabled. > -- > 2.35.1 >=20 >=20 >=20 >=20 >=20