From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.6253.1646126604511986079 for ; Tue, 01 Mar 2022 01:23:24 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WuymT9AX; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646126604; x=1677662604; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=npYLuAtVdv9ZDIAGqPTzelGE6BmHQkwDwpFT9zYvdH4=; b=WuymT9AX0Ph5hF2O3TimDC7yL1zpyN579ddaEWuFEg2hulibFtHlWrRD cad8xEEmZGbAf2AmLeme9QDKjC+TltmXVuGrvraLwW827wGJoa0rbNwTT M1kZ9aIzlGYeMJq26O44FeS1VDVK1PgmgzsrU/mE5zalD4hLwmRm/zRsN MBqM8F/dwVTECNxso2C2rFvfSscKfhUv68wmq2DmNSaAUZ9ATzfljt6Ne SLYIW6LCLz+nNGz3yGlfDrzqZbtqC/7uqoH/jyqMHQe217rkGFcOdjmJH ecfgBeisF0nfbtAd9a7/BrTOo4QVapJt8OLlJPU4tV8m38mci6ZjXAagK Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="339528673" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="339528673" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 01:23:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="804583356" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 01 Mar 2022 01:23:09 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 01:23:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 01:23:08 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 01:23:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VpxLFuVdIssB7mOyZIDjehbulpBGVehpVbX0lK3P/08w/AuuPlETDfeMsJCsiqef7ymvSW/3tuB6IxpXobjY669QIsKXKXnc5ZA5bOOAFZqkIi3zItqjJL0SuNj/JSSrM/MKYJ3YjioE2tfrh7TBG4yicPExadgBgmFjZ4osvQ0KDwWtqvWh9TvZqNnk0OLqjGOdcy29pngnwIvEh5H/mAbIuKpsyd5kEBK/QsoPYkzs0HjNW5BgEHT0L/zshTaQW4Fi+AOIoW5BVDOm0vbxtO56LyZDHgsa5UqNTXjCy9z5zhwaxyQSCIVepH4WYg4H0Tg1ENOPloERwpyjfFTmzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aU2ARK2iiriIqWW4zqtYxC6OGnjHTOIftMJAmDGdtbE=; b=P9vBHiehf0EWdkq5SkQBkKZSgtE/78DoXdUDF4KxLV2hi4SfoRw1VN8Mn+if2uK2RZPt12WVBSwgGIMwbhh0J/UlGsga3GOFWvwHZKqX6JmOdNxZB2Ho6kwHr5KzRkL/O/L9ncoN31k76pr/eCtf9uhu8wklRXl1NAPWRw2zruE9vNS2fLLYu244evOLXuYUxAxgowgWib/ElPJ873KJj+qeIoxLRncNEld/f3cfvH+sJncUrtiOEZCzxNpK8AxFL+HN7cjAxlaku871q/TB+ApyxyIvdrlY/95FwlhamV2Rt8VPYgMhOltczlRTPashdQ6GvYcakN05DUg0l0B5gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY4PR1101MB2200.namprd11.prod.outlook.com (2603:10b6:910:19::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Tue, 1 Mar 2022 09:23:06 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::99b6:d326:2925:4d2f%3]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 09:23:05 +0000 From: "Ni, Ray" To: "Jiang, Guomin" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" , "Gao, Zhichao" Subject: Re: [PATCH v2 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error Thread-Topic: [PATCH v2 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error Thread-Index: AQHYLU2Dcus28PVW5kWB+6Lu4TNGsqyqQUDA Date: Tue, 1 Mar 2022 09:23:05 +0000 Message-ID: References: <20220301091850.828-1-guomin.jiang@intel.com> <20220301091850.828-2-guomin.jiang@intel.com> In-Reply-To: <20220301091850.828-2-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06e29e37-2f88-41b9-fe98-08d9fb6517d0 x-ms-traffictypediagnostic: CY4PR1101MB2200:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IWTjhLxI71kAy0+vHeFN1jP9/u0gESwRac9Ki0bxDFrKupjOB7oKcpthx8Bw6bWS6NFX7syC+QV+JiDazxauytd3gnWKt4yqaVuuO3bnpDhe0ahGhSzWdvhvBxbRBtyxDgEj/0PLstQ8WwyAeKsKBf6R/TSBIwi6zrBUv5wH3Kk0eLSW5tlheZVLRNlxDqQJ2Qfd1YTg2Dh1MBhhxR8HhvzJnayL1CjVfW6781J+5/qAOS4wOb+uFAYexFMEZnixABdMO5vIbpEfzz2Bx2pm7mojNNRMSmWfZCXe5DYtI8eNLf8z7UfvbIAFMULTfmtbCRehDJY0biL4WSSaR5fuuL6OF5x3mjrRpEG7qcWcOI+K5Jyv55j9fEkSGm6lgEb4QswSNWSIAlix6UT3aKuieL3MBsLjaxp3hZMV189pZ1MGpnYLJG0xzz4smyPg1MqF7Yc7zgeIxgJaGioIb7def5WN6Tm1Lhb8ibrqKYfsSwmysWqDWAqrdULYV/AJkcBSlLv1R0nfI8iodg3EHInr6utxfCLDAPsH+iQE8jccejr3pi6GRoJSJjDP+/Wgbp8ieLxN/TkAWXiNFGRlc5LaVwG7mne0xo2oxPD1oE9/YUkcBAl9XeXLqoW5VpnXGHlaLrGEU2xN5AvmzW3UPTxGbVMsDXwiB4iFnm3PcvpyxGfB8m6E21gxWj1KqwrL3tAopu4y2YkhOZ/MtcGWkPWaLCjkKoljXiNza3Ip1+LT1KpHDNiU/WHDFWEndRPCM1ryc2tYU879T5r8F+8k8I1X1rGCVDPKmslqxHP2sMEnZ2Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(53546011)(8936002)(55016003)(9686003)(52536014)(6506007)(5660300002)(82960400001)(7696005)(38070700005)(38100700002)(2906002)(54906003)(316002)(110136005)(86362001)(508600001)(26005)(66476007)(966005)(107886003)(186003)(66946007)(66556008)(66446008)(64756008)(71200400001)(33656002)(4326008)(122000001)(8676002)(83380400001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tr6lrCDfctMHFHqrioi3XsssyIZGpyClv9FbqtCVwOwrC78CscWuArBzijMW?= =?us-ascii?Q?bFFPqwcshXjzYnWmd272Z0nUDWGmGVQwGgIi/7owKHvHUcmLQDiveQRpCvY9?= =?us-ascii?Q?LieiBW9XdG5nW/UssNVZhCZI04PZyXKQkS/uFhtd00nhIkasTmmyACoxUBoN?= =?us-ascii?Q?IvFPEJtPI72D5YqSZnkKRCRyC0vdO1UUNQdQJJGo38sHYLkxayDjql3O/QQc?= =?us-ascii?Q?ESNf5xbET2gzGgpYflEhtTLcrYB/JfklZM4GKdX84kLHP3m+dLWGu9ksz3zW?= =?us-ascii?Q?S4i5sn17IyJOS3czt12mJodD9EYoQI7AGCTj8v6vyMGymc1gRUQrT0wQGBSC?= =?us-ascii?Q?EFnudgwns+kLgqonO7Ucq7rQUZ2k4nMpAGuTPq9edC8+wtUTRl0G0pK006dc?= =?us-ascii?Q?iNmvXgeECD0Sgp8bN5xDKUbCiOsocEUtzEnWxm5K299hJoanLqDl2DgYjeXe?= =?us-ascii?Q?K2O4P1Irgp8bIu6Mg80SYTDf4uYpwdbwh7TiRTKsJzUNoIIKWqqeISDS9JNA?= =?us-ascii?Q?9tjJtP6AX6ftjCGspZuzpj5Qm9d5zNyhO4Pn/Z4xNcD90CKVYs1ZYvKEO51p?= =?us-ascii?Q?hVk1+jVM9ZmLJDoAWBNKY5PJapYpctNq3JNLnxOk7V9teFoS6kpi9XLmg4j7?= =?us-ascii?Q?cQ7mW/ZW+EBQ98Ky3vNZdr9OU+waK8aSVUtakoTFeLSl2UfyV/gH+CIRfSAy?= =?us-ascii?Q?0NUzc/La3a/As1ru62ydmGHv2hFpKZLc1ekjcwfiq8ucowE89Jd18v06ZK6W?= =?us-ascii?Q?RXtesw83Re2anhBAJyyCcfhSmvWJdLVFd9tp/NLugU0d1w+kmuNjrUe9BuPT?= =?us-ascii?Q?leHHIGNde/miTpGIcy0dHqo3ha/ZEjlJLb/nCcgvo66TdvjyUG/A5rUtUeO+?= =?us-ascii?Q?9Q3L0CEUdKxvp8kW8vqELMMFji57nk2noOP11gO7ECS1VH7M4RV3rUtsCFeG?= =?us-ascii?Q?r7sXDo+gaTZYEWi7B5ScEAn+cRrtjhXQsKklLWmNUG9cJCqK9VtQXaS41EjJ?= =?us-ascii?Q?M+RhNN+ZU9qzx/34vZEWNKJGOjZuX8QQXFj4crbAw/7Me/TkjT2bubfnbNr5?= =?us-ascii?Q?viYR0gyTXCsBtOqLnewZhIZm6IYJof8y0wTvgC7rNKS5bugBZajgj2yGp7ni?= =?us-ascii?Q?glv+p6ehludaeX3D8BPFaWNC1RCfl/yZEkD8S8fK3GEqcItSsRr7/9IGWiyJ?= =?us-ascii?Q?E4M16ru8FyH7roDEQgsxX18xC57iEx5Is00CtBpHNmG3Gj4wJYtsAUq9NhKR?= =?us-ascii?Q?EFG4MiNVxPvRi3krRv4InByrddHRAaaARsjiW6YI1XKPUavxwDEIPTKiiqfB?= =?us-ascii?Q?hsSCxW56ydzCSmqkuTdcG856fJos6Mu7rjQk4JbboM0CQkfpIDHLRia8mbRb?= =?us-ascii?Q?6ZQVrsR7vMzex+rTDjAbKCVKgdm9ubPodWjQkWilho8eQsE/lWG8/GfZ9jcz?= =?us-ascii?Q?6IBIJMDP2oe6utq6E4gtpl9Llen5dhEhebLxD8j0neVJXxl2o7IC4V4X2efn?= =?us-ascii?Q?d35yZ4FUEHQosW8EV1coxvQinxLM/dK0t/F9A4v9PXF71ZSdZ/mQ501wkXnL?= =?us-ascii?Q?xB9tokc15pt+/6gzX5zDKwPc5o4bEKcW9t2AQZfbBGBa5BViwSB/KSNkAKDm?= =?us-ascii?Q?nNUowKdOOt13NpDfbaNAYSU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06e29e37-2f88-41b9-fe98-08d9fb6517d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 09:23:05.8071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +DImn/Q6oE2Ey/1D17w6jmnIRiaUKnuLUbwONceGro6iVXTIfFnWgWd+8y5pq1nVgcQZuhZStXzIZarL/S+JGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2200 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Jiang, Guomin =20 Sent: Tuesday, March 1, 2022 5:19 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Gao, Liming ; Gao, Zhichao ; Ni, Ray Subject: [PATCH v2 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to ma= ke sure no error REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2668 SetMode will fail in some case. for example, without XServer. Should handle these case when SetMode fail. If we don't handle it, it will Segmentation fault. Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Guomin Jiang --- .../Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index 8f0cba9fcde9..07436cbd15bf 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -1,7 +1,7 @@ /** @file This is the main routine for initializing the Graphics Console support r= outines. =20 -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -518,7 +518,7 @@ GraphicsConsoleControllerDriverStart ( } } =20 - if (ModeNumber !=3D Private->GraphicsOutput->Mode->Mode) { + if (EFI_ERROR (Status) || (ModeNumber !=3D Private->GraphicsOutput->Mo= de->Mode)) { // // Current graphics mode is not set or is not set to the mode which = we have found, // set the new graphic mode. --=20 2.35.1.windows.2