From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.7579.1660014863354328847 for ; Mon, 08 Aug 2022 20:14:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dfLyEYN7; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660014863; x=1691550863; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SzE6Mm5ROYv6uyfWMUuui2payjGpKg+cdj5qlJ+m9QM=; b=dfLyEYN7Y6Bh+I3ygacIopHCH5DOZGxvC7bCKzbcloBKhBPPcWcnua7v Qn6L+yh6G8bJWyAxQGHVawiBJhNWxQxGUugdeWEjqeType0H5lPohdlLE H6txtTsOEG3eWbMYOH5eRez6xXmnQO77scd6HffWy0aUA2zr3m7VxC1T5 fFAvzXJE5Rk+lw3tUHUM4BdXhFTgcPWkggFUn29jdBSpRWcCSnqR84Spi E6CzDnAKMt2CdMQCDq2zMMF85uylt/XY3aqpubGF+9seWtEBnY/+5OWsU sR8P4B1xaouoEmv4m0v6XUF8Nlz1PoBm/Q/9MSWf1M6PSTlThPShoz96l A==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="288307248" X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="288307248" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 20:14:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="664249862" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2022 20:14:12 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 20:14:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 20:14:11 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 20:14:11 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 20:14:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kB40AuDErRTaea9xelWBugST4LkyPS8ia7Zi91IeKpCCCDmKRNWOEMjf7dgVuWEEzIOMKMTZ39I2FHSA0QOwBQ0s5hDPF81DQDoDiI/NEVSLTWWsYH/ihYFrG+EQyXw6zOvzPFLFN68bFQtv7nLo3ktcsxtF/3NjsLCQlRTSLk866kYV8a3FL5WW0m4zyLRpRwjTVyn02h4DrQ9zPyg8oueFtUJAb35/OpDeIokAaDohqUWHCmHPb6TIkw/yBpZRUKUpQMuEBa7OWnvId9JT4hVM7UJKHyBOv6MozbWaab0jRiDDpyFLdONXZDeRzVYt0UeuI+b9m/azEpj74IlH3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WBGI8glB7QlI53Gg/MkM4MchCoRfoKAquT50q2NUPrw=; b=hxA8otyRPbkf0z3UOzVxmeNf6S3mmCpx4swk43sYahRNdwenw+WxNzwr0q0S5H/8X06Ya944Wqc1L9KezgGDjsZqZexnXJytf4hUqkQhgFlmL88RmARNFiXH4+tuxSaYSbW2EN6jRcee2jto15MrNV3L7iHBXsvV1fYzlD1HvaTFRw4dBRmsbfp+po7yJqDvnvsCZxUWFxaAeR1fcDwwzC8hCdvAtGm3gl3TWbVwWRmPipMygk3HWnXcFw3OQEcfX0jJQDvzdTGsrbbfd9tBUDNnHeS9sN2MTTQ0pWGucjGghKmXzBIXVhYjMM7olswbz1GJdAB7RhzTvT7Ttf6z/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by CY5PR11MB6091.namprd11.prod.outlook.com (2603:10b6:930:2d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.21; Tue, 9 Aug 2022 03:14:08 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::991b:97a0:7836:5174%10]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 03:14:08 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Dong, Eric" , "Kumar, Rahul R" , Leif Lindholm , "Bi, Dandan" , "Gao, Liming" , "Wang, Jian J" , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v3 0/3] Simplify InitializeSeparateExceptionStacks Thread-Topic: [edk2-devel] [PATCH v3 0/3] Simplify InitializeSeparateExceptionStacks Thread-Index: AQHYq48GzbZVe/cWCUCqqll4OBG4l62l5J/w Date: Tue, 9 Aug 2022 03:14:08 +0000 Message-ID: References: <20220809012537.1513-1-zhiguang.liu@intel.com> In-Reply-To: <20220809012537.1513-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a3e2040-f0c1-4eac-17c1-08da79b5396a x-ms-traffictypediagnostic: CY5PR11MB6091:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mmvRthPSnWsZ/wnk9KuLYuPMeJOq/A3K2ZvGSFGQSMz1eYJSQTSd5nbfxI+2waRNtyjvTyaFDo7kdEIrUq9SbmA7h1WvOqaR7nymKKLVtnvOq1LV233NkYUltxHwTu3GvEau1GDFNInw3OAj6RsWBLlz5umPuRYoOPKFvtYAYyLCCUIssUVDk5ULJkex4NLBzuzXK9Hr8TJgwrRHfIvhYwjVtE4L9xbFDjnf8mhV0fVD47IiCc/goI6NsmWFWf4Heuxop6imKKjDG/SzIKMj5bIV5zNi7tgmoz5VNxBJv5f2UkLx3qwcgnkF2JUv/Fa3x3Y0SvWKr7eInSqK1WXyP3SSXlY634KmL77zBE18Z7bQDw+w/VhlFaKtRlSdqWro1qoiIb8I/mWAbzd7TXGYdeV6IOfNGYMBZdoC4XThKvQfequ6cp3VJ42Wuw212rC0nqDyhUHqXb0AMR33z7VPSfZKlOhdUMse5BKBjNPw1zSQnj1D0JlzwEf6iTt7lcuL39NljQ2PCApvpowp2qHLL9ZSEjlgDRe1xWGsW/4Fymf1XuC4cWN6S/u9bsWuspfUZ8ifDQSaTUZMivfSl0BqpKIY2cEXVa9LBQqhZG2ivCMlMVTDGQxJerQeGAY0Zm52kSuJ1YioaaBGkFTxN3ySh6+pHxoK+7XhUAESWPTof07ydeoudqXhBHmPKVq1a6bhfwMJDlphyfLf22FDikYlMmkI0UVq0cJQ5gHFFtY3h2r4xEjDHyIom93aCTFClHF9Lj1SRnuu82MWNi3X7lgY5ZTuQWXPDxOc3DJKAM6jsKUsDf3ILibSBVDLQ6kUgUEcdmV/6FD4DceoQkthQXRONKtKcWiMiHYN0cQO1eC5UKmxE6XvMR9wx4OT2pr4yjQg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(366004)(136003)(346002)(39860400002)(6636002)(19627235002)(316002)(8676002)(4326008)(66476007)(64756008)(66446008)(76116006)(66946007)(66556008)(55016003)(52536014)(5660300002)(8936002)(54906003)(2906002)(38070700005)(82960400001)(86362001)(122000001)(33656002)(38100700002)(7696005)(53546011)(41300700001)(6506007)(26005)(9686003)(71200400001)(110136005)(966005)(478600001)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SyuKxEXGqvgfIg2U606rcPx2X0MrvX7nKBem6R9Ba1PSLAvV+/Z3HgALylhi?= =?us-ascii?Q?rF62VNZGuMstHkrByVc+kowZWJQyzYCZ1Ly5UlQX+HhF1JAtiN+eM/yWsznN?= =?us-ascii?Q?3bIF45mQD1T2QZAcvOVrsZyfN6sAaDzCpu/4DJSRgcDDPbb46IQ7XSMte7qT?= =?us-ascii?Q?tz5i04ha5/gWxazHBPzYqhPs4hvwHSzz1lHAhx0Es0MzHEPag40RdPVbn8nY?= =?us-ascii?Q?aR88oJFQxbF8YnwwYxLGPbB53gwaL5Vw2hGDp15NfXt6WT5XKFLMWaVbZ7gR?= =?us-ascii?Q?okFgrerJkoef5/MgJgi2CPhpbhVy6bVYE32Cu2SNC9Q73Ua4cT/U5U9vY42N?= =?us-ascii?Q?oDeGy6YSyJ06p4sKVuqziruaJMxVXchnEaKde+oJTiEYbCaTtb+Qe7RhHmKx?= =?us-ascii?Q?dfDTuxFKXBOyxe3RmenhELGdSGrb7UUKzJYTv8N5ksetJ/jTZ+rHBDrqMYzk?= =?us-ascii?Q?6XfrEsT+oRCyLxEz10Ep2uAhcs5DPbfJJi9EGLuHPSovwWH75w4qcrMsZhk/?= =?us-ascii?Q?uc4jFALHvDU9rI2cqGHAf90ZuX49PjzDMwr+QdQpQAYvsLwqTdt8JWzx2PP9?= =?us-ascii?Q?etbtKeezPHYO0Nosfv19Lh3frKixX3p6DQPOLL4UICqOsaE5YSp/2y8HuOmP?= =?us-ascii?Q?BPyPo6cAQwjPyVN/CObW/BMefJOv4FcwA4QuH9vSheBjyDn5+Jzanx+nPK2L?= =?us-ascii?Q?AeOfPmSxCbpWsnTMpY+Vr0pMl1dtFxFhTL0wlKUdpNywzFWDkKDzLf4Kcxy6?= =?us-ascii?Q?24xxofgNcncCzXiLDG5wp+f9yKgotoNLlkV+efV4rvGmJYhhOqXmG6xkt5Mj?= =?us-ascii?Q?fRXXKC3/aX4DQUAE3bV/a5FAFmevncaXkDTqH8brUHAXArlIpt2DFlQ43zdJ?= =?us-ascii?Q?zT/Wfzdmvpf2xBN/Z0LoqEC2E6tQLPlNQS2S5pdilB1iaekRj9xosB2smonk?= =?us-ascii?Q?rTmOlmbH/Vvo2LorX0gfeQWetkRjwIVYONPr/zi5kmuo457lC4dq43h6QLb1?= =?us-ascii?Q?cD8PTocoL7YGNBQOwDgSo9Np8Wbv6CTfQ2zlcU5J6mYorRqlgjECJJGeppQi?= =?us-ascii?Q?aBLvRxJQ0kgyhKST8kwgiqg8cqs5nl9jZGJa/2zZTTdaeyErwgMgrapzXzCs?= =?us-ascii?Q?/JYibx6W1Ryi6COM/2hN9cIZ5JD7LCevQ/XQdYicYgOebgxVOthPELjC6aI3?= =?us-ascii?Q?bkv0PXxTwJ47+NMt1ovQnl3IH2eRUuDj5H1A8UNRO01FmGf/Wj+1kqWwNnwB?= =?us-ascii?Q?NgUaJwVYLvAJYyYzvBRQ7J6V3jMSsDQS1hYyPaa3kx9lxH2pg5VCe3sq8Emc?= =?us-ascii?Q?mTjsdXUAjKSOq5TZ7wTDzVfy41+UFnlpqKVAFAfdRnNcgs7v+sZWLZz7Xoh7?= =?us-ascii?Q?k1YjwCRjata25bPYP4zz8Wf5PLNBgvYwrNCaMihK0FkwIb+A4FN18pPSZFrV?= =?us-ascii?Q?kYia/hShRm5/92lhrmRUN0d8C3Gwk4USE40kyHB8eqvytb5Mip0cKbpYri6m?= =?us-ascii?Q?D54c59DmDKUjCP/dGXA1dP4fL1AxnHFNZIPVE727cyBJgWAJsScWzhiGTgSC?= =?us-ascii?Q?4M/h1p3wLKwRDrGo4Z0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a3e2040-f0c1-4eac-17c1-08da79b5396a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2022 03:14:08.5329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DHE3CH/2oYaHWrvHZ8xFvvNXK2oSul2xSi7MnGIWp7mTpcOw/U1FD7ikldQgbF1MgG3kNk/cUwJoULfZDMggNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6091 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Tuesday, August 9, 2022 9:26 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Leif Lindholm ; Bi, > Dandan ; Gao, Liming ; > Wang, Jian J ; Ard Biesheuvel > ; Sami Mujawar > Subject: [edk2-devel] [PATCH v3 0/3] Simplify > InitializeSeparateExceptionStacks >=20 > The patch set is to hide the exception implementation details, > so that caller don't need to know anything about IDT when separate stack > for it. However, this patch set changes a library API, so I have to > change multiple packages inside one patch. Otherwise, I can make sure > every single commit can build and boot fine. If anyone has good idea to > separate the first big patch, please tell me. Thanks in advance. >=20 > V2: > Add another patch to Simplify the CPU_EXCEPTION_INIT_DATA definition > Keep the memory layout picture in CpuExceptionHandlerLib. > Fix some code and comment issue according to Ray's comment >=20 > V3: > Change the code behavior when the needed size is zero: skip instead of > assert > Fix the bug that treating the TSS as part of GDT > Reorder the modification in the patch set. > Code can be seen at https://github.com/tianocore/edk2/pull/3124 >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Leif Lindholm > Cc: Dandan Bi > Cc: Liming Gao > Cc: Jian J Wang > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Zhiguang Liu >=20 > Zhiguang Liu (3): > UefiCpuPkg: Simplify InitializeSeparateExceptionStacks > MdeModulePkg: Move CPU_EXCEPTION_INIT_DATA to UefiCpuPkg > UefiCpuPkg: Simplify the struct definition of CPU_EXCEPTION_INIT_DATA >=20 > .../Library/ArmExceptionLib/ArmExceptionLib.c | 15 +- > MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 4 +- > .../Include/Library/CpuExceptionHandlerLib.h | 82 +------- > .../CpuExceptionHandlerLibNull.c | 15 +- > UefiCpuPkg/CpuDxe/CpuMp.c | 162 ++++------------ > UefiCpuPkg/CpuMpPei/CpuMpPei.c | 176 ++++-------------- > .../CpuExceptionCommon.h | 57 +++++- > .../CpuExceptionHandlerLib/DxeException.c | 112 ++++++++--- > .../Ia32/ArchExceptionHandler.c | 71 ++++--- > .../CpuExceptionHandlerLib/PeiCpuException.c | 94 +++++++++- > .../PeiCpuExceptionHandlerLib.inf | 4 +- > .../SecPeiCpuException.c | 15 +- > .../CpuExceptionHandlerLib/SmmException.c | 15 +- > .../X64/ArchExceptionHandler.c | 67 ++++--- > 14 files changed, 411 insertions(+), 478 deletions(-) >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20