From: "Ni, Ray" <ray.ni@intel.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Abdul Lateef Attar <abdattar@amd.com>,
Garrett Kirkendall <garrett.kirkendall@amd.com>,
Paul Grimes <paul.grimes@amd.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [PATCH V3 3/3] UefiCpuPkg/SmmCpuFeaturesLib: Clean up header file inclusion in SmmStm.c
Date: Mon, 31 Oct 2022 04:48:30 +0000 [thread overview]
Message-ID: <MWHPR11MB16315419817C9B6736ECA1788C379@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221031024912.60-3-abner.chang@amd.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Monday, October 31, 2022 10:49 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <abdattar@amd.com>; Garrett Kirkendall
> <garrett.kirkendall@amd.com>; Paul Grimes <paul.grimes@amd.com>; Dong,
> Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com>
> Subject: [PATCH V3 3/3] UefiCpuPkg/SmmCpuFeaturesLib: Clean up header
> file inclusion in SmmStm.c
>
> From: Abner Chang <abner.chang@amd.com>
>
> BZ# 4093: Abstract SmmCpuFeaturesLib for sharing common code
>
> Remove the header files those are already included in
> CpuFeatureLib.h.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Paul Grimes <paul.grimes@amd.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
> UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> index 4e8f897f5e9..3cf162ada01 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> @@ -7,11 +7,8 @@
> **/
>
> #include <PiMm.h>
> -#include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> -#include <Library/MemoryAllocationLib.h>
> #include <Library/HobLib.h>
> -#include <Library/DebugLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Library/SmmServicesTableLib.h>
> #include <Library/TpmMeasurementLib.h>
> --
> 2.37.1.windows.1
next prev parent reply other threads:[~2022-10-31 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 2:49 [PATCH V3 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Chang, Abner
2022-10-31 2:49 ` [PATCH V3 2/3] UefiCpuPkg/SmmCpuFeaturesLib: Abstract arch dependent code Chang, Abner
2022-10-31 4:48 ` Ni, Ray
2022-10-31 2:49 ` [PATCH V3 3/3] UefiCpuPkg/SmmCpuFeaturesLib: Clean up header file inclusion in SmmStm.c Chang, Abner
2022-10-31 4:48 ` Ni, Ray [this message]
2022-10-31 4:47 ` [edk2-devel] [PATCH V3 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB16315419817C9B6736ECA1788C379@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox