From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [Patch V4 4/4] UefiCpuPkg: Add R8/R9 etc in EccCheck ExceptionList
Date: Mon, 17 Oct 2022 05:13:20 +0000 [thread overview]
Message-ID: <MWHPR11MB163154C3E4F476C755D70C178C299@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221017051128.781-5-dun.tan@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Monday, October 17, 2022 1:11 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar,
> Rahul R <rahul.r.kumar@intel.com>
> Subject: [Patch V4 4/4] UefiCpuPkg: Add R8/R9 etc in EccCheck ExceptionList
>
> Add GENERAL_REGISTER.R8/R9 etc in EccCheck ExceptionList
> of UefiCpuPkg/UefiCpuPkg.ci.yaml to pass CI EccCheck.R8/R9
> in structure GENERAL_REGISTER of CpuExceptionHandlerTest.h
> lead to EccCheck failure since no lower case characters in
> R8/R9/R10 etc.
>
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
> UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> index bbdc44a45b..a377366798 100644
> --- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> @@ -15,7 +15,15 @@
> ## "<ErrorID>", "<KeyWord>"
> ## ]
> "ExceptionList": [
> - "8006", "main"
> + "8006", "main",
> + "8005", "GENERAL_REGISTER.R8",
> + "8005", "GENERAL_REGISTER.R9",
> + "8005", "GENERAL_REGISTER.R10",
> + "8005", "GENERAL_REGISTER.R11",
> + "8005", "GENERAL_REGISTER.R12",
> + "8005", "GENERAL_REGISTER.R13",
> + "8005", "GENERAL_REGISTER.R14",
> + "8005", "GENERAL_REGISTER.R15"
> ],
> ## Both file path and directory path are accepted.
> "IgnoreFiles": [
> --
> 2.31.1.windows.1
prev parent reply other threads:[~2022-10-17 5:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 5:11 [Patch V4 0/4] Add Unit tests for Pei/DxeCpuExceptionHandlerLib duntan
2022-10-17 5:11 ` [Patch V4 1/4] UefiCpuPkg: Add Unit tests for DxeCpuExceptionHandlerLib duntan
2022-10-17 5:11 ` [Patch V4 2/4] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib duntan
2022-10-17 5:11 ` [Patch V4 3/4] UefiCpuPkg: Add Pei/DxeCpuExceptionHandlerLibUnitTest in dsc duntan
2022-10-17 5:11 ` [Patch V4 4/4] UefiCpuPkg: Add R8/R9 etc in EccCheck ExceptionList duntan
2022-10-17 5:13 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB163154C3E4F476C755D70C178C299@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox