public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Pierre.Gondois@arm.com" <Pierre.Gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words
Date: Wed, 24 Aug 2022 01:06:04 +0000	[thread overview]
Message-ID: <MWHPR11MB16315CB228762EF1D9F9D1D18C739@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB40251D358619F64EA25598D1CA739@DM6PR11MB4025.namprd11.prod.outlook.com>

> +  if it exists, debug agent wiil copied it into the local Mailbox in SMM space.
There are more errors in the original text. E.g.:
wiil -> will
copied -> copy

Can you help to fix them all?

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao A
> Sent: Wednesday, August 24, 2022 8:51 AM
> To: Pierre.Gondois@arm.com; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words
> 
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> 
> Best Regards,
> Hao Wu
> 
> > -----Original Message-----
> > From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> > Sent: Wednesday, August 24, 2022 12:00 AM
> > To: devel@edk2.groups.io
> > Cc: Pierre Gondois <pierre.gondois@arm.com>; Wu, Hao A
> > <hao.a.wu@intel.com>
> > Subject: [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > In an effort to clean the documentation of the above
> > package, remove duplicated words.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> >  .../Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebug
> > AgentLib.c
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebu
> > gAgentLib.c
> > index f49a592d2762..619f466c68b1 100644
> > ---
> > a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebug
> > AgentLib.c
> > +++
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgent/SmmDebu
> > gAgentLib.c
> > @@ -158,7 +158,7 @@ RestoreDebugRegister (
> >
> >    If InitFlag is DEBUG_AGENT_INIT_SMM, it will override IDT table entries
> >    and initialize debug port. It will get debug agent Mailbox from GUIDed HOB,
> > -  it it exists, debug agent wiil copied it into the local Mailbox in SMM space.
> > +  if it exists, debug agent wiil copied it into the local Mailbox in SMM space.
> >    it will override IDT table entries and initialize debug port. Context will be
> >    NULL.
> >    If InitFlag is DEBUG_AGENT_INIT_ENTER_SMI, debug agent will save Debug
> > --
> > 2.25.1
> 
> 
> 
> 
> 


  reply	other threads:[~2022-08-24  1:06 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13   ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28   ` Leif Lindholm
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12   ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26   ` Leif Lindholm
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12   ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09   ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29   ` Leif Lindholm
2022-08-24 13:31   ` Chang, Abner
2022-09-05 13:54     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55   ` Chiu, Chasel
2022-09-01 23:18   ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24   ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31   ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00   ` Yao, Jiewen
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32   ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24  5:34   ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24  0:50   ` Wu, Hao A
2022-08-24  1:06     ` Ni, Ray [this message]
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11   ` Sami Mujawar
2022-08-23 23:00   ` Yao, Jiewen
2022-09-05 13:55     ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25  3:12   ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB16315CB228762EF1D9F9D1D18C739@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox