From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.8549.1648455890212303609 for ; Mon, 28 Mar 2022 01:24:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dKwVOTUb; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648455890; x=1679991890; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LzkryJawYYIrYxcw7bvGAhAp5qDme0zF+sbEYp2IAFw=; b=dKwVOTUbUYJzl/mNQQ2aytF62bI1ZIGND1TSQYxP/0wntOn2gCaaCvuH 0oiC1fg8DcaM6tF1x2UF/4ikjZIPqSJfwMD0q8hdsAary72UgT34D0lbs 14WrKQnG20MnRP5FSH4mSxCHp/LyxSOEPek+/nEgGcXzUogjlktddOOYn Yik7Ds5J76jv2Y2vwgvOUe1CHX+0GQ4rfIaWAemSTXw9cSS7wIVOyd+TL vsQP6FW24M6lqO2DbHhXbsFz4Y7hyuYm2P8tVJv2BmxPgGbKOu2sPrAlI l/CfP4j+45nYbMZxcxjgU+Yj+DsgRy8LLkp5uG1g8hKw+26spRt5ggQy5 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="258913828" X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="258913828" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 01:24:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="617706896" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 28 Mar 2022 01:24:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 28 Mar 2022 01:24:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 28 Mar 2022 01:24:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 28 Mar 2022 01:24:48 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Mon, 28 Mar 2022 01:24:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D/2hBEUPaplmHtimajeImx2w/Hsqv0uyifC7yVh+g+VgxUPFEAWFD6QpyDys6G7G56zDzrc/eXYUtfrRBF0UIsixyyz9Siy8xhWqU1SBWYFXYhdzFS3J5W3PJJsnGKN97j6Yc4FFqiwXfdIRPhLMi8rGbovoWfQlCcu6xcWnIitXSz2s7GZrHJR6dLcjxbP01vRFQxQ3e+EkbPuHj1KtJUPwBo4yzMn1KMRVWZPj/JaEDeM3ZoNB7XbUWJnknYWum4xtta04c8XixdPE6IKGrJ5Gy0k98J0IQx5zR2TEVrHhMSLfUMOca8dzxZIvaq7EQu4YIhdv2P2HAPBNi1ijDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sc7egQTvTg8yvkUeH3mfBQfZIaeWf+lc3J2wRMMTu/o=; b=ZNiVVPFfq2DgnLj+Mgz7kz1Dyja8D//oxGNZbdnjsyB9BYKZT19ugQjdllUyTx7twJcDcf/aNI56nXtI6iE5gzLb4xKOrLxI4XVI87/HmYM+rHDQ8M8abYvwKu4rCuKms5XrBjkRs2rXrBQIXEZInZx6mzFqyv8zf9fcPbAs8Z20gSpn8/sCXzvYDGhiBMT/xI9qt+nHgbNBz+4RKHbIkt67JzWQtE9gwi94iZK2c5GoVu/yAcntg9wOxjSsj1aWnEPkAbwPb7o8lwflRPZ43kEbhN1PKD9wLbI92F3mbX5r4etHzMG0zuNEgvMfAeIOeqk5g7YnXezQ06byFGwHpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA2PR11MB5116.namprd11.prod.outlook.com (2603:10b6:806:fa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Mon, 28 Mar 2022 08:24:46 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::30a3:3926:64ca:50d5]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::30a3:3926:64ca:50d5%8]) with mapi id 15.20.5102.023; Mon, 28 Mar 2022 08:24:46 +0000 From: "Ni, Ray" To: "Xu, Min M" , "devel@edk2.groups.io" CC: Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , "Dong, Eric" , "Kumar, Rahul1" , "Gerd Hoffmann" Subject: Re: [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Topic: [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib Thread-Index: AQHYQnsovJRR9thT8kCzmGw5PO96MqzUcxPw Date: Mon, 28 Mar 2022 08:24:46 +0000 Message-ID: References: <6ae0bfcd1c819318d3745732950e4cfc88c373da.1648454440.git.min.m.xu@intel.com> In-Reply-To: <6ae0bfcd1c819318d3745732950e4cfc88c373da.1648454440.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bcc4c976-0b5b-4ed9-8c76-08da10946b37 x-ms-traffictypediagnostic: SA2PR11MB5116:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZaMmmLfLZTRzS7uo/Zlzw7Fc3HW2v6pM8JEbsXfwTFXFUT08P5qxeZEmR3BNE3dCmEiZSp/f+BVb3Qz/AJ3TauiibtmLlRNFtXKNdtqJ3cfSZTgAb1Em7svjvSPTbbd18ZANfim/yr4UAfwepJOzFpDDCwQZ+0Py7uZKlbYFZlwwt5ePf0CuiTyrGcnYlTB4on+9L9epZIQU7nLvOp7OTRG/EvkdcUvt7shmu1b+b2VoMWTrvocQciJF6+TlNBVPD0rTNu+CwJIYtccJk/gQu5RhCgb6j2xsqhGOwnZHWzmNsqSJ9egrJUyDsD/Np0BPJyZsahqwRFZqSRndWHsS0Lv0YuOtFQjm+umkTVJeLs6WcVWWmM1tn8ewsY/g/lDxZuKYR5jn94kxfS/KVJXGRHilOGCo/PbhO8EJmTFq8ygnU0HkVR3myqORPFRjlVDw8ihE3zFmFYqJu1s4HWb/CTgIlZszXUMhbXzghZTwqnAJt/fOt7XvJgp6jYxCLyN/NjF1lHPHaywUR8CtIhaEs4Ls5Q8cmjliZznOPivvU2m/xKJwFC6qUrEu6njU1T0wPLrqwQbiwb4Hg/v3yCMkucg54hZ0Tqz7MouXNfFDfGVbxPvpkWuXd45W66/mtrABUtc/9UhL4qcUc2CKszdBL/9+h5qMtX6idJkEw1oLqAG/9lGlQrGo4JdhUR5JtdpNu0WAo3L1X5bOzKTV5drUcQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(5660300002)(38070700005)(38100700002)(33656002)(86362001)(508600001)(122000001)(54906003)(66476007)(316002)(2906002)(66446008)(8936002)(186003)(110136005)(55016003)(64756008)(52536014)(71200400001)(4326008)(9686003)(8676002)(66556008)(66946007)(7696005)(6506007)(76116006)(26005)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Spghw6Hvx8tVZ3yJXZBKIKOc/3owXc4HUz20HDrnyvAA6ZTaxbzridWTKoEb?= =?us-ascii?Q?r60VAwKDvJoHRC6QQXqRyT+9BhGfJGP6dsvFlsKtpRcb45wNm0yPLBn22Hhy?= =?us-ascii?Q?ytPl9lnXrStkYEt0BN5gMz6yrRx3BDI4o5en6NVFEycfH9rwaAuBmdHURNh3?= =?us-ascii?Q?QGYbpKBkOsevkE8IpmRCKeiWa9eWRNUFeij7+2UEOJjztv7x58Sh+hDLmamf?= =?us-ascii?Q?L/xG7aE7SdnGm62NDNdJfLaEGqJiQLh4wmj5ZlVDU0ejXcj4CZzAoLnSUhaJ?= =?us-ascii?Q?qs/kd0eT5S4HHrmVRRRJjIHWRE+4/Q5ApDYbhkSA2f1PqorfAgreqSbBryKx?= =?us-ascii?Q?oHS9ilOw+8dd+Nvza7taBlJHsAfs3H/QcFxgy0f6p4eNW+YhHskrrmHSbYP1?= =?us-ascii?Q?reIgVxNPo2bBXPWyWfdouvV57QP1+OGXaZpmld4DgjHwZvZVdNSVFY0yVsjH?= =?us-ascii?Q?78OCqOKUc/LQHCADOS5hzUzF3P3OaN+o05qrFemh7MOnGlkjSVsvsu7LjODU?= =?us-ascii?Q?Xr+jWmuaqjmOvpMFyPg2rXeLSJxNY5NUBY7oSjVClkm4EWknWt9X3a0xxXKf?= =?us-ascii?Q?0U1y3HlC0UQxWuigpJa74L0JezCo3quQNy7HS5X7jbFVKGEN8bzImOXvJ3WW?= =?us-ascii?Q?fSl1gl8W4n/VVayeeAF1NFjENdhtpoB0jk+LqTWUFwJ2X5StueEQd0wDaDQG?= =?us-ascii?Q?zO07Ou+2buYa1V0S0gvmLK/j71qGzoCtiZvfZz7TNtbEE9KZSOFPbl9p+pN6?= =?us-ascii?Q?Hhe5m6BRWtPGQUrwE5iZcZapeDuBnLkC0PKEGgF7X0y9J4GhbUlpnJ62Asa+?= =?us-ascii?Q?BQBDdiBGCXk0I8URN3/exNMntqzkG00eBm6ipuMDxSahQsEboU48UNj2SxqS?= =?us-ascii?Q?jZtbTE8NFE05g82gEZTZTVK6e408AX819bQpO3M390FrmX44uQl2AAqaS1D4?= =?us-ascii?Q?bIrT/1gk0P1uBbWfHUpsXRVZ+ULiCvODohjCDZAF8EZF75hpQKTk3OWcbJyD?= =?us-ascii?Q?q/8Tpj1A8XAX3TpvxKln30DyC+5P9ck55mGjwiEzELBV7HfiKacgz85UDrDn?= =?us-ascii?Q?sGz50/3u9kws4XMGb5vC1H6sHFXNOuEKcxqJ8LLSVhMFWtOzCxaLACKVBG2q?= =?us-ascii?Q?hts09VyO9D3YYNeZjJNvqHkdYqDoswHTbP1ppqVB2aCrke7Ls20N7mHS3meL?= =?us-ascii?Q?qaD3KlhaVBId7ws9ehyM6LYiWdz8XgDzrjdBxroTh7KtJENeEwK91jmn+KoY?= =?us-ascii?Q?ilf+RquNqivWkIzayxQxh5iA5uQkZXCNuluPXpYITmToIog0oZZiIL/0vQoR?= =?us-ascii?Q?v4SqkAenXRuKa8cYEbjNPwGbGpjaCBo9wmroUPmOii9zUDG7wuQvI6GuosAr?= =?us-ascii?Q?omp0bugG43dZlw/E0svKGechEqy7o7R7/n+w0BR5RqBys/rd5PmtgLbo2VMy?= =?us-ascii?Q?oHY4YikKxc3Lmbcj5MS5WhucA0Nn8KqMT6LVshwb543GyWTLwyih8WGANZci?= =?us-ascii?Q?bRuKKrcXwlbRbBZaz/Gys30KVhg+xQA0w2jjPSxRQfVImhejeVEqyw8yw2Nw?= =?us-ascii?Q?R7ABA5vUEUGgtPKfRSZN0cB5MRcjs+SRd+eLSSVhmOp3X4RZyFzsofATQIUj?= =?us-ascii?Q?XJcr3npAQzogwqNfF1c6HEAk9euZAAmp+NAhxN4sRpeG7Ks9k//G0Q3MDaG0?= =?us-ascii?Q?qwg6avRXb9pdIYD9futP6R54/W1I31hL0xOAT3r6juQrj/B0?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcc4c976-0b5b-4ed9-8c76-08da10946b37 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 08:24:46.4947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DQDgdr9i/Hv1GudC0p1U/H5pjcWixHgGmk4tzECzOwIUVQME2Y5Q63rUpgPH9pso4wVNII+80CAJQBLEn8QKFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5116 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + CopyMem (ProcessorInfoBuffer, &gTdxProcessorInformation, sizeof (EFI_PRO= CESSOR_INFORMATION)); Min, You may not directly copy the whole structure to ProcessorInfoBuffer. Because per the structure definition(below), ExtendedInformation is only fi= lled when CPU_V2_EXTENDED_TOPOLOGY is set in ProcessorNumber. This behavior is to be backward compatible with old caller that passes old = structure (without ExtendedInformation) and support new caller that passes new structure requiring ExtendedInformat= ion. So, the correct behavior is to only fill ExtendedInformation when CPU_V2_EX= TENDED_TOPOLOGY is set in ProcessorNumber. The CPU_V2_EXTENDED_TOPOLOGY is a flag to tell callee that caller provides = a big enough buffer for ExtendedInformation. UINT32 StatusFlag; /// /// The physical location of the processor, including the physical packag= e number /// that identifies the cartridge, the physical core number within packag= e, and /// logical thread number within core. /// EFI_CPU_PHYSICAL_LOCATION Location; /// /// The extended information of the processor. This field is filled only = when /// CPU_V2_EXTENDED_TOPOLOGY is set in parameter ProcessorNumber. EXTENDED_PROCESSOR_INFORMATION ExtendedInformation; } EFI_PROCESSOR_INFORMATION;