public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Rehan, MohammedX" <mohammedx.rehan@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Zhichao" <zhichao.gao@intel.com>,
	"Esakkithevar, Kathappan" <kathappan.esakkithevar@intel.com>,
	"Pethaiyan, Madhan" <madhan.pethaiyan@intel.com>
Cc: "Thirupugal, MadhaviX" <madhavix.thirupugal@intel.com>
Subject: Re: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure
Date: Thu, 10 Feb 2022 02:46:52 +0000	[thread overview]
Message-ID: <MWHPR11MB16316648289916BB2D3590E08C2F9@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b972aef626b58508c24e048d0aff487e57b20e63.1643982208.git.mohammedx.rehan@intel.com>


+  if (TimerPeriod) {

Please use "if (TimerPeriod != 0)"


  reply	other threads:[~2022-02-10  2:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05  5:19 [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure mohammedx.rehan
2022-02-10  2:46 ` Ni, Ray [this message]
2022-02-10  6:59   ` MohammedX Rehan
  -- strict thread matches above, loose matches on Subject: below --
2022-02-15  8:07 MohammedX Rehan
2022-02-15  8:09 ` Gao, Zhichao
2022-02-16  6:34   ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB16316648289916BB2D3590E08C2F9@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox