From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.16059.1671435854012284167 for ; Sun, 18 Dec 2022 23:44:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hZl0GSxf; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671435854; x=1702971854; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bOyc1bPKmmrzefs/RtpDMx/aPkebxarCf8KhjZ/d2hE=; b=hZl0GSxfAcWMFU+ugJduEv6l4BYOCSOHvCGQzNFtPKz+Jwj+odwd5Lg/ Hm6O4MR7YgCmm9fKDRVkokA2E60NOyEMWnceUrR04elxLNPuaWUt3/Dqc Kt6Ba8X5n2q/CTwgnfodwivO9RWct3Z34Gr/xpsGWLYnuacBPiJk8CXbd Ftuf0hjG6gs+uB8QfJUIviFSUPH0qMGa0kEMl9dzlUc0O1rKKi/8oa6aH C2JufXF7XENYFKKnkTeBJ6E+Ab01+2QcjxNyP5r/NQwCYQvE0Kmyul//x 1L0ahAxaUaYhr5JtzU1FCWVHM+KHBAj1rpYh7u15rsN0SCErKp8I9nuu6 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="298966629" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="298966629" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 23:43:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="739238758" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="739238758" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 18 Dec 2022 23:43:23 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 23:43:22 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 23:43:22 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 23:43:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdFAjJ06R+NU9fO/ObQHZ6nqC67oVSC+gjg7PD92S19HD1VcmLLvOmd5QdiIewfwJagHFix4hEIQJKQw3MeW57ZZJCJHIL+gUUsP7ihhhmmY017UB7TInAHeZckOLneBy8Z1g2nc9ljDlEI8O1RkEEC5BnvR8vpR3F4Ub+XBII3Yq93Koe+7KetErfDBivQoIf+dhcSOkDSsirr1T14jqXrxEQDb00kHQB0fnAThb7m218y3lXx6lDtmS2gvrBWKN91+XhrQTZRqBEWmMmU13BQeq1hDhBnN3E14c+60jjw6MNgNGrm778aJsuSPvXRwvL2oAU82VJAHDH99BPFxqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kWERaM4MjoNclPIEwYGEUvOrowZ3h7KA/IYOPXzQyK8=; b=dTN07Gb241YsNB4564lHvcU31/a9DsMem7OKQshG5fSnlJhYaOYK5OkHM7/AGDc9ktvi6vO7NCfILqZvFMdmpGtmBUWBnmZmbqsrvgOC18z0M+rsjCYxKgpSBqqQjkyAuE+vqppKZr6ts9hh6MOU+bEQa5InUfyhqrx/I7PFuhZsUVXbZgMqczyEVmJUfyegPsWZ6AcI3i/hlKbQW1bFaAg/UmkxvAKrUvCL+sSXGJGwSU+6kviD+HangNilDwarWkzYpzG//JTmTcWXQzsCJButmtok8Ayb1OAv3aUhKa312a66fRPkSJD3HxPqxZ9k+Fjim7PQ5+c3mEvtKSrDHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by DM4PR11MB5277.namprd11.prod.outlook.com (2603:10b6:5:388::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 07:43:20 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 07:43:20 +0000 From: "Ni, Ray" To: "Liu, KasimX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" , "Guo, Gua" Subject: Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Topic: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Index: AQHZE30YlYP1JP3WJkGp2s1rF+kDNq5009Qw Date: Mon, 19 Dec 2022 07:43:20 +0000 Message-ID: References: <20221219073944.3142-1-kasimx.liu@intel.com> In-Reply-To: <20221219073944.3142-1-kasimx.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|DM4PR11MB5277:EE_ x-ms-office365-filtering-correlation-id: d07f625b-e0f7-43f5-9bca-08dae194b32c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Tio4fTGOpF5x7Wd36Z+pS+bvBFAtXRJ5u7GoIisVr0Pjc/sqFo/U60mlosuv1LOYdgd8ev0byF2YQBsvSs4WeqZj+Jb4oEZxjrz+rP11OIAHn8fIra/FYQs3ccySCkHInTdKlgZDOJB5FGRp/l2dxFgejkZ1eQyggyKSeSa5cKldxjpVvdvQ8QFSj3nW+3ad0Q5ttmA8CcTNqdsyOBwWjGcBU7/XVVZrQD0F4fgPD/+MNgtk1Js62kproUxacfcNvcCIS16SIHEJVEqzboFMb4Tr/5VbDuQoTPB5bPtBuQVcb2QA+fXiWc41ZDcQK8U5ea7QvxnlXTeBUVltBbCgLE42PaZ7G50SXxPCBm3ikFb1TN8RhuKjHRkhYhT7EiteFaZ7Y8aE7IaT4RFMCJzTRnkwUznMvgZk06TV7lFWYxcWnypQp597YrvFEQ5DRvOpUIW9ZlxPK9NG+kEjfmbBm418DyXzYx1m2zpN9MyG3ugzgyRwjW6ef1jio8C3j2GbVMDLHvcijTyJrfSbnpeLuBDntLD9HvntYr9UHeAoVz9us1HB12yssd6PzUSBqwga2JGgzwdoU9t7KmP90MTK5P0JIk4BcTcAqkou3OzZcPY4N6loDdFMLmzA1dOBmSYbpcCzob1jMYoA3nSq8GCwU9y+WW5Uw0ds9oVlLJq1A5We2hjo9RhlE5+egxlEZeq1b/Tj/mBB1FmSzG9LOjMa48rmyFaSrBJwG81HrnN0X9w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(366004)(346002)(136003)(396003)(39860400002)(376002)(451199015)(7696005)(6506007)(53546011)(8936002)(966005)(122000001)(52536014)(107886003)(186003)(71200400001)(478600001)(26005)(38070700005)(9686003)(110136005)(54906003)(86362001)(316002)(66946007)(66556008)(38100700002)(82960400001)(66476007)(8676002)(66446008)(64756008)(76116006)(4326008)(41300700001)(33656002)(2906002)(83380400001)(55016003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?02hLUD3CmEEoeXS1EcUkXwVguhE5XwM3cX231tdOTYuaAcPUzWlWWcIT0LXe?= =?us-ascii?Q?MYwyJ/Bp9T5B+ji7tYFcG6TdTLKfi9aSJSgl/rkp6PIvoFIPCLSTcUdv2eVu?= =?us-ascii?Q?SDucUk0s0nMFjoGErtH1UQuI+nViFwGoTTFUOK1bflzLssDD0L6lNXmexJf3?= =?us-ascii?Q?9zal4l6U2XNeQKBFoE5rOgTjkSQ1gEV29q1lWz8RCecXG0W4632Qguk3/VQI?= =?us-ascii?Q?5FK14ABYSq1RVknLM98XSLItdMmsarQGafjYqU4AyRiRhwHxlmjtU53DHAS8?= =?us-ascii?Q?ELK/YBqFmZAAXp+rt8hZYWtJdtajaPlyh7dPxAVwO5Rrk1ipuyilCQY04DJv?= =?us-ascii?Q?mOCAYWTdyOiE517Zdy1nxaYxmd4YsL46i3FAnbsd6bS6FfHhhEKfnIbaxIV3?= =?us-ascii?Q?eTT48C7mvV3csQqxE9vaxkn8sob8YBpZtGRmqdJcrJcOJvVgtbpxy+R16nFw?= =?us-ascii?Q?cWQax7hKCTR9T1PFqCvYMLJWpJLkKVY54airARTFK14bNFp/l7u8cUYQJHAC?= =?us-ascii?Q?0EVmS2p0QdmlQQjdRXl8rG0z6IGzLCiC4y4SVwU39T53kr7FQbyhpuLcBbRE?= =?us-ascii?Q?IFjg7D1sXztA5L7k6giAyERB4IVDHipK84vfnHsCcet4pE070H118YDBNguJ?= =?us-ascii?Q?VrhS8eD05M6nXnqzGS2QcrhsjOz7l6Q2+gos2QiEhYiQ2kHXkDTPkkIo3zye?= =?us-ascii?Q?XHoETe3wLYFxLLz1bGdu2lXsAYhEpDTpQThVWEgyuh5QQ2o3wV1TmJvJ34Md?= =?us-ascii?Q?qp5jOkr3pDRixxCKiz2qB8WIZ759Jm34/T7o2c9+SauylZAovAiaKrM1z+Vn?= =?us-ascii?Q?ylcQwOrQreYkM+VkwMJf2t0yCWH17EDlHwjEhvuCUPk8i4xlwzr3eDpqkFjB?= =?us-ascii?Q?XJR7FHdBe/ezd9YAd3ljhUapK8eHuZfdockpKlQ1ZnwPzxs09IAWloTwuUPo?= =?us-ascii?Q?3cEpYMqMyIlX3W7yiF9Qpd4ygBzCnO4pTtUOZvnBw3GU6ivsEjMAO+u4Y78X?= =?us-ascii?Q?2MHr5T2K1x+f5CngwyHO0Sn9TXvJ5p6P8/+Y7UpghGBIEKvwy9DEHL0bzTpl?= =?us-ascii?Q?OmpgxXCr2+yfRKAbOs0aw4rhg/ylM/FyYUw425EirNb/ZHIDclLiDkIcf6Yh?= =?us-ascii?Q?1PCUGDd748CkFU/RCiuhOw0rSxF74Wx2BKz3yLa7mcyoMtvk2MYvft8YckPi?= =?us-ascii?Q?hZfbQ8VRtSifIuTawuFvKxC1CXCxOdpa5EMTZM+A1v8tAPjhyvUM9oheUKW2?= =?us-ascii?Q?n6GTpskFZR0nPo3dZyP4uo8uLs42S0UEP4gxChHAn0HAoGUb5YLzTebRnR+I?= =?us-ascii?Q?7uRL74WL5O08attVTkE0oM1mJER6S89JRMklsUxdR909eAkv5VRLCNdU7uql?= =?us-ascii?Q?6HmJw9dxvq6lh8HwLGP+/0c+/MDwlxRviRX1a1f3C7byZaWpYEh3vrPUOO9e?= =?us-ascii?Q?jQRj8Qv4ey5DKoFGocoZtnh/W6ymSHCaaJDJl9TC96DVG1iVaHkTv1Rp8tlz?= =?us-ascii?Q?J0v96WNhKFzQOpYLdyXj86euF1VmzVfZudf2VSw02ZK2rNDYNrC0yVLvzCWN?= =?us-ascii?Q?sAzCuHafyS1kpjB19Nc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d07f625b-e0f7-43f5-9bca-08dae194b32c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 07:43:20.3176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sSDS0YI+BnJDZrPT2IyV3q9jtTVep/4ovKMVMtrLvIs7hv5o4kjl1t5S7TcOFm76Vex5lbiRFlYfn7HKPL9LNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5277 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The initial goal was to remove dynamic PCD dependency from bootloader. Is that still the goal? If yes, maybe depending on dynamic PCD is not a good idea. Thanks, Ray > -----Original Message----- > From: Liu, KasimX > Sent: Monday, December 19, 2022 3:40 PM > To: devel@edk2.groups.io > Cc: Liu, KasimX ; Dong, Guo ; N= i, Ray ; Lu, James > ; Guo, Gua > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD >=20 > From: KasimX Liu >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4193 >=20 > In order to remove RTC_INDEX/RTC_TARGET from > the UplBuild macro list,change the RTC_INDEX > /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: James Lu > Cc: Gua Guo > Signed-off-by: KasimX Liu > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChips= etPkg.dec > index ed2d95550b..a53ca777e8 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -84,6 +84,14 @@ > # @Prompt RTC Target Register address >=20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000= 0023 >=20 >=20 >=20 > + ## Specifies RTC Index Register address in I/O space. >=20 > + # @Prompt RTC Index Register address >=20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001= E >=20 > + >=20 > + ## Specifies RTC Target Register address in I/O space. >=20 > + # @Prompt RTC Target Register address >=20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000= 1F >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > ## Defines the ACPI register set base address. >=20 > # The invalid 0xFFFF is as its default value. It must be configured t= o the real value. >=20 > @@ -146,14 +154,6 @@ > # @Prompt Initial value for Register_D in RTC. >=20 > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0= x0000001D >=20 >=20 >=20 > - ## Specifies RTC Index Register address in I/O space. >=20 > - # @Prompt RTC Index Register address >=20 > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001= E >=20 > - >=20 > - ## Specifies RTC Target Register address in I/O space. >=20 > - # @Prompt RTC Target Register address >=20 > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000= 1F >=20 > - >=20 > ## RTC Update Timeout Value(microsecond). >=20 > # @Prompt RTC Update Timeout Value. >=20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN= T32|0x00000020 >=20 > -- > 2.32.0.windows.2