From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.32382.1669861074701735279 for ; Wed, 30 Nov 2022 18:17:54 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iLMFXRHR; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669861074; x=1701397074; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QN3vydLk9c8C52uqAmPKm/PUpek3wPIFJfni1EEBsVQ=; b=iLMFXRHRKoFH27uqPIshfT6hQfh1otRPgyYJhCOHbO0AH8d/98Pb7ytR Cz2QnCPzPzNXw0xLY/E1FC1Wu6ef6R674xz7HURTAr72rKB4j4Kyn5Suw FhKs4edZ9PcmeSpRnxAyGWlBN3akvcKOfniupm1McUJ6EOCWHsYZWEtdF gJeodNvzG9kTD5eZDuWxkwrakuWNQdiKaEEXeGgEDoa6Hr3JaKvHJ7E67 rdqhu2/Vs0FNACFILeC10ytLt8717+PQw7zPeCMK78Xz7wygUnLshQKpn 3gOg2MEE1GruVuMjdwICHhxVZMjhcEzwIFqOJ2VZJopf8fU0lVY9eKb/C g==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="401840560" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="401840560" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 18:17:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="646567637" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="646567637" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 30 Nov 2022 18:17:53 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 18:17:53 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 30 Nov 2022 18:17:53 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 30 Nov 2022 18:17:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0lA4QJem9TmXM1rLyQ+QWyQYlbNwSbC+4IMReAhimKA8CxwbY6ZXOZ+0xnm16ELjNSqSHBVDpC4qN/SuDPGW/g9OipSmhhQcZPfY7Jp9l8WSscKnxZgOSrm49hizPpA3vqJtiljYN1oEKiD+sD8q0gWA0n3pWGS2ed7XmFQe0pRkHQKgtXkqoogF7RTaSJdWLG7W1SHbqXw2dMlnV2XGOPc9XlmU/yujZ3CNBZ8WacxSJyTPmyLMU1+CqyN2/mf7jTIHrgBZkJDoDl+GEYXMQu5DhdXpJ/v3yTPNjue49s9FunTF87ZWxDjK31ymGZqHKDogxwkWwYp0xFmHg8arw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yGvgnBhCbINPX+RaeU9ILo0H3SVCoHHzklhpQCLmwS8=; b=ZgRKVAJVf3EaO5Tzc+vDJ8GCWLcZ0F0ewI3cKqnq3PNK3L2S4zD8gXqWBMA9dE5aaHMUICNQAwAEo3IzTgcOcdUARNvYXvJFlrnxlCBPsNENPG3kbUfAMM0bmDxjRTzNP4A9TMZ7uoiyeLR9ruWvAsmnx85Yq+Go1aKfAoP/V3r8WkrPCIZP7KvREuiH4mh/NbQIft4FKWEjiaZtu9rHAAcr071IekElUvVNGVQe4I4AjXtnrMwkJ5cAaCrBxMJhgmKSKroEKBik9adER4nHAB+/IvSONLGoeSVBUPS6HDSkY/yWV6vkB9OW5DEFbaFfBZGZp18dN8gYMsjLb2xkNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 02:17:50 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e%12]) with mapi id 15.20.5857.023; Thu, 1 Dec 2022 02:17:50 +0000 From: "Ni, Ray" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Michael Kubacki , Sean Brogan , "Liu, Zhiguang" Subject: Re: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public Thread-Topic: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public Thread-Index: AQHZBQGTNvR2XAjWz0mU13fwC9fqyK5YTE2A Date: Thu, 1 Dec 2022 02:17:50 +0000 Message-ID: References: <20221130211956.584-1-michael.d.kinney@intel.com> In-Reply-To: <20221130211956.584-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|MW4PR11MB5872:EE_ x-ms-office365-filtering-correlation-id: 42781e4a-9810-4c8b-49d4-08dad3423f2d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jlFxQ4Y2vt1MCxvdItQN7QE7iQ7ACPEN9iFhFh2oEdXWUKUsBScB2v2eQ80HZT1RCBN8m4TYUmdtCY4QGYKodQB+9H9kw8L0N0XqYsU5AdyszCLklL5slOrNxRRAAe+gWnSExbrfwywdFT1ggzrJfrygFSPCHXb60pS7M7qkmbsk6gEV4xk+sOH5gJjLnXxxd+3X8gFbCwJcnfOajuqk2jhN6ebJSIUdQI2tmPCdVhtyFA26L/bBr5mbM1AITVoedyvwKh4JX5lc0KCluprJTSKk1I0yth+lb3qxmcTezjC95ptZZQ5X/gDb7x78gPLABApqJy/2bFK556KXoBMcSol0sahnUHTgdH5zwxdfdqROB/8H76hr02NQOCDxgOBGwebhEcLU+d+R7syF2hYCDZlTBBOZfemGe1aNGp6sqaQJkpiCgodxMHIN9PdPO/ZLzwTUBy3GlvKLXEJ1whVL8rhQtEUD9IDOos4mRbWRzTEw2QzVeaENWcYKRRhzPH1IDmJno8f87TvlSCrIu5YiKsyd7w5tqSpNNeoLx8V/4HhQ0o8D+h+eME7G9PrCT8lNU58RDvgJje0L6pe0Y0k+GfRwHMggQ7TMoQNgbTyEBuElNV93L7sghLeYJ32KKDVPMt4m/gxy0Etc9EUEtJb1WsLLYHb56PRfJsVlavtRjk1zGPcsmXmCsssRb/vibek30LNxke1K+B9+ZhWTcWnkZvH6GmRYOdIAo5rp2gl3RC4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(136003)(39860400002)(366004)(451199015)(38070700005)(55016003)(82960400001)(86362001)(478600001)(110136005)(316002)(54906003)(33656002)(52536014)(66556008)(41300700001)(2906002)(71200400001)(64756008)(66476007)(8676002)(66946007)(966005)(76116006)(66446008)(5660300002)(4326008)(8936002)(9686003)(83380400001)(122000001)(53546011)(38100700002)(7696005)(26005)(107886003)(6506007)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gXGbbOjb5VELfLU4BmxG4e0u3rQhEeywJNsHw3R7MwsHbHdh7A9Y9PCyai5E?= =?us-ascii?Q?y9IXxhxVPmwpvsZgwTSShloGp6ECaYxLy/BMXPUWVqGjIclK6aY9Y4+prW1A?= =?us-ascii?Q?08jP0ZhT2wCWg4vee3EcVK1BHziEnLY4Fko0TNyVB0q6aB5ldndnK8Zmwerv?= =?us-ascii?Q?BWExKyz4ja3TQWpWvoyIp2B3crdKU3UQb6t7FoKMqj9rmlZjn3uwJ9dnLWV+?= =?us-ascii?Q?3AqKVa/gGoEdh6b2db1BdakhM/jeZjpEDEpZPRSUNxaaZug51PQIKhzm2N/P?= =?us-ascii?Q?cISIheKbMnvdRcqaQ7E1GVcQl/NoO18qigndixtbMNZd9nSjxoVDpC40a4LS?= =?us-ascii?Q?C8DerraiDXBMm79Zz6FyoFYHwT462U3tlFgfBaj9hTfZ6gQZZj3h1ZIyfWni?= =?us-ascii?Q?4LeOAOHkcRmpad/OpquTbzIpufQwAUiqO19h/p5ghut1g+FM8lJF6YNkIMD4?= =?us-ascii?Q?BjEYHqDmT9NfoOnVBAXttgpQbj3PjQAFSvuuHo5yDiyCkgdMioWWanizwGYA?= =?us-ascii?Q?o2J+9SiPNU55VNx+GZ7IqQ0Ju8ELl9TChr442Ue7sMjk9lqmsBjdfLm/HbJS?= =?us-ascii?Q?qcaNtoer76W/ytSKiiuIau0Kt7XHbnbKrWc8fM56Ia3aYyrb1gDKvFITD/l/?= =?us-ascii?Q?hSoGceyj6zDznE+TFBrgIX5CCyLnvIBQ8u0HjIJS1dMALirD3e+tSRxzSIIH?= =?us-ascii?Q?X841glx4SJs/aqsRahn+Ty+rnXIN2xC8qfoahGitS9Uwn8SwZgGc/iH3qPwn?= =?us-ascii?Q?p/oqTpEcjphEnU/TJrpc/t1y66UXkrpce4VogQcNDvlsqjJl+C9cSvTEqIDZ?= =?us-ascii?Q?FLS4tFOl99bKSbGKPUFcd5H2nrxmgE5RSV6n4ZQwbdiSLwZ+TO8EBp4KSjLy?= =?us-ascii?Q?2ptoZGnu0F++5k3TkLSXwsRrJApXPqxnzMlPXOVjHBYbpuQO4SIkEaMt/vmH?= =?us-ascii?Q?ZSFun7UbZR2aNRgzXVFoGqSXugXEXePl4txFbDdoxz0WAstijUS8HL7tyAho?= =?us-ascii?Q?KW2BU9LVZmQXPsZ2Tx4ECUh2B2e8He0EBdhEQukpegOigX2EKeS1JZQjPLXZ?= =?us-ascii?Q?LSdOkgBSEiC0ypqvBixTRmrs0KM2PTKfLeodhXUfIYFxtbLd+H7MXW8djjaw?= =?us-ascii?Q?mmjD7JxHK/+TT1Mu9h1ychc8T+2+vu/7UWSglKCl7OCQeFCQXpLPBxzdZLkT?= =?us-ascii?Q?riwcB8opfA9TNFTcGeC189XIaRbWINtgLzubX1OYWv46wUpR7+6eL12v4NYT?= =?us-ascii?Q?i9DZ6jTdra32MuO4S7DRcuQlmkTnuXGgkqu1oUUZXIQMbV7zmFEXy1IC/YhP?= =?us-ascii?Q?7wz6Bnbc4thtBjvrHw/izdfr87AIPz4p3d8xGivnMPv7cpIda3KEoX/x+c5g?= =?us-ascii?Q?xqEHPAuGx6Qf1oyjXy/Uim5cxm/yIWL9xS2FHoLos/LhTitaW5kyF2oJ+Mv6?= =?us-ascii?Q?uJpOV++zH/XuDepl2iXFRlFRVE4JCAtF6NFEAHHmQ4atMKdsK9LjwOITqNRq?= =?us-ascii?Q?VbPNmDqgI+nH++GOBy8U6uBSxwZl7YSOHUJmb92E3yX8/IYazYYvLdotBAdR?= =?us-ascii?Q?wfG1PS8uCGYl37Tvr5xxMqLmL6kwH6vcc1I6fNB8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42781e4a-9810-4c8b-49d4-08dad3423f2d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 02:17:50.6956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bcQEVrnRguOe6+ZzXRK4Omp+cCmRNoEbeqnGzly4XBQoo2Oei1a+DxOglUoaMqw8VRVb7+YsG1xuF2oJxvq19g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5872 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, December 1, 2022 5:20 AM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Sean Brogan > ; Ni, Ray ; Liu, Zhiguang > > Subject: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to pub= lic >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4178 >=20 > * Change GoogleTestLib class from private to public. > * Change UnitTestPersistenceLib class from private to public. >=20 > Cc: Michael Kubacki > Cc: Sean Brogan > Cc: Ray Ni > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney > --- > .../Library/UnitTestPersistenceLib.h | 0 > UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec | 13 +++++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) > rename UnitTestFrameworkPkg/{PrivateInclude =3D> > Include}/Library/UnitTestPersistenceLib.h (100%) >=20 > diff --git > a/UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > b/UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > similarity index 100% > rename from > UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestPersistenceLib.h > rename to UnitTestFrameworkPkg/Include/Library/UnitTestPersistenceLib.h > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > index ed12f32009d8..14e387d63a0f 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec > @@ -26,11 +26,16 @@ [Includes.Common.Private] > Library/CmockaLib/cmocka/include/cmockery > Library/GoogleTestLib/googletest/googletest >=20 > -[LibraryClasses.Common.Private] > +[LibraryClasses] > ## @libraryclass Allows save and restore unit test internal state > # > - UnitTestPersistenceLib|PrivateInclude/Library/UnitTestPersistenceLib.h > + UnitTestPersistenceLib|Include/Library/UnitTestPersistenceLib.h >=20 > + ## @libraryclass GoogleTest infrastructure > + # > + GoogleTestLib|Include/Library/GoogleTestLib.h > + > +[LibraryClasses.Common.Private] > ## @libraryclass Provides a unit test result report > # > UnitTestResultReportLib|PrivateInclude/Library/UnitTestResultReportLib= .h > @@ -39,10 +44,6 @@ [LibraryClasses.Common.Private] > # > UnitTestBootLib|PrivateInclude/Library/UnitTestBootLib.h >=20 > - ## @libraryclass GoogleTest infrastructure > - # > - GoogleTestLib|Include/Library/GoogleTestLib.h > - > [Guids] > gUnitTestFrameworkPkgTokenSpaceGuid =3D { 0x833d3aba, 0x39b4, 0x43a2, > { 0xb9, 0x30, 0x7a, 0x34, 0x53, 0x39, 0x31, 0xb3 } } >=20 > -- > 2.37.1.windows.1