From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4107.1666150477505963175 for ; Tue, 18 Oct 2022 20:34:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=adqlWtzr; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666150477; x=1697686477; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=wKi0Mga8WuB5YjKfu14XYlqtUmF/VSYbl22OwxbmEKw=; b=adqlWtzrgjYlns324R57mp+oZfQgYnyM7IuKunNqmcXhubKxZa2MUdBo d3fdBp4K2VMuueCzWPokjfCMUJqQ8Zna2qZmCvQo1Qv/dyvMXo/wm2Ge+ r7TmMFxr5LVSk5jxzKaZL2cGBrlv23lfxRhQ199MBuz4fEILylFcQa6H9 ouFlkmLkoI+x28n7ga6LeeVUldLdWUPSfByL7cYfLYND6sjHHzq4qyQRs uTJzoU9eJ+zEaKtoQzI3FhWYY/IRbGJ8UFS2yYBz/qwwS8zQh4Zo7ABgo Ac7qB3pvjII2X0pBrT23tqv5j9FXFA6neQLwHHGxnRt9JGrw5EShohqFi g==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="368348647" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208,217";a="368348647" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 20:34:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="733991865" X-IronPort-AV: E=Sophos;i="5.95,194,1661842800"; d="scan'208,217";a="733991865" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 18 Oct 2022 20:34:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 20:34:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 20:34:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 18 Oct 2022 20:34:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 18 Oct 2022 20:34:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5Mj6Vs2ZEXwRgjnsBVgiq7FMrBGoAF74q1fqVSw7iLWNNsH3er6vZYUuuYDlpBLjXbT81fB6S9spjGYDNJFTrX8cCKLFj9J198iGa4iF0PXCOOxhsnx7mhmNME+YMYX3OXgJOTBRo0FG9AO5L/EhNT/i+YXSIIlyWoCBXDh65dLavvW4uaGTQuGzY6HNfqhNQE/ZBcUvCCKAoT0WAUTtTD1PWfgdwOqvzhVZRA3WcOo72iY8tDF6qzPlZR2fVKVR+/mO9bPBvUyv6OEshtMF0/GgbVRswemN8Ro79Oip2RGCx+12I3yxgjDfiatsA9eBWL6kVYkWSqa4qYzd+AjjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AsEtc3VM8nYTH1qad/GFdsLYjbDiy7mXDIe1ZHvjk9o=; b=QsuWLHrOCVNNKB+F9SDVzwzggbHPEF98V3zWOYE5vsUjADcb+rTbb7gD9ILZeNiPYX58BIn0mvVg/WYoYs71I9FtonkXInfOcCElhyIcxEL8NcurSEOJl3G5DjmByy3dDCR0XJnd0VbAbcD0T/e+1r7l03ji2ZcrVvSA8aO/5IOkMl/S5X+cmCIKK3mNuE3DJrSY8IF3uRu4dTRpIXtrY0JBhjwk+zcSEah4L+rvYHWCTXt3Lcf24K8s5/1UPQHE6UpZUkUT1Aa3lKixyPPfGGv7p4360tUx3fhztYCUEmvs7jpSqwNltfGbwGjK4JvKeWZQnBp1zlqWVqphIEefLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BL1PR11MB5400.namprd11.prod.outlook.com (2603:10b6:208:311::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 03:34:27 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 03:34:27 +0000 From: "Ni, Ray" To: "Chang, Abner" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Topic: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Index: AQHY4IwdJvxATEGPoUyuAxn4QIPxlq4TrRAAgAA/8gCAASlMgA== Date: Wed, 19 Oct 2022 03:34:26 +0000 Message-ID: References: <20221015114757.383-1-abner.chang@amd.com> <20513.1666072896702226815@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-18T09:50:25Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=78326f6d-fc56-4f8f-94af-d36ea31b7d13; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|BL1PR11MB5400:EE_ x-ms-office365-filtering-correlation-id: 11803c0c-adfc-48df-8e00-08dab182d304 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fuk+QTLriVfahwdUhgOMw0UMHQMq3ok2BBUhf2nLaKQjjZOJUxT9hO7HHj6hh81kZoKD/HHfX4oLjqoj1iqytc/5vA6KvKF2jExWSkEGwUnKU2BAM6NjYQld5J6hdq9/ViKPXQDHimcQQ6g+uvR6Q92Oz2iKnjjWNK86bjYGPRYI1Qq5fLKof4POXJ07MwrI+9lYkSQ+fUAKV8hq6FdR5n8NdOydC8IPSTYF/oXkLKVIbUpXflEX2+HHuS5VyAIgiX5U7+T4x0iQLBN7ZR1TLB4VQoGoa+kL/ozvn3cG+SJt8m2RhGF3rOgAy4QhIbqWmB1zJgrgvLN4gYwX7X7dX4IK5juZhQ/Ls9RxHhNh2wUv3QjNuptwvXEoFhsfztgbmyiGTdUfnCvIbQ5qwcFCgnDrZqLQynSSimELpy7mqolL7iLiP0N7YBgyLDI1OUOpgd9j8a5vcZ9dVgzWX6Q8zc3x3ePJ+i81Ka5t0WVLV0j27YaM0syx1Aw/asyRmsO4len7A5WKgQjVX/Y0C1NIMWRw7w8AiaMOC6M2/JSLybhEjSgC9qpf5Y/rSyKv4VGWmNbP66xK9wsp861Y438T7H/f9VH//yaJ8pK5GpX0HGtRuz38yorRFmwpFuLKlo3SZIswPE6th0ri6lX8UTMsWfWlWClbsU8Rb3K2xYXDit8CBhgLU7IuXFvqK9d+wCgGC+Via7w4YnGwcHloyn0rYNMOGSUbLrxDjgVYJ5NiBM5ySXzy1D2FlW/xQCcXlC+jywb06/ifzeNNvOPMG54+qA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(71200400001)(186003)(83380400001)(26005)(38070700005)(86362001)(82960400001)(5660300002)(2906002)(38100700002)(8936002)(15650500001)(52536014)(55016003)(8676002)(64756008)(478600001)(41300700001)(9686003)(110136005)(6506007)(7696005)(53546011)(316002)(66946007)(122000001)(76116006)(66446008)(66476007)(66556008)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KcHBak4NvQjCTbnhBqI7CPQzhHlkqMRdiIkURq5SHYmGxK6JomPiagMQXQwd?= =?us-ascii?Q?qmq0iYBbGQ0qNO4Oa6DvRbcKCvpXM96SpT1wmt4UVsjcY6/ELhE37YXlAzBX?= =?us-ascii?Q?UO8rE4fEaBhgBclP/LIvighuqj7yaqWGeuAp28V68+itPbiBcXw1vVSD0WWs?= =?us-ascii?Q?TOcrpwfKBKcY2JuzM151NZBS/db9aWsM4ns/at6mnZnKP5qHgDt0s3QKRort?= =?us-ascii?Q?AvQMvkpzoB3FtFh57a+qxN6a+nfMwqQbK2NPoJZgupX2NrfXRw+tPBw7vCG8?= =?us-ascii?Q?5UWLZ/L1eMucCkshKALOhCJoBmE0FmQdBTbxBkrfRwAxECWM5vmN2+e5ukGw?= =?us-ascii?Q?dFP91HCOHmdeCLQWcAXcXi5tzrDFLQr95nxvIs46+fqfvqYyR9lHnvTw2H/x?= =?us-ascii?Q?TddzSr+nGr75fRXqpzVs/vD7iTf1VgoMSLpEu2LszkffJgn55JHo/EqjY/7j?= =?us-ascii?Q?zvfRStyD+4cS8elxK7K7tr/OaOde1LICSNtEGyjShuipHqh3LPPqpr3pVsuA?= =?us-ascii?Q?7L7ENXC0/RaExevcP8mPGNP50y4jkBB3yen8xe6wBDN3jGHl1Godd81GbSA+?= =?us-ascii?Q?3l7Bx+tjq5eRRNAuwuuAXHc4WLiTed/bMCHwjsSGwE1btJ4T0q0QkahQt5oN?= =?us-ascii?Q?8qGppAp/YZU2HSxgHqXF+HqCkE2nDEn4udqIqPa8YrIJTWOcrMDj+J6qYw2l?= =?us-ascii?Q?E1dAWvndqLdzhuCGRDF1ECKpttDZx70MC5zy0XEnBKrt1Muuks4eLQHx8OHf?= =?us-ascii?Q?sPl0jnlIgV5wY4sQ47+oB0DDekJPSvmvDpACAz0qEsJvXBXJBgAM9vvVm8+h?= =?us-ascii?Q?SGzp+0F4hhJhha6sM8dU3rtHXO8/US9K7x22K8vsifYgQ2DXZbxFg00sOl0d?= =?us-ascii?Q?ZZtKyDnOIt7nqEaUdax9wwCx+CTkkSwsxyh0U2uU91ENhtqKI4IZ0qJ7a3pm?= =?us-ascii?Q?ClLKQkLt25VWg/J/UBwTKUI7CBZ+bkoxRoBar5g4ZP4lqdJa76FglhuysHBn?= =?us-ascii?Q?7mSBNnaiD9MhnfUq7lI5osbsgS6adowRjBVaCTZ/jIRqs6ZXry/UZmKMExoN?= =?us-ascii?Q?xO2OTVtnGA9HHmuEqbJOo/7E0YbmZ9lrkGFNTeB6E4gITj4RHEpYtIwXtxUV?= =?us-ascii?Q?PhzM6A02eKhf0Jn3yR6aN6nMj5ZyDTbHmLLjywhbnvVw555e4zkvuIMphxu7?= =?us-ascii?Q?dJnBR9e8kHux/k1HPUedu94otQ3a2vkhT1TKAx9yW9nb5ixxMz3DCRoz2Fzp?= =?us-ascii?Q?ST/XudBmYvqyqRB9JBw9/td65c1qIYYTK7Bkx6Y8LZvdwG19dagmICsmUpkk?= =?us-ascii?Q?OPTVz9jfwA5e0B7yJtJbXzd/996fmaad8sV8igQbqrf6IeApro8uwnEJkRDf?= =?us-ascii?Q?j6eao7GwqzC2lpAXIotRkAYlCeSi4WmkvrlQrdeaEagFSq7z4Gijc08UYvcC?= =?us-ascii?Q?iK6YQ6Fw25nSoQgOwC7qgHnYiXBH+PIsf4Ho+mGM74W0pgBvX2qiwX5iIXtk?= =?us-ascii?Q?vuEOKqKduJMxx8kmSn18LJZ3fyuUBiJuOVDFjuPk3wNyYl9jaRyWw63ZUMUr?= =?us-ascii?Q?02MdrkOaJ95iFMu6Bhb7hS1/IK/Bu6bnULvZNb+u?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11803c0c-adfc-48df-8e00-08dab182d304 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 03:34:26.9877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tNMNk6QOewR5F8ODON1234U/As1zVKrMRTe7qsSoJu6e4OnwarvTuZQazzLsi7YqX4xw3sjl1Kl0J4ExL5YSjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5400 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR11MB16317468CC10E4513F186FD88C2B9MWHPR11MB1631namp_" --_000_MWHPR11MB16317468CC10E4513F186FD88C2B9MWHPR11MB1631namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Oh I see! Reviewed-by: Ray Ni From: Chang, Abner Sent: Tuesday, October 18, 2022 5:50 PM To: Ni, Ray ; devel@edk2.groups.io Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections [AMD Official Use Only - General] Hi Ray, ][].* The simple naming rule was already defined in the 4.3.1 to 4.3.= 4 sections. We are not intending for defining the file naming style. This s= ection is mainly for the format of attaching and to the = filename. For example, how do we add AMD to SmmCpuFeaturesLib? Is "Amd"SmmCpuFeatures= Lib or SmmCpuFeaturesLib"Amd"? This is what we would like to define for the= processor archs and vendors. My opinion is we can just leave the file format naming as it was defined in= this spec. Or how about if we say "Refer to 4.3.1 to 4.3.4 sections for the file namin= g format" for in below? [][].* OPTIONAL The is represented with a BNF, ::=3D'Ia32' | 'X64' | 'Arm' | 'AArch64' | = 'RiscV64' | 'LoongArch64' | 'Ebc' ::=3D []* Example: Ia32X64Arm or RiscV64LoongArch64 OPTIONAL * REQUIRED Refer to 4.3.1 to 4.3.4 sections for the file Naming format. Thanks Abner From: Ni, Ray > Sent: Tuesday, October 18, 2022 2:02 PM To: Chang; Chang, Abner >; = devel@edk2.groups.io Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. All look good to me. Thanks for addressing my comments regarding simplifyin= g the rules. Except for one minor comment: I still don't think we need to define rules f= or source file names (4.3.5.4 EDK II source files within a Library/Module i= nstance). And the rule "[][].*" doesn't specify what could be. That leads t= o allowing any style of the file name. --_000_MWHPR11MB16317468CC10E4513F186FD88C2B9MWHPR11MB1631namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Oh I see!

 

Reviewed-by: Ray Ni <ray.ni@intrel.com>

 

From: Chang, Abner <Abner.Chang@amd.com>= ;
Sent: Tuesday, October 18, 2022 5:50 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

[AMD Officia= l Use Only - General]

 

Hi Ray,

 

<CpuArch>][<Vendor>]<FileName>.*

 

The simple <FileName> naming rule was already =  defined in the 4.3.1 to 4.3.4 sections. We are not intending for defi= ning the file naming style. This section is mainly for the format of attach= ing <CpuArch> and <Vendor> to the filename.

For example, how do we add AMD to SmmCpuFeaturesLib?= Is ”Amd”SmmCpuFeaturesLib or SmmCpuFeaturesLib”Amd”= ;? This is what we would like to define for the processor archs and vendors= .

My opinion is we can just leave the file format nami= ng as it was defined in this spec.

 

Or how about if we say &= #8220;Refer to 4.3.1 to 4.3.4 sectio= ns for the file naming format” for <FileNmae> in below?

 

[<CpuArch>][&l= t;Vendor>]<FileName>.*

 

   <Cpu= Arch>   OPTIONAL   The <CpuArch> is represente= d with a BNF,

   &n= bsp;            = ;          <arch> ::=3D'= Ia32' | 'X64' | 'Arm' | 'AArch64' | 'RiscV64' |

   &n= bsp;            = ;            &n= bsp;       'LoongArch64' | 'Ebc'

   &n= bsp;            = ;          <CpuArch> ::= =3D <arch>[<arch>]*

 

   &n= bsp;            = ;          Example: Ia32X64Arm= or RiscV64LoongArch64

   <Ven= dor>    OPTIONAL   *

   <Fil= eName>  REQUIRED   Refer to 4.3.1 to 4.3.4 sections for t= he file

   &n= bsp;            = ;          Naming format.

 

Thanks

Abner

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, October 18, 2022 2:02 PM
To: Chang; Chang, Abner <A= bner.Chang@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

All look good to me. Thanks for addressing my comments regarding simplif= ying the rules.

Except for one minor comment: I still don't think we need to define rule= s for source file names (4.3.5.4 EDK II source files within a Library/Modul= e instance). And the rule "[][].*" doesn't specify what could be.= That leads to allowing any style of the file name.

--_000_MWHPR11MB16317468CC10E4513F186FD88C2B9MWHPR11MB1631namp_--