Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> PierreGondois
> Sent: Monday, October 10, 2022 5:48 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; Alexei Fedorov
> <Alexei.Fedorov@arm.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT
> fields for ACPI 6.5
> 
> + Ray Ni
> + Zhichao Gao
> 
> as the patch wasn't sent to them.
> 
> On 10/10/22 11:20, PierreGondois via groups.io wrote:
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > The ACPI specification updated some terms in accordance with:
> > s1.1.1 Principle of Inclusive Terminology
> >
> > Update the PCCT parser accordincly with these new terms.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> > ---
> >   .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c   | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.
> c
> > index 8cffdaaf0716..8ad39090afe3 100644
> > ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.
> c
> > +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.
> c
> > @@ -146,7 +146,7 @@ ValidatePccDoorbellGas (
> >     IN VOID   *Context
> >     )
> >   {
> > -  // For slave subspaces this field is optional, if not present the field
> > +  // For responder subspaces this field is optional, if not present the field
> >     // should just contain zeros.
> >     if (*PccSubspaceType ==
> EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
> >       if (IsZeroBuffer (
> > @@ -214,7 +214,7 @@ ValidatePccErrStatusGas (
> >     IN VOID   *Context
> >     )
> >   {
> > -  // This field is ignored by the OSPM on slave channels.
> > +  // This field is ignored by the OSPM on responder channels.
> >     if (*PccSubspaceType ==
> EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
> >       return;
> >     }
> > @@ -237,7 +237,7 @@ ValidatePlatInterrupt (
> >     IN VOID   *Context
> >     )
> >   {
> > -  // If a slave subspace is present in the PCCT, then the global Platform
> > +  // If a responder subspace is present in the PCCT, then the global
> Platform
> >     // Interrupt flag must be set to 1.
> >     if ((*PccSubspaceType ==
> EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) &&
> >         ((*PccGlobalFlags &
> EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=
> 
> 
> 
>