public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Xie, Yuanhao" <yuanhao.xie@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>,
	"Ma, Maurice" <maurice.ma@intel.com>,
	"You, Benjamin" <benjamin.you@intel.com>,
	"Rhodes, Sean" <sean@starlabs.systems>,
	"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Change some configuration of the payload
Date: Fri, 1 Apr 2022 12:46:15 +0000	[thread overview]
Message-ID: <MWHPR11MB163178F020A9AB6FB3A728928CE09@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR11MB50379FE9EFB09DD32DE28013F0E09@SJ0PR11MB5037.namprd11.prod.outlook.com>

Thanks for the explanation.
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Xie, Yuanhao <yuanhao.xie@intel.com>
> Sent: Friday, April 1, 2022 5:56 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>;
> Rhodes, Sean <sean@starlabs.systems>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Change some configuration of the payload
> 
> Hi Ray,
> 
> The reason why we use PeiDxeDebugLibReportStatusCode instead of BaseDebugLibSerialPort is that
> Base Debug library is based on Serial Port library, and it can only send debug messages to serial port device, while SerialPort
> supports to print debug msg in other places.
> 
> Thanks
> Yuanhao
> 
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Friday, April 1, 2022 10:05 AM
> To: Xie, Yuanhao <yuanhao.xie@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>;
> Rhodes, Sean <sean@starlabs.systems>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Change some configuration of the payload
> 
> >
> >  [LibraryClasses.common.DXE_CORE]
> > -  DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> > +  DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
> 
> If DxeCore uses the ReportStatusCode instance, some debug messages may disappear comparing to the case using SerialPort
> instance.
> Because the ReportStatusCode driver runs a bit later. Is it for saving the payload binary size?


  reply	other threads:[~2022-04-01 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24  2:04 [PATCH] UefiPayloadPkg: Change some configuration of the payload Yuanhao Xie
2022-04-01  2:05 ` Ni, Ray
2022-04-01  9:55   ` Yuanhao Xie
2022-04-01 12:46     ` Ni, Ray [this message]
2022-04-01 13:24       ` [edk2-devel] " Sheng Lean Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB163178F020A9AB6FB3A728928CE09@MWHPR11MB1631.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox