Re: [edk2-devel] [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code

["Ni, Ray" <ray.ni@intel.com>]

Agree.
Yu,
can you please add the UefiCpuLib in [LibraryClasses.IA32, LibraryClasses.X64] instead of [LibraryClasses]?

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Thursday, March 3, 2022 5:58 PM
To: Pu, Yu <yu.pu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code

On Wed, 2 Mar 2022 at 09:20, Yu Pu <yu.pu@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394
>
> Invoke GetPhysicalAddressBits() defined in UefiCpuPkg for CPU physical 
> address mask calculation and remove the duplicated code in 
> StandaloneMmPkg\Library\StandaloneMmMemLib\X86StandaloneMmMemLibIntern
> al.c
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
>
> Signed-off-by: Yu Pu <yu.pu@intel.com>
> ---
>  StandaloneMmPkg/Library/StandaloneMmMemLib/X86StandaloneMmMemLibInternal.c | 10 ++--------
>  StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf          |  2 ++
>  StandaloneMmPkg/StandaloneMmPkg.dsc                                        |  1 +
>  3 files changed, 5 insertions(+), 8 deletions(-)
>
...
> diff --git 
> a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf 
> b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> index b29d97a74607..94f7fbb1c4f7 100644
> --- 
> a/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
> +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.in
> +++ f
> @@ -43,12 +43,14 @@
>  [Packages]
>    MdePkg/MdePkg.dec
>    StandaloneMmPkg/StandaloneMmPkg.dec
> +  UefiCpuPkg/UefiCpuPkg.dec
>
>  [LibraryClasses]
>    BaseMemoryLib
>    DebugLib
>    HobLib
>    MemoryAllocationLib
> +  UefiCpuLib
>

Isn't this dependency X86 only?