From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.4501.1668587180162083118 for ; Wed, 16 Nov 2022 00:26:20 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=UtrwGrtU; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668587180; x=1700123180; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pZmgtnhXv/7RjiNdlISd2AaZFglM58NglHIDaEpuTkE=; b=UtrwGrtUGVc1RcfMan9J3ufY0eDK0TlwVOGq3lg6HC1MIRvYZhVy5UGq z6sMkJBKcx3fN+tO65pS0JnVVij1WvnpReSQxQcB5pJTN3GBe9AkPAZXb oI0opySDnV11vNU2uj6Xq6X+1yBrJVKr2nQHeinQv/o+OT1di4qQtFCFG Vzsm96kV9yBxS9HGVSsca94ASO0zoAtI9tYYeXIFeaRKdK/UxLbGjmXqf F9ACzfBOrIkE3syUpuoGq7bC7gH1xkC4uu8MlFMERrQDeJL9WE4+JmnVJ W4l9AlG+jV3aNoZRJhsnu95CRDOC+ZgitfexvL7hJFu1+YssKv6EMz+Mc Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="374618239" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="374618239" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 00:25:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="764240210" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="764240210" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 16 Nov 2022 00:25:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:25:32 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:25:32 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 16 Nov 2022 00:25:32 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 16 Nov 2022 00:25:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Riz2vhUNjXwweSaHcDNkUdxfB57oaNmnxiM+rlOvFPf1ca43ZbV8x/z76shFp8fRiG6qvrvzrlSGjA9EtFmD/jY6Og4TSbxy2snzhLo6eKf4xceRzaJCaQr9WNtTC/7/sekZ01zUz0eURc5rry6iE6wfrGvrl6f//yTEunGbhz3SEqqKI5MBpAlNL5a89QfrMYdNAlO4eNPwApEP83iL/G6kWgFt+RbJMIxlcaV/eQaG0TxWy9LI+ErySIAa6T8DvZDiJQC9LDPzr3l1DE17tUdjw5yW9uMjgS0R3xLIT51/R5qlIILUVlz64LoyjNMRfuSvVmMiwyoWP/IJX+9Www== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWS5WD51HkTvVueuJNwbvgmxTC8QOEJgcKe/vClMz5c=; b=FsK56K9CiXTM/Jg534CpLYOFXESd4rrPvkHl80LcsfR3HpQVfhrKTmjhMBcAXgvBhI5YtY5v/KXR4g/phs30sD+NNKHczD2OMEgXwbYE44/bbph2+Wnp9Ja1nc+oHi2fo+t4wzMp+rAafm6tLiomsPW5/kYMNaCXFU0gdwZgiTwLqKSAvR9kt6vD/Hit4se0zSo9+QTNj2bvHEWVGzeral3A8daHPC3tPvKVAqS5aLbM5NgfbtrIuOcGc09hyyGyuhON5n1Z/t3Khqb38n/Ytkb2KkafTQchYpJcmtjPS6/zwVEbmWnJbITd87D4e6QU1LMlK3g9IjnjqKZEiFIHlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA0PR11MB4576.namprd11.prod.outlook.com (2603:10b6:806:97::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Wed, 16 Nov 2022 08:25:30 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2c28:e02b:3dc0:b817]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2c28:e02b:3dc0:b817%12]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:25:30 +0000 From: "Ni, Ray" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Oram, Isaac W" , "S, Ashraf Ali" Subject: Re: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return Thread-Topic: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return Thread-Index: AQHY+ZTcNx2Cc6avZ0yh1iyFuqIge65BNsWw Date: Wed, 16 Nov 2022 08:25:30 +0000 Message-ID: References: <20221116082418.259-1-michael.d.kinney@intel.com> In-Reply-To: <20221116082418.259-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SA0PR11MB4576:EE_ x-ms-office365-filtering-correlation-id: aa0b4a1f-f646-456f-dddb-08dac7ac1f94 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mOP1gHczRbA11L8fugr4kwCrcME6Cw6sRnj4fCwjwLnYtd6yhD4CIHdVM7j62qMsxWizbM7cs6Gmi6PlpNBjmzS+6lGBmhKI3qo+xiAbMm8/a2wmcr44aVnxCI5Nse1lZLiJ/OV4rN5wSRNPnG7YGXSsKHiV0+KO70V0qrhvmS+Iw65ybjL0f65XgOJHS7L62OEZoC31PXTgmhhtZG7wSLAt4pSiePU60ZG8Vc80FXOY6sslEHjcakFMqX7TvIndRcjynztkSFN6jHHCxn19epZ1CtNCpQSyTsy7TQ41DfIb/rbeUTF8d7uF4YFpn+pO0MEM5UCY/v34F3A+dTzzHO8lCZicGicgT9lLZAJuva0xQIPQJgkmk23UuynadLbdRHLfUqoH0ztuSsWGNq681/cv8lSuuBNXb8JTCeJ2xuPHGfUHXaxLdMQ1Jnm1RMSX3xDSQP+FUpRtnVa37W/5wrCpxqI9P3oG8SJFv46E3vvTfpr4TNPNVHusmoccBzvNakD66x3zAnJU71CYdx+g+1ycqiJgdTKm3yUCoToHK7tFeBhm/8sbdOZGDJC/dQN9mW2itAfK1I8cuSP3rwrFwS+ryMaLYNUZbPuo886zN6gDCtPOstda/LAJx4xqJQiApWQA6re5ZJwxoKODoVOmwWEVSosQDMM4wQ17WwLdfVFFtoznrCaT3paLB+sL2XoRA/I7hK9elhaRNrDEKwhPT4TRxrLatid6o/TR7D83Fax4Ov7dxGGp2HnKc3tJ6EQo0iG6h7rZUA1UYQSAw+gJIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199015)(26005)(38070700005)(9686003)(122000001)(38100700002)(66556008)(76116006)(66446008)(64756008)(4326008)(33656002)(66946007)(316002)(53546011)(86362001)(8676002)(478600001)(5660300002)(186003)(66476007)(41300700001)(2906002)(82960400001)(8936002)(52536014)(71200400001)(107886003)(83380400001)(55016003)(7696005)(6506007)(54906003)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FIFtaoeSeDAUfU4maCWnEix32cQ1zzpjLSunMm/h0gMSiaSZOD3hKpf/Hi0/?= =?us-ascii?Q?YP7M4J/RkdMQX+fVG7E45iGji/t3xwzlWCpVJHFsi2vCKsigiROeIvAJOono?= =?us-ascii?Q?wpfxdeuD2ef64d+0KmwIlL7V1rcE9K07hpS8DHznUOEazKR1OhAumNGc6w05?= =?us-ascii?Q?p22wiO+d9FlW4/wXTvlIJCoDpHe4E/jTz+9rl2AlpA+lRmeyYFrUKpzPA9py?= =?us-ascii?Q?wQ1FYnw2jy+6A3du4G9HtsnSNUWr6vlb7aMJUXISc/dNpGmI7uVpN+pGXGU9?= =?us-ascii?Q?Qok78g9UImtMOTc2ygmdN+FzsN9tb5ihHJqKjFPzeBc7gMP6rVZ7sUEud7BU?= =?us-ascii?Q?e8SymyvcXv7Qmvupk3G6UH0JKevYEV2eu5XxELlW3ynVMm6nN4WPkf+vp/SD?= =?us-ascii?Q?G/gTdkK9Tx2tihcjQsV2JBLzXB43w9rmglq7d/ebxhiZ/xJvAfvArGaF8Lrj?= =?us-ascii?Q?cUtRiy/8XBHXGg917KyQFNCVsOrjy29II1LEA66pnJwDY247KuCzS17I9cYD?= =?us-ascii?Q?6bu30UVpjmIsdlOuBHrp2fckh8X8von0lGiw7W9rr/FGX12boyUvc1jsDkHx?= =?us-ascii?Q?XyqR/Pa47R1ZqTzPhR8OE7F6TJ+6SDyDyc1xwKjkiEB+iYx+KdCA4DSznEyk?= =?us-ascii?Q?4f8+ZigsraXrbJbSlgOWnMI9xuBLAGQqRNw/senFmFIps01I7sFh3lu+pSDm?= =?us-ascii?Q?GRtQFckAal9Fu5kYCzf3MGQSRqQlgdn6H6117PyL4X8eRDiYoPYH5xsqdKj0?= =?us-ascii?Q?sK+AoYcNpVcrZgHIA1Bfz3SsjXY/c+nwhx5mrG5W96rNK5ONjPT+2o/0RbKD?= =?us-ascii?Q?jDAmDji33OR7SeMMRjQyGotE8NR/0lVRrCGAjPg62Q4t+6g9lrceXpel9ktB?= =?us-ascii?Q?qw6bysUNSxcD6rvxlBFW8mkPx6L2cQtgNfvVTpxTHHjfCXu0SS6vtPJMLyoM?= =?us-ascii?Q?1xC9HPf21qclhiv7StKbqJjqAazBoapPWMp9rk7eWFSAKTJOts4sx/frHnar?= =?us-ascii?Q?dBQtfG8KPsToONLjZJJHc7FhAUbktejmJMGLLNpOO9QFKviXAnIG6G7BeRe4?= =?us-ascii?Q?+GBlV5kKdG+cclgebj6JqURuagZB2tWgUrJ3zxe0tYifks/58jrlXSfzy57R?= =?us-ascii?Q?9rKQNFB726byPDywLtQI0eP7vTwnTbYqHCG+HLJO07bB9rjclfg8+CHzwIUp?= =?us-ascii?Q?MCKPyJ1Sts2XOU3uaopPGlHKiNEFcBCx6OoFTfuKSl7HBUnP/FKnjmfetv/5?= =?us-ascii?Q?Kk8i4d8lVQ+gzNIvrwLZREVNGt1Qxy4qZV0m+b5oWdd2fwO3ViTFj/WuvLTS?= =?us-ascii?Q?YE9+BxDUxWz2hF/ZaUN67RGk37oqLe+R54Jf7KT10eiyy6743N2Pu73NqxuL?= =?us-ascii?Q?nvkdJ8j+AkumH/c7VxeL+WpkDcvSeGt0cqZGfme4vpE3bxGtMf6NLHshSGfy?= =?us-ascii?Q?0TxddRI24cOZRiWmV+07IdD0VvDyjtthM2/RJwfaLLqrEj3d/oAS+XC16lo+?= =?us-ascii?Q?ZbtjrIPOHkwYT3AHyufnAkqONBi0ddJaxlHRDoYocgelElAStcw4x0e4t6Lc?= =?us-ascii?Q?OsM6D4i6vhO7s6z+cmJyLgKPpTEZPcUf5mZs9JzI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa0b4a1f-f646-456f-dddb-08dac7ac1f94 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 08:25:30.4186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Mf2h6Aj2u/+wI9Uc5wRdOIchsrYNTTu87kMIppf8mwmNLAg169Zc+dhq3ZHCAU4r0NcEuIbNI8pFypA7clmPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4576 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, November 16, 2022 4:24 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W > ; S, Ashraf Ali > Subject: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected inco= rrect return >=20 > CreateSecondLevelPagingEntryTable() has a return type of > VTD_SECOND_LEVEL_PAGING_ENTRY * and an error condition > returns a value of NULL. >=20 > Change return value of EFI_SUCCESS (value 0) to NULL to > address CLANG compiler detection of incorrect return type. >=20 > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Isaac Oram > Cc: Ashraf Ali S > Signed-off-by: Michael D Kinney > --- > .../Feature/VTd/IntelVTdDmarPei/TranslationTable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Tr= anslationTable.c > b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/TranslationTa= ble.c > index a806c4c000..bb121a608e 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translati= onTable.c > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translati= onTable.c > @@ -109,7 +109,7 @@ CreateSecondLevelPagingEntryTable ( > BOOLEAN Is5LevelPaging; >=20 > if (MemoryLimit =3D=3D 0) { > - return EFI_SUCCESS; > + return NULL; > } >=20 > Lvl4PagesStart =3D 0; > -- > 2.37.1.windows.1