From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.7711.1652796713291075125 for ; Tue, 17 May 2022 07:11:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q2NvamQf; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652796713; x=1684332713; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=kDasyguIrqwtw9LMaSSUAmdekA+vC+9Q8rMuvlfgzMU=; b=Q2NvamQfvcYKTa5nN2DY+KxFwFgav61KTLT21SUmrBB2XCKALplqxbjD NaGE9WrZLxEoKsUQc+4wmAhcRyh/qSBu52aIkMpeQuOF1UbO8yrQrJL8o 5IZAuCGInvd8TmOWnTasaoza83Tp4buMNOm25ieues8tEBxP+KQKNh9Wt BpK4aKZiYyc9UAUwpNNvLYQ+fkSm0JtwcKTbW07mHUkZ1DbofT9WJ2Ftb mE/FL9P5LEbMfADeJ9rltOyN8HHqmcoQD/0+cvJXcJx2h2F0ptHtvLYtA HPMp2pbKhrCcUXBOA9CT5q43RKpfMX7TA3ifEtw8MkgKTgR1V6KO++qp0 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="271318471" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="271318471" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 07:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="568910755" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga007.jf.intel.com with ESMTP; 17 May 2022 07:11:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 07:11:51 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 07:11:51 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 07:11:51 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 07:11:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ByRdpL6dGcQh/zzQM+s8FEQamSir6ZJC1r/jaQ0hYm+TpcxbfDCKy83x6usFO5rwYp1sgehTabdyZAkaoCXWInt0PfPJZcCsgyQKfsChRppfBYn3jniGyTHr9hkSPQVLw5q4PmVYg1RmmVlRIpomHFfsYcY4eVBFdI9K5NkQuZ7xni6fNxBGitiLxCMoaws3qSu59QFz0aMC2zaRPpHrOTpiX20m+e44hf6+HS3u8fZn1skMc1V0WLBhCGm3FZJ9KLVCK66M5JNTQ+XvaHTo/rxkAlrKfw7wARf34LmugJfwb/7gkNw/MysiXsDMVRuSc8HDyUBivUH4oS2QbKGLiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ufofOd4RdD+hAkxN3bMbmnchhRR8/vaL8abjw4hQWjE=; b=DKUFMKt5CaR+r/lmJR1KbNTLt9sQuGgQ2ThsGqUlnyeDcQaTXFAKnh3BMZ+mJbvtyPrH+JvLGRFKcFWA0Je0I2PDJKnHCAs/7UNUBKtofBoER5iDnmyHmPpedRvCR0Ud+JQorEZy6HVw2KaCsmg5JXLWeJ3FexjPe0RX8UROvc6JTmdI3xhRPmklGdCkZ33hiqf9x4NceJSu0tRmo0mjK5mZpW0yimKI54aYtY+M8MtVsqqORK/GQHwEcePiAFGAm6Ll+1yBOwRyYmiWP12wWsjVIv+VnXk18WQR1FQzYPSYnN7t6bFcXMMVGDX2ZtXf92q53jCnE1anVbj8SqRPkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BYAPR11MB2824.namprd11.prod.outlook.com (2603:10b6:a02:c3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 14:11:46 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2d8b:3e7f:83d7:1e56]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::2d8b:3e7f:83d7:1e56%8]) with mapi id 15.20.5250.018; Tue, 17 May 2022 14:11:45 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "ashishsingha@nvidia.com" , "Wang, Jian J" , "Gao, Liming" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options Thread-Index: AQHYaXkDxvzjqgDaOUGA+N4I7Cw7660jHPRw Date: Tue, 17 May 2022 14:11:45 +0000 Message-ID: References: <3fe4f5fff1141c3576ccf81b5993992c2bee81bb.1652741915.git.ashishsingha@nvidia.com> In-Reply-To: <3fe4f5fff1141c3576ccf81b5993992c2bee81bb.1652741915.git.ashishsingha@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4190fe2-e1f7-438c-3390-08da380f2ce0 x-ms-traffictypediagnostic: BYAPR11MB2824:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PJEf2HfNl1EhgH7B0yubrMlS6Y+fSZ3+/CPoMh+UOvxXJjkMzF6S1uWFhru/2rDb/96gSJp0xs/YTz8rqvLv+KSFKpkVHfj95NIstyxtEdWUOH/Z2kOE2JK6drC4haFr09u1ZS3+cSAwLDKwSJiIluquGO8caZcef5GarpOyVNmGxYVmpAsI6FLBFynAKvhF2wD3/hpDFTzfLwRcgyp6Sku0uPB6CJcLpIbFEm7tI/Q4jVB2Dar6OZ5q2ba+rQXEcTbrhTikb26nEFpwnfm1X8/XWdc1FWUDdcYtS3aX8dNfjujEUw+2oykr6g1CZYQ/nukpdbfhpp+htMyLWUkc1bB/0wRM/+uNUeaPhIvRZK5/91MhpKhpdj7A9aziZliNHnf75uoSetjF1JroWkG31907cC0lJk3Mlu90qVcfTEUHnTf+1UtL21GHjEIMCXdk1F4LYLh+nJpmHBhj0yoKYsakw/R0BYIRglRtKWNhkTJckNFzHtlTpWFt3SAziUfMbinHkqJ9Ouvr4dfDn2UQl2dVq1KBnjnArcoZO83Ajk3XQPrwHeovTphcR7uKSkA87d8/gVGZTLMLhXPVFejJvDI9XW2ZhZmdP7IKFXuI5VCegt+zg7FXkDSDiMAEfVP0vII3OxpEaTqmgzmOBnV6Qi5uWMT4C3lkqnu8hQJGqkWpFfcTK7G9z6B7w9VewnrJqUlXEajtiIpqZi5DQCSCP+EsPkZccZ1PhRPAbXit1ESzWCpynA6dsw5M89j2Zx+TDSh4gNZ3OwviQV+kLAt544hp000VIp+I7j5YCaVVkW6yo1CVQguc7y4jEeFsEHZQsJBo0HPPOgMI8jXf1CQWWA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(53546011)(55016003)(966005)(52536014)(8936002)(33656002)(38100700002)(71200400001)(26005)(2906002)(6506007)(66476007)(66446008)(316002)(8676002)(83380400001)(7696005)(9686003)(6636002)(38070700005)(110136005)(122000001)(82960400001)(86362001)(66946007)(76116006)(64756008)(66556008)(186003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HsibWKVdjT4LRQkO2S9LgPOoq0KxOKHuu2LorovW/5nbB0eLKXRiNfxfcSCv?= =?us-ascii?Q?LQke4UWDiy8y1WTFC+ogq4CfVM1nIS98nrvhTUwupwYCcdlIv53z93oO5Kxm?= =?us-ascii?Q?pzV5P4jvUD2XkVqaFXN8PzEWIt7VzdJerFJEsSffl9QG2C7Z9LbFju6cv/rc?= =?us-ascii?Q?0sLSd+9Iu1F5hayhhJ79R+bb1QgSQhNLa+/ED2FO84lgNjL578AONcwuhvY4?= =?us-ascii?Q?Hf85n8h+a7YqXNAylGTYe2PxF+tB8a2n5k3q4zdeIhGgQGFkx/zA7kvTivvy?= =?us-ascii?Q?J/rdvkwsFEp8qXrgSH+6JS1dE7XBGmgojQ7Tq1wi+P7jJxj2URIkP3WgW1pA?= =?us-ascii?Q?l76srhD42ITQMosPVoJko871wxfhKPkPzRnHcRowV9/7kFWJZNdeijlFtYI5?= =?us-ascii?Q?qSmub9M61cRGJDAXeQ+iBjhIdflH5V8VCTt6LsRHOl7Pj63cJNq2Bs26IeHZ?= =?us-ascii?Q?JnpsXto6xtWfByCrNp3PKdQDy/yAn0+We8wKGgrEgEzC/I/kBqaOfRx0zL3O?= =?us-ascii?Q?5s0vYNx+0CLQQt3Nv3CYe+JOoV2MeFrnJhXALg9jNpPy6xCuhcZyQ2HrjDOF?= =?us-ascii?Q?JF8UZOeuw6gQuvu6VQ74AxrIZLxU1MjUBknaKKhFoZkMKACjrTFC2LawiSJY?= =?us-ascii?Q?bkBr7oxa8a8TbA50+rwB94F45g2QPMvW0e+CR7gQPTDdkgbDOJjrhHI1j4bb?= =?us-ascii?Q?ekuBTbInxEzagnF/fFHg1DQsNF04ESm2W9qy22yCXIKCYVg51MDodopcq8oq?= =?us-ascii?Q?cb9WvSX51ObQIPwuXn8AIEWnI3NW49ngFiL6b+D4Fff172e4JD018ADjr3kO?= =?us-ascii?Q?Ts/MyMTbLHXjUw/cd5tZ2Jzg8eTOYqx9Gvi+32rI6aIvXrM8n27ug6jHT3iX?= =?us-ascii?Q?kH3rV8NZR83z8TNaUgGbvEC+7jGi15R5IRjvefelPRchOG0/MZ6epzacLKue?= =?us-ascii?Q?dF4nf7vMJQ6N8pGGTIKlSBHKt6N/u94XrX8s4lWKsEaT8BZsmmXTsXWNY2uD?= =?us-ascii?Q?sbxG3jAjPxwtNa3ytVevQ1tnPPYGkGu3PHv4P9VvtGvS0SDAeiIDGpvB4GAX?= =?us-ascii?Q?tbTjHwJaUJi8N5dIFtzxqCkOUluYvuYsfUUL4jdvbq2TGNBUVUuKSM393+7V?= =?us-ascii?Q?Z94G0LdXfY1952sojM+VabekbxIsPFL3DwBQFcMZayM8DvuWBy2wzWVlNglI?= =?us-ascii?Q?7VaKLV2D5Phjw6TNgPYa9mT8agQZjAh0xGXN+liPzDGMSjbyzt5u8KzIBkDo?= =?us-ascii?Q?uhxfvFOyMFYgSAY6D2yTCMOrCORrVANuzzzvEGUvRoSZCXR4GNWa9SK0ohbO?= =?us-ascii?Q?wse8lDCb7qojHI3yXMi3iQ4tgARAUefw0eeeGSzSfgd+IxRCpIcl4UvWMj8N?= =?us-ascii?Q?K4Q7GZ1jhv55MKEfwkGBBT1/Wijlu9cjtPwJoxSnXbi5ApqGVmnLQGq5H7CN?= =?us-ascii?Q?mUAVk1EregfZ22ACLjPeoFB/whT5FkF0Po0H/yoMqvsrBirYxz5zaovjp3xE?= =?us-ascii?Q?y0q5nDkJfN23TTQ2AGqpJjmTZ+bBQAuP78hiuxRyqfzpjG7maR1Hyxus5f4b?= =?us-ascii?Q?ZJZ4AyC785BAzYRK8hGLW61KAKwZx9sdeZoi9OvbrWyp3A9UrsMzgDY+6M6C?= =?us-ascii?Q?YFRlw7XcAYaBF/oULfp0c/liUUsZXhTdDLcGgW1s2quZCIqguexdvFL3UGBG?= =?us-ascii?Q?d2Jl4y+n6U6ePmEP6FV6qpMhlmOrKwcNCh3AQXjY/ERZlCqKDXeEKbNFEQHL?= =?us-ascii?Q?GV592nz+Pg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4190fe2-e1f7-438c-3390-08da380f2ce0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 14:11:45.3808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: frudui9hncPp3ts54jlprSfqMCgVn9x0fOIFdoxrwWPcRsJGUvii0hzpYXZywpAQYe3J2key5R2SnZIV5l0dXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2824 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please use the EfiBootManagerSortLoadOptionVariable() to sort the boot opti= ons from PlatformBootManagerLib. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashish Sin= ghal via groups.io > Sent: Tuesday, May 17, 2022 7:02 AM > To: devel@edk2.groups.io; Wang, Jian J ; Gao, Limi= ng ; Gao, Zhichao > ; Ni, Ray > Cc: Ashish Singhal > Subject: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurab= le New Boot Options >=20 > Add a new PCD to be able to configure whether newly detected boot options > are to be added at the beginning of the current boot options list or at > the end. >=20 > Signed-off-by: Ashish Singhal > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 6 +++++- > .../Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 + > MdeModulePkg/MdeModulePkg.dec | 5 +++++ > MdeModulePkg/MdeModulePkg.uni | 4 ++++ > 4 files changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModule= Pkg/Library/UefiBootManagerLib/BmBoot.c > index 962892d38f..8a46100c2a 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > @@ -2435,7 +2435,11 @@ EfiBootManagerRefreshAllBootOption ( > // > for (Index =3D 0; Index < BootOptionCount; Index++) { > if (EfiBootManagerFindLoadOption (&BootOptions[Index], NvBootOptions= , NvBootOptionCount) =3D=3D -1) { > - EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], (UINTN)-= 1); > + if (PcdGetBool (PcdNewBootOptionAtStart)) { > + EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], 0); > + } else { > + EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], (UINTN= )-1); > + } > // > // Try best to add the boot options so continue upon failure. > // > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.i= nf > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > index fe05d5f1cc..46f41a7c63 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -119,3 +119,4 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile = ## CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdDriverHealthConfigureForm = ## SOMETIMES_CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxRepairCount = ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdNewBootOptionAtStart = ## CONSUMES > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index cf79292ec8..9d696f117b 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2146,6 +2146,11 @@ > # @Prompt GHCB Pool Size > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0|UINT64|0x00030008 >=20 > + ## This dynamic PCD holds the flag to tell UEFI boot manager whether t= o add newly detected devices at > + # the end, or at the start of the boot option. > + # @Prompt Add new devices in boot options at start > + gEfiMdeModulePkgTokenSpaceGuid.PcdNewBootOptionAtStart|FALSE|BOOLEAN|0= x00030009 > + > [PcdsDynamicEx] > ## This dynamic PCD enables the default variable setting. > # Its value is the default store ID value. The default value is zero = as Standard default. > diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.un= i > index b070f15ff2..8e68db1c25 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1325,6 +1325,10 @@ >=20 > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_HELP #language en= -US "Used with SEV-ES support to identify > an address range that is not to be encrypted." >=20 > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNewBootOptionAtStart_PROMP= T #language en-US "Add new devices in > boot options at start" > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNewBootOptionAtStart_HELP = #language en-US "Used by UEFI boot > manager to decide whether to place newly detcted devices at start of the = list or end." > + > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT #language = en-US "Guest-Hypervisor Communication > Block (GHCB) Pool Base Size" >=20 > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP #language en= -US "Used with SEV-ES support to identify the > size of the address range that is not to be encrypted." > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20