From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.13932.1671610313787052514 for ; Wed, 21 Dec 2022 00:11:53 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PNA//f1J; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671610313; x=1703146313; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=JdPGWmmyXQiVy30YEnOblFP+82X8xQ3O040V2gd4hHs=; b=PNA//f1JHY1DJns3dlESGF3lsk1oD0V9BSwKT2X+q/IF5mPmEDuZvVJP t06EYTYFkyd9BMsezfC3woNglD0yhoNYSvpdnkx8k36ZT0Ct1S6QSTeMP Wpeo4gg0uFkilYd4IS37iFjogu6mR7DvAf62curhm9H48iI6fyTNvWRle E9KGylTaVsiJCpub9VdjnxrpEXjS6pv2m44wLP1lEYlfy8m3TjHlgFaQY 4LjzuTPEtRfeMTp/b9ZT6XXywNTAENo0yGjxpqfUDxHpIOcBBdMdRMOV0 7PJ5B0n+exD3HI7GafUMdfl2WlTIKnyMpPGn7fkw2IO1h6cjWyNI5dphh A==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="346936763" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="346936763" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:11:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="714735119" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="714735119" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 21 Dec 2022 00:11:38 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 21 Dec 2022 00:11:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 21 Dec 2022 00:11:38 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 21 Dec 2022 00:11:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VoFFP4ipIggRq5FCgr/okj9kYptrTh8PoEz/Vg+U/znAId2so2uvZqyv9L98ajGdt4IeNIi7Im4NOGlVf/jnTeM5RvwVTcakz2Zy8jw64EwWUFwndO9xL3AtNe8TY0YuAzrZV2MFehsolNWr/cf25Z6EvFt6JCYC7QrV+ezx8EAfi7/GHCyNs5pyl7yrgIXruEYL1tETVPSyz90nX20G7h/7orUltIdGwPpEyiefI7DXV82V+J4krLK+eKEVC2EXe8kCkbk7A0lR9zRxrxsWId1RklI5oqcwNDgcq7OXm3eog9Pe/Zh0GGywygntrpBw1WV/YR5RYFe5EH76utUTHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=URsSJAegpbZtXHbqej+qeOWDaraPr3righDRei9dkJs=; b=aMTN1LhBJ0+60ldjno9qiL0MMf+EHd3uorfgEPdpjoChABnPvMkoixMPxVbckdkGYpRPTNLK66YIHqDh7TQ3Mi/VxEdznXlgCtJ4xIx94nX0bTxF1vZlH/a8C2iRGxIFsW/MNNxdlBUfVJ06bO7ME5nfzU+gBYfOtZKiOg1DWVsz0h2tI1CIc8F4284rEeAhAeRsUA/kjJXhFjH1AL0Pj7eLuVUhHlm7/u+ng3fP6FrFY97HQQHCItRmkT4gB2JuFVWzax+sn7ZPelm41ObSkOcHCczFcxHuVwCx6/ZwfU0penrYExo5TS/hO9Ko1Eylg4YwDSMPjzistHiy4HkRqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA1PR11MB6920.namprd11.prod.outlook.com (2603:10b6:806:2bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:11:36 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405%4]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 08:11:36 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Tan, Dun" Subject: Re: [edk2-devel] [Patch V2 0/3] Introduce page table pool mechanism in SMM page table Thread-Topic: [edk2-devel] [Patch V2 0/3] Introduce page table pool mechanism in SMM page table Thread-Index: AQHZFPQFeum7DUc5eUeOmxRrns52aa53/bYA Date: Wed, 21 Dec 2022 08:11:36 +0000 Message-ID: References: <20221221042156.280-1-dun.tan@intel.com> In-Reply-To: <20221221042156.280-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SA1PR11MB6920:EE_ x-ms-office365-filtering-correlation-id: e5eab67e-03cf-41a5-3d45-08dae32afad2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K6H9VPbjPrh4KPoIf3EgRv5IuRahGnQpmvpUxU+HCLqSKmBWhNuTd7pgCFza6NHlmPp0Cm9ykaMjMx4bLoKVxphVKIuGBd/99msjxMhJI+nQH5ECetUdlgiTzECM4n3VATmUholYwK6xLXlBhsW/xSHHiqkSHm2klsKDNBtKHC2wNjtOOwDhxQOlVnx3U7PYltm9ffHuyKJo9aZGfckzdeHeL/ZJxtH3YNPG41HCgkjAMhh7Lb2ebHodnEKSaF7MtIkCkFEXOdif6wlN+o3S7wl2qB69GuqCOXuYibwCPma0ptd2MPqT7I0tAWnHRluV57413t9zhPh2allgQirAazFCGTherrzZflUdqOtDrboTHEPChtJtDkCpXsc8QNHPWiP3tjMq3xHmSyEmLyXFG5H9VJhVyob735nfe2A87cdG/CXFXZNabV/dRveeLdJpKf/RtJox/awh4lbib7l29Do+EKxD4edaPx5X9leYZ88aFbRwzCjdAA/Q7OBShEsAeBrcKE/s+PUF0zfVoWYtblaPISY699AnWHZ5IRx67lDowj0y5CpythfG6wNFGeiQxypEm2zFytpxInTBQL8QKU0E05lX5vay1yBRDtBUd8CHHRFZ4V6nS8NVn4symR/A5KzulqE0Gb8a08ju//I1+vcOmakZTltPT7HdZ+dBhL59oBoi1uodjoOIJJouQULYXx4Gci0Cd4naN89w3w7phYyJs9yulhLm1GoN3UiBVfTqRb4exJvD8+34pPkfJs+NwFRozsHfI7ng9R7J6Q8Klg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199015)(41300700001)(122000001)(82960400001)(8676002)(38070700005)(38100700002)(33656002)(5660300002)(52536014)(2906002)(8936002)(53546011)(83380400001)(7696005)(6506007)(66899015)(66476007)(71200400001)(966005)(478600001)(66556008)(316002)(66446008)(86362001)(66946007)(64756008)(110136005)(6636002)(9686003)(76116006)(186003)(19627235002)(55016003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TaL3s+u2CRZNIqdMcwCn4E5TD1Iln9G15H1QOLRP857UhnxBWaah0xsKrEak?= =?us-ascii?Q?MpQ0oNh0zg53Lu1uQZzZ6THgdS7PStNQ+HmqHDO1DnJvhocVw2QOK8fJLQqF?= =?us-ascii?Q?TD+sbWp9NEC+PiS7h7Sby+adXt3OyqSe5q4rbn2QoPnnPjSjFKpTbEpKqLLo?= =?us-ascii?Q?a6jFYutO3svRI1iJ3AakN9+Ex+OrpzaRlkSN0DhuwRDGfwOsI6foJXvajnk+?= =?us-ascii?Q?WX+vkDIBHdoSRYFs+XWHeD8MyPJkENQk6+CcHZty4OIVjefGZn9i8sfYU2IW?= =?us-ascii?Q?We4KHzAWIYneXerWMY/vWGwqVHxJ9tZSA7yJ1gW12xUwhoaF0AUTSUBwFiW4?= =?us-ascii?Q?eOXQ0JfOIo1fqI6Db20hrDFZY9x7N5HSx4ja0FpsQF620JAVKoPskyam6f1x?= =?us-ascii?Q?nWwmOfRekPoyWSQAoAFovz2y8EVISetfYQatdAOILVtIrsFx0RWSIZ334T46?= =?us-ascii?Q?iaM7XqeIjHmXdTfj4KB7s6PRztr7eS8XMpPw1GuTJiOqK52hHIjzcFzvqFBk?= =?us-ascii?Q?qd6M0g2d3OoCf8m5mXirJd67M0wWfs6MjKqzzV3vrvzs0x5cslEbSq4fq8FH?= =?us-ascii?Q?ikF9A/zINUYBG5baJN+ALUgyTD4UkSgt2W+x16PbI5U8RBekXg/p54pLHv6l?= =?us-ascii?Q?SWL/UqOoR/YEFtZGV+uzQO1FqeN2sgCKjmOBU0z+5ieRHM+HfiZZ6WSg9qjf?= =?us-ascii?Q?HNo/pocE9UoVY+jvCFAbG5KwZ9yu3X1VbMsUi27BLYEsoqkRM5g9wPsnqwbB?= =?us-ascii?Q?7dMdLtsbe7iVJlhct3ILTvs7o237X1qRyNFSqPGMknzdiMpYAIxBD9wFbpkl?= =?us-ascii?Q?a4XNe9cOOj0Mfk2m82et/Zoeci7Bv5ZpI4OVRzOkcOGZySqGu10CU718MJw1?= =?us-ascii?Q?rN6W3qZzFsnHL4XHViEMTHEqoQn52QbZGn2Qia2CbzHlAk2ic8VuvUsR3ORN?= =?us-ascii?Q?jRCuwV9saTYzR7sD0pZ97F+dETPgm8FG5O6pRFebfaweKGYcVtbqC145EwII?= =?us-ascii?Q?nczEQnPoBTyxKzULcftSApHLrlKhMkc5oIvuxJf3GyUdvbkolX1NUeqrRZQp?= =?us-ascii?Q?/NaKAPbvZMiUp4pbetmeEZyng2TawV3hyaHNUR/KDSlXRexHYRCIqtYb6afM?= =?us-ascii?Q?lPmE0WtPfJV5mfYqfuKEj1J6vqeEVE3ciwVHSgcGkH3eFi9N/65V/QpXIlwc?= =?us-ascii?Q?3Hc3ZwGDIRSJhXrGraOVIQer8Hya+Clp63JkOi6oQWYOfn6ICnvzo4sp34nu?= =?us-ascii?Q?xThKYRd0DF5IV/myTHv2awAuCKgjj3U4uCwVeqU/CvNtSt0CySdrpsOApXYs?= =?us-ascii?Q?M/K5D0eS4GrqMIYKS9XumL78y2g5ESrDPshEnk5M9ce0pCuphIKk0Z+tKgXV?= =?us-ascii?Q?Pxy33ODuGJ9S4ePPtBMcFKasfI9+8h1wKqhPvmvP7hRu6L2QlqmeifPAL5sr?= =?us-ascii?Q?pBaHIV0mAGkqp7f/VzMV2N++CIBuA+sERmp8Lw+KuajN01mNwbxNAWfGEae3?= =?us-ascii?Q?DZ1XqoO5X2V/no6hE9Br/fz159RThDCOytDOXK6VRjbRabXOCQYB6FopIwXH?= =?us-ascii?Q?nzqlW4DZ3wRhoTv+JLN9hpSZQkIi0v2r7fzQbplE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5eab67e-03cf-41a5-3d45-08dae32afad2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 08:11:36.1935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7DaeH3LPvzbAWm918/5yrUczEwoVBkc6LgAJIrRj9tR8+sLZQPJUpgGZrYYR+S31KndjIb+07ffUU0EjuVRpZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6920 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Wednesday, December 21, 2022 12:22 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V2 0/3] Introduce page table pool mechanism = in SMM page table >=20 > 1.Introduce page table pool mechanism in SMM page table > In V2 patch, add code to disable CET before disable CR0.WP > 2.Remove unused API in SmmCpuFeaturesLib.h > 3.Simplify the code to set smm page table as RO > In V2 patch, remove unneeded code to align pool address and add some co= mments > when marking whole page table pool as read only. >=20 > Dun Tan (3): > UefiCpuPkg/PiSmmCpuDxeSmm: Introduce page table pool mechanism > UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h > UefiCpuPkg: Simplify the code to set smm page table as RO >=20 > UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 25 ---------------= ---------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 121 ---------------= -------------------------------------------------------------- > -------------------------------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 30 ---------------= --------------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 30 +++++++++++++++= +++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 273 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 169 ---------------= -------------------------------------------------------------- > -------------------------------------------------------------------------= ------------------- > 6 files changed, 303 insertions(+), 345 deletions(-) >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20