From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"Nong, Foster" <foster.nong@intel.com>,
"Albecki, Mateusz" <mateusz.albecki@intel.com>
Cc: "ardb@kernel.org" <ardb@kernel.org>,
Pawel Polawski <ppolawsk@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Wu, Hao A" <hao.a.wu@intel.com>,
Oliver Steffen <osteffen@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Chang, Abner" <abner.chang@hpe.com>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory
Date: Fri, 29 Apr 2022 09:08:47 +0000 [thread overview]
Message-ID: <MWHPR11MB16318DBFD91BFAEFB3E0D6F18CFC9@MWHPR11MB1631.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220429084710.r7qrmtwov5tngzj7@sirius.home.kraxel.org>
>
> Hi,
>
> > > I'd say the risk for regressions is rather low, though, given that it
> > > only affects configurations that would fail PCI resource allocation
> > > today. Or am I missing something?
> > >
> > > In any case, the PCIe spec is clear about this: I/O space is optional,
> > > and we need to incorporate this into the generic code at *some* point.
> > > It makes no sense for every individual platform to keep adding these
> > > hacks.
> > Do you know how Linux handles this?
> > Can Linux allocate resource for PCI(E) devices? How does it deal with the IO type?
>
> Yes. Details depend a bit on the specific configuration, but in general
> linux will try assign io address space to pcie root ports and devices
> plugged into those ports. A failure is not considered fatal though.
An error message and continue?
>
> A more common case than the pci root bridge not supporting io address
> space at all is having more than 16 pcie root ports. Given io bride
> windows are 1k in size and we have 16k total there is simply not enough
> io address space in that case, so some of the root ports stay without
> io and linux is fine with that.
Does it have some certain policy that IO resource for first root bridge should
be satisfied?
>
> > Why changing the MdeModulePkg's IncompatiblePciDevice driver can avoid
> > stalling the patch series?
> > I feel it's enough to just change the OvmfPkg version.
>
> It's not much of a problem for ovmf even without such an update,
> typically the devices used with microvm don't have io bars in the first
> place.
>
> Also note that without this series pcie devices are not supported at all
> on microvm, so not supporting all devices initially wouldn't be a
> regression.
>
> I'll look into it in any case.
The safest way is to change OVMF now.
Add @Nong, Foster and @Albecki, Mateusz for comments.
>
> take care,
> Gerd
>
>
>
>
>
next prev parent reply other threads:[~2022-04-29 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:37 [PATCH v5 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-04-22 7:37 ` [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Gerd Hoffmann
2022-04-25 20:49 ` [edk2-devel] " Ard Biesheuvel
2022-04-27 0:32 ` 回复: " gaoliming
2022-04-27 3:08 ` Ni, Ray
2022-04-29 6:50 ` Gerd Hoffmann
2022-04-29 7:00 ` Ard Biesheuvel
2022-04-29 8:13 ` Ni, Ray
2022-04-29 8:47 ` Gerd Hoffmann
2022-04-29 9:08 ` Ni, Ray [this message]
2022-04-29 9:46 ` Gerd Hoffmann
2022-05-02 10:48 ` Gerd Hoffmann
2022-05-23 11:48 ` Albecki, Mateusz
2022-05-24 6:24 ` Gerd Hoffmann
2022-05-25 18:26 ` Albecki, Mateusz
2022-05-31 16:11 ` Gerd Hoffmann
2022-06-02 10:00 ` Ni, Ray
[not found] ` <16E9A2157ED8983D.16936@groups.io>
2022-04-27 3:13 ` Ni, Ray
2022-04-22 7:37 ` [PATCH v5 2/6] OvmfPkg/FdtPciHostBridgeLib: " Gerd Hoffmann
2022-04-22 15:01 ` Abner Chang
2022-04-22 7:37 ` [PATCH v5 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2022-04-22 7:37 ` [PATCH v5 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2022-04-22 7:37 ` [PATCH v5 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2022-04-22 7:37 ` [PATCH v5 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB16318DBFD91BFAEFB3E0D6F18CFC9@MWHPR11MB1631.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox