From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.8054.1651223331819657001 for ; Fri, 29 Apr 2022 02:08:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=G4u+/ksK; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651223331; x=1682759331; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=du/duAYtuFFKmUPvJgdnNeefAtlwRoSHFZ09xFWUIaE=; b=G4u+/ksKIpOBL/txTzn3KzdnwtWRg5rdoGWeUHTpYLpNhMVTSZD9/FoE cRb6OyE9WB3/cjLVXqVE471UYlrKnR6ATFr2dKC6WDbje+Nytxp+FKD7H CixVT9ZzAiKXK9I8jZjT/NEYNyEzPcqT01qNWZ6SuJqugE1B3WhgtXT9L mjE+4YjbrbZgessK80GXn5dQaBoc4GZhPMebSdebPpKunqm56zxhi/Hj9 lDq59ie/9s2Au0NyfW09NnRpHpeMzOFx1PVsviCj0c4Qqk0CPkZ0bU9zl /uealSM3hz5XHMztGMYtTBpN+mLfqIYMAA5vfUhh3Ft5LH5liFuRCYtnA g==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="264173106" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="264173106" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2022 02:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="534393644" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 29 Apr 2022 02:08:50 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 29 Apr 2022 02:08:50 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 29 Apr 2022 02:08:50 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 29 Apr 2022 02:08:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHzzB9AqxMnDe3KQi2Mn//XNbHBc5RoWocZI0mNQLo2KRlzUMqQZEnMs7sjQUxgkfeLpAb92y3mYuifrTmDRUWRK0IrBzwZVIcq9ApvjxLRCOcvOWYqpDffyGzX6j0ajOr8KTVpSeEXmWRnQmecxR3/71z8ceCphm9LMVc7kPbRy4uG3uVBdiMs1seQYaqAwAf+DgX5P3aPcY+qL51IMSRBvreKILI4QEGMEt0Jt59T6kKOVOndFW3ZxuX9Cb3XKYtQAp0WoXsdJ/Y5IPodiAA6RnCtX1k9V2koaofepEN64LWC7wJBN1MXzWPeJqR4dAd3MnyE5KG4X6/AdGxFoQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C5pwwGxgza/mEKOuiUwSiljx4FipUu71yFn+soPlxMo=; b=BdXzphUubeU6jw/97b5r8zJJ3ZuNQLbrqVL7YCPA8Wzj4bd+0S/wjeZumTqonnocVFjxXhnUkvz0QrvoZn1Vyq7EoghfYb8pULbQNtl6dUtDBs53MVL6oNk165K8+vsFMorx4qvFqOhEYCkh7txFw61lfrwv+mj/BdA6pMEPVSChqylo/xkm9jvyHtupZ9BSyj5WdhaCN6Dfn2qD0KnKRFQLeUmJiBhyuterxvJaCyabP+1gjNVLlnz2ya0ee4P2pYg7pFFSylVM0xH4i5YNJzdjwRf4AvQdpUambrFUrHkBv3RYoabDjHODAltHRSzyZdkwSUr622yqoFYs76QMiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by DS7PR11MB5989.namprd11.prod.outlook.com (2603:10b6:8:70::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 09:08:47 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::ccd3:2b56:48a4:507a]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::ccd3:2b56:48a4:507a%9]) with mapi id 15.20.5186.023; Fri, 29 Apr 2022 09:08:47 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Nong, Foster" , "Albecki, Mateusz" CC: "ardb@kernel.org" , Pawel Polawski , Ard Biesheuvel , "Gao, Liming" , "Wu, Hao A" , Oliver Steffen , Leif Lindholm , "Justen, Jordan L" , "Yao, Jiewen" , "Chang, Abner" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Thread-Topic: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Thread-Index: AQHYVhvU5MdWAOnuDUKwsMDSCCPoXa0BH5sAgAH74QCAA2M1gIAAAraAgAATguCAAApMAIAAAhCQ Date: Fri, 29 Apr 2022 09:08:47 +0000 Message-ID: References: <20220422073713.2087781-1-kraxel@redhat.com> <20220422073713.2087781-2-kraxel@redhat.com> <20220429065047.7ed7xvawzmfdja2h@sirius.home.kraxel.org> <20220429084710.r7qrmtwov5tngzj7@sirius.home.kraxel.org> In-Reply-To: <20220429084710.r7qrmtwov5tngzj7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69afdf0a-68c0-4d67-3ee5-08da29bfde6e x-ms-traffictypediagnostic: DS7PR11MB5989:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uMP8KV7Vc9RTdWo9Q1cM/XucIb+Aick2ZsUDCGNq/vS21WWlwM/w4owroZNP3A+4599m8gMRufJG44z3D/LM7YGgunB8EQhixOv7CW9sFDLjXZ++RkA/AGaFLSRqnmzi0YpWgPAoO/R6yVLpYgg0YA/JWL1BmVTjX/ovAtPkeAm3Q0WHFjJ4cg8YsFPXDdkZ+kEcVXVkpo78mruj6/jIPoNbmTbWhJ/JVw7silXcv9CxgBNeHjBw349lA8DnIuJhchokPZz92Y9YNk35h3lSU9Yi7NXhgVnAo8GURFCFsDUk7rac+KnHxDMgnGp87UJrQ+0hGNK1CfSHqpOQXG9rbS+Hv2CsDe7fNRouPwrKVe6LoOK/7h7GsBLY26rBvykWib4JqR9DiA+gdlfsd7WNkrALpxditQ/5UHUCF/JS0Wj8a9PZIkuKyOqfWNonUujLQJRDHeNHtZ7eYNX/JDz7V+mpfd89KFLSQXWsW6GJaZKcohq1aLd6kXk8ThnbeIhytcE5IGfVijB//j1nXEXqzsmo/TmvynwV2rIkz9GO02fuCklwEzQWHfdinTN/O/hXloJ1KMPkJl9NBFXOWP7QqwPxXotkYtG1JilnW2MXS54UeLycxMNAQ6cL95Xl0SIj60WrHdFX3AiCUNrU7A+nJghKq8eJA39tGr0dKFQ43HtZtKpWc+leTZ8XIsBFcl2heDiPUYCw+mGCmUiCL9De19waCHGPO8wkGIH6D7WKu+KMOVErCoBfYrMMeq6fDB1Sz0vRb6LPWpLNp1eEtxMEK6hCsl2zmXxU9cVtlmicW4ZRI96CQg7pWM8h5IxmZLhnuIWNdTzsQSFhdbIHRVRkAA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7696005)(186003)(66946007)(66556008)(5660300002)(316002)(66476007)(33656002)(2906002)(76116006)(55016003)(52536014)(4326008)(6636002)(8676002)(66446008)(64756008)(83380400001)(8936002)(110136005)(54906003)(71200400001)(107886003)(86362001)(966005)(508600001)(38100700002)(82960400001)(38070700005)(26005)(9686003)(122000001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iYz6S36IyOBK/tXyYI+nlbAJ3qAgz7NfYojn9KYe7G4S0CgcgAohZbGnOaTI?= =?us-ascii?Q?X7dhsXLdXIeSz7LzUd0wbqOeTiJgPLXu7BzIsVPhpqua9sjWjG6DZhM/1uZB?= =?us-ascii?Q?i55yhAQZm3WcJBLe8ll0oebJnx9gSuDFSp2CAcHI3PYoeToHQmXCZZO+qkcV?= =?us-ascii?Q?ZGXGH5IT7MPEQcQnat7dY4RzDIbg4H/M0Se8+lxmkbJijFPcgw0KDkVy0w8l?= =?us-ascii?Q?VY200hggLNzamNo5viAoseib9QOYdWRy5CNBkgeDRtUqPVobFT2fd9RwDv85?= =?us-ascii?Q?s5zToNbm9MwazhkgrCiUdm8B+hO3DzFBVP4SVxpKsEedsBcZg0fvZD1ZeVbC?= =?us-ascii?Q?phiXSkKVSktxFqdNDvfbS/sTWDkNMK8Sas8nqqICkn8TdK+XsVVEOe85X2kN?= =?us-ascii?Q?qzQmeNzrrgSpKZzX3AgiX4c9TwJdMnfkAzzh+/+xAm6pqQa/XOs1UHhlCqKA?= =?us-ascii?Q?lBWFcHEOUWSFFJPD26c3yGlTSXWterwtDJvsljHtY0Qvlnhf9YEbjRrGm8mb?= =?us-ascii?Q?9hutNuxEU7kIKq35aBz/SP81CEa9F3RK3bEIrtUIfawjqFv/38zIusC9yCH2?= =?us-ascii?Q?Guvw0eXhulIU+xKzOPuNPqOjbC2jf8nCPKiHQX8gpPir7YwSe9dToMmANGV1?= =?us-ascii?Q?JNAc0USA0Yt+5FIHRu+FyqzkHRL2fo5lMbY7ypLHo5BDMsrp7uaRDlZbQzH2?= =?us-ascii?Q?zkYiWoGHp7LQDcCBCsHJXkVOEOsv2cc0v9dkeiA4DkC/6Xu1sgKzLybAjPEY?= =?us-ascii?Q?MNZSvHI16aQhxCpNHmmiCQwv3rHV3j1xvgzj+/kdfxjWe3WxVgP0Yk8qoKzQ?= =?us-ascii?Q?Bld0Q1n4AyzcG2jUK85W8n5LVBzSIr2gVTYHzWFFudk0qepwnMPeuDGFVDI8?= =?us-ascii?Q?2kvnOmUawz4vfYxZPRHyLpapDFx9zjwLpLKaGgkqUOlfhoL1tIjMXcy8K/IU?= =?us-ascii?Q?aoE5Wjf9+OGcqN3+Wef69FHnnmm+hEWNEeYeAakCOfNyN2lBA9mbCjVm9rZy?= =?us-ascii?Q?zw2wpM4qaST+rIiB4Z9SXnwOuBkArRD+3IGhRJV11yfgQCfT42bW2EqVB5gz?= =?us-ascii?Q?5HZbjz27k6xdeEeMqSRjIyBkmgqOQ6OsFuFfgzarfq/xv679TGqTFI8QMvbM?= =?us-ascii?Q?eZD2hrhaVyjCMhb4YlfZgOswE91JnmcOofH74jZ4PLY6cWw3SIxqy9hKz4bP?= =?us-ascii?Q?mL9FjkZpzsz0atF96ocN8VSAvD+m83iTQrKFeLcfSdp7Whu2Z/7pVmFPReXF?= =?us-ascii?Q?5knbYrzWbK0V7NyCFfUwB53m3IkzVMNHKHvfwdNIScQvakBt0MPsj2rDoRnS?= =?us-ascii?Q?Cb9kJW9sPR4mBXkamo59uFsGEYkB4dPJSiktk1USPBnSMqCDXIauRXMjiA0b?= =?us-ascii?Q?p1f1B73mSAInbwemUwD9NS5K6kUMnEopAabxth42aCJcv4dcqpIa3uUOY0ck?= =?us-ascii?Q?o3+9XysbCWAyWvPTbG7Jeu/JjC/tKDMLAr/r8UUDQDGofA9/lLx1cHbUeVX/?= =?us-ascii?Q?3Tgnw3rq1+QsT5q2c/leaOWXD9DRZggDIVvJ7TlrYW3GxIMhRPJD05o46QzG?= =?us-ascii?Q?u3/rfAj9tDW8VMjkh4LEgfAlGtKIRrDFHJVo83bBpaHREavLNZ1uj/JhsQmH?= =?us-ascii?Q?vSksl06ZrZuVdoi0jaq7yqAHgtQJYsdISmoEovsN8b0fASOsCjajgGX0qecP?= =?us-ascii?Q?KOnqNXymRfHal57eD86thrMDEbFubxS79K0tL4EWsbELiVCSsIPCxsq9V3WK?= =?us-ascii?Q?NHUhs9BVjg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69afdf0a-68c0-4d67-3ee5-08da29bfde6e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 09:08:47.3449 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5+wYNd81gwtreEO5aVY+q9uRWkBUr7FFSvfZUu6A5GXx2z51mkJNr8I38NqBPk93j3OH+7C8IhUiVaNzIgBgHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB5989 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > Hi, >=20 > > > I'd say the risk for regressions is rather low, though, given that it > > > only affects configurations that would fail PCI resource allocation > > > today. Or am I missing something? > > > > > > In any case, the PCIe spec is clear about this: I/O space is optional= , > > > and we need to incorporate this into the generic code at *some* point= . > > > It makes no sense for every individual platform to keep adding these > > > hacks. > > Do you know how Linux handles this? > > Can Linux allocate resource for PCI(E) devices? How does it deal with t= he IO type? >=20 > Yes. Details depend a bit on the specific configuration, but in general > linux will try assign io address space to pcie root ports and devices > plugged into those ports. A failure is not considered fatal though. An error message and continue?=20 >=20 > A more common case than the pci root bridge not supporting io address > space at all is having more than 16 pcie root ports. Given io bride > windows are 1k in size and we have 16k total there is simply not enough > io address space in that case, so some of the root ports stay without > io and linux is fine with that. Does it have some certain policy that IO resource for first root bridge sho= uld be satisfied? >=20 > > Why changing the MdeModulePkg's IncompatiblePciDevice driver can avoid > > stalling the patch series? > > I feel it's enough to just change the OvmfPkg version. >=20 > It's not much of a problem for ovmf even without such an update, > typically the devices used with microvm don't have io bars in the first > place. >=20 > Also note that without this series pcie devices are not supported at all > on microvm, so not supporting all devices initially wouldn't be a > regression. >=20 > I'll look into it in any case. The safest way is to change OVMF now. Add @Nong, Foster and @Albecki, Mateusz for comments. >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20