From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.7815.1664437663007501645 for ; Thu, 29 Sep 2022 00:47:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=V3KIRgLH; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664437663; x=1695973663; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TT5S/aRPxfNnO3GxgUP4VwhEoxlVbPceuHT1ruRRSFU=; b=V3KIRgLH9Z7J3ydP1arCbaVlVCJ+vFiEawQIMD0UWqHwabja15RPz1zO GCkFuF+9Uq6h9yvh8gQSSA6W8wKLkuK0rj3u6Ef0bPhppiRU8QOGQekwG 8mqqKs8QPzKtllEjRT0MVljnW66oRrvaOiyFg6dV8nArYdru0elPdItAB 5TgZ/ixGmxFQHywAsNaErKoR9eV0xamVkiCb71IlpegE9bsbYSdoiY0ao LTspCU2GHj/DpTVrYxoVcdYwyGIOYyrSVQx+zJZMVSMLih5DpZ8UHxr7i lXZosfL7HzWSlYG5VutQh0HMp3Am0YZM+mIipL4rEroGM/oBGrDJRe86F w==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="300540801" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="300540801" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 00:47:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="653007466" X-IronPort-AV: E=Sophos;i="5.93,354,1654585200"; d="scan'208";a="653007466" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 29 Sep 2022 00:47:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 00:47:33 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 00:47:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 29 Sep 2022 00:47:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 29 Sep 2022 00:47:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aX/qlpu1Zg6JSk4AJhkc1/bVMt3DC9NcbC7qxucSwLrhqzNORECbi2YH0nv8UQxZzP5IFkXf1aSqEJo7qqWI24n4BmaX940O2juqznG2LfiBATEMfpJPh5ZFC7o3w+linU3MUSKuzugO9Xvu+IPMQCAe61RRyFHUjw1qi7LwLh/BsxQIb7GZ+L04AgEUJ9uVIlIRpCVpZ5iz5b/DYoIALXqlum96VJ2neEUMA9H1Ib8sDCl4ErCxQMWOQxPQFni9zgmhitO/NBnh349PHGR2s70+M9fVN8vJ5eFBjI+xcck4ETjXPEFuIBZCfpfNyVGCrUdDcCKc//fVI1uhRYwo8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lDz8LAuST4rtZPR5XTBiCbtPlCS5bOL7L2MSOVMITlI=; b=VsvMmC+vsyDB27cp3/E6qmag6uenwMGxVBmmx/dMA/COP/ybGFKo9KqHhT4Do3lA9H6iHVqB7njiGWpnIB0EiUWpcYXsJjHCXHTAQ921S5wT3eaBqoO1XSBD6kXwe0WoU9mZVpvUijgXzTrbPgzJ0RxkVR+jYF+IpTQm24FnmCUncrcPI9R3OxJlEgzEWQTd774xCWQ4ITvQUE/x+d/jjVMfxu9uuEj6NywDMj/lvGzeThcBV2/nf/8D90Es6Fds8q9e3X//QlKHHHylsLZkhMDWO+cicwiRFyqt4iZSmv6z5qWiTmZ5+u1BV6fURwVj5aLcXrU/b/YpAYmGqr4luw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SA1PR11MB6783.namprd11.prod.outlook.com (2603:10b6:806:25f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 29 Sep 2022 07:47:31 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 07:47:31 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "sunilvl@ventanamicro.com" CC: "abner.chang@amd.com" , "Kinney, Michael D" , lichao , "Kirkendall, Garrett" , "Grimes, Paul" , "He, Jiangang" , "Attar, AbdulLateef (Abdul Lateef)" , Leif Lindholm , Andrew Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Topic: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Index: AdjPX4ZZG0rDXS4WTdOIWvoiYOLYcgC9rttQAC2dmIAAMr8a8A== Date: Thu, 29 Sep 2022 07:47:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SA1PR11MB6783:EE_ x-ms-office365-filtering-correlation-id: ae4039b0-7715-4052-fa21-08daa1eedd1e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3c2dIecoPt0rwUAxzzEgFlJ8aX9/0MeWR7QPh9r7fJzrQJ+YjMJtC66jhoZomIEQ8qrf287pBWO+ssfw9HcnKmUJdJh/i1WxOZsi7ILIr8fyf+oHSeYjeW1iJsk3z/hKgvtl4oeshQSNgswJtE0uTdLYXkd+d/T4Wl3Zo68qcP7EEszP9kYQoG2AzaK/hFvicdJgCGfJOsKDzt2kx/tOj83WM9pbQGPZ07smEwN8RRK1n46cZ5+FdXpGjosdvDfWcMmg9jZWI2QLkFVhyZN9IfeO7ac1OjXlqNqy8pPLSEzu1Yfa16v+G6E3mCE27V6fRKhCJDGGmKwNEs1wicJ1fNFRaR8ClFcOYPU5KSM28nZd+mLUJCtcpZExHFiWEwmlX7debeENpFNhOSqBkMV6TqBxbONCqE9aYyfJSCaVdmRrPDhLZRK2sTZOAtls+A5g6+HnYG7KeIOlscdVNjM8vrbTvSVp1QEbExQh2QHOqXEWrMwaXT4JHWfiK7T8mvejRf+3xp6T4tVi2vtgVWxZGldS2bmDFRehV3KgWVPh+66yMHDYvsv+lF2vXt+lW0rUf6OeJIQjDGNrU+nuDjwmpvYql/GHMjkUlBohSexnlAog8Y40EXl22dgbl49UwMp0CaW25RfobwkD89TiU5+nMxR5YS7w3XTnQePdsws7Nxv65DzsB64kOv9Mx4f7ul8Qpw5rjI9v0EExop4HIw7rgglTITbbFuCb9tQeUatU46tmEQKEwyT2oODePrGhhHSGyfCCMFloSUqyJ9M1ZLCxfWLqKCRchLRxTlMrZWv5sYCW+yI2F1SUyj2bMBFXz99hREzhaR4/l7GkQKjoclEzFg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199015)(66899015)(71200400001)(478600001)(966005)(186003)(54906003)(110136005)(33656002)(6506007)(122000001)(5660300002)(38070700005)(7416002)(2906002)(7696005)(66946007)(66476007)(66446008)(66556008)(8676002)(64756008)(4326008)(76116006)(316002)(26005)(9686003)(53546011)(52536014)(8936002)(55016003)(82960400001)(41300700001)(83380400001)(86362001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qnr8W378oePxs1kc9z1irT1sINby2sQegd/Z4mz5rvcKIcF5ax9c6l9oZFxn?= =?us-ascii?Q?dqpFx/RLzTt5p+zqVJMBSZrALURmiMPl2OQlwDa0FQzy3gUYcUb8MGQ4+Yph?= =?us-ascii?Q?26Tm9EbpUlp6UC6SZtwPLob5IAv/tRUkfFZrsilpKhhdB9SWhM4n+Ne4Udck?= =?us-ascii?Q?SiBOCEb3knJM/uo7vIM3zxd7cVK3TAxJTbR54dJbwqzMVoAYX8OpP9TpKcun?= =?us-ascii?Q?mOuaQwSUTIXMOTLRMS0040Rk0yvZyEVb5Cqgbw2zX9pQm6/9N31rVpbelGY6?= =?us-ascii?Q?K3w2VT39YYVASytk7p9OQPEXGkoU0qVpZPApFJ0Dgcp6fNOO3tUIoHoaeDpi?= =?us-ascii?Q?gHla6k0hjCH5zKwLuGHnR9Nwy7n3F6SydCmOBd/2vzUAnJYDNx0vOgwbzurK?= =?us-ascii?Q?nMfuhunIcjglkri9aDNQ69X0sYLj5Am+2GvXdscZ6X34nfUxkhM1Hk9iYClG?= =?us-ascii?Q?++gOiC14Zkst34I4oATiHq5q1gupCO7Z/YTmkp0GsvCxB8SDNCwh+4rYQ2Gd?= =?us-ascii?Q?FvCn4ybf9F6wcsId4bSnp2DRldzR+AT4lM33urOttkF8nBMBiJCO0GliML89?= =?us-ascii?Q?Om6kxD1l+tdZqjGMxCKk/ol01M3ElTe4hU9dAQzZJY+Ny8HB9jnrrC1VG8xN?= =?us-ascii?Q?vg/llCYiV+ps9sy5tkWwBCVEg++3SIEasyWSe/qn90fcaxrS3kVRt0+G5Xv7?= =?us-ascii?Q?W5qNIZo8Zpa7qYmNKnPFhc0doZ/zQwkIO42DFI+3kSKqsGtYUbCT06oKoWkB?= =?us-ascii?Q?6Qq2cx26wPQTLhfSRyIZ0JRRQpUS6Uybh9bfn6eRj2tTqzJfk6S3Pdk7DU+e?= =?us-ascii?Q?rRxr4+ei/rQlkOcDjPwEgwAffeTi7zKCcNokIge9vApIrF4TNzuyWN5mLM8f?= =?us-ascii?Q?VNrhPGwsLPqPI4HSRRx0ijjm94UHQ9KUcu1EzeuqrO3C9/fDZgcgcL+LwUpD?= =?us-ascii?Q?4gxsUUrVY4jSQrMRvHN6FLQkCB10a81xGwe4I6pBXhsz7/TnTLSuvoyxz36z?= =?us-ascii?Q?G+zh4VrfUW9vK6psCyuV7j5BmMyWj5EEsxE/Wvme2d5vjXrDQvav/yRSiBnU?= =?us-ascii?Q?i+4pkuwxERPPYgTZhw/EGAESCklOFotrgDCNOFSaso75VTEOGBKRyIP43ywN?= =?us-ascii?Q?tHTSQY2aHUI8/O3e14JRyxarEgAo6MzOP8DJa7rwsk8wca0asPUE1dlL5LBt?= =?us-ascii?Q?vKGrSJAHkmVdV7xqj6pb1ghwEvDXGJvpChYBr7gVuowCZ7BB9L5alELDMv03?= =?us-ascii?Q?tIZy+N1vJRMN9jRCg0rOEf9LJ/nMX5zj+eb3GCAzcrzEyzK3Wd5UtW3g9wfd?= =?us-ascii?Q?zhEbmbwzNf791Ok6iVJYvsqrwqWWGnPNwyleVSv2vS5bKjYHXzPCt4rTLTpz?= =?us-ascii?Q?9QIJUhVrznXDq9tDzWDz51w+/dbtIEVkEtTY50wxh9sjz76puW/J8Ju3Mtgi?= =?us-ascii?Q?LgfndsIYF8Gr3XHUtNv75Np20tUGKO+d1Ibzzu6PVkrvePxprFlzW9w0s//u?= =?us-ascii?Q?3s68GfSnPPPtp/OoqvC+/PEHmWzfbUCwi2XsuueeOA/GKTQzfzFx7/A76j4G?= =?us-ascii?Q?V7bMhEMBEs5k7DBSwYE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae4039b0-7715-4052-fa21-08daa1eedd1e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 07:47:31.0117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N1rqSbE+Yv7lY+cXOLSJLLRFD+k+8FeBIgGGpU0b19jb2cp2DLVz/qZFhJOzyVRprxF1FJVoe/iFO7eanNX64g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6783 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sunil, I don't have concern with your changes. Perhaps you can also move all existing source files to X86 folder. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Wednesday, September 28, 2022 3:34 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: abner.chang@amd.com; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction fo= r > archs >=20 > On Wed, Sep 28, 2022 at 03:33:45AM +0000, Ni, Ray wrote: > Hi Ray, > > > > 1. When a new arch's implementation is introduced to the existing > module which was developed for the specific arch: > > > > 1. The folder reconstruction: > > > > * Create arch folder for the existing arch implementation > > [Ray] Do you move existing arch implementation to that arch folder? It = will > break existing platforms a lot. > > > > * Create the arch folder for the new introduced arch > > [Ray] I agree. But if we don't create arch folder for existing arch > implementation, the pkg layout will be a mess. > > > > [Ray] Hard for me to understand all the principles here. Maybe we revie= w > existing code including to-be-upstreamed code and decide how to go. > > >=20 > Could you please take a look below changes which is trying to add RISC-V > support for CpuDxe? > https://github.com/tianocore/edk2- > staging/commit/bba1a11be47dd091734e185afbed73ea75708749 > https://github.com/tianocore/edk2- > staging/commit/7fccf92a97a6d0618a20f10622220e78b3687906 >=20 > What do you suggest with above example? >=20 > 1) Common INF for all architectures - but modify INF alone, no X86 > folder creation. >=20 > This is what I have done in the commit above. May be of least impact to > existing code > since it is only INF change. But like you mentioned this is bit weird tha= t X86 > files will > remain in root folder directly along with some common files. >=20 > 2) Common INF (CpuDxe.inf) + create arch folders X86, X64, IA32, RiscV64 = etc >=20 > IMO, this is probably the best approach. What would be the challenges > with this? >=20 > 3) Separate INF for arch like CpuDxe.inf for x86, CpuDxeRiscV64.inf for > RISC-V. >=20 > This again probably is not a good idea. >=20 > 4) If the module/library is specific to one arch (ex: SMM(X86), > SBI(RISC-V)), then create separate INF. >=20 > Thanks! > Sunil >=20 >=20 >=20 >=20 >=20