From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.4551.1664343814570851681 for ; Tue, 27 Sep 2022 22:43:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZVHQGHu3; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664343814; x=1695879814; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=POBNh6lATWpc4ixZnz80xzgYhYA2GtPBMRJC4ehaMJU=; b=ZVHQGHu31U5yKk6KYbVOBapki3WhvLOR2LA4rUDhoJ6RMhB4c0nUHx6a TJrBnXhYBZ/PncQ3mP8PSRCtiXo3xBGvgy4mU7sFm8t65W6bFRjIbW2gA mD5IhgnTv0qsrRGGAKwn2z16XPqR9CHSMoO3bi7QqsqSJpSZHmsMJcQL8 O4k0tm21nLdvhI66v1m/83r+eRDN9nbShWxbqzkkLHSymHFmtxXZ44iuN JJf3VaFCe5q+g0UzjxnY0e2UNQ9Eel8qJYmqtOFM0PlEFZ1iIvjVc1MEh lskR8pDXY+ipLkDj+f8zCeL2w1F/pZfuVd0y4NhePXzH0Agj12KAwK8gj g==; X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="281881746" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="281881746" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 22:43:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10483"; a="654996453" X-IronPort-AV: E=Sophos;i="5.93,351,1654585200"; d="scan'208";a="654996453" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 27 Sep 2022 22:43:34 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 22:43:33 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 22:43:33 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 22:43:33 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 22:43:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSM3NJ+vKMrpZFP4a6pBRZrrKa1Bqy2UQakis2DHRR7t/SJLFu4PE5/oU65Ghg1iWRou3NtusvlkbT/xX2O7fWLG7WVG+Yc4Be/ciiYMyOMxKYTrcsaS4ECGtvwWligeG4V9H+imN/Jz0rvHwVNwzB783FZpuMS+25SrYex6797vWVmaQ6OWsXpLN0kDlZQ6P6SMDvSMxUFzPkPSin1AhD8v3edJJ385hdS3elWWAAPfVs8XGq7GXU6epGRWoCTOle5wI7BV9QGyCoMkVvupINAg1rzN2Qeq2BgGNyT+M3n2T+6M4jqrDd30PUEVOihN0MeuAJImSGQ+dy97CgJTmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6z9NpwjBSr7MDQP4oK7xZt7wniHG2EFPZ7CQAOmTdnw=; b=lOmNFhlmeb20G6cX7bE1EvEgCheyyMopqELWPI9gKB6tu4GM33d4cuODU8pAUn23MMLKnYy0eG8HIpAO+vv0VXXIQS8LvIU9SRvVDdbXeWTUiurzYV52cQw0dOZsag8yQvcmM5rOziw+f871UZg1/M5O1+dfpPRnn/4M25WqkB7tR5nID6y83eOcT7GEac5YeSI7aPWxo9R8rCjhJ1KhB2+b41LIG1d+qKo+MyCxr2YnXXefVU9vc3vZ4NzfwSLJWztdXzD9mKaXKja4gzXKbPe35a2StqU7shj17XR/JGzOqSEV6iOhjSXA34G4UhLx94BlSFtvRoDb6gCMQ5GhnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.27; Wed, 28 Sep 2022 05:43:26 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5676.017; Wed, 28 Sep 2022 05:43:26 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack Thread-Topic: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack Thread-Index: AQHY0t0GvJ6qwzSDNkKhF0GZjvozgK30VOIA Date: Wed, 28 Sep 2022 05:43:25 +0000 Message-ID: References: <20220928015157.1647-1-dun.tan@intel.com> In-Reply-To: <20220928015157.1647-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|MW3PR11MB4570:EE_ x-ms-office365-filtering-correlation-id: 240f986b-3389-43ed-141e-08daa1145d27 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AznJjnf7LEPQemdmftmV5JkWRy38hwYgNwA3/Riuu05Rvfem7xUd4uB+gmCR+MIV5tTvB5ccha/dojX4xHjkoE8w3tpi3UGaR0X4bNSSzxDeCb5cZXC+enhO/CjvZG5+sQSgCC8gL8I3yLcToDrg8v2sSKCUC5ejDfqZnMtXvLUw5YIUyjZKaU5aQZkp+JQaFcZ4xmacRgjZ1dxHQgiUCd9oqkmexlna2IZ0F5Qyze+1SBawNNVrtNYyASnGeiQpSG1x516eZz4PFw8/VOlFTe8hOuYxvGlTUsEfhQ/sVp/Rw1mDPO0hvZg/1oh0yE8EQOFByk7PG7D0Im21Y6Yu6NentT2ikci9MQpbmcAL/orEjydAZCf+WqNoUIdhQYNCN74X/X5HH4eFYlLMKhE3nJemUi+5Ks2Ip10WtSXxZ1FvZE7TFzq6xrlpChcWMWciIr9zIhcLdJLLQzPBOd9hsuK0/306DW9k6NcZtPLQIxbnvE73+nx0LhYXrpW9vO4c8H3l1mQqaqTAx+R1ZFYL4L2vOgy1aNLvsymaj3k0RtVw9wJFSKEzgZkHMf5fOUNO76lgdzjxoWQLbB03REskA/G0Rzxwcu/U137uGFUnuRZN6IyVit2fVf1KMFwsIhCNbjT9PSsBm7LZOKzckpxoRA1RL+4pBAzah0QtomMOg0nsCVIBxcv/lVv8U4YPoItUwEGkvqXVS3ax6vu37AaNak+EbDvVaw+YrlvtcVc44O3rL5+6VrGkWA4doaGexRkxGgXLM/G7pPkDhQHGrYXfk6gLxXvXPpjS0v/6s3ZmGnI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(33656002)(82960400001)(38100700002)(2906002)(110136005)(86362001)(55016003)(54906003)(38070700005)(9686003)(7696005)(6506007)(316002)(122000001)(107886003)(53546011)(26005)(41300700001)(66446008)(8936002)(478600001)(76116006)(71200400001)(66476007)(66946007)(64756008)(66556008)(4326008)(5660300002)(186003)(52536014)(83380400001)(8676002)(135533001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gkxWY/tQ5YovwRst5P0d3x423znkjVYWXMYabAdUcMayMjjZJRmUgsoVHgai?= =?us-ascii?Q?qNZpggZltQXe+vMoibGEEjN88aFpWyOyEDHTglWk+vMRb4e+jwdPs9g0OXDk?= =?us-ascii?Q?72X33Hp3AYo99TSTb0uP19P8LF2eyCIR0oe5PpTeCxczWF/gicyvixfpJbIG?= =?us-ascii?Q?u/q2SoFxPEDT/+YSKqtb/dGp1bBwApFM3Rfhwxd7MfNrCFadOdJJzd8Sl9Zg?= =?us-ascii?Q?VgMspyQj/f9p+rOuK3O7JUNBrFs32iy4AponAcXz6haxTZ/Oyi8TZGxLbjKl?= =?us-ascii?Q?jC9MSfphbGj9V1Sme/WvjWKXki/6ug7/im0xZub7wrC0iNjWwYM6w/9UPghx?= =?us-ascii?Q?Aj1i7TQ3qsT7xW/uI4DzFJQgXgV4m8DEb2BVRu4528vQkjgzOnY3wFyGUEPl?= =?us-ascii?Q?kaZtKpgVn9ZWJtKTpfftRzMryyaCzRVWZLHLeCByb/cbajAISliFzzFjl3tE?= =?us-ascii?Q?jz33x/47vJrdjqkGgCPh6zsbmlFf0ZJPPIfUgP2RqPMen6w24RxImc1Ye4AG?= =?us-ascii?Q?MkkwY5lSYvnE2kG2Y/DT0iu/9A04LTPhsrITgxp7J2qPgTS+Geqxm/e3ffet?= =?us-ascii?Q?9egUNZbXfHdWz2/nLf6jw+olDth40OnJVh+X/9PRnFHfQxZnzeo0vw8nOxcB?= =?us-ascii?Q?kTL4J+zTQWtPxREkPkA7d8FPhBJCwFIhERxCJHmvRFw761nyDI4lbksMPjPh?= =?us-ascii?Q?MDk85+bAPf/WveU+ydFSBtyqPAOS5tkdQu4OJH0U+JDdmdLndEmasVYXfXRL?= =?us-ascii?Q?cOuE5tnZSmh43madU9HGOtKlAdRUKebluts3q20SnN33UfOkftF9k6H5acXz?= =?us-ascii?Q?52EzUQYMXcdpUxIS4fUSEanzs3iwLMC6r1g2d02ggAuz3gbOKcBWF/fNs8pv?= =?us-ascii?Q?PyWPmOTAeUX+2Bwylfl9k6OJhnRaz4mfJxPqeTG8m4GhB8SbSw3YyuV5yHLO?= =?us-ascii?Q?x/sCEmwA335U/xHBB/5f8ivN382jbcq2Q6TjQRrqu3uzXyGKAUVT0+LKcOZa?= =?us-ascii?Q?mUmCEMekO0pPrhl4/CUhLOBN4wKtHYJ9XObGSxhoF6zhpikVeWogILu/xWRz?= =?us-ascii?Q?mTDvtRlGndQ8Q16fkb7i89ksnrMm8hu2Ar04hEeh/SMe0rdJx0YF+sSG6HGg?= =?us-ascii?Q?5ljWy6gRi/6hh7+OJxAB2am0Uc56bKe68/fWFtiNUI0+ZLBf+wtKGmaHq+4K?= =?us-ascii?Q?ZkyXCwjAKQwAd2AIJYPB1VxEOJsHuRb0xWQCswiA1HsRPcaQQiTjyMRAfJVt?= =?us-ascii?Q?EImKRIdSZ2MbCodU5lQ7guscxIc11HU+k9MQTOIzd5H/ztU7VcENM0/IoPgD?= =?us-ascii?Q?8YNlxcOTKoniegfvNOfJwhziWKl0bdYD3QxAXKEZBdEtbHWGpe4HpbE7FcAH?= =?us-ascii?Q?k/1yfhcqKU4jRRsNih3v+BkToIjkijJBxDZ1XH4BMc9pX67892pop66EVOpl?= =?us-ascii?Q?6SVF3kXiwWsJLqGg1icd+Ql7mveTNBrIEsZJaJoZY21FsyZZrcd6f2ry8kyg?= =?us-ascii?Q?XlYzgxYLnYxj0a0rBnwXnGAEFkroXEY+6Au/NCClLGkWlUWZ/LMo7irVgPic?= =?us-ascii?Q?Ifzcia5Kv/PMJCdFQvc9xDYgkZ8wSLWFtXg1nxuz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 240f986b-3389-43ed-141e-08daa1145d27 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 05:43:26.0450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XY9pNr4mQ9fQmNhBtoSxZJvmuye8cwNmI2BterLHQy4UC8vGVbn03L2ckQFVqcVYw/txo2VGN5fUrL+6AlstTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4570 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, September 28, 2022 9:52 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R > Subject: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to > allow bigger stack >=20 > This commit is a code optimization to allow bigger seperate stack size in > ArchSetupExceptionStack. In previous code logic, CPU_STACK_ALIGNMENT > bytes > will be wasted if StackTop is already CPU_STACK_ALIGNMENT aligned. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > --- > UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | > 2 +- > UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c | > 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler. > c > index 8c398ebc5b..c8fa30a32f 100644 > --- > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c > +++ > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler. > c > @@ -215,7 +215,7 @@ ArchSetupExceptionStack ( > // Fixup exception task descriptor and task-state segment > // > AsmGetTssTemplateMap (&TemplateMap); > - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; > + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; > StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); > IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; > for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; > ++Index) { > diff --git > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c > index 80e9f08e5b..74b2193cb0 100644 > --- > a/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c > +++ > b/UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c > @@ -223,7 +223,7 @@ ArchSetupExceptionStack ( > // Fixup exception task descriptor and task-state segment > // > ZeroMem (Tss, sizeof (*Tss)); > - StackTop =3D StackTop - CPU_STACK_ALIGNMENT; > + StackTop =3D StackTop - CPU_STACK_ALIGNMENT + 1; > StackTop =3D (UINTN)ALIGN_POINTER (StackTop, CPU_STACK_ALIGNMENT); > IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)Idtr.Base; > for (Index =3D 0; Index < CPU_STACK_SWITCH_EXCEPTION_NUMBER; > ++Index) { > -- > 2.31.1.windows.1