From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.46190.1671526474454933207 for ; Tue, 20 Dec 2022 00:54:34 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=heQYmXID; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671526474; x=1703062474; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SUNj1ZJoC++Us2ldadwsGcQVpLqWjwuLDSOECA1bXqo=; b=heQYmXIDQ88y4CUR8er+MyorkDN3nBndzOz6b7FE4H7LiEMrVo19o7n9 8xv198ilr0f3Zcm5B5+G0qR3nx33OmYcskjfjio1bsK9E9yfX9Ztg55xC Ovasr53EWQ2VKfDXAAUnVY3KPu77uJKLhww72ouNmRJz7DTftJmz6K1/X cODdxTEDJsoBCPGlVsYeEu9a7da/0F8PUgEEKAF9HH4gt73CagIeI5ZnI gq/skDZES4TKa4398e/HzVsdgD/rSuFqI+byYZ9wQiMf+8Ymz0Gp0etNY JqwMpQX/2ejgjDjbjl+apqsDWogLVVYNuEd+BedIyufwPjXLGiO/Gleet g==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="320742194" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="320742194" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 00:54:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="825151883" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="825151883" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2022 00:54:34 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 20 Dec 2022 00:54:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 20 Dec 2022 00:54:33 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 20 Dec 2022 00:54:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EFAsde3o/uLhCI0u3gPSreGgnXCTqvZn+RP2e/e2b0HZy4CIbKqxKT3oG0rKrgoBP/ZxW/BwsrtrGZWXfgGHUUTvLTpY6wRG8/w6IJrTJhRrHkLEcupoo159wLtWqvG1oG/pLxONN9G2gWo1ZNbGCTKjVBePdQVPAIraw1lYnyqATmUGhvHKqTqfITfq034TsLgf4AhPmtnfSJHZXon0dgXAYVrQ5MkiM4xooYtbo5UqGtsejunvp1QVm1Qcw0nrfb2/+sCy7WttjAi5vzl2Mjsos8dMOi7Gveya2WgK0kyKMSI5fSsQ7sDf+fUqXjjQs+xLFPpXFrRKt6Jfi2bTsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VfiRgsaH9RUdEOdCu6R6EXqJiIxD6mIXwt4yDhlYK64=; b=QO3i7Ad8UmusaDXE0J3/TqM/wR8VMqixQBb39w2BWACtX4Jp1YZfhttU0Vw2OhI6YfBva6thiGoTKBIlA1v7JWShFBQyltcE9dEgZHsp6VTSz/nB65UL5UyyWrD6CUDFkQdyFZtsloccgO8/DWbbA3G6b/z9KJTKOWApPwc8Iianz+b8fD4rlIDXxiB7KVzSuuRDB+SDXMN4GHx94wI6x1ymSptXq/BMFlhXChN/qlUiYT5xai5W8wvggwwdullywVWAB8Wck4sHsYZVhRJ1rUy4hblkxah4woLQrZFowQRMYgLItMZ24A8MOUpZVE4raSPeg4qsaR4/b0CP/6D6LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by SJ0PR11MB5614.namprd11.prod.outlook.com (2603:10b6:a03:300::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Tue, 20 Dec 2022 08:54:31 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405%4]) with mapi id 15.20.5924.016; Tue, 20 Dec 2022 08:54:31 +0000 From: "Ni, Ray" To: "Guo, Gua" , "Liu, KasimX" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" Subject: Re: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Topic: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD Thread-Index: AQHZE30YlYP1JP3WJkGp2s1rF+kDNq5009QwgAErHACAAHtcEA== Date: Tue, 20 Dec 2022 08:54:31 +0000 Message-ID: References: <20221219073944.3142-1-kasimx.liu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|SJ0PR11MB5614:EE_ x-ms-office365-filtering-correlation-id: 7fd084dc-bbdf-49bc-70e6-08dae267cf24 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mTtzZPkhX+hsqH3tmqyf6sp0nESo73dPzABd0U2VxhQDF7ykPzkK0AtvjNAvBSXiy3zb8jUg6ZeBCDk2OsUa+TPW/shMmgES5yg1n7oaJulDfk2uVyTFw1KAv1osefqpQPZDMraLDAHBoYbHSe0pCVcY6dYnWisehsgCtujYv7ET54x4VujEPq4Qtkw9EgwVJn2iPTC5Yubkb41T6pODR/LDSDHS7sPBeiuUH1RTnMI3TiIUjWt/vyaIWVeU5ZxDxLUadusW8Lmepf1nlRBRYuFGAJTZyozwNHAFJPRKwcYOn/0lnkC4s3kzdPy/mn5LmituuRo+D35tmxooSaIfhCiZAeQu6Ls+WVfJA4F+QxcW+NYVbOM8jh8K5L3IhBT/t/RCcryPgleSZAGXPSkTcdbYZgQOJxz48M3mfIOeMK7le9gxF1IW1yL9F2Kb3zYW62wZYtxYA3/asre5+1ItTCUZYF1ywD8rcegiIhvY2jLrowRWcOeNb17+PIJMr9sKxlJzSdy93u2Y5Hk9R3qzlKTGC2Mu+pIUE75YBZRFN/B/hIFDEH1A2HmDKhJZNiOeDM3MFu8mzemUrE4PD+zUG4jGgpe9XcZC95z3kiwEzwemJMrGoDWHX4DBE4VF5lgPHa6NFC3JHpTvg1LiZiddklnO9fcoYaOuQJ2PWwhFFsMQ9pZ7NmZCb2qTj/YzArNBZAFiAqKGzHlOMpt7xkO9RpTsuiH+BjU4x4SgN2reGDU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199015)(110136005)(82960400001)(54906003)(122000001)(55016003)(966005)(38100700002)(478600001)(2906002)(316002)(5660300002)(8936002)(66946007)(86362001)(4326008)(66556008)(66476007)(66446008)(76116006)(64756008)(8676002)(52536014)(83380400001)(38070700005)(26005)(71200400001)(41300700001)(53546011)(33656002)(7696005)(6506007)(107886003)(9686003)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?he5svx331YjMMMDI6ym1AoI9Y7eP42lxlD4OYmOQyX6WiaokVbywUpDYdlHF?= =?us-ascii?Q?aq41sYGIbX5bBOF1oCIrp9YYyTMrJRdfrPrgnbu8Zj9X3XobMDpd4bxbiiMt?= =?us-ascii?Q?pbwnfvtpOW3jMRT3ggyQOS9LwJBxesuln1nedlygwki98TCIR41+Bel2nZvY?= =?us-ascii?Q?JkJ3PTGApzFJMozLvh7JCfQcRHZbU1UuemApbPTiNgVnZqiiqNHoQj0ET6CI?= =?us-ascii?Q?S7Gc2ukhMWbFWep6x+DooAo9CIA0R/nbZ/Q8gpxnIiF9uzJzxvBPUrPu8+bg?= =?us-ascii?Q?vimbQuoZmPbXN8oMjxoQpic/8YViI8ca29uS1i4pFv5GIZLEZverHQMy1I0S?= =?us-ascii?Q?HBlnpLIpZMEYhsfZuyiAOtiMywfbornLcgG6IG4iBAhZ4T99qAw3FOEby4t4?= =?us-ascii?Q?O/dQ5p9YKvEOOY1DyJ9fHcmKuZ+awgmaBW9cWPoC3A2sunNhFP/DeHk03BnR?= =?us-ascii?Q?l/asb6La/FcDFuUdiGjXQMCAu8Zj74NT0lK0CqiN2IMMZK1hlDqqmO7Szhzk?= =?us-ascii?Q?m9qXuK2F8XXBWRynPOD4K2djoJouAoEt6rXZHj9772tzanzBVqPABmtctZos?= =?us-ascii?Q?Y73KeHjw0vyFDuVWapEXkaiHYMTD4FAOczg+PFIIoPxNqaQCLuuxfM3bMEqb?= =?us-ascii?Q?7li2o5CAGTQdaI3uuX17HmnxOHXF7LT3n+ZIPO55DvtT3Eqo5GR9+GEzYUe2?= =?us-ascii?Q?2U20KT2rw7vO2Tfp3YXojAv1Obv2hNij0WvKpbkGjKCZMID55MtoStB8cdBF?= =?us-ascii?Q?2AIIBDZckQJ7U9ZO8sjA47Uz1ARPtrKJ4InCjri0x+ErUWOybWicauVEJ8OW?= =?us-ascii?Q?3frVtYQzSwQnv4+rKA6iGdFjolCE9dyLo0p7mDZwUPhi59yMAPX/y5CbSIqQ?= =?us-ascii?Q?xFO3PE7LO5I1G/OlPFGXbDO8pePuX0lu4Xa4myW5L/QPFC/eAE47hbNO5S+f?= =?us-ascii?Q?7khJb2su8qmZLEmzGL0edKPzFvJVfRvFHzUsXMeVJX5GyP95z0GSrif9E7bp?= =?us-ascii?Q?o6pVyC+oM4fQgxQfJe4NCxxNzYm5riRbQJyGyvTzNW8tfSN5Vs/yVQbgOjmR?= =?us-ascii?Q?BeAf6VR3QK099qoHIO2/T5K/Idbwt5Tr82VXcD3p4DS+ts9Y+NvsSbGKWP1h?= =?us-ascii?Q?oVHwHVE7xu4nX+DcWcC4hBfgygyq0lHWTmWhHUGltmoQmn3U7sJUtFb90NJZ?= =?us-ascii?Q?J5k2dYR4n2Yg3FIhGnPTDW/j3s25Q8SERMVmaeIfjbM/3bZ6fzczRyNLd20I?= =?us-ascii?Q?FzHBg50IoLRCEx6a1tjczv/W/4kwkJnCK7XCUNfN6szhWYrnxpGcQu5p99kl?= =?us-ascii?Q?wZlgRKS0EJUNxgQTU1QHIbXrF64tWyfy1JfNlTh/xpEgrLhGV3w5jW960cRA?= =?us-ascii?Q?D7MeKTwKm2oK4KmfeaTlU+mChg96+oAz45Vx5iZkuBts6SugKcv+zPVM1llc?= =?us-ascii?Q?X3vrzrrVDXKpEVguNWHleWD/ChhbhzSeHCPEn7aD3MzBZ2QSXPrDm3v6twxU?= =?us-ascii?Q?5U/Wa9RTx/cv0yhbS8XcDS5nkZxn7VYjqYWRgxaP0EXcNA8UwL5L9FpqgsGf?= =?us-ascii?Q?tpX7GxQv0y5wgDVBTms=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fd084dc-bbdf-49bc-70e6-08dae267cf24 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 08:54:31.0658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fMmofa7Nrf7WRSZa/d1aAKJOxp6w6lTGh36/fOkCFyW3CDuTskACMc6zDnoZ9TyQdzfgcyv6o4FvBS1qmklDtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5614 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. I see. I am fine with that. Reviewed-by: Ray Ni > -----Original Message----- > From: Guo, Gua > Sent: Tuesday, December 20, 2022 9:33 AM > To: Ni, Ray ; Liu, KasimX ; devel= @edk2.groups.io > Cc: Dong, Guo ; Lu, James > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD >=20 > The goal reduce macro requirement to build UniversalPayloadBuild.py. >=20 > For UPL: UefiPayloadPkg dynamic to set PCD based on UPL defined HOB. >=20 > For PPL: These PCDs on PPL (Booloader) will keep on FixedAtBuild and gene= rate HOB data. >=20 > So the change is move these PCD have compatibility FixedAtBuild only to F= ixedAtBuild + Dynamic. >=20 > Thanks, > Gua Guo >=20 > -----Original Message----- > From: Ni, Ray > Sent: Monday, December 19, 2022 3:43 PM > To: Liu, KasimX ; devel@edk2.groups.io > Cc: Dong, Guo ; Lu, James ; Guo, = Gua > Subject: RE: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD >=20 > The initial goal was to remove dynamic PCD dependency from bootloader. > Is that still the goal? > If yes, maybe depending on dynamic PCD is not a good idea. >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: Liu, KasimX > > Sent: Monday, December 19, 2022 3:40 PM > > To: devel@edk2.groups.io > > Cc: Liu, KasimX ; Dong, Guo > > ; Ni, Ray ; Lu, James > > ; Guo, Gua > > Subject: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD > > > > From: KasimX Liu > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4193 > > > > In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro > > list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to > > PcdsDynamicEx > > > > Cc: Guo Dong > > Cc: Ray Ni > > Cc: James Lu > > Cc: Gua Guo > > Signed-off-by: KasimX Liu > > --- > > PcAtChipsetPkg/PcAtChipsetPkg.dec | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > index ed2d95550b..a53ca777e8 100644 > > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > > @@ -84,6 +84,14 @@ > > # @Prompt RTC Target Register address > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister64|0x0|UINT64|0x0000 > > 0023 > > > > > > > > + ## Specifies RTC Index Register address in I/O space. > > > > + # @Prompt RTC Index Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x00000 > > + 01E > > > > + > > > > + ## Specifies RTC Target Register address in I/O space. > > > > + # @Prompt RTC Target Register address > > > > + > > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000 > > + 001F > > > > + > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > > > ## Defines the ACPI register set base address. > > > > # The invalid 0xFFFF is as its default value. It must be configured= to the real value. > > > > @@ -146,14 +154,6 @@ > > # @Prompt Initial value for Register_D in RTC. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD|0x00|UINT8|0 > > x0000001D > > > > > > > > - ## Specifies RTC Index Register address in I/O space. > > > > - # @Prompt RTC Index Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|0x70|UINT8|0x0000001 > > E > > > > - > > > > - ## Specifies RTC Target Register address in I/O space. > > > > - # @Prompt RTC Target Register address > > > > - > > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x000000 > > 1F > > > > - > > > > ## RTC Update Timeout Value(microsecond). > > > > # @Prompt RTC Update Timeout Value. > > > > > > gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UIN > > T32|0x00000020 > > > > -- > > 2.32.0.windows.2