From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.4268.1665468852969328658 for ; Mon, 10 Oct 2022 23:14:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WE935hol; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665468852; x=1697004852; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lKT3LfxAriD99qIMIM9/Pwn1h5ELl8QjD4Y1VI1F8Kw=; b=WE935holBaBlfiLmoIC67kyNplvxirQYP9wtSXTKx/6wgX1I7s2wuVfL NgHMfoI8R1jHevRXrPkqdzDycDwGWJqX2HgWQAs3b02F4679VpCzptVdJ zAfpyWtGjDzBVhT6ZqGhAmd/HcWHxVnr8Tih7Mw9smsoHVBX0a2Dl9H9S BK4Ir93fD4De/pS5sOUVyoqSQ8OO9XHrdw49khqRNOeDaZPZrWUixVDhq XBdZ+qYC9Yn/Zmsj2qaa/3v1fG4ho7UH4e02AKjdq2V1wA/NaviXtxfTj QaS3itmpxgxsmDQAsv5Fv9LGsGxxnaTI+ZzEWyrRl0Bp87R59pL+iqu1R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="284799846" X-IronPort-AV: E=Sophos;i="5.95,175,1661842800"; d="scan'208";a="284799846" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 23:14:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="626242420" X-IronPort-AV: E=Sophos;i="5.95,175,1661842800"; d="scan'208";a="626242420" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 10 Oct 2022 23:14:11 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 23:14:11 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 23:14:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 23:14:10 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 10 Oct 2022 23:14:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDj3zszt8KFKJZFGdJF105WWHnoGv2+mfVnX2+IOwY+4r4079Yr8HiwgLy7Z3Xg5NBlOJZ9fcWtjB3CyVU2sozfsi8+zCwngE8DjGKDXRFH4DuSSXm3CB4ryjktF0Kltbtpc8MHaimKt9fEn+Eq7gik00b4N2kFHVRUkLhyk1ht1bylOnyE3l9kcfQLd7fVh3LpKFbWSxbSxW3yFgmqCiEeDuRvIZze+Y9g/frPY8MxkRbvk4THmoHeDtFKaW+XQ7xwsuJ8bZHjYagiZlB/FVeh2I5ujVvuMvFCwnJm2nqoXzONo2PRM55N3JsaitFb0FjsZ+8uy+39I2pwKvtoOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WPs9wG920E4tyLgu0hEvAbfz3NApAzAi3Pc5kPB/qSo=; b=gTjGxRKEJvn5gKXousUGCPoPlMWJHz+ME2Hyad4qomaCXAIUiyjopWOjg5vUaYH1hPAiTGjZqYYmFxSngXxCws3P6j7E0bildS2P4Z32XVZ7u+otIH7XeTSCnbwO5vc+UVHEZ20l7KWw0he7Ts6OlAgKPGeTRqmGf4olhi3X68C/O21wtXe5CoIQbO7Bp3aojVsYtTYWEjgksh8IkQZJesBshAEC9TGIYwiZ9RwSumRVthgPnOCMBqSD6A5HjAq7fNghDXNF0eONmD5oruRBtC6fU3tQ09qMJ33iNXuFqFE+wOsej0AQK7CSh+Lxt289vfPHOKAyg2KPKK8PDnOQaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by IA1PR11MB7199.namprd11.prod.outlook.com (2603:10b6:208:418::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Tue, 11 Oct 2022 06:14:08 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::483f:4bb5:a15f:f571%11]) with mapi id 15.20.5709.015; Tue, 11 Oct 2022 06:14:08 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [PATCH] UefiCpuPkg/CpuPageTableLib:Support PAE paging for PageTableParse Thread-Topic: [PATCH] UefiCpuPkg/CpuPageTableLib:Support PAE paging for PageTableParse Thread-Index: AQHY3TbN6SNEYpKprEeFtSeZ+9e66q4ItFUA Date: Tue, 11 Oct 2022 06:14:08 +0000 Message-ID: References: <20221011055935.457-1-dun.tan@intel.com> In-Reply-To: <20221011055935.457-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|IA1PR11MB7199:EE_ x-ms-office365-filtering-correlation-id: 3741124d-e4e8-4727-3ab6-08daab4fceb1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ILTOmQ7/imwe/GW/xZq6HLja5hKUdalJB2gbQd88q8HxuT0YeVppLp5fdWhNAJsb5QqwZ06D/i09ACv6EjJu4kHfhRnGAmb15yQdAHSlYbP/rfYas+/blA/NgdqBpTKx66Owe3JaHlN2C/aij0Hc4yx866aNC4hx1+MfTBCK95tAhWvpnxR4vqdj5VFqr+rNK1+yTuLeMUEGCwEuQkZmDxSq/MUz9ehprqaBpkgSvKX9426FNez18xzc4J2m5J+9xkDwr/5F1nDALke6h/vGpEUnQ2shgp01LL+bjYVp4PKxrmfUmhJCamFI9SYUKGqV1Ie+fUq5p86v/fineNx9GtiuJzvtpEuP0euavHfNRWa7K8lIB9gnptbu2M7QPJ/4VM12rv97/8tZ/bbXKI7JtzONxDvY/+3VTeN7OE7WM+zYMx82cwkAVlTz63iHhYKfS/cVwIcF0RO/koUQ97YE9gXJskRayD7Rc56dMmgLXm2euTOJJZ5MGEC14f6cYOMMALVZW0sar5CIj2GljMWE7BJjBo6ERp+lVGPzqiXryx9n2NL9vkKoXaX72xJrxssLBcSrroY9mcuL2ExxNc+viIknOwrkjLVK5i/1TWQQnpJCYWX5RDXkFXWIfjkUkKKm5cglDYbvxfcv4qLgjqezvuzzRBgegv+q6VhzWBVUENmdrVO08QsJp2CTCxwWAcP0nOuEO/IB+2ccULIMiY32EBvv3A62sxu3ViMiYK1oOG5cFV7n/Vf0/HFBXvOrGIN8wI8sLlnxNUSRR/v7nOVElw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(346002)(396003)(136003)(451199015)(8936002)(66946007)(52536014)(5660300002)(41300700001)(38070700005)(83380400001)(186003)(107886003)(38100700002)(122000001)(8676002)(6506007)(53546011)(7696005)(4326008)(64756008)(55016003)(316002)(66556008)(54906003)(66476007)(76116006)(478600001)(86362001)(9686003)(82960400001)(71200400001)(110136005)(33656002)(2906002)(66446008)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P98X/nD+ResOsHcDELudgvPwkk9pN138WrJ7k9jHHwNaA+80FTAtS7fejEpF?= =?us-ascii?Q?Z9Se9gZnpcor3pqEkYJ/N6OuPWo6bk1KKsLZNWbJuQ2JwVDj4hPvqUNWT5q5?= =?us-ascii?Q?TICBj6VdoA4DvN+aNXAVVQIblDk+0M6gYEx22KHBD52+K1nsIxirfJ+u4keK?= =?us-ascii?Q?7GwVPfXmsa8Unf5rvP28mebIwuwgocX0c3IH3ixCfksGlR3u+lrOXtUqNZ0j?= =?us-ascii?Q?auz2VWhBrsee5FUmepZm0X3ejmLsTry5KuKy03aQmfQMGLkn6jsOBgvUt6iL?= =?us-ascii?Q?tWJaRq5EwZjvFEm8uduPCYJiVAkZ0dihOUsDDKC3NklRLTuJMJTRiTlw7M7s?= =?us-ascii?Q?ByTiD1KQSANq8Opfy3aB/udkZw0r3SkvGJ6EPV49mKh/YhHrrhOaNInHzHmP?= =?us-ascii?Q?9P2z4WyG/lgHrxkuxYyM2ifyNpyD/2q6L2p798rFmWI5siDYmZkrdL2A9z4Q?= =?us-ascii?Q?7L+t6yqZaRlnHH+6l4dn8953ujoF05XUEF255JxfcpHbjjtS7Lfg3FmvQgoF?= =?us-ascii?Q?9oE0Rs60JuPpHFTLiYdWf/bAKJGc084VkGWg9VjslbhBU9/IhSDDgCANKx4R?= =?us-ascii?Q?16f2Ns55xING4KQ8DT9U9fmqi1/u8ZQPXI7LeDsmGIdP8lLx0iNOTiK4VG9r?= =?us-ascii?Q?bLCQInf9Ls+3RmZV4r1qXRA9ui6UjGOD0o/s1D+YxjesgC8K55ACgamwK7hw?= =?us-ascii?Q?5QkgOJWf+erozz2kN/LJDos9WHNjQSf4+O+1wHhCvix83KY9RxHbqJhO1tDh?= =?us-ascii?Q?s67fhbNxMbhEcqZeRSnL+6g9yPGwgJhdkJOEV+AeW6iqqWdnEXPYypCOlxih?= =?us-ascii?Q?fvSqJ9OpV3jIjzczw3n6KweVEV8C85xI9BEAuZdswguj47bKJom6FyM1T07S?= =?us-ascii?Q?pvxhuXe9XmhUCOcJdLTyqH23F8yOkV69FYaXP+7on6YUXjPWzjOK+coEYxlj?= =?us-ascii?Q?buByZ3v/HiskdHeth7izEU9DGBHI5mbFYB5KytU19PCT5vF687i7qk6Mhxmo?= =?us-ascii?Q?Kys7nwgcKcWPET9rjCbcD1Ptsw80iNXtn/KQ9WUhLuzOfcZ6pTbcRD/Cuwyc?= =?us-ascii?Q?/f1dVDk0dIyukrnC5ZPEWanXX2kVB+G+TIUnYkSIs6ePmBPVjtY2eT/2N49B?= =?us-ascii?Q?jDb27VWSx3F4U64XmMoIohGS9Dnd0xXwe4pJZgHOX/XhdBNU8O8stVedXuXJ?= =?us-ascii?Q?ql4XWLiU7p1chk7LLYK8sUOPE12bjqKv9KoHEKrRib8wzOeYZoAevgu3rY2v?= =?us-ascii?Q?I1AtxVWrFfisWgvSziEYSvdeyLBmM4Mvn2Ul2o4V/QjZA3clhECkyjl5lerr?= =?us-ascii?Q?YKHIz6+umaMZfsgk/20YA8+n63soMgoCbjAvPp+e/l1jSQ/vfHwiliSXgPEC?= =?us-ascii?Q?n1AykQSMvyYEItw413O051f9vKAkmTz4UQfj7f1SAhBgFw37kvnisXOedEgT?= =?us-ascii?Q?inkJlKisqUk+Ma50SF75yb488ml9QIWQAYtjXpxh7PQWv5S3tQIYWie1SwrM?= =?us-ascii?Q?Aq+nNAMtuiAwTiih+Bqbfowuo+PYEesem0NQgjBtCjmgtDSjNmEy7cSm/U8a?= =?us-ascii?Q?881KBPiItc2jNmAx3JrB+fmQWdJFeoPKJMXm4ymR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3741124d-e4e8-4727-3ab6-08daab4fceb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 06:14:08.4521 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8KxLNW2Zjw9JipIB8dQBquAl6nrixh006CaeKFL4g1ljEklHBUHh6fFBD5VzlH9jGoxWXEPxzRCW8MMdWZFGow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7199 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I didn't enable the PAE support because I found slightly differences in log= ic that creates the PAE paging structure. I agree that PageTableParse() supporting PAE is more straightforward. Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Tuesday, October 11, 2022 2:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R > Subject: [PATCH] UefiCpuPkg/CpuPageTableLib:Support PAE paging for > PageTableParse >=20 > Support PAE paging for PageTableParse API in CpuPageTableLib. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c > index e66961e122..65490751ab 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c > @@ -270,10 +270,9 @@ PageTableParse ( > IA32_MAP_ENTRY OneEntry; > UINTN MaxLevel; >=20 > - if ((PagingMode =3D=3D Paging32bit) || (PagingMode =3D=3D PagingPae) |= | > (PagingMode >=3D PagingModeMax)) { > + if ((PagingMode =3D=3D Paging32bit) || (PagingMode >=3D PagingModeMax)= ) { > // > // 32bit paging is never supported. > - // PAE paging will be supported later. > // > return RETURN_UNSUPPORTED; > } > -- > 2.31.1.windows.1