From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.12988.1671420176047279457 for ; Sun, 18 Dec 2022 19:22:56 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KVtlSICB; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671420175; x=1702956175; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Sncvv6RMpKZMOV+XYGmZCk3Obn0NYjkaC4fd994f4TU=; b=KVtlSICB1w7cDnndAigITRJUMYdz9Om5PM3b6JT49Kkt1eZvlt+WLMbE HN/UsTrkcXimNz5SYDlbV0P9exR5eCuLB96BalScpjxZeksyQYWH20qYk rDdYoVZftyiekLU2IjRdSuNZz9Blfx4hT8aGg2jxKmjfEIZDDIz9Dqt6M 0kr56K7PKdQEqvgunb5jDJXu8k1WJmo+VLleFll2+fUMUDqzbBtOzsTeh +mlibtFfAIdW0IoLkkz8OtQr+bf/QOWDTdBAT3WKyXuro8KGZ4f3mxqbu q35kgT5pb4i+I2sBlxuPbNy5aZgFum+nhKxh6mwTlvC34A/Be+vtA8vk+ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="319309359" X-IronPort-AV: E=Sophos;i="5.96,254,1665471600"; d="scan'208";a="319309359" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 19:22:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="682875378" X-IronPort-AV: E=Sophos;i="5.96,254,1665471600"; d="scan'208";a="682875378" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 18 Dec 2022 19:22:53 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 19:22:52 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 19:22:52 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 19:22:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3ZHdybCTAoeNAT5DWuUcZ3f0Tc31iXcfPm+Qmfq601YLgP+qqnI8csnsHHq9s9Nz4cNLgwYOpk0PMIMxP8H8uAe3CYa2ZsPu731h8htcqvBEn6dn6blS/D0uxpjyFEWAAmLdx52p1CJFm6aoig6rklnJtUtAZuBPI7gcj8z8/VF6IMy03OIYeU8XQ30reZ/IiGCSv42Pm27u0cbWbIb2A+CEnEa4USgaP6FAGUSpJ7b5TPvepgZ6R6BaGCQ+WgyfOIMHchA77LRtmelRZ7k4SXpd7m3ffrTDdmXapKYJeHw0tE1QnFUGgo1v/4AvoDSlgi9B1N5DoxMcjl1T70W4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D6siXZZUZKs33p1VJtaXC3b88+e/1TyIZpjBJMvT0lo=; b=RRWQ51kGd13lOmQXl4WqN79OHIFJrr5Qh4EDaoENsiBI5nKNG0cOtSPUGINbugg8q83XWUqhjDRJzA3+5zXr8ZBpBsSudOz/te57BzikMnq47hcAQhPUZ3D9oQwaVx4kdpC17uBt3F8rayFckkwfwJxxn7lopRzvbb2QEQVmznb88S/YMxdgdgRqf58HhwXiCo/JsvwQ/XA7ILXYZjCZig/hn8u4OB9uuNRM6gcRs6CP/c9HcqK5SYetpgl0QpE9mvxyTgoWMQAjkXkccqo/n5t5fqthddkWTfBkTEdJrA5KJyDCLffgySwXbYuhFjdctJJAwxRjclEAmD1aYR/CnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by BL1PR11MB5430.namprd11.prod.outlook.com (2603:10b6:208:31e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 03:22:50 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::994e:d3c4:7608:3405%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 03:22:50 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" Subject: Re: [PATCH 2/4] UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS. Thread-Topic: [PATCH 2/4] UefiCpuPkg: Has APs in 64 bit long-mode before booting to OS. Thread-Index: AQHZEynPZNsb90aPzUyZ8o4KKa3HlK50iKDQ Date: Mon, 19 Dec 2022 03:22:50 +0000 Message-ID: References: <20221218214317.3431-1-yuanhao.xie@intel.com> <20221218214317.3431-3-yuanhao.xie@intel.com> In-Reply-To: <20221218214317.3431-3-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|BL1PR11MB5430:EE_ x-ms-office365-filtering-correlation-id: ddcbe3c4-0002-4af6-b6d7-08dae1704f0e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RS52dF5Aad3Ygk+1PYadei2nQ4h7HcTwVpLaEWzTNsVQELlUhapuJi9EO945KVD6mYfLeVM36w3omkzc7kf30u9YvsZjZlQRspDUArMFI745bu/jhDtS8OKDvPfekAOLgYVzdRuWfwhQipymq8Wjc1jJEdzpqkXpw/y/AjXbIBG6b/ji4tCp/Xz6o1I6O0vry9LQnvkMeKe2WqIA8A1YinwL8ez3R7DtAx4DFGhCG3mQ4GEhJX6ikvVO7zl+H5F+2JKaO86PuxnfSDutkOj/TOiHTjiatZFOcxKALlH1hGHU4TtHMTFaO4YB4NC/XBf6jhrHtgtDonB7oP468cw8GxHEfMjnmDZEDRicTjfRrPDb7/8ee1EaMIZW/DlXfgjsjJCh+t6y5NvKYFgfM6VdtDh7YBmiX9XU6FxuyxLXA7Qz3VKZJmg+4zcSpcBZZd+8xuoGaXLRsr9vnb0zL+qAZA/KnMzBPPL1PWTbW6Dwk2ktuYu2p8/eZePs+c25+fXlRs6OtmgwQ6h3P2VX33DwAKeIYq51pw1oUJdtPQb36Cl/8K7l4XfbXEfN+dlh58jUrjcCOgSjAlC44nnYr+eADXT04vzRS1gC8a7ZFEO/OFtPf5poRXVBpvRNdwJq0+lwF4f/RE8ybCFrj4npcAbm2QkS5dM9FBYCLLcnYUqoUHKoMKWY+w763PTaqn6LrfGosnEAcUrIcWwoN/oIf90JCA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(52536014)(38100700002)(8936002)(83380400001)(71200400001)(6506007)(478600001)(7696005)(2906002)(110136005)(55016003)(41300700001)(186003)(33656002)(316002)(26005)(9686003)(19627235002)(122000001)(5660300002)(86362001)(8676002)(76116006)(66946007)(66446008)(66556008)(66476007)(64756008)(38070700005)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0E2K1U4jKUPitpARpLzYWcXeImn/vH3XKBlWa4O+lpUiW0Iuyq7HkZam9VLb?= =?us-ascii?Q?tEezxHfrIZM7PP4Qc0LMoC7rsEJMFOo5ytXffuCNn18uDa+f7/eE4PgbMPl2?= =?us-ascii?Q?moFizNTwBfpWbPSvrQMGCvXMMC3Q+h1e+g43nlLtPj36yug1cyLaCagDoAe9?= =?us-ascii?Q?j0c8Lsq5N5eda0A0pSZPs5C3qEvFj31tH2YItZvAbmU3fPFRzytXmOxXc839?= =?us-ascii?Q?h/5DNBrSwKJMV1vzO1CTOhVFehNUrA4FKJHTZZ88o2bql3n8F/wyme01DdDd?= =?us-ascii?Q?HzXB8wr27kP6GizV5afuHKwAqWuPBfa+oobqciRp9GL14OQpvuioeNcTsvnB?= =?us-ascii?Q?km7aI7Ro9CaRfMKJ+uOObaCtC27GFqsi5cRHA8z0YSY8AIfNuioQ2marKB2L?= =?us-ascii?Q?Wa3QqlH3brXgNvI0/hQ+nXpnSkD4Y05Ts+hfQeJsT8hsfxk+oGb77rWywpRY?= =?us-ascii?Q?Ijo2Om9OZQHPsRD01Gd4dhES996r95+3WzfhcY6dcaVf32gt68pXMO13a9Ro?= =?us-ascii?Q?Q07ki/qZ2uCC3XB0lGAZgmC90aY153MitKYR2idHcWrUSZol90aTZ6tlaIw4?= =?us-ascii?Q?tb79RrP1cg+vkSqNf9p7s4exZV0tGA7ghJTY2DtOMS0REL3owInlljWvFcGo?= =?us-ascii?Q?poH7t++vZfikkgxY3wWnuE1/Z1qxtbs0va9rY4fLCzAuSdL+nCJHygF6Qr2E?= =?us-ascii?Q?lFOyLQQKXDIJ4wzvLywAfyPKE+8Yej9IMvv5QoSUL5/cYJEw+GJ1KwXljcXi?= =?us-ascii?Q?4fFheoAxNRtW4Lj9arxFIHb7zpok98iYvSdnY4nPqNvWa0FWSNtNgtBZ1P7g?= =?us-ascii?Q?TQUpam2r6TLb+k3D6aA0VfrLawe5JGxiaNoY98XEQ6S8AuEFua9yGm2rwKZs?= =?us-ascii?Q?pALcjC9LMTeBVF/D1TpUXWUvKq5bZROaCqRuSZiL2mjk4sBB52+GI3i60e7X?= =?us-ascii?Q?5v7qPnO0byZooyEp5Us2Tkz6OnAmkSxqHxQyeaADeueG/P0xaY+6ug0kVejD?= =?us-ascii?Q?xVQDmH8//36CGWbk4TiCV1WCxF+C/jckgFqIatVOvyhvnnMFT3ErQZvPCYNB?= =?us-ascii?Q?LDlRlaLhHuimZk5+sQVmOrjcCM36dFaXT5mr0E3RK9l6Kq+foxTr0bVUJnak?= =?us-ascii?Q?dsCHxRAuZCaPny3WoHiK89walhJmQ3XZJzKMV1O4ALIgXG1phxNrgTOSFVm4?= =?us-ascii?Q?m4pPOEI/lVllRDmtwgUkV3pqVhn+Ch1IzzW5XPKdnObz0M56RVC5qge/FJas?= =?us-ascii?Q?VxabbL7cKBAyjZkVJ8ARdi8RYk4faCNulPHYBcP4tY91SuVTmQGT5rFyVnS6?= =?us-ascii?Q?2DalCeoHX3wxcZRMxCd49/Surv5Qinr6BkVx42x9+Lv26TT/bauS0ns2W8MG?= =?us-ascii?Q?rIpy8EO475wAKs6r4TMIhKpldaNnQbGdL/f5ztQ2k8XI+VZngt0VpqFhco69?= =?us-ascii?Q?5m7Mu4G01ZA71m2MpLVx2KQeMQJHOZGbkogLCB1cBX2jE+nfupIELFmkMcqd?= =?us-ascii?Q?PaZNiQgBwMJn1rKpEirD35UuvtGEW+vhB/RHAgYppDXYN0nAJWdLfqAU2PHe?= =?us-ascii?Q?t4SDFb0a16bqmytA0xg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddcbe3c4-0002-4af6-b6d7-08dae1704f0e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 03:22:50.5141 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dPUQT2xmm1HyJhyDLg2jcTtosLifOKdmiWQgxbwTWOE9c4Q1Zkiv5uttjid2lCKPDPpT2HkdkE+mn3g8PfkPzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5430 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + > + PageTable =3D CreatePageTable ( > + mReservedTopOfApStack, > + ApSafeBufferSize > + ); > + > + mApPageTable =3D PageTable; 1. Can you directly assign the CreatePageTable() return value to mApPageTab= le? So that the local "PageTable" is not needed. > + > + mReservedTopOfApStack +=3D CpuMpData->CpuCount * AP_SAFE_STACK_SIZE; > + } 2. Can you confirm if above change to mReservedTopOfApStack is needed for A= MD path? > diff --git a/UefiCpuPkg/Library/MpInitLib/Ia32/CreatePageTable.c b/UefiCp= uPkg/Library/MpInitLib/Ia32/CreatePageTable.c > new file mode 100644 > index 0000000000..54ec42469e > --- /dev/null > +++ b/UefiCpuPkg/Library/MpInitLib/Ia32/CreatePageTable.c > @@ -0,0 +1,28 @@ > +/** @file > + CreatePageTable 3. File header comments are too simple. > + > + Copyright (c) 2016 - 2022, Intel Corporation. All rights reserved.
4. Copyright year can be just "2022". No need to have "2016". > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include 5. Can you try to remove the above two library header inclusion? > + > +/** > + Create or update page table. 6. The function header comments could be: "Create 1:1 mapping page table in reserved memory to map the specified = address range." Please update in header file as well. > /** > Initialize global data for MP support. >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm b/UefiCpuPkg/Li= brary/MpInitLib/X64/AmdSev.nasm > index 47fc8e9325..b2d95adf6d 100644 > --- a/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm > +++ b/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm > @@ -514,4 +514,4 @@ DoHltAmd: > jmp DoHltAmd >=20 > BITS 64 > -AsmRelocateApLoopEndAmd: > \ No newline at end of file > +AsmRelocateApLoopEndAmd: 7. The change to add newline character should be in the first patch, not in= this patch.