From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.102005.1671021430047322675 for ; Wed, 14 Dec 2022 04:37:10 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eDHBXm0+; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671021430; x=1702557430; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vlCz7w1RAlNhp9zhDR6P8dcQx7Y2HjeoPmbfP1fHrf0=; b=eDHBXm0+q8AncbLI0DlmfvoTESN3dLDNPCyg34kRO038/7LBXc79kK6s iul1YUDHfqVE8LU6Uu8aDX/MsxleRkjKGYk2vXK4eSIBwsXzN+Vu6QyDx TwvS7XWXGycTtFEkOBGIcDadyBuyX8f74xzrpAfjSmU0tY4zqDETsiAmD PavYWmFph8nPaj8DnDYaDg/tdBrnYjVn3tww+jqge+TaLKeiE+ld1MNBD R+bkJDjhKINbVosT+V2ZfzYFMBlzmt7+LzftmSw7ZI0DlxCkxTBVYef// 7+3+sZQXb4PLA47EMcnmmJSf/vRM50c6iPz5SgunUvlLPnz7zTxbqNT18 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="306032607" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="306032607" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 04:37:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="791294384" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="791294384" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2022 04:37:08 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 14 Dec 2022 04:37:08 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 14 Dec 2022 04:37:08 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 14 Dec 2022 04:37:08 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 14 Dec 2022 04:37:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgPZbh4owvjVpQecKFhhhiJkPSVKbGXgyiUVGAkFekfwsBZ/0Y13jmlTr2E4mzGvzZgYTGTR4BE3yWLjAcAM62zh60MTd865/YQiBl4O4Y8uv3mGVAPutc2QM2pIWWK0RZe3Dmy+P14TVwvw2KbR4up3eL2fjN7NmdAhey3gHT4kF2DvSNwETqUzj/P7NvJzvOF2j3jPqEYxwB58OuuKnDy00UtzfoWB2dTUSHcPQqHH7UJQi1nPTe9Mutld4O6Fe84dLNyB3zFuT0Dzyml+88/lCFSs+cieV4NLNY8kzAkgFrCvl9sHOrTanLMKebyEEU+mhYEHWaJ2xLJEHbxsYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vlCz7w1RAlNhp9zhDR6P8dcQx7Y2HjeoPmbfP1fHrf0=; b=I8F6V0QprBdPp2bsEAWZLjyZGO8YR1WZ4eLJYwe+ppor7KxSNLltrXrusYEonvqb4qPpC/hPgrFr/w6o0gmsvf9wfiKc0wbnECXbMTcPQXqeNQp82vT8ijsUrtbcQZzr4Sv7iWKlessGVuTFB7Y9U5MW8fbldUVVPkPAv/pZylf0dHmIFlkL7cYxVvZDd3S0A9zwVRnDySoTrK9Wo9mEv5FJ6yIgvO6gB7bahQ8Q7hI+FIhnneKhc/+Pfa0Ej5Mr7EdCmeHNKbA9kYx8TYNr1L8FU44v71OLi1N1Wi+EarqFQ7yqpgFUUl3NLeiE70q849dfk9XvnDixhVe7Px8XFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MW3PR11MB4699.namprd11.prod.outlook.com (2603:10b6:303:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 12:37:05 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e%12]) with mapi id 15.20.5924.011; Wed, 14 Dec 2022 12:37:05 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" CC: Sunil V L , "Wang, Jian J" , "Gao, Liming" , "Dong, Eric" , "Kumar, Rahul R" , "De, Debkumar" , "West, Catharine" , Daniel Schaefer , "Abner Chang" , Andrew Fish , Ard Biesheuvel , Heinrich Schuchardt , Anup Patel Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Thread-Topic: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib Thread-Index: AQHYwq48vhYxUeZHmU+SsZg7QrtLf65jsmBggABLqACAADus8IAJgKKAgAAxTvA= Date: Wed, 14 Dec 2022 12:37:04 +0000 Message-ID: References: <20220907113626.540065-1-sunilvl@ventanamicro.com> <20220907113626.540065-11-sunilvl@ventanamicro.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|MW3PR11MB4699:EE_ x-ms-office365-filtering-correlation-id: 4ff0fab3-65ef-44e2-2612-08daddcfe831 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p0rwuJwws/CnsmzfCI5+r/aRnM9OTxWT2LQ7Oa2Nsl1jnXn8hEUHaD48h1QP7DI9aiGmuYRRgSdanEBKQysw9Y1n0max9a9vH+newY07Lj5QdewlUj3jevu2CYGncszMADPOwz4ffsjjMeS3GrHEWWOGsHDLpYY8TB5BytDMFOSYXOSXoMlJ3r0PaT5GVXS64+G0BPBa9ToNVtx8V9dlbLX1m6FE2AKNtmMnObE3H6y/94TQPkOc4Pc529tXDtTlPJ7OO4YaEA/SN8iM4X7lE4lAxz7jFa6t5qJkGnskZW2BcpOg1xG8Pdc7Lx9IltUVu27Xumnpz4PIeM9WIeHLtg7+88q6cRJlD5raBmQXw3PiBvGtauuo5/N+32lPGxw7cfn/5vSNluLUxrUIit8zCwqrwUU4MZXLCG661eWq5w9dXMMu37uF7LegoqqgAKQvna6i5y8LYeWuVSYf15OrZGkPdfZ1ulgK8xYyd2srvjonQWluYHT7EEwulMlv+TY7xmzXUr9ZkzLSGvPXrEJRc7r91gWpp/3nb7zS6TArc1nK+aV82ykXrtUp3Ve9nc3nPhWJDAzIqvv4bfJY7htM70QzO/REjtgDLWLlCD0EevRPzUxILazrew6r0fyi8Kcg9JeUR6ayqayA/wFm7Rjke12orBwEKO/cgqtGBD7+H7bkA6ePjvMmhTgPAizsCh6B+u9+1hSxBCehewVoAhipxCC/UdxNcJC5Qpn2XxdHcckyHXx4ZIZNOj4peJXfDMn8wuO+351VBPy3EDaUv48QNc5KRbX0xQz3E0h8zHFCle0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199015)(66899015)(52536014)(110136005)(5660300002)(86362001)(6506007)(8936002)(82960400001)(38100700002)(38070700005)(33656002)(7416002)(54906003)(66446008)(316002)(8676002)(966005)(186003)(83380400001)(478600001)(71200400001)(122000001)(53546011)(76116006)(66556008)(4326008)(66476007)(7696005)(64756008)(66946007)(9686003)(55016003)(41300700001)(26005)(2906002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NAeJd2rHFUvILCdr0DZn/VOqpBYGZM1Vq45r+u74bI9v0RaRYhwBisQtcIIr?= =?us-ascii?Q?8xd0O4H6XcDDtECvB5yzuLI4y3xnhcAfgzjZoKZp4ZtBT3LOt3vq3narEIAj?= =?us-ascii?Q?jqHJFsy42qiQY9a6/UDe87/ztyThKkP6Qup/3wLzjRTWbDKgqzU52A6wKJbu?= =?us-ascii?Q?n2kuAwU0aX9RcyXCDCcxMliW+35GPZhmZqI4QWQsC81OkcBeO6cOPpfKubge?= =?us-ascii?Q?hPe263l2SKB9A84kkaEYWKhpdskvTAahY5T8G+Ji7XUWG/eITQ2qMZWOQMhj?= =?us-ascii?Q?0Rp6tml0Idti44rv9U+kFPhxlScNrmVDT0yZUnsWtcpkeuMGeOe7uLwNfI6A?= =?us-ascii?Q?dtq1v2qpCB8FALOEmyM5f2mbWQwjfYdbekaGyXXRZgOSr2RBG/AhJ+2L6dvL?= =?us-ascii?Q?o5nTSeUSn6Z3X3E1uIOPSvuFwSQea0gp0buLu+4/pV+K0Ny3ZPiy+ysFaElH?= =?us-ascii?Q?84X2Ch2x/tg9SQkKgvpPEKobE6/G4Lp/w3BVzUFdiSHLDfTQ3zoX2riYaAmG?= =?us-ascii?Q?DBDYQKAA6BEJtyKf2Kw2G4JjexH1Ko7V89mfM0xOQq12NSSw+Iq/WSnfACKI?= =?us-ascii?Q?MCH3UBzJnwKYDspfGjXr/TSkkCESy5R0jB4mN+FadwVpFfSXpU3p10D1D5QE?= =?us-ascii?Q?QZz0ETArKXBdXMcoj0/c5KapuiQ7xx80ko3D5Q8DL+/e3QX41hlPn7M8Bz12?= =?us-ascii?Q?XiXnJkEwkW/b+Ect5K7SR6zrzELGL9XSQJ2PL8ppT0AkHWFjQpRzTaAaMNPN?= =?us-ascii?Q?ct9PRiASLCIYLViicxm8aexc/lOlDWPJQjUaLAzYNr7hluQZPcshSHpYz+im?= =?us-ascii?Q?UU70wgVNnlLMdIJA39ZIVvH3adBwhcIADTV4q/fgV3pK+o0ACmZEtqEU3Zm6?= =?us-ascii?Q?8x2QuL+DmjvW+C3aoEsdJqrifVHiGBO93p/38B/WAqeAYJiNvjxfKOku5kb/?= =?us-ascii?Q?kAUwuMin+E/n5kJylo6QNbUYdJy2gtn02GsIx6QF/iSUtIueEH74Sjae489h?= =?us-ascii?Q?2m+/snrMJOy/5eDcbJWvdPXpsBdgyV6a70blchsirsbct8OonhkCOGRpvJeO?= =?us-ascii?Q?o/i87Y3YpiCfhruY1PbHqW0uLHu0hvYxi380gEhTmXNqqQJ7hWSPDukv5MyE?= =?us-ascii?Q?NfDHASlVoquRdy9kFsAXdfyug+4avEkii/fgMKtWQcnWwTHugCPcGIc7HflX?= =?us-ascii?Q?2Kht2Pzbi/MV3VT7YkkDdZq7Uep8rRCEHmgojsOhH0nkFm5OiWGB97fPvKBT?= =?us-ascii?Q?ls3nPXq7hvU6wsoqekYU7CEbGcNCVjXQ/TZsaoWyCrJr5eaQxBQw+GXJkO1P?= =?us-ascii?Q?Jp2k5Mz+hbNOKaTwK0MBqk7lIgQSw4l+DZpetu0m9NC4Athc2dBPYZ06oGdd?= =?us-ascii?Q?w1QKcTTengItRzmF2IDKH7LkG/4QFw/m8kCKPnzmkRJcPOYvSBgxnN5zERPh?= =?us-ascii?Q?zcGG1Sr6rojki6+lu9Ri1q57XKgEhbfZpAPd/9a4DsPo5pos36no4zugjeGv?= =?us-ascii?Q?YRW0Qm2byyJ1r70bcjsQF79rJMgnlToIxYxlUMd5zq/BunsqZVcILCS0svrq?= =?us-ascii?Q?i+agm+Z3G5uN1AT/bRk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff0fab3-65ef-44e2-2612-08daddcfe831 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 12:37:04.9225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4sAdHOs4yZIbiaJCdcYtCTFy/28mlmWKX121I2y6b48EJg6gCG9AwcDKZErdSffX83RwtH2O0f+ZRDIIPSPoNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4699 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable No. I agree that rename can avoid confusion in future but that will cause lots = of build break in all x86 platforms. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif Lindh= olm > Sent: Wednesday, December 14, 2022 5:39 PM > To: Ni, Ray > Cc: Sunil V L ; devel@edk2.groups.io; Wang, Jia= n J ; Gao, Liming > ; Dong, Eric ; Kumar, Rahu= l R ; De, > Debkumar ; West, Catharine ; Daniel Schaefer > ; Abner Chang ; Andrew Fish <= afish@apple.com>; Ard Biesheuvel > ; Heinrich Schuchardt ; Anup Patel > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V sup= port in DxeCpuExceptionHandlerLib >=20 > Hi Ray, >=20 > Should we then consider renaming DxeCpuExceptionHandlerLib > DxeCpuExceptionHandlerLibIA32X64? >=20 > Best Regards, >=20 > Leif >=20 >=20 > On Thu, Dec 08, 2022 at 08:32:31 +0000, Ni, Ray wrote: > > Yes. I am not sure if the preference for modules in other packages. > > But for code in UefiCpuPkg, I don't prefer this way. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: Sunil V L > > > Sent: Thursday, December 8, 2022 12:58 PM > > > To: devel@edk2.groups.io; Ni, Ray > > > Cc: Wang, Jian J ; Gao, Liming > > > ; Dong, Eric ; Kumar, > > > Rahul R ; De, Debkumar > > > ; West, Catharine ; > > > Daniel Schaefer ; Abner Chang > > > ; Leif Lindholm ; > > > Andrew Fish ; Ard Biesheuvel ; > > > Heinrich Schuchardt ; Anup Patel > > > > > > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V > > > support in DxeCpuExceptionHandlerLib > > > > > > On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote: > > > > Sunil, > > > > Is there any source code sharing between Risc-V and IA32X64? > > > > From the patch, I cannot see any. > > > > If that's the case, I would prefer we don't mix the two separate > > > implementations together into one component. > > > > Can you please create a new CpuExceptionHandlerLib instance for Ris= c-V > > > instead of including the Risc-V sources into the existing INF? > > > > > > > Thank you very much Ray. Sure. That approach is also fine with me. > > > > > > BTW, https://edk2.groups.io/g/devel/message/95726 was the latest seri= es. > > > Sorry for the confusion. Let me update this series and send new versi= on. > > > I think your input is valid for other modules also like TimerLib. > > > > > > Thanks > > > Sunil >=20 >=20 >=20 >=20