From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.145197.1669713090470219560 for ; Tue, 29 Nov 2022 01:11:30 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=VYEPXAr4; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669713090; x=1701249090; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OFV7Cic0fsp9xuMaMDMJjSGVGisEynMfjCfVAkGnuGY=; b=VYEPXAr4TnKW6w7evsIRjHHXKutEYh3I4K8GKoY5ChalsFkMDOlb48Sn EXXxCPFD2LM7fPu6kcTrugbkujn9t0gvHsoE1dPlsKrZ0+Iqhg/ZYhcY7 b7v2oPsg7zAV54ToU0JzVyXOEELTdZjYjBVH4adIaBOnIi/261ZMnnn6r 17BunL0sDXTHxSMJjzPBWjIrNpdbsRzBHKpjdPZlnjDADeDbFPUVI/6qH O8ghDeQ0Xm30eUT8RWxW2pzExsq+c8JiNibQLq+Y9xeSzTUn4B+zBHqfh UM9aNpBCPrjCvt2i8R4SwO3jZfb9P0+cb53z4aS3OlfEFjpF7hHFa++wH A==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="401351516" X-IronPort-AV: E=Sophos;i="5.96,202,1665471600"; d="scan'208";a="401351516" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 01:11:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="707140975" X-IronPort-AV: E=Sophos;i="5.96,202,1665471600"; d="scan'208";a="707140975" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 29 Nov 2022 01:11:29 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 29 Nov 2022 01:11:29 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 29 Nov 2022 01:11:29 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 29 Nov 2022 01:11:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkd+xvTAu4lcKQHSfpklXe7FDTcck6KHig6w4BYjlZG3uJUgXLfqAhN1WKDW69cT8YBN8HwClBDuyTyxV7qjJdAI2Fey7M0vdJ+CqyJISaVEPSajBovXjUNkzBJ/98MCpJggG/xDot3WBw8kVNJp6Yw6heUyC2CJDM6hMUK46E5tH8UJJYSRMOylYoER37z0o1BGJZUvBRXXLAmZUYDVIKeyMHpDovfSSug//IZJ45NbALsr3ZQ6rsWYSKqqLD3tnnlHOXsxp1rcOti0fa/I8NRZRWOlr/FmxjuoY2tmftioBbViYEhiDo7wW8D8vaQIbk85dZ5V+DBBssCy0TInDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y0f3S0d+DJ4janjJYI1/iIpPyWYNjKLV3aT0SZvBUVU=; b=DKSDkYfYe6l+nCc8ER4ESqimYu39Wd0jpKmf0ZHqaAyJYbCs81GQ5u+gfxVZkif9rCHubMg9s9zr7Li5cPGMAmQI3Rxh4VjzHIGcOYf0T+SrjJucHSrXnCX2/NWMCwiLnftVYSeEml7CQQDtenv6ErEX5C72Rq1aM0+AH/JcF8wRN3kp5hbAHYVvvEVG0sUNxT/wR/vrC8iz6XtffcN/lwUiDxumxBT6EzxfTVrlFBQAJbdKuM54AneQDSSpruBvEvyOIubRIkKi3mqzbjv0M3j3aQSd/KGXrOn5wnxgCqyp+vJRuGb6jD/FD0rKk5zYWBJ5Qu/TGhmqAqYlYG5LQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) by MW3PR11MB4667.namprd11.prod.outlook.com (2603:10b6:303:53::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 09:11:27 +0000 Received: from MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e]) by MWHPR11MB1631.namprd11.prod.outlook.com ([fe80::69c8:2676:4674:1d2e%12]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:11:27 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Dong, Eric" Subject: Re: [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not Thread-Topic: [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not Thread-Index: AQHZA8tCeA7HPyE0rEOw8jXgIx2w8K5VlPDQ Date: Tue, 29 Nov 2022 09:11:27 +0000 Message-ID: References: <20221129081852.12888-1-jiaxin.wu@intel.com> In-Reply-To: <20221129081852.12888-1-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1631:EE_|MW3PR11MB4667:EE_ x-ms-office365-filtering-correlation-id: 2401699b-e168-4422-2656-08dad1e9b238 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: otIIsMwG4wOBOKfiXgmf2ZUvfaC/+n2zoyIxb+ANrFz0GaJoaW40PUvb/ROCZ5ZCpFfptyR5d9pIv42BioIiy0iKEG7a+vrJLv41e948Wp3sSLdKFq9eapVrZUNzLc1Bs3peBctervtDST/PL9PiK+EK+pjJ8LjkEx7e9BV6a8zB+bcWGCIJF23pxQfcWI71FPRppOJKMuXNIL3mK07Zh58SL5uOwYrE841PokI2QnKUFTbOifc9A2OI+c3VfryrEq8Vlt9/b5PDPfWCSGOct4CxZ0NOhR8jWIDXC4CQ9JeRTlptaw+NMuGcne/67kamhLcoP/lIklwZmn+auSIa990wMhA8FWGDJJhgouopmIGD65QnBeJ3pGCU1UkAY5RxhPcIg39UEldHStRxB5aIUSHNZhAzNNpcaNNSy5lcaBt8CrmGqcvySr5FW1lSnIi61jJmHohdEy4O4QIr1uQSOLgTICvLmh9yFNff2HCoNYzpgBjx0/1PQJgziuXnxSVntGMN1F3YtkDqLH6s9EVNvoIcraaDWaT/LKtQvgGDDvTWdowPg8TFlpPVibX0I12YBILrBrlkqnXCrLMegFOEg4ti+/BZTHiMJiWI3ur9G04YmoXY2BGYj2uaRxa3HvnBeDnRJMkvMP6XCsysa4YMvVyJKeBXdVH/nNKbhqlPcskUv7tbLdZXZS+fIjh0MPqsuarymkshypTpd6KptayNMqdCsW6wV/Se+ZKFXqsR9G8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1631.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(396003)(366004)(39860400002)(136003)(451199015)(4744005)(5660300002)(55016003)(33656002)(9686003)(26005)(316002)(110136005)(82960400001)(52536014)(41300700001)(66446008)(186003)(76116006)(66946007)(66476007)(8676002)(66556008)(4326008)(15650500001)(64756008)(122000001)(38070700005)(38100700002)(8936002)(2906002)(83380400001)(86362001)(6506007)(966005)(107886003)(7696005)(71200400001)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9CKKc9euRJpshZN7KqjwTQYczoeH7NTWn9bb/zj9CIMsIxJz0dMhRhg/bVJ8?= =?us-ascii?Q?HUDrw1TRe+zltnO4f6JygDdgBE7grgieIfrS0vm8puPPQ/bnxcT6OQrbREd2?= =?us-ascii?Q?0SDxAlu4xbVBAPgQzM5VLINvASLpBwEb1Z0lyxOIZMrFi7l0macbD+LNP7HI?= =?us-ascii?Q?wmd3DkR3jS+PAS8OIc5/hb2pGugvUUUdqcagQ3xVf26rredpMudb6w+vhJjw?= =?us-ascii?Q?33GUFExY2OIFtdXca3LqJGE8JxPeYE98bKd8m7ucxkDjz/Cs/62j3iK4ydxr?= =?us-ascii?Q?V/+1vLIJlAinUDnR05ns07pb0sif8F06cZZ6R5iEKppgtOWP0D1MTHsfyy7W?= =?us-ascii?Q?6Yi9jkvCJer/Cx2NRga39K1/I8yIWSiNJXzNwOUMoUG6dQDZCTIcS+idQsm8?= =?us-ascii?Q?2ip9KyehP8ZU9xaAZ3N0+g9ZhYPpv9MVqjIlVF1unbsOi6fbGmZncnULhT/O?= =?us-ascii?Q?0XMhjsta+k+eMn8zhtfPI+7+1NaxvXGbIIzOQDlG3iEDG8fvcTq3gvk9ekxm?= =?us-ascii?Q?OYgAMFlyazPTAfAW1OmBfWA4YYLHBSCJ6+/AgZ23wqoGVkbOBFbAoXZzRuyG?= =?us-ascii?Q?fAVDFdTTzYW/RpnRobrJlmItp8lDWer0Ns2CKVXKIyZpH9jS7n/lOU0IqWFM?= =?us-ascii?Q?Hxo2/651+YJHGzJvqih2WfXXw8wxmNoCuGvdZUxNU1wGLgo6TQYKv37UmFEe?= =?us-ascii?Q?VRjAe5i/Uj3kWd+LrwQiqydAR3KdLKhJHP/Xi2Acfr4FheFzNf6a0rjrBJCM?= =?us-ascii?Q?z8A21I+gc9CloeLDQoVQWY6xHHtpgoV9mSJnOF6waoF9OhBFywBwUwJM7Xu8?= =?us-ascii?Q?bC2zZJ7Tmm8cr6c4SIET7cOBG/zTVLjoJkyqLkN1iFOmHxbkltEVBaMiV6w+?= =?us-ascii?Q?7sa5ZX8HQL2DurL+c/X+pp6jhMsFti5kVhWdWqyK3yw0gJkgVt1g8evat5NG?= =?us-ascii?Q?NCv7+N0UOEgHX3cHQ3wOQM0qVezcENg0o2bcMgKNr81W4yDRiubVi1tV3uRo?= =?us-ascii?Q?y+WChHOtRX7tDLe0jSkguXN3AUIqxT9Z40ZZ0gjsfzgarhY6seDAwPHNnKDT?= =?us-ascii?Q?7oI9iOZtmUH7T9XgVCVP6w6NLKJ2K2ySaHdrkER+UEr4MSHEPztukufTu5CM?= =?us-ascii?Q?7TlZoo8yuIim6Y2NfW/02EmmlgqDZcilPVXMw1MnxClxD9KDH/aigaetTLFo?= =?us-ascii?Q?cktDnXncsx1rLbZjXKee1S9q+umo0tWbX9d1YmgK4WUbUHbS7FrDfPAtPSXn?= =?us-ascii?Q?oakcrYfdJPwxna6IOra0A59GLDJKhKDiqMzsM1QMNr19jHU5Pyoc9kAD6jeW?= =?us-ascii?Q?G0YyzmAq9GoQ0Pmem/CweXJ9YVWZt02fpbrrgjJWEhTdj9Gpgd6y0RuPovCM?= =?us-ascii?Q?uPyNJvcI7Mr7tQZq6gF6jcXYsUqB2SHzy+rspsahVRBZDYU38g6VWPtPok+N?= =?us-ascii?Q?N6giSYnsuinYPPmhOvYUqVlyZbrEGTSLF8Eiqr1w3Ox6oKEUdMdsIjoHVNw1?= =?us-ascii?Q?jJLSqlVxe6G81XsnVP8wkea3gMpY9lb/jRly+mS83b2SYbx81NUZeYdvol4c?= =?us-ascii?Q?gjm0DnUi0/oJ1gbHBGs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1631.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2401699b-e168-4422-2656-08dad1e9b238 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 09:11:27.3799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j17utGW98K+wdcM9gaKXk2S2erIbHXbGfW25KCyqRaXmi4b6NXofQjioLlMx5i7mszquGBXoYcjQ/cLS5nngpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4667 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4173 >=20 > The blocked register might return the counter instead of bitvector. This > request > is to update the code to handle the case by checking SMM Delayed/Blocked > AP Count > to decide all CPUs in SMI or not. The code change actually assumes the SmmRegSmmBlocked, SmmRegSmmDelayed and SmmRegSmmEnable registers return the number of threads that are in blocked, delayed or disabled state. Can you provide suggestions regarding how to change those close source CpuS= mmFeaturesLib implementation which still returns the bitmap value instead of count in the= commit message? > +UINT32 *mPackageBspInfo =3D NULL; The variable name is confusing. Can you rename it to "mPackageFirstThreadIn= dex"?